[jira] [Commented] (DELTASPIKE-1206) support for CDI 2.0 feature

2016-09-26 Thread Mark Struberg (JIRA)

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522421#comment-15522421
 ] 

Mark Struberg commented on DELTASPIKE-1206:
---

Seems Romain was right and I was wrong. 

> support for CDI 2.0  feature
> ---
>
> Key: DELTASPIKE-1206
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1206
> Project: DeltaSpike
>  Issue Type: Test
>Affects Versions: 1.7.1
>Reporter: Mark Struberg
>Assignee: Mark Struberg
> Fix For: 1.7.2
>
>
> CDI 2.0 will add support for only picking up beans with an explicit scope 
> annotation. This reduced the memory footprint while also speeding up the 
> bootstrapping.
> See https://issues.jboss.org/browse/CDI-420
> We should add this annotation to our beans.xml and verify that we still work. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DELTASPIKE-1206) support for CDI 2.0 feature

2016-09-26 Thread Martin Kouba (JIRA)

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522307#comment-15522307
 ] 

Martin Kouba commented on DELTASPIKE-1206:
--

I find this approach rather hasty. The name of the tag is not decided yet 
(altough it seems there are no better ideas). And yes, we're planning to add 
this feature to Weld 2.x as well, once there is agreement and final PR for 
CDI-420. Just my 2 cents.

> support for CDI 2.0  feature
> ---
>
> Key: DELTASPIKE-1206
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1206
> Project: DeltaSpike
>  Issue Type: Test
>Affects Versions: 1.7.1
>Reporter: Mark Struberg
>Assignee: Mark Struberg
> Fix For: 1.7.2
>
>
> CDI 2.0 will add support for only picking up beans with an explicit scope 
> annotation. This reduced the memory footprint while also speeding up the 
> bootstrapping.
> See https://issues.jboss.org/browse/CDI-420
> We should add this annotation to our beans.xml and verify that we still work. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DELTASPIKE-1206) support for CDI 2.0 feature

2016-09-25 Thread Romain Manni-Bucau (JIRA)

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521041#comment-15521041
 ] 

Romain Manni-Bucau commented on DELTASPIKE-1206:


@struberg there was no question when i spoke of jaxb :p. This is clearly the 
case and even if OWB and Weld don't they are not the only ones to read these 
files (either for CDI itself or even for other things like tools)

> support for CDI 2.0  feature
> ---
>
> Key: DELTASPIKE-1206
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1206
> Project: DeltaSpike
>  Issue Type: Test
>Affects Versions: 1.7.1
>Reporter: Mark Struberg
>Assignee: Mark Struberg
> Fix For: 1.7.2
>
>
> CDI 2.0 will add support for only picking up beans with an explicit scope 
> annotation. This reduced the memory footprint while also speeding up the 
> bootstrapping.
> See https://issues.jboss.org/browse/CDI-420
> We should add this annotation to our beans.xml and verify that we still work. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DELTASPIKE-1206) support for CDI 2.0 feature

2016-09-25 Thread Mark Struberg (JIRA)

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521038#comment-15521038
 ] 

Mark Struberg commented on DELTASPIKE-1206:
---

Nope will NOT break anything!

NO CDI impl reads beans.xml via JAXB. JAB-S sucks big times in terms of 
performance, thus neither Weld nor OWB use it.
Note that both Weld and OWB introduced own tags and we already have those in 
our beans.xml in DeltaSpike!
Also the scan tag worked ok even in older OWB versions. I don't know of any 
issue in that area. 

So no, it's not a problem at all. 

> support for CDI 2.0  feature
> ---
>
> Key: DELTASPIKE-1206
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1206
> Project: DeltaSpike
>  Issue Type: Test
>Affects Versions: 1.7.1
>Reporter: Mark Struberg
>Assignee: Mark Struberg
> Fix For: 1.7.2
>
>
> CDI 2.0 will add support for only picking up beans with an explicit scope 
> annotation. This reduced the memory footprint while also speeding up the 
> bootstrapping.
> See https://issues.jboss.org/browse/CDI-420
> We should add this annotation to our beans.xml and verify that we still work. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DELTASPIKE-1206) support for CDI 2.0 feature

2016-09-25 Thread Romain Manni-Bucau (JIRA)

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15520966#comment-15520966
 ] 

Romain Manni-Bucau commented on DELTASPIKE-1206:


Will be broken to servers using jaxb to read beans.xml and I can guarantee you 
some do it ;)

> support for CDI 2.0  feature
> ---
>
> Key: DELTASPIKE-1206
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1206
> Project: DeltaSpike
>  Issue Type: Bug
>Affects Versions: 1.7.1
>Reporter: Mark Struberg
>Assignee: Mark Struberg
> Fix For: 1.7.2
>
>
> CDI 2.0 will add support for only picking up beans with an explicit scope 
> annotation. This reduced the memory footprint while also speeding up the 
> bootstrapping.
> See https://issues.jboss.org/browse/CDI-420
> We should add this annotation to our beans.xml and verify that we still work. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (DELTASPIKE-1206) support for CDI 2.0 feature

2016-09-25 Thread John D. Ament (JIRA)

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15520961#comment-15520961
 ] 

John D. Ament commented on DELTASPIKE-1206:
---

Good idea Mark.  However, what do we do if something doesn't work? From what I 
remember, OWB older versions are generally sensitive to the contents of 
{{beans.xml}}, in so much that CDI 1.1 scan tags cause it to crash.  In the 
past, we have discussed and agreed to make a DS 2.0 that targets CDI 2.0.  See 
also, e.g. 
https://lists.apache.org/thread.html/5d9baec12e1340a38c01453924570660bb25ff56e9539ae28d0ecdf3@1460035517@%3Cdev.deltaspike.apache.org%3E

> support for CDI 2.0  feature
> ---
>
> Key: DELTASPIKE-1206
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1206
> Project: DeltaSpike
>  Issue Type: Bug
>Affects Versions: 1.7.1
>Reporter: Mark Struberg
>Assignee: Mark Struberg
> Fix For: 1.7.2
>
>
> CDI 2.0 will add support for only picking up beans with an explicit scope 
> annotation. This reduced the memory footprint while also speeding up the 
> bootstrapping.
> See https://issues.jboss.org/browse/CDI-420
> We should add this annotation to our beans.xml and verify that we still work. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)