[jira] [Commented] (DELTASPIKE-1226) NPE in DeltaSpikeLifecycleWrapper with OmniFaces 2.5 FullAjaxExceptionHandler

2016-12-08 Thread Gerald Turner (JIRA) 

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732855#comment-15732855
 ] 

Gerald Turner commented on DELTASPIKE-1226:
---

I had an email exchange with the author of omnifaces.

He's fixed it in 2.6-SNAPSHOT in this 
[commit|https://github.com/omnifaces/omnifaces/commit/23d7baff39dad10ae57e1f06c3ea212a13d9bd91].

> NPE in DeltaSpikeLifecycleWrapper with OmniFaces 2.5 FullAjaxExceptionHandler
> -
>
> Key: DELTASPIKE-1226
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1226
> Project: DeltaSpike
>  Issue Type: Wish
>  Components: JSF-Module
>Affects Versions: 1.7.2
> Environment: JBoss EAP 7.0.3.GA; DeltaSpike 1.7.2; OmniFaces 2.5.1; 
> PrimeFaces 6.0.7
>Reporter: Gerald Turner
>Priority: Minor
>
> I have a JSF application with web.xml declaring an error page, and I am using 
> [OmniFaces 
> FullAjaxExceptionHandler|http://showcase.omnifaces.org/exceptionhandlers/FullAjaxExceptionHandler]
>  to render failed AJAX requests with the error page.
> Since upgrading to OmniFaces 2.5.1 the application has been having 
> NullPointerExceptions in DeltaSpikeLifecycleWrapper when 
> FullAjaxExceptionHandler performs it's error page rendering. Triggering the 
> so-called "Error in error page itself" condition.
> I believe [OmniFaces commit 
> 59459007|https://github.com/omnifaces/omnifaces/commit/5945900731da60f609d7dd36f0fe28ce3f26edbf]
>  is the culprit.
> I've breakpointed at the NullPointerException thrown in 
> DeltaSpikeLifecycleWrapper#render and found that none of the fields like 
> _contextExtension_ have been initialized.
> Downgrading to OmniFaces 2.4 works around the issue.
> Stacktrace:
> {noformat}
> 2016-12-07 14:26:25,581 SEVERE 
> [org.omnifaces.exceptionhandler.FullAjaxExceptionHandler] (default task-100) 
> FullAjaxExceptionHandler: Well, another exception occurred during rendering 
> error page '/csst/error.jsf'. Trying to render a hardcoded error page now.: 
> java.lang.NullPointerException
>   at 
> org.apache.deltaspike.jsf.impl.listener.request.DeltaSpikeLifecycleWrapper.render(DeltaSpikeLifecycleWrapper.java:115)
>  [deltaspike-jsf-module-impl-1.7.2.jar:1.7.2]
>   at 
> javax.faces.lifecycle.LifecycleWrapper.render(LifecycleWrapper.java:92) 
> [jboss-jsf-api_2.2_spec-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> org.apache.deltaspike.jsf.impl.listener.request.JsfClientWindowAwareLifecycleWrapper.render(JsfClientWindowAwareLifecycleWrapper.java:160)
>  [deltaspike-jsf-module-impl-1.7.2.jar:1.7.2]
>   at 
> org.omnifaces.exceptionhandler.FullAjaxExceptionHandler.renderErrorPageView(FullAjaxExceptionHandler.java:536)
>  [omnifaces-2.5.1.jar:2.5.1]
>   at 
> org.omnifaces.exceptionhandler.FullAjaxExceptionHandler.handleAjaxException(FullAjaxExceptionHandler.java:411)
>  [omnifaces-2.5.1.jar:2.5.1]
>   at 
> org.omnifaces.exceptionhandler.FullAjaxExceptionHandler.handle(FullAjaxExceptionHandler.java:364)
>  [omnifaces-2.5.1.jar:2.5.1]
>   at 
> javax.faces.context.ExceptionHandlerWrapper.handle(ExceptionHandlerWrapper.java:100)
>  [jboss-jsf-api_2.2_spec-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> org.apache.deltaspike.jsf.impl.exception.control.BridgeExceptionHandlerWrapper.handle(BridgeExceptionHandlerWrapper.java:109)
>  [deltaspike-jsf-module-impl-1.7.2.jar:1.7.2]
>   at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:119) 
> [jsf-impl-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:198) 
> [jsf-impl-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> org.apache.deltaspike.jsf.impl.listener.request.DeltaSpikeLifecycleWrapper.execute(DeltaSpikeLifecycleWrapper.java:89)
>  [deltaspike-jsf-module-impl-1.7.2.jar:1.7.2]
>   at 
> javax.faces.lifecycle.LifecycleWrapper.execute(LifecycleWrapper.java:77) 
> [jboss-jsf-api_2.2_spec-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at javax.faces.webapp.FacesServlet.service(FacesServlet.java:658) 
> [jboss-jsf-api_2.2_spec-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> io.undertow.servlet.handlers.ServletHandler.handleRequest(ServletHandler.java:85)
>  [undertow-servlet-1.3.25.Final-redhat-1.jar:1.3.25.Final-redhat-1]
>   at 
> io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:129)
>  [undertow-servlet-1.3.25.Final-redhat-1.jar:1.3.25.Final-redhat-1]
>   at 
> net.xoint.csst.common.util.SlowRequestFilter.doFilter(SlowRequestFilter.java:113)
>  [CSST-war-common-2.12-SNAPSHOT.jar:2.12-SNAPSHOT (local)]
>   at 
> io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:61) 
> [undertow-servlet-1.3.25.Final-redhat-1.jar:1.3.25.Final-redhat-1]
>   at 
>

[jira] [Commented] (DELTASPIKE-1226) NPE in DeltaSpikeLifecycleWrapper with OmniFaces 2.5 FullAjaxExceptionHandler

2016-12-07 Thread John D. Ament (JIRA) 

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730441#comment-15730441
 ] 

John D. Ament commented on DELTASPIKE-1226:
---

Hi, I'm fine with leaving this open.  If they need us to fix something, we can 
fix it.  However, it seems like their implementation isn't correct.

If its OK with you, I can create a ticket in their github issues and see if 
they respond.

> NPE in DeltaSpikeLifecycleWrapper with OmniFaces 2.5 FullAjaxExceptionHandler
> -
>
> Key: DELTASPIKE-1226
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1226
> Project: DeltaSpike
>  Issue Type: Wish
>  Components: JSF-Module
>Affects Versions: 1.7.2
> Environment: JBoss EAP 7.0.3.GA; DeltaSpike 1.7.2; OmniFaces 2.5.1; 
> PrimeFaces 6.0.7
>Reporter: Gerald Turner
>Priority: Minor
>
> I have a JSF application with web.xml declaring an error page, and I am using 
> [OmniFaces 
> FullAjaxExceptionHandler|http://showcase.omnifaces.org/exceptionhandlers/FullAjaxExceptionHandler]
>  to render failed AJAX requests with the error page.
> Since upgrading to OmniFaces 2.5.1 the application has been having 
> NullPointerExceptions in DeltaSpikeLifecycleWrapper when 
> FullAjaxExceptionHandler performs it's error page rendering. Triggering the 
> so-called "Error in error page itself" condition.
> I believe [OmniFaces commit 
> 59459007|https://github.com/omnifaces/omnifaces/commit/5945900731da60f609d7dd36f0fe28ce3f26edbf]
>  is the culprit.
> I've breakpointed at the NullPointerException thrown in 
> DeltaSpikeLifecycleWrapper#render and found that none of the fields like 
> _contextExtension_ have been initialized.
> Downgrading to OmniFaces 2.4 works around the issue.
> Stacktrace:
> {noformat}
> 2016-12-07 14:26:25,581 SEVERE 
> [org.omnifaces.exceptionhandler.FullAjaxExceptionHandler] (default task-100) 
> FullAjaxExceptionHandler: Well, another exception occurred during rendering 
> error page '/csst/error.jsf'. Trying to render a hardcoded error page now.: 
> java.lang.NullPointerException
>   at 
> org.apache.deltaspike.jsf.impl.listener.request.DeltaSpikeLifecycleWrapper.render(DeltaSpikeLifecycleWrapper.java:115)
>  [deltaspike-jsf-module-impl-1.7.2.jar:1.7.2]
>   at 
> javax.faces.lifecycle.LifecycleWrapper.render(LifecycleWrapper.java:92) 
> [jboss-jsf-api_2.2_spec-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> org.apache.deltaspike.jsf.impl.listener.request.JsfClientWindowAwareLifecycleWrapper.render(JsfClientWindowAwareLifecycleWrapper.java:160)
>  [deltaspike-jsf-module-impl-1.7.2.jar:1.7.2]
>   at 
> org.omnifaces.exceptionhandler.FullAjaxExceptionHandler.renderErrorPageView(FullAjaxExceptionHandler.java:536)
>  [omnifaces-2.5.1.jar:2.5.1]
>   at 
> org.omnifaces.exceptionhandler.FullAjaxExceptionHandler.handleAjaxException(FullAjaxExceptionHandler.java:411)
>  [omnifaces-2.5.1.jar:2.5.1]
>   at 
> org.omnifaces.exceptionhandler.FullAjaxExceptionHandler.handle(FullAjaxExceptionHandler.java:364)
>  [omnifaces-2.5.1.jar:2.5.1]
>   at 
> javax.faces.context.ExceptionHandlerWrapper.handle(ExceptionHandlerWrapper.java:100)
>  [jboss-jsf-api_2.2_spec-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> org.apache.deltaspike.jsf.impl.exception.control.BridgeExceptionHandlerWrapper.handle(BridgeExceptionHandlerWrapper.java:109)
>  [deltaspike-jsf-module-impl-1.7.2.jar:1.7.2]
>   at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:119) 
> [jsf-impl-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:198) 
> [jsf-impl-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> org.apache.deltaspike.jsf.impl.listener.request.DeltaSpikeLifecycleWrapper.execute(DeltaSpikeLifecycleWrapper.java:89)
>  [deltaspike-jsf-module-impl-1.7.2.jar:1.7.2]
>   at 
> javax.faces.lifecycle.LifecycleWrapper.execute(LifecycleWrapper.java:77) 
> [jboss-jsf-api_2.2_spec-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at javax.faces.webapp.FacesServlet.service(FacesServlet.java:658) 
> [jboss-jsf-api_2.2_spec-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> io.undertow.servlet.handlers.ServletHandler.handleRequest(ServletHandler.java:85)
>  [undertow-servlet-1.3.25.Final-redhat-1.jar:1.3.25.Final-redhat-1]
>   at 
> io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:129)
>  [undertow-servlet-1.3.25.Final-redhat-1.jar:1.3.25.Final-redhat-1]
>   at 
> net.xoint.csst.common.util.SlowRequestFilter.doFilter(SlowRequestFilter.java:113)
>  [CSST-war-common-2.12-SNAPSHOT.jar:2.12-SNAPSHOT (local)]
>   at 
> io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:61) 
>

[jira] [Commented] (DELTASPIKE-1226) NPE in DeltaSpikeLifecycleWrapper with OmniFaces 2.5 FullAjaxExceptionHandler

2016-12-07 Thread Gerald Turner (JIRA) 

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730307#comment-15730307
 ] 

Gerald Turner commented on DELTASPIKE-1226:
---

I was wondering that, hence set the bug to "Wish".  Given that both projects do 
much for compatibility, working around bugs in CDI / JSF implementations, it's 
hard to discern which is at fault.

I haven't opened an issue with omnifaces, I should, but I shy away from 
creating an account with github.com :(

Please close this bug, sorry for the nuisance - thanks!

> NPE in DeltaSpikeLifecycleWrapper with OmniFaces 2.5 FullAjaxExceptionHandler
> -
>
> Key: DELTASPIKE-1226
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1226
> Project: DeltaSpike
>  Issue Type: Wish
>  Components: JSF-Module
>Affects Versions: 1.7.2
> Environment: JBoss EAP 7.0.3.GA; DeltaSpike 1.7.2; OmniFaces 2.5.1; 
> PrimeFaces 6.0.7
>Reporter: Gerald Turner
>Priority: Minor
>
> I have a JSF application with web.xml declaring an error page, and I am using 
> [OmniFaces 
> FullAjaxExceptionHandler|http://showcase.omnifaces.org/exceptionhandlers/FullAjaxExceptionHandler]
>  to render failed AJAX requests with the error page.
> Since upgrading to OmniFaces 2.5.1 the application has been having 
> NullPointerExceptions in DeltaSpikeLifecycleWrapper when 
> FullAjaxExceptionHandler performs it's error page rendering. Triggering the 
> so-called "Error in error page itself" condition.
> I believe [OmniFaces commit 
> 59459007|https://github.com/omnifaces/omnifaces/commit/5945900731da60f609d7dd36f0fe28ce3f26edbf]
>  is the culprit.
> I've breakpointed at the NullPointerException thrown in 
> DeltaSpikeLifecycleWrapper#render and found that none of the fields like 
> _contextExtension_ have been initialized.
> Downgrading to OmniFaces 2.4 works around the issue.
> Stacktrace:
> {noformat}
> 2016-12-07 14:26:25,581 SEVERE 
> [org.omnifaces.exceptionhandler.FullAjaxExceptionHandler] (default task-100) 
> FullAjaxExceptionHandler: Well, another exception occurred during rendering 
> error page '/csst/error.jsf'. Trying to render a hardcoded error page now.: 
> java.lang.NullPointerException
>   at 
> org.apache.deltaspike.jsf.impl.listener.request.DeltaSpikeLifecycleWrapper.render(DeltaSpikeLifecycleWrapper.java:115)
>  [deltaspike-jsf-module-impl-1.7.2.jar:1.7.2]
>   at 
> javax.faces.lifecycle.LifecycleWrapper.render(LifecycleWrapper.java:92) 
> [jboss-jsf-api_2.2_spec-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> org.apache.deltaspike.jsf.impl.listener.request.JsfClientWindowAwareLifecycleWrapper.render(JsfClientWindowAwareLifecycleWrapper.java:160)
>  [deltaspike-jsf-module-impl-1.7.2.jar:1.7.2]
>   at 
> org.omnifaces.exceptionhandler.FullAjaxExceptionHandler.renderErrorPageView(FullAjaxExceptionHandler.java:536)
>  [omnifaces-2.5.1.jar:2.5.1]
>   at 
> org.omnifaces.exceptionhandler.FullAjaxExceptionHandler.handleAjaxException(FullAjaxExceptionHandler.java:411)
>  [omnifaces-2.5.1.jar:2.5.1]
>   at 
> org.omnifaces.exceptionhandler.FullAjaxExceptionHandler.handle(FullAjaxExceptionHandler.java:364)
>  [omnifaces-2.5.1.jar:2.5.1]
>   at 
> javax.faces.context.ExceptionHandlerWrapper.handle(ExceptionHandlerWrapper.java:100)
>  [jboss-jsf-api_2.2_spec-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> org.apache.deltaspike.jsf.impl.exception.control.BridgeExceptionHandlerWrapper.handle(BridgeExceptionHandlerWrapper.java:109)
>  [deltaspike-jsf-module-impl-1.7.2.jar:1.7.2]
>   at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:119) 
> [jsf-impl-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:198) 
> [jsf-impl-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> org.apache.deltaspike.jsf.impl.listener.request.DeltaSpikeLifecycleWrapper.execute(DeltaSpikeLifecycleWrapper.java:89)
>  [deltaspike-jsf-module-impl-1.7.2.jar:1.7.2]
>   at 
> javax.faces.lifecycle.LifecycleWrapper.execute(LifecycleWrapper.java:77) 
> [jboss-jsf-api_2.2_spec-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at javax.faces.webapp.FacesServlet.service(FacesServlet.java:658) 
> [jboss-jsf-api_2.2_spec-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> io.undertow.servlet.handlers.ServletHandler.handleRequest(ServletHandler.java:85)
>  [undertow-servlet-1.3.25.Final-redhat-1.jar:1.3.25.Final-redhat-1]
>   at 
> io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:129)
>  [undertow-servlet-1.3.25.Final-redhat-1.jar:1.3.25.Final-redhat-1]
>   at 
> net.xoint.csst.common.util.SlowRequestFilter.doFilter(SlowRequestFilter.java:113)
>  [CSST-war-common-2.12-SNAPSHOT.jar:2.12-SNAPSHOT (local)]
>   at 
>

[jira] [Commented] (DELTASPIKE-1226) NPE in DeltaSpikeLifecycleWrapper with OmniFaces 2.5 FullAjaxExceptionHandler

2016-12-07 Thread John D. Ament (JIRA) 

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730284#comment-15730284
 ] 

John D. Ament commented on DELTASPIKE-1226:
---

Gerald, did you also file an issue w/ the omnifaces team?  The problem is that 
they're manually looking up a lifecycle but not triggering the event for that 
lifecycle, which never calls execute.  The way they're manually setting the 
phase ID means the event doesn't get published.

> NPE in DeltaSpikeLifecycleWrapper with OmniFaces 2.5 FullAjaxExceptionHandler
> -
>
> Key: DELTASPIKE-1226
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1226
> Project: DeltaSpike
>  Issue Type: Wish
>  Components: JSF-Module
>Affects Versions: 1.7.2
> Environment: JBoss EAP 7.0.3.GA; DeltaSpike 1.7.2; OmniFaces 2.5.1; 
> PrimeFaces 6.0.7
>Reporter: Gerald Turner
>Priority: Minor
>
> I have a JSF application with web.xml declaring an error page, and I am using 
> [OmniFaces 
> FullAjaxExceptionHandler|http://showcase.omnifaces.org/exceptionhandlers/FullAjaxExceptionHandler]
>  to render failed AJAX requests with the error page.
> Since upgrading to OmniFaces 2.5.1 the application has been having 
> NullPointerExceptions in DeltaSpikeLifecycleWrapper when 
> FullAjaxExceptionHandler performs it's error page rendering. Triggering the 
> so-called "Error in error page itself" condition.
> I believe [OmniFaces commit 
> 59459007|https://github.com/omnifaces/omnifaces/commit/5945900731da60f609d7dd36f0fe28ce3f26edbf]
>  is the culprit.
> I've breakpointed at the NullPointerException thrown in 
> DeltaSpikeLifecycleWrapper#render and found that none of the fields like 
> _contextExtension_ have been initialized.
> Downgrading to OmniFaces 2.4 works around the issue.
> Stacktrace:
> {noformat}
> 2016-12-07 14:26:25,581 SEVERE 
> [org.omnifaces.exceptionhandler.FullAjaxExceptionHandler] (default task-100) 
> FullAjaxExceptionHandler: Well, another exception occurred during rendering 
> error page '/csst/error.jsf'. Trying to render a hardcoded error page now.: 
> java.lang.NullPointerException
>   at 
> org.apache.deltaspike.jsf.impl.listener.request.DeltaSpikeLifecycleWrapper.render(DeltaSpikeLifecycleWrapper.java:115)
>  [deltaspike-jsf-module-impl-1.7.2.jar:1.7.2]
>   at 
> javax.faces.lifecycle.LifecycleWrapper.render(LifecycleWrapper.java:92) 
> [jboss-jsf-api_2.2_spec-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> org.apache.deltaspike.jsf.impl.listener.request.JsfClientWindowAwareLifecycleWrapper.render(JsfClientWindowAwareLifecycleWrapper.java:160)
>  [deltaspike-jsf-module-impl-1.7.2.jar:1.7.2]
>   at 
> org.omnifaces.exceptionhandler.FullAjaxExceptionHandler.renderErrorPageView(FullAjaxExceptionHandler.java:536)
>  [omnifaces-2.5.1.jar:2.5.1]
>   at 
> org.omnifaces.exceptionhandler.FullAjaxExceptionHandler.handleAjaxException(FullAjaxExceptionHandler.java:411)
>  [omnifaces-2.5.1.jar:2.5.1]
>   at 
> org.omnifaces.exceptionhandler.FullAjaxExceptionHandler.handle(FullAjaxExceptionHandler.java:364)
>  [omnifaces-2.5.1.jar:2.5.1]
>   at 
> javax.faces.context.ExceptionHandlerWrapper.handle(ExceptionHandlerWrapper.java:100)
>  [jboss-jsf-api_2.2_spec-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> org.apache.deltaspike.jsf.impl.exception.control.BridgeExceptionHandlerWrapper.handle(BridgeExceptionHandlerWrapper.java:109)
>  [deltaspike-jsf-module-impl-1.7.2.jar:1.7.2]
>   at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:119) 
> [jsf-impl-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:198) 
> [jsf-impl-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> org.apache.deltaspike.jsf.impl.listener.request.DeltaSpikeLifecycleWrapper.execute(DeltaSpikeLifecycleWrapper.java:89)
>  [deltaspike-jsf-module-impl-1.7.2.jar:1.7.2]
>   at 
> javax.faces.lifecycle.LifecycleWrapper.execute(LifecycleWrapper.java:77) 
> [jboss-jsf-api_2.2_spec-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at javax.faces.webapp.FacesServlet.service(FacesServlet.java:658) 
> [jboss-jsf-api_2.2_spec-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> io.undertow.servlet.handlers.ServletHandler.handleRequest(ServletHandler.java:85)
>  [undertow-servlet-1.3.25.Final-redhat-1.jar:1.3.25.Final-redhat-1]
>   at 
> io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:129)
>  [undertow-servlet-1.3.25.Final-redhat-1.jar:1.3.25.Final-redhat-1]
>   at 
> net.xoint.csst.common.util.SlowRequestFilter.doFilter(SlowRequestFilter.java:113)
>  [CSST-war-common-2.12-SNAPSHOT.jar:2.12-SNAPSHOT (local)]
>   at 
> io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:61) 
>

[jira] [Commented] (DELTASPIKE-1226) NPE in DeltaSpikeLifecycleWrapper with OmniFaces 2.5 FullAjaxExceptionHandler

2016-12-07 Thread Gerald Turner (JIRA) 

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730252#comment-15730252
 ] 

Gerald Turner commented on DELTASPIKE-1226:
---

Yes I see _execute_ being called, however it's on a different instance of the 
DeltaSpikeLifecycleWrapper than the one when _render_ is called (with NPE).

Sorry my debugging skill isn't very good on these layers of the stack yet.

My guess is the different instances are before/after the exception in the AJAX 
request is handled by FullAjaxExceptionHandler.

> NPE in DeltaSpikeLifecycleWrapper with OmniFaces 2.5 FullAjaxExceptionHandler
> -
>
> Key: DELTASPIKE-1226
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1226
> Project: DeltaSpike
>  Issue Type: Wish
>  Components: JSF-Module
>Affects Versions: 1.7.2
> Environment: JBoss EAP 7.0.3.GA; DeltaSpike 1.7.2; OmniFaces 2.5.1; 
> PrimeFaces 6.0.7
>Reporter: Gerald Turner
>Priority: Minor
>
> I have a JSF application with web.xml declaring an error page, and I am using 
> [OmniFaces 
> FullAjaxExceptionHandler|http://showcase.omnifaces.org/exceptionhandlers/FullAjaxExceptionHandler]
>  to render failed AJAX requests with the error page.
> Since upgrading to OmniFaces 2.5.1 the application has been having 
> NullPointerExceptions in DeltaSpikeLifecycleWrapper when 
> FullAjaxExceptionHandler performs it's error page rendering. Triggering the 
> so-called "Error in error page itself" condition.
> I believe [OmniFaces commit 
> 59459007|https://github.com/omnifaces/omnifaces/commit/5945900731da60f609d7dd36f0fe28ce3f26edbf]
>  is the culprit.
> I've breakpointed at the NullPointerException thrown in 
> DeltaSpikeLifecycleWrapper#render and found that none of the fields like 
> _contextExtension_ have been initialized.
> Downgrading to OmniFaces 2.4 works around the issue.
> Stacktrace:
> {noformat}
> 2016-12-07 14:26:25,581 SEVERE 
> [org.omnifaces.exceptionhandler.FullAjaxExceptionHandler] (default task-100) 
> FullAjaxExceptionHandler: Well, another exception occurred during rendering 
> error page '/csst/error.jsf'. Trying to render a hardcoded error page now.: 
> java.lang.NullPointerException
>   at 
> org.apache.deltaspike.jsf.impl.listener.request.DeltaSpikeLifecycleWrapper.render(DeltaSpikeLifecycleWrapper.java:115)
>  [deltaspike-jsf-module-impl-1.7.2.jar:1.7.2]
>   at 
> javax.faces.lifecycle.LifecycleWrapper.render(LifecycleWrapper.java:92) 
> [jboss-jsf-api_2.2_spec-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> org.apache.deltaspike.jsf.impl.listener.request.JsfClientWindowAwareLifecycleWrapper.render(JsfClientWindowAwareLifecycleWrapper.java:160)
>  [deltaspike-jsf-module-impl-1.7.2.jar:1.7.2]
>   at 
> org.omnifaces.exceptionhandler.FullAjaxExceptionHandler.renderErrorPageView(FullAjaxExceptionHandler.java:536)
>  [omnifaces-2.5.1.jar:2.5.1]
>   at 
> org.omnifaces.exceptionhandler.FullAjaxExceptionHandler.handleAjaxException(FullAjaxExceptionHandler.java:411)
>  [omnifaces-2.5.1.jar:2.5.1]
>   at 
> org.omnifaces.exceptionhandler.FullAjaxExceptionHandler.handle(FullAjaxExceptionHandler.java:364)
>  [omnifaces-2.5.1.jar:2.5.1]
>   at 
> javax.faces.context.ExceptionHandlerWrapper.handle(ExceptionHandlerWrapper.java:100)
>  [jboss-jsf-api_2.2_spec-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> org.apache.deltaspike.jsf.impl.exception.control.BridgeExceptionHandlerWrapper.handle(BridgeExceptionHandlerWrapper.java:109)
>  [deltaspike-jsf-module-impl-1.7.2.jar:1.7.2]
>   at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:119) 
> [jsf-impl-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:198) 
> [jsf-impl-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> org.apache.deltaspike.jsf.impl.listener.request.DeltaSpikeLifecycleWrapper.execute(DeltaSpikeLifecycleWrapper.java:89)
>  [deltaspike-jsf-module-impl-1.7.2.jar:1.7.2]
>   at 
> javax.faces.lifecycle.LifecycleWrapper.execute(LifecycleWrapper.java:77) 
> [jboss-jsf-api_2.2_spec-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at javax.faces.webapp.FacesServlet.service(FacesServlet.java:658) 
> [jboss-jsf-api_2.2_spec-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> io.undertow.servlet.handlers.ServletHandler.handleRequest(ServletHandler.java:85)
>  [undertow-servlet-1.3.25.Final-redhat-1.jar:1.3.25.Final-redhat-1]
>   at 
> io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:129)
>  [undertow-servlet-1.3.25.Final-redhat-1.jar:1.3.25.Final-redhat-1]
>   at 
> net.xoint.csst.common.util.SlowRequestFilter.doFilter(SlowRequestFilter.java:113)
>  [CSST-war-common-2.12-SNAPSHOT.jar:2.12-SNAPSHOT (local)]
>   at 
>

[jira] [Commented] (DELTASPIKE-1226) NPE in DeltaSpikeLifecycleWrapper with OmniFaces 2.5 FullAjaxExceptionHandler

2016-12-07 Thread John D. Ament (JIRA) 

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730235#comment-15730235
 ] 

John D. Ament commented on DELTASPIKE-1226:
---

Hi Gerald

Do you see the {{execute}} method being invoked in this case? 
https://github.com/apache/deltaspike/blob/master/deltaspike/modules/jsf/impl/src/main/java/org/apache/deltaspike/jsf/impl/listener/request/DeltaSpikeLifecycleWrapper.java#L67

> NPE in DeltaSpikeLifecycleWrapper with OmniFaces 2.5 FullAjaxExceptionHandler
> -
>
> Key: DELTASPIKE-1226
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-1226
> Project: DeltaSpike
>  Issue Type: Wish
>  Components: JSF-Module
>Affects Versions: 1.7.2
> Environment: JBoss EAP 7.0.3.GA; DeltaSpike 1.7.2; OmniFaces 2.5.1; 
> PrimeFaces 6.0.7
>Reporter: Gerald Turner
>Priority: Minor
>
> I have a JSF application with web.xml declaring an error page, and I am using 
> [OmniFaces 
> FullAjaxExceptionHandler|http://showcase.omnifaces.org/exceptionhandlers/FullAjaxExceptionHandler]
>  to render failed AJAX requests with the error page.
> Since upgrading to OmniFaces 2.5.1 the application has been having 
> NullPointerExceptions in DeltaSpikeLifecycleWrapper when 
> FullAjaxExceptionHandler performs it's error page rendering. Triggering the 
> so-called "Error in error page itself" condition.
> I believe [OmniFaces commit 
> 59459007|https://github.com/omnifaces/omnifaces/commit/5945900731da60f609d7dd36f0fe28ce3f26edbf]
>  is the culprit.
> I've breakpointed at the NullPointerException thrown in 
> DeltaSpikeLifecycleWrapper#render and found that none of the fields like 
> _contextExtension_ have been initialized.
> Downgrading to OmniFaces 2.4 works around the issue.
> Stacktrace:
> {noformat}
> 2016-12-07 14:26:25,581 SEVERE 
> [org.omnifaces.exceptionhandler.FullAjaxExceptionHandler] (default task-100) 
> FullAjaxExceptionHandler: Well, another exception occurred during rendering 
> error page '/csst/error.jsf'. Trying to render a hardcoded error page now.: 
> java.lang.NullPointerException
>   at 
> org.apache.deltaspike.jsf.impl.listener.request.DeltaSpikeLifecycleWrapper.render(DeltaSpikeLifecycleWrapper.java:115)
>  [deltaspike-jsf-module-impl-1.7.2.jar:1.7.2]
>   at 
> javax.faces.lifecycle.LifecycleWrapper.render(LifecycleWrapper.java:92) 
> [jboss-jsf-api_2.2_spec-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> org.apache.deltaspike.jsf.impl.listener.request.JsfClientWindowAwareLifecycleWrapper.render(JsfClientWindowAwareLifecycleWrapper.java:160)
>  [deltaspike-jsf-module-impl-1.7.2.jar:1.7.2]
>   at 
> org.omnifaces.exceptionhandler.FullAjaxExceptionHandler.renderErrorPageView(FullAjaxExceptionHandler.java:536)
>  [omnifaces-2.5.1.jar:2.5.1]
>   at 
> org.omnifaces.exceptionhandler.FullAjaxExceptionHandler.handleAjaxException(FullAjaxExceptionHandler.java:411)
>  [omnifaces-2.5.1.jar:2.5.1]
>   at 
> org.omnifaces.exceptionhandler.FullAjaxExceptionHandler.handle(FullAjaxExceptionHandler.java:364)
>  [omnifaces-2.5.1.jar:2.5.1]
>   at 
> javax.faces.context.ExceptionHandlerWrapper.handle(ExceptionHandlerWrapper.java:100)
>  [jboss-jsf-api_2.2_spec-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> org.apache.deltaspike.jsf.impl.exception.control.BridgeExceptionHandlerWrapper.handle(BridgeExceptionHandlerWrapper.java:109)
>  [deltaspike-jsf-module-impl-1.7.2.jar:1.7.2]
>   at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:119) 
> [jsf-impl-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:198) 
> [jsf-impl-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> org.apache.deltaspike.jsf.impl.listener.request.DeltaSpikeLifecycleWrapper.execute(DeltaSpikeLifecycleWrapper.java:89)
>  [deltaspike-jsf-module-impl-1.7.2.jar:1.7.2]
>   at 
> javax.faces.lifecycle.LifecycleWrapper.execute(LifecycleWrapper.java:77) 
> [jboss-jsf-api_2.2_spec-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at javax.faces.webapp.FacesServlet.service(FacesServlet.java:658) 
> [jboss-jsf-api_2.2_spec-2.2.12.redhat-1.jar:2.2.12.redhat-1]
>   at 
> io.undertow.servlet.handlers.ServletHandler.handleRequest(ServletHandler.java:85)
>  [undertow-servlet-1.3.25.Final-redhat-1.jar:1.3.25.Final-redhat-1]
>   at 
> io.undertow.servlet.handlers.FilterHandler$FilterChainImpl.doFilter(FilterHandler.java:129)
>  [undertow-servlet-1.3.25.Final-redhat-1.jar:1.3.25.Final-redhat-1]
>   at 
> net.xoint.csst.common.util.SlowRequestFilter.doFilter(SlowRequestFilter.java:113)
>  [CSST-war-common-2.12-SNAPSHOT.jar:2.12-SNAPSHOT (local)]
>   at 
> io.undertow.servlet.core.ManagedFilter.doFilter(ManagedFilter.java:61) 
>