[jira] [Commented] (DELTASPIKE-560) interceptor for @NavigationParameter

2014-04-12 Thread Rafael Benevides (JIRA)

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13967588#comment-13967588
 ] 

Rafael Benevides commented on DELTASPIKE-560:
-

Thanks.

I'll update the test cases with this fix and send a single patch file with
them on Monday.



 interceptor for @NavigationParameter
 

 Key: DELTASPIKE-560
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-560
 Project: DeltaSpike
  Issue Type: New Feature
  Components: JSF-Module
Affects Versions: 0.6
Reporter: Rafael Benevides
Assignee: Gerhard Petracek
 Fix For: 0.7

 Attachments: DELTASPIKE-560.patch


 The documentation about @NavigationParameter says Instead of using 
 parameters in any case, it's also possible to configure them statically for 
 particular methods
 This seems that it isn't working when the @NavigationParameter is added to a 
 @Model class



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (DELTASPIKE-560) interceptor for @NavigationParameter

2014-04-10 Thread Rafael Benevides (JIRA)

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13965508#comment-13965508
 ] 

Rafael Benevides commented on DELTASPIKE-560:
-

Should the NavigationParameter work only for redirected pages ?

 interceptor for @NavigationParameter
 

 Key: DELTASPIKE-560
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-560
 Project: DeltaSpike
  Issue Type: New Feature
  Components: JSF-Module
Affects Versions: 0.6
Reporter: Rafael Benevides
Assignee: Gerhard Petracek
 Fix For: 0.7

 Attachments: DELTASPIKE-560.patch


 The documentation about @NavigationParameter says Instead of using 
 parameters in any case, it's also possible to configure them statically for 
 particular methods
 This seems that it isn't working when the @NavigationParameter is added to a 
 @Model class



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (DELTASPIKE-560) interceptor for @NavigationParameter

2014-04-07 Thread Rafael Benevides (JIRA)

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961847#comment-13961847
 ] 

Rafael Benevides commented on DELTASPIKE-560:
-

If you need help on impl the tests, I can do it after DELTASPIKE-306. Thanks 
for the patch

 interceptor for @NavigationParameter
 

 Key: DELTASPIKE-560
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-560
 Project: DeltaSpike
  Issue Type: New Feature
  Components: JSF-Module
Affects Versions: 0.6
Reporter: Rafael Benevides
Assignee: Gerhard Petracek
 Fix For: 0.7

 Attachments: DELTASPIKE-560.patch


 The documentation about @NavigationParameter says Instead of using 
 parameters in any case, it's also possible to configure them statically for 
 particular methods
 This seems that it isn't working when the @NavigationParameter is added to a 
 @Model class



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (DELTASPIKE-560) interceptor for @NavigationParameter

2014-04-04 Thread Gerhard Petracek (JIRA)

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960328#comment-13960328
 ] 

Gerhard Petracek commented on DELTASPIKE-560:
-

thx for reporting it rafael

 interceptor for @NavigationParameter
 

 Key: DELTASPIKE-560
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-560
 Project: DeltaSpike
  Issue Type: New Feature
  Components: JSF-Module
Affects Versions: 0.6
Reporter: Rafael Benevides
Assignee: Gerhard Petracek
 Fix For: 0.7


 The documentation about @NavigationParameter says Instead of using 
 parameters in any case, it's also possible to configure them statically for 
 particular methods
 This seems that it isn't working when the @NavigationParameter is added to a 
 @Model class



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (DELTASPIKE-560) interceptor for @NavigationParameter

2014-04-04 Thread Rafael Benevides (JIRA)

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960332#comment-13960332
 ] 

Rafael Benevides commented on DELTASPIKE-560:
-

Ok. If you need, I can work on that since I need this feature for a 
DELTASPIKE-306 example

 interceptor for @NavigationParameter
 

 Key: DELTASPIKE-560
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-560
 Project: DeltaSpike
  Issue Type: New Feature
  Components: JSF-Module
Affects Versions: 0.6
Reporter: Rafael Benevides
Assignee: Gerhard Petracek
 Fix For: 0.7


 The documentation about @NavigationParameter says Instead of using 
 parameters in any case, it's also possible to configure them statically for 
 particular methods
 This seems that it isn't working when the @NavigationParameter is added to a 
 @Model class



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (DELTASPIKE-560) interceptor for @NavigationParameter

2014-04-04 Thread Gerhard Petracek (JIRA)

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960352#comment-13960352
 ] 

Gerhard Petracek commented on DELTASPIKE-560:
-

i've it already (locally)

 interceptor for @NavigationParameter
 

 Key: DELTASPIKE-560
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-560
 Project: DeltaSpike
  Issue Type: New Feature
  Components: JSF-Module
Affects Versions: 0.6
Reporter: Rafael Benevides
Assignee: Gerhard Petracek
 Fix For: 0.7


 The documentation about @NavigationParameter says Instead of using 
 parameters in any case, it's also possible to configure them statically for 
 particular methods
 This seems that it isn't working when the @NavigationParameter is added to a 
 @Model class



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (DELTASPIKE-560) interceptor for @NavigationParameter

2014-04-04 Thread Rafael Benevides (JIRA)

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960356#comment-13960356
 ] 

Rafael Benevides commented on DELTASPIKE-560:
-

Ok. Thanks. I'll test it when it gets to upstream repo.

 interceptor for @NavigationParameter
 

 Key: DELTASPIKE-560
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-560
 Project: DeltaSpike
  Issue Type: New Feature
  Components: JSF-Module
Affects Versions: 0.6
Reporter: Rafael Benevides
Assignee: Gerhard Petracek
 Fix For: 0.7


 The documentation about @NavigationParameter says Instead of using 
 parameters in any case, it's also possible to configure them statically for 
 particular methods
 This seems that it isn't working when the @NavigationParameter is added to a 
 @Model class



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (DELTASPIKE-560) interceptor for @NavigationParameter

2014-04-04 Thread Gerhard Petracek (JIRA)

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960358#comment-13960358
 ] 

Gerhard Petracek commented on DELTASPIKE-560:
-

the reason why it wasn't done is that we wanted to ask users (if they prefer it 
over a simple injection of NavigationParameterContext).
(+ if we should use a separated annotation for the interceptor)

 interceptor for @NavigationParameter
 

 Key: DELTASPIKE-560
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-560
 Project: DeltaSpike
  Issue Type: New Feature
  Components: JSF-Module
Affects Versions: 0.6
Reporter: Rafael Benevides
Assignee: Gerhard Petracek
 Fix For: 0.7


 The documentation about @NavigationParameter says Instead of using 
 parameters in any case, it's also possible to configure them statically for 
 particular methods
 This seems that it isn't working when the @NavigationParameter is added to a 
 @Model class



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (DELTASPIKE-560) interceptor for @NavigationParameter

2014-04-04 Thread Rafael Benevides (JIRA)

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960362#comment-13960362
 ] 

Rafael Benevides commented on DELTASPIKE-560:
-

I'm ok with having both options (@NavigationParameter and 
navigationParameterContext) I don't think we need a separated annotation since 
it force users to be aware of many annotations for the almost the same 
purpose. Btw what do you call 'interceptor' for the 'navigation-parameters' 
feature ?

 interceptor for @NavigationParameter
 

 Key: DELTASPIKE-560
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-560
 Project: DeltaSpike
  Issue Type: New Feature
  Components: JSF-Module
Affects Versions: 0.6
Reporter: Rafael Benevides
Assignee: Gerhard Petracek
 Fix For: 0.7


 The documentation about @NavigationParameter says Instead of using 
 parameters in any case, it's also possible to configure them statically for 
 particular methods
 This seems that it isn't working when the @NavigationParameter is added to a 
 @Model class



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (DELTASPIKE-560) interceptor for @NavigationParameter

2014-04-04 Thread Gerhard Petracek (JIRA)

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13960375#comment-13960375
 ] 

Gerhard Petracek commented on DELTASPIKE-560:
-

i agree (that's why it was in codi that way) however, some IDEs outline an 
invalid usage.

 interceptor for @NavigationParameter
 

 Key: DELTASPIKE-560
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-560
 Project: DeltaSpike
  Issue Type: New Feature
  Components: JSF-Module
Affects Versions: 0.6
Reporter: Rafael Benevides
Assignee: Gerhard Petracek
 Fix For: 0.7


 The documentation about @NavigationParameter says Instead of using 
 parameters in any case, it's also possible to configure them statically for 
 particular methods
 This seems that it isn't working when the @NavigationParameter is added to a 
 @Model class



--
This message was sent by Atlassian JIRA
(v6.2#6252)