[jira] [Commented] (DELTASPIKE-577) Test-control: Add delegation of container boot
[
https://issues.apache.org/jira/browse/DELTASPIKE-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13975073#comment-13975073
]
Romain Manni-Bucau commented on DELTASPIKE-577:
---
${openejb.home}/conf. Depend surefire config but by default:
${project.basedir}/conf
Note: when ignored you have in logs:
{code}
Cannot find the configuration file [conf/openejb.xml]. Will attempt to create
one for the beans deployed.
{code}
and home is logged too:
{code}
INFO - openejb.home = /xxx/yyy
{code}
Test-control: Add delegation of container boot
--
Key: DELTASPIKE-577
URL: https://issues.apache.org/jira/browse/DELTASPIKE-577
Project: DeltaSpike
Issue Type: Improvement
Components: CdiControl, TestControl
Affects Versions: 0.7
Reporter: Karl Kildén
Priority: Minor
container.boot(); is used by Test-Control.
This is nice for simple tests with cdictrl-openejb but I think it would be
nice to have the possibility to target the boot(Map?, ? properties) that is
available for the openejb container. I want Test-Control to delegate to me so
I can boot myself.
I am thinking something like:
@TestControl(bootDelegate = PropertyAwareEjbBootDelegate.class)
public interface BootDelegate {
public void boot(CdiContainer cdiContainer);
}
That way tests could be way more dynamic and end users could boot the
container in any way they want.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (DELTASPIKE-577) Test-control: Add delegation of container boot
[
https://issues.apache.org/jira/browse/DELTASPIKE-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13975106#comment-13975106
]
Romain Manni-Bucau commented on DELTASPIKE-577:
---
wherever it is, it should be before the container is started
Test-control: Add delegation of container boot
--
Key: DELTASPIKE-577
URL: https://issues.apache.org/jira/browse/DELTASPIKE-577
Project: DeltaSpike
Issue Type: Improvement
Components: CdiControl, TestControl
Affects Versions: 0.7
Reporter: Karl Kildén
Priority: Minor
container.boot(); is used by Test-Control.
This is nice for simple tests with cdictrl-openejb but I think it would be
nice to have the possibility to target the boot(Map?, ? properties) that is
available for the openejb container. I want Test-Control to delegate to me so
I can boot myself.
I am thinking something like:
@TestControl(bootDelegate = PropertyAwareEjbBootDelegate.class)
public interface BootDelegate {
public void boot(CdiContainer cdiContainer);
}
That way tests could be way more dynamic and end users could boot the
container in any way they want.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (DELTASPIKE-577) Test-control: Add delegation of container boot
[
https://issues.apache.org/jira/browse/DELTASPIKE-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13975110#comment-13975110
]
Gerhard Petracek commented on DELTASPIKE-577:
-
@karl:
at that point the container is started already. use e.g. a static-block
Test-control: Add delegation of container boot
--
Key: DELTASPIKE-577
URL: https://issues.apache.org/jira/browse/DELTASPIKE-577
Project: DeltaSpike
Issue Type: Improvement
Components: CdiControl, TestControl
Affects Versions: 0.7
Reporter: Karl Kildén
Priority: Minor
container.boot(); is used by Test-Control.
This is nice for simple tests with cdictrl-openejb but I think it would be
nice to have the possibility to target the boot(Map?, ? properties) that is
available for the openejb container. I want Test-Control to delegate to me so
I can boot myself.
I am thinking something like:
@TestControl(bootDelegate = PropertyAwareEjbBootDelegate.class)
public interface BootDelegate {
public void boot(CdiContainer cdiContainer);
}
That way tests could be way more dynamic and end users could boot the
container in any way they want.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (DELTASPIKE-577) Test-control: Add delegation of container boot
[
https://issues.apache.org/jira/browse/DELTASPIKE-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974794#comment-13974794
]
Romain Manni-Bucau commented on DELTASPIKE-577:
---
No
-Dopenejb.configuration=/path/to/openejb.xml would work or just create a conf/
folder with openejb.xml inside.
You can also use system properties to declare resources
Test-control: Add delegation of container boot
--
Key: DELTASPIKE-577
URL: https://issues.apache.org/jira/browse/DELTASPIKE-577
Project: DeltaSpike
Issue Type: Improvement
Components: CdiControl, TestControl
Affects Versions: 0.7
Reporter: Karl Kildén
Priority: Minor
container.boot(); is used by Test-Control.
This is nice for simple tests with cdictrl-openejb but I think it would be
nice to have the possibility to target the boot(Map?, ? properties) that is
available for the openejb container. I want Test-Control to delegate to me so
I can boot myself.
I am thinking something like:
@TestControl(bootDelegate = PropertyAwareEjbBootDelegate.class)
public interface BootDelegate {
public void boot(CdiContainer cdiContainer);
}
That way tests could be way more dynamic and end users could boot the
container in any way they want.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (DELTASPIKE-577) Test-control: Add delegation of container boot
[
https://issues.apache.org/jira/browse/DELTASPIKE-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974833#comment-13974833
]
Romain Manni-Bucau commented on DELTASPIKE-577:
---
@Gerhard:
#1 owb should have (owb.properties)
#2 agree
#3 doesn't change the fact you *need* to start/stop by class otherwise you are
broken if you dont use it for all tests which is pretty sure today
#4 ok
The point for me is either we integrate it with boot(Map) or we drop boot(Map)
from the API but we need to stay consistent everywhere IMHO.
Test-control: Add delegation of container boot
--
Key: DELTASPIKE-577
URL: https://issues.apache.org/jira/browse/DELTASPIKE-577
Project: DeltaSpike
Issue Type: Improvement
Components: CdiControl, TestControl
Affects Versions: 0.7
Reporter: Karl Kildén
Priority: Minor
container.boot(); is used by Test-Control.
This is nice for simple tests with cdictrl-openejb but I think it would be
nice to have the possibility to target the boot(Map?, ? properties) that is
available for the openejb container. I want Test-Control to delegate to me so
I can boot myself.
I am thinking something like:
@TestControl(bootDelegate = PropertyAwareEjbBootDelegate.class)
public interface BootDelegate {
public void boot(CdiContainer cdiContainer);
}
That way tests could be way more dynamic and end users could boot the
container in any way they want.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (DELTASPIKE-577) Test-control: Add delegation of container boot
[
https://issues.apache.org/jira/browse/DELTASPIKE-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974851#comment-13974851
]
Gerhard Petracek commented on DELTASPIKE-577:
-
@romain:
@#1: yes - but you just add owb.properties to your test-classpath (see #3)
@#3: that's done already per default
no - we don't need to keep both in sync since that are different apis and
#boot(Map) was just added for openejb afaik (which i don't like at all btw.,
because it isn't portable across the existing implementations)
Test-control: Add delegation of container boot
--
Key: DELTASPIKE-577
URL: https://issues.apache.org/jira/browse/DELTASPIKE-577
Project: DeltaSpike
Issue Type: Improvement
Components: CdiControl, TestControl
Affects Versions: 0.7
Reporter: Karl Kildén
Priority: Minor
container.boot(); is used by Test-Control.
This is nice for simple tests with cdictrl-openejb but I think it would be
nice to have the possibility to target the boot(Map?, ? properties) that is
available for the openejb container. I want Test-Control to delegate to me so
I can boot myself.
I am thinking something like:
@TestControl(bootDelegate = PropertyAwareEjbBootDelegate.class)
public interface BootDelegate {
public void boot(CdiContainer cdiContainer);
}
That way tests could be way more dynamic and end users could boot the
container in any way they want.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (DELTASPIKE-577) Test-control: Add delegation of container boot
[
https://issues.apache.org/jira/browse/DELTASPIKE-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974852#comment-13974852
]
Romain Manni-Bucau commented on DELTASPIKE-577:
---
well it is portable but values are not.
I'm +1 to remove it btw if we don't integrate it with cdi runner. Just make it
highly inconsistent for me.
For me cdi runner should just be a CdiRule to help to handle scopes. Boot is
generally
Test-control: Add delegation of container boot
--
Key: DELTASPIKE-577
URL: https://issues.apache.org/jira/browse/DELTASPIKE-577
Project: DeltaSpike
Issue Type: Improvement
Components: CdiControl, TestControl
Affects Versions: 0.7
Reporter: Karl Kildén
Priority: Minor
container.boot(); is used by Test-Control.
This is nice for simple tests with cdictrl-openejb but I think it would be
nice to have the possibility to target the boot(Map?, ? properties) that is
available for the openejb container. I want Test-Control to delegate to me so
I can boot myself.
I am thinking something like:
@TestControl(bootDelegate = PropertyAwareEjbBootDelegate.class)
public interface BootDelegate {
public void boot(CdiContainer cdiContainer);
}
That way tests could be way more dynamic and end users could boot the
container in any way they want.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (DELTASPIKE-577) Test-control: Add delegation of container boot
[
https://issues.apache.org/jira/browse/DELTASPIKE-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974981#comment-13974981
]
Karl Kildén commented on DELTASPIKE-577:
Romain, I tried adding conf/openejb.xml here and there but not sure if I
succeeded with anything, not sure.
I have the normal maven structure with test/java and test/resources. Should it
be test/conf/openejb.xml?
Test-control: Add delegation of container boot
--
Key: DELTASPIKE-577
URL: https://issues.apache.org/jira/browse/DELTASPIKE-577
Project: DeltaSpike
Issue Type: Improvement
Components: CdiControl, TestControl
Affects Versions: 0.7
Reporter: Karl Kildén
Priority: Minor
container.boot(); is used by Test-Control.
This is nice for simple tests with cdictrl-openejb but I think it would be
nice to have the possibility to target the boot(Map?, ? properties) that is
available for the openejb container. I want Test-Control to delegate to me so
I can boot myself.
I am thinking something like:
@TestControl(bootDelegate = PropertyAwareEjbBootDelegate.class)
public interface BootDelegate {
public void boot(CdiContainer cdiContainer);
}
That way tests could be way more dynamic and end users could boot the
container in any way they want.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
