[jira] [Commented] (DELTASPIKE-889) ValidatorWrapper causes filtering of multiple custom validators in ValidatorTagHandler

2015-05-02 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14525472#comment-14525472
 ] 

Thomas Frühbeck commented on DELTASPIKE-889:


Thanks for the hint to use JsfModuleConfig, it works definitely in 
1.3.1-SNAPSHOT.
But w/o turning off the behavior is absolutely the same as in 1.3.0.

I tried to reproduce the problem in a sample page, but I failed. Is there any 
known further dependency, why we hit this problem? 


 ValidatorWrapper causes filtering of multiple custom validators in 
 ValidatorTagHandler
 --

 Key: DELTASPIKE-889
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-889
 Project: DeltaSpike
  Issue Type: Bug
  Components: JSF-Module
Affects Versions: 1.3.0
 Environment: JSF 2.2 / Wildfly 8.1 
Reporter: Thomas Frühbeck
Assignee: Thomas Andraschko
 Fix For: 1.4.0


 InjectionAwareApplicationWrapper wraps custom validators.
 In ValidatorTagHandlerDelegateImpl the check for class equality causes a 
 unique constraint on validators, so effectively filtering all wrapped 
 validators but the first:
 for (Validator validator : validators) {
 if (validator.getClass().equals(v.getClass())) {
 found = true;
 break;
 }
 }
 
 if (!found) {
 evh.addValidator(v);
 }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DELTASPIKE-889) ValidatorWrapper causes filtering of multiple custom validators in ValidatorTagHandler

2015-05-02 Thread Gerhard Petracek (JIRA) 

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14525478#comment-14525478
 ] 

Gerhard Petracek commented on DELTASPIKE-889:
-

no and with the current snapshot you can e.g. also drop javassist.
if you like to debug it - it's in InjectionAwareApplicationWrapper
#managedOrDefaultConverter and #managedOrDefaultValidator.
with the current snapshot you shouldn't see ConverterWrapper or 
ValidatorWrapper for custom tags, because #resolveManagedConverter and 
#resolveManagedValidator should find the result/s which will get returned (if 
the converters and validators are valid - see 
ConverterAndValidatorProxyExtension)

 ValidatorWrapper causes filtering of multiple custom validators in 
 ValidatorTagHandler
 --

 Key: DELTASPIKE-889
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-889
 Project: DeltaSpike
  Issue Type: Bug
  Components: JSF-Module
Affects Versions: 1.3.0
 Environment: JSF 2.2 / Wildfly 8.1 
Reporter: Thomas Frühbeck
Assignee: Thomas Andraschko
 Fix For: 1.4.0


 InjectionAwareApplicationWrapper wraps custom validators.
 In ValidatorTagHandlerDelegateImpl the check for class equality causes a 
 unique constraint on validators, so effectively filtering all wrapped 
 validators but the first:
 for (Validator validator : validators) {
 if (validator.getClass().equals(v.getClass())) {
 found = true;
 break;
 }
 }
 
 if (!found) {
 evh.addValidator(v);
 }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DELTASPIKE-889) ValidatorWrapper causes filtering of multiple custom validators in ValidatorTagHandler

2015-05-01 Thread Gerhard Petracek (JIRA) 

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523249#comment-14523249
 ] 

Gerhard Petracek commented on DELTASPIKE-889:
-

please add javassist as dependency to get proxied converters/validators (with 
v1.3.0).
however, please also test your application with the latest snapshot of v1.3.1 
(since we move to asm and custom proxies).
we have arquillian-drone based tests which pass also on wildfly - there 
shouldn't be an issue.

 ValidatorWrapper causes filtering of multiple custom validators in 
 ValidatorTagHandler
 --

 Key: DELTASPIKE-889
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-889
 Project: DeltaSpike
  Issue Type: Bug
  Components: JSF-Module
Affects Versions: 1.3.0
 Environment: JSF 2.2 / Wildfly 8.1 
Reporter: Thomas Frühbeck
  Labels: custom, jsf, validator

 InjectionAwareApplicationWrapper wraps custom validators.
 In ValidatorTagHandlerDelegateImpl the check for class equality causes a 
 unique constraint on validators, so effectively filtering all wrapped 
 validators but the first:
 for (Validator validator : validators) {
 if (validator.getClass().equals(v.getClass())) {
 found = true;
 break;
 }
 }
 
 if (!found) {
 evh.addValidator(v);
 }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)