[jira] [Commented] (DELTASPIKE-901) org.apache.deltaspike.data.impl.builder.postprocessor.CountQueryPostProcessor doesn't respect order by

2015-05-22 Thread Rafael Benevides (JIRA) 

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14556595#comment-14556595
 ] 

Rafael Benevides commented on DELTASPIKE-901:
-

Patch tested and applied. Is there any more item that prevents to close this 
issue ?

 org.apache.deltaspike.data.impl.builder.postprocessor.CountQueryPostProcessor 
 doesn't respect order by
 --

 Key: DELTASPIKE-901
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-901
 Project: DeltaSpike
  Issue Type: Bug
Affects Versions: 1.3.0
Reporter: Romain Manni-Bucau
 Attachments: DELTASPIKE-901.patch


 using select p from MyEntity p order by p.someString
 and
 {code}
 @Query(named = MyEntity.findAll)
 QueryResultMyEntity all(@FirstResult int start, @MaxResults int 
 pageSize);
 {code}
 I get 
 {code}
 org.apache.openjpa.lib.jdbc.ReportingSQLException: expression not in 
 aggregate or GROUP BY columns: T0.PROPERTY_KEY {SELECT 
 COUNT(t0.property_key), t0.property_key FROM properties t0} [code=-5574, 
 state=42574]
 {code}
 the count post processor doesn't handle the order by correctly.
 Wonder if we should add order by parameters in the select clause or just 
 ignore it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DELTASPIKE-901) org.apache.deltaspike.data.impl.builder.postprocessor.CountQueryPostProcessor doesn't respect order by

2015-05-19 Thread Daniel Cunha (soro) (JIRA) 

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14551476#comment-14551476
 ] 

Daniel Cunha (soro) commented on DELTASPIKE-901:


Updated patch. Improvement in test. : )

 org.apache.deltaspike.data.impl.builder.postprocessor.CountQueryPostProcessor 
 doesn't respect order by
 --

 Key: DELTASPIKE-901
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-901
 Project: DeltaSpike
  Issue Type: Bug
Affects Versions: 1.3.0
Reporter: Romain Manni-Bucau
 Attachments: DELTASPIKE-901_2.patch


 using select p from MyEntity p order by p.someString
 and
 {code}
 @Query(named = MyEntity.findAll)
 QueryResultMyEntity all(@FirstResult int start, @MaxResults int 
 pageSize);
 {code}
 I get 
 {code}
 org.apache.openjpa.lib.jdbc.ReportingSQLException: expression not in 
 aggregate or GROUP BY columns: T0.PROPERTY_KEY {SELECT 
 COUNT(t0.property_key), t0.property_key FROM properties t0} [code=-5574, 
 state=42574]
 {code}
 the count post processor doesn't handle the order by correctly.
 Wonder if we should add order by parameters in the select clause or just 
 ignore it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DELTASPIKE-901) org.apache.deltaspike.data.impl.builder.postprocessor.CountQueryPostProcessor doesn't respect order by

2015-05-16 Thread Romain Manni-Bucau (JIRA) 

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14546837#comment-14546837
 ] 

Romain Manni-Bucau commented on DELTASPIKE-901:
---

Seems this commit fixed it 
https://github.com/apache/deltaspike/commit/81f47b3260a4fffc7883d50ac2fc868001fb4bb7

Few more inputs in my case:

- was using openjpa
- order by was on primary key which was a String

If you have a test with these 2 constraints I'm happy :)

 org.apache.deltaspike.data.impl.builder.postprocessor.CountQueryPostProcessor 
 doesn't respect order by
 --

 Key: DELTASPIKE-901
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-901
 Project: DeltaSpike
  Issue Type: Bug
Affects Versions: 1.3.0
Reporter: Romain Manni-Bucau

 using select p from MyEntity p order by p.someString
 and
 {code}
 @Query(named = MyEntity.findAll)
 QueryResultMyEntity all(@FirstResult int start, @MaxResults int 
 pageSize);
 {code}
 I get 
 {code}
 org.apache.openjpa.lib.jdbc.ReportingSQLException: expression not in 
 aggregate or GROUP BY columns: T0.PROPERTY_KEY {SELECT 
 COUNT(t0.property_key), t0.property_key FROM properties t0} [code=-5574, 
 state=42574]
 {code}
 the count post processor doesn't handle the order by correctly.
 Wonder if we should add order by parameters in the select clause or just 
 ignore it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (DELTASPIKE-901) org.apache.deltaspike.data.impl.builder.postprocessor.CountQueryPostProcessor doesn't respect order by

2015-05-15 Thread Daniel Cunha (soro) (JIRA) 

[ 
https://issues.apache.org/jira/browse/DELTASPIKE-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14546225#comment-14546225
 ] 

Daniel Cunha (soro) commented on DELTASPIKE-901:


Hi [~romain.manni-bucau],

I tested here on snapshot version and it seem work fine.
https://github.com/danielsoro/deltaspike/commit/6f9a03155ecc7ff387b8613ab487f003bc710ea8

I'll put this patch to add this test in data module if you validate as ok.
See you. :)

 org.apache.deltaspike.data.impl.builder.postprocessor.CountQueryPostProcessor 
 doesn't respect order by
 --

 Key: DELTASPIKE-901
 URL: https://issues.apache.org/jira/browse/DELTASPIKE-901
 Project: DeltaSpike
  Issue Type: Bug
Affects Versions: 1.3.0
Reporter: Romain Manni-Bucau

 using select p from MyEntity p order by p.someString
 and
 {code}
 @Query(named = MyEntity.findAll)
 QueryResultMyEntity all(@FirstResult int start, @MaxResults int 
 pageSize);
 {code}
 I get 
 {code}
 org.apache.openjpa.lib.jdbc.ReportingSQLException: expression not in 
 aggregate or GROUP BY columns: T0.PROPERTY_KEY {SELECT 
 COUNT(t0.property_key), t0.property_key FROM properties t0} [code=-5574, 
 state=42574]
 {code}
 the count post processor doesn't handle the order by correctly.
 Wonder if we should add order by parameters in the select clause or just 
 ignore it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)