Re: [DISCUSS] GitHub PR Builder

[John D. Ament]

Yes, sorry, I wasn't clear.  If you rebase their commit then it has a
tendency to not close the PR which is when you need "This closes #123"

John

On Wed, Jul 6, 2016 at 6:21 AM Daniel Cunha  wrote:

> Hi John,
>
> When we're following the steps presented by asg-git, the PR is marked like
> merged.
> For example:
> https://github.com/apache/deltaspike/pull/57
>
> The steps:
>
> https://issues.apache.org/jira/browse/DELTASPIKE-1180?focusedCommentId=15361289=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15361289
>
>
> On Wed, Jul 6, 2016 at 6:50 AM, John D. Ament 
> wrote:
>
> > Short answer is you can't.  You need to pull the branch and push to our
> > master.  You need to make the commit message include the "This closes
> #123"
> > line to make github know to close it.  Or ask the requestor to close it.
> >
> > There is an open git-dual POC from infra.  Last I looked, it wasn't doing
> > well.  May be worth raising to the board?
> >
> > John
> >
> > On Wed, Jul 6, 2016 at 4:44 AM Thomas Andraschko <
> > andraschko.tho...@gmail.com> wrote:
> >
> > > +1
> > >
> > > Stupid question but how can i merge PRs from github?
> > > The last PRs from georgekankava
> > > <
> > >
> >
> https://github.com/apache/deltaspike/issues?q=is%3Apr+is%3Aopen+author%3Ageorgekankava
> > > >
> > > are looking good.
> > >
> > > 2016-07-06 8:54 GMT+02:00 Christian Kaltepoth  >:
> > >
> > > > I think such build jobs are very valuable. So +1 for them.
> > > >
> > > >
> > > >
> > > > 2016-07-06 4:06 GMT+02:00 John D. Ament :
> > > >
> > > > > Hey guys
> > > > >
> > > > > We've been getting a few more PRs over github.  Its IMHO easier to
> > > merge
> > > > > those instead of patches in JIRA tickets.
> > > > >
> > > > > I went ahead and created a PR build job.  When someone raises a PR
> > > > against
> > > > > us in github, it will trigger a build.  Right now that build only
> > runs
> > > > OWB
> > > > > 1.6.x, but I think it would be good to get more tests in there.
> Say
> > > one
> > > > > embedded container and one full container?
> > > > >
> > > > > What do others think? Useful? Not useful?
> > > > >
> > > > > John
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Christian Kaltepoth
> > > > Blog: http://blog.kaltepoth.de/
> > > > Twitter: http://twitter.com/chkal
> > > > GitHub: https://github.com/chkal
> > > >
> > >
> >
>
>
>
> --
> Daniel Cunha
> https://twitter.com/dvlc_
> http://www.tomitribe.com
> http://www.tomitribe.io
>

Re: [DISCUSS] GitHub PR Builder

[Daniel Cunha]

Hi John,

When we're following the steps presented by asg-git, the PR is marked like
merged.
For example:
https://github.com/apache/deltaspike/pull/57

The steps:
https://issues.apache.org/jira/browse/DELTASPIKE-1180?focusedCommentId=15361289=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15361289


On Wed, Jul 6, 2016 at 6:50 AM, John D. Ament  wrote:

> Short answer is you can't.  You need to pull the branch and push to our
> master.  You need to make the commit message include the "This closes #123"
> line to make github know to close it.  Or ask the requestor to close it.
>
> There is an open git-dual POC from infra.  Last I looked, it wasn't doing
> well.  May be worth raising to the board?
>
> John
>
> On Wed, Jul 6, 2016 at 4:44 AM Thomas Andraschko <
> andraschko.tho...@gmail.com> wrote:
>
> > +1
> >
> > Stupid question but how can i merge PRs from github?
> > The last PRs from georgekankava
> > <
> >
> https://github.com/apache/deltaspike/issues?q=is%3Apr+is%3Aopen+author%3Ageorgekankava
> > >
> > are looking good.
> >
> > 2016-07-06 8:54 GMT+02:00 Christian Kaltepoth :
> >
> > > I think such build jobs are very valuable. So +1 for them.
> > >
> > >
> > >
> > > 2016-07-06 4:06 GMT+02:00 John D. Ament :
> > >
> > > > Hey guys
> > > >
> > > > We've been getting a few more PRs over github.  Its IMHO easier to
> > merge
> > > > those instead of patches in JIRA tickets.
> > > >
> > > > I went ahead and created a PR build job.  When someone raises a PR
> > > against
> > > > us in github, it will trigger a build.  Right now that build only
> runs
> > > OWB
> > > > 1.6.x, but I think it would be good to get more tests in there.  Say
> > one
> > > > embedded container and one full container?
> > > >
> > > > What do others think? Useful? Not useful?
> > > >
> > > > John
> > > >
> > >
> > >
> > >
> > > --
> > > Christian Kaltepoth
> > > Blog: http://blog.kaltepoth.de/
> > > Twitter: http://twitter.com/chkal
> > > GitHub: https://github.com/chkal
> > >
> >
>



-- 
Daniel Cunha
https://twitter.com/dvlc_
http://www.tomitribe.com
http://www.tomitribe.io

Re: [DISCUSS] GitHub PR Builder

[John D. Ament]

Short answer is you can't.  You need to pull the branch and push to our
master.  You need to make the commit message include the "This closes #123"
line to make github know to close it.  Or ask the requestor to close it.

There is an open git-dual POC from infra.  Last I looked, it wasn't doing
well.  May be worth raising to the board?

John

On Wed, Jul 6, 2016 at 4:44 AM Thomas Andraschko <
andraschko.tho...@gmail.com> wrote:

> +1
>
> Stupid question but how can i merge PRs from github?
> The last PRs from georgekankava
> <
> https://github.com/apache/deltaspike/issues?q=is%3Apr+is%3Aopen+author%3Ageorgekankava
> >
> are looking good.
>
> 2016-07-06 8:54 GMT+02:00 Christian Kaltepoth :
>
> > I think such build jobs are very valuable. So +1 for them.
> >
> >
> >
> > 2016-07-06 4:06 GMT+02:00 John D. Ament :
> >
> > > Hey guys
> > >
> > > We've been getting a few more PRs over github.  Its IMHO easier to
> merge
> > > those instead of patches in JIRA tickets.
> > >
> > > I went ahead and created a PR build job.  When someone raises a PR
> > against
> > > us in github, it will trigger a build.  Right now that build only runs
> > OWB
> > > 1.6.x, but I think it would be good to get more tests in there.  Say
> one
> > > embedded container and one full container?
> > >
> > > What do others think? Useful? Not useful?
> > >
> > > John
> > >
> >
> >
> >
> > --
> > Christian Kaltepoth
> > Blog: http://blog.kaltepoth.de/
> > Twitter: http://twitter.com/chkal
> > GitHub: https://github.com/chkal
> >
>

Re: [DISCUSS] GitHub PR Builder

[Thomas Andraschko]

+1

Stupid question but how can i merge PRs from github?
The last PRs from georgekankava

are looking good.

2016-07-06 8:54 GMT+02:00 Christian Kaltepoth :

> I think such build jobs are very valuable. So +1 for them.
>
>
>
> 2016-07-06 4:06 GMT+02:00 John D. Ament :
>
> > Hey guys
> >
> > We've been getting a few more PRs over github.  Its IMHO easier to merge
> > those instead of patches in JIRA tickets.
> >
> > I went ahead and created a PR build job.  When someone raises a PR
> against
> > us in github, it will trigger a build.  Right now that build only runs
> OWB
> > 1.6.x, but I think it would be good to get more tests in there.  Say one
> > embedded container and one full container?
> >
> > What do others think? Useful? Not useful?
> >
> > John
> >
>
>
>
> --
> Christian Kaltepoth
> Blog: http://blog.kaltepoth.de/
> Twitter: http://twitter.com/chkal
> GitHub: https://github.com/chkal
>

Re: [DISCUSS] GitHub PR Builder

[Christian Kaltepoth]

I think such build jobs are very valuable. So +1 for them.



2016-07-06 4:06 GMT+02:00 John D. Ament :

> Hey guys
>
> We've been getting a few more PRs over github.  Its IMHO easier to merge
> those instead of patches in JIRA tickets.
>
> I went ahead and created a PR build job.  When someone raises a PR against
> us in github, it will trigger a build.  Right now that build only runs OWB
> 1.6.x, but I think it would be good to get more tests in there.  Say one
> embedded container and one full container?
>
> What do others think? Useful? Not useful?
>
> John
>



-- 
Christian Kaltepoth
Blog: http://blog.kaltepoth.de/
Twitter: http://twitter.com/chkal
GitHub: https://github.com/chkal