[GitHub] [directory-scimple] erant10 commented on pull request #213: Draft: Applying Patches to resources

2023-01-03 Thread GitBox 


erant10 commented on PR #213:
URL: 
https://github.com/apache/directory-scimple/pull/213#issuecomment-1370204659

   @bdemers My main concern with this implementation is that PatchHandler is 
coupled with InMemoryFilterExpression, which is only meant to be used with the 
in-memory implementation... I wonder if there is a way to abstract-ify this 
FilterExpression so that it can be easily modified for non-demo purposes...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org

[GitHub] [directory-scimple] erant10 commented on a diff in pull request #213: Draft: Applying Patches to resources

2023-01-03 Thread GitBox 


erant10 commented on code in PR #213:
URL: https://github.com/apache/directory-scimple/pull/213#discussion_r1060889752


##
scim-core/src/main/java/org/apache/directory/scim/core/repository/ObjectMapperProvider.java:
##
@@ -0,0 +1,27 @@
+package org.apache.directory.scim.core.repository;
+
+import com.fasterxml.jackson.annotation.JsonInclude;
+import com.fasterxml.jackson.databind.AnnotationIntrospector;
+import com.fasterxml.jackson.databind.DeserializationFeature;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.introspect.AnnotationIntrospectorPair;
+import com.fasterxml.jackson.databind.introspect.JacksonAnnotationIntrospector;
+import 
com.fasterxml.jackson.module.jakarta.xmlbind.JakartaXmlBindAnnotationIntrospector;
+import 
com.fasterxml.jackson.module.jakarta.xmlbind.JakartaXmlBindAnnotationModule;
+
+public class ObjectMapperProvider {

Review Comment:
   of course, feel free to merge :)
   
   Yeah I got the map conversion idea from this pr - 
https://github.com/apache/directory-scimple/pull/29
   which might not be the most efficient but it seems simple enough...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org

[GitHub] [directory-scimple] bdemers commented on pull request #213: Draft: Applying Patches to resources

2023-01-03 Thread GitBox 


bdemers commented on PR #213:
URL: 
https://github.com/apache/directory-scimple/pull/213#issuecomment-1370126103

   I almost forgot, but if you haven't already, can you fill out an Apache ICLA 
(or CCLA in needed)
   https://www.apache.org/licenses/contributor-agreements.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org

[GitHub] [directory-scimple] bdemers commented on a diff in pull request #213: Draft: Applying Patches to resources

2023-01-03 Thread GitBox 


bdemers commented on code in PR #213:
URL: https://github.com/apache/directory-scimple/pull/213#discussion_r1060871770


##
scim-core/src/main/java/org/apache/directory/scim/core/repository/ObjectMapperProvider.java:
##
@@ -0,0 +1,27 @@
+package org.apache.directory.scim.core.repository;
+
+import com.fasterxml.jackson.annotation.JsonInclude;
+import com.fasterxml.jackson.databind.AnnotationIntrospector;
+import com.fasterxml.jackson.databind.DeserializationFeature;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.introspect.AnnotationIntrospectorPair;
+import com.fasterxml.jackson.databind.introspect.JacksonAnnotationIntrospector;
+import 
com.fasterxml.jackson.module.jakarta.xmlbind.JakartaXmlBindAnnotationIntrospector;
+import 
com.fasterxml.jackson.module.jakarta.xmlbind.JakartaXmlBindAnnotationModule;
+
+public class ObjectMapperProvider {

Review Comment:
   I recently refactored some of the JSON/ObjectMapper bits.
   I'm not 100% that will help with this usage, but it is something we can 
investigate.
   
   
https://github.com/apache/directory-scimple/blob/develop/scim-core/src/main/java/org/apache/directory/scim/core/json/ObjectMapperFactory.java
 
   
   This _may_ come into play when dealing with patches that contain values from 
SCIM Extensions.
   That said, with your approach using `objectAsMap` it _may_ not make a 
difference.
   (Mostly a note to myself, to go back and look at the ObjectMapper-related 
bits )



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org

[GitHub] [directory-scimple] bdemers commented on pull request #213: Draft: Applying Patches to resources

2023-01-03 Thread GitBox 


bdemers commented on PR #213:
URL: 
https://github.com/apache/directory-scimple/pull/213#issuecomment-1370112056

   Related PR for cleaning up/enabling patch related tests: #217


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org

[GitHub] [directory-scimple] bdemers opened a new pull request, #217: Enable UpdateRequest patch related tests

2023-01-03 Thread GitBox 


bdemers opened a new pull request, #217:
URL: https://github.com/apache/directory-scimple/pull/217

   These tests were disabled, so they have been reworked with a new 
PatchOperationAssert
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org

[GitHub] [directory-scimple] bdemers merged pull request #214: Bump dependency-check-maven from 7.4.1 to 7.4.3

2023-01-03 Thread GitBox 


bdemers merged PR #214:
URL: https://github.com/apache/directory-scimple/pull/214


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org

[GitHub] [directory-scimple] bdemers merged pull request #215: Bump mockito-junit-jupiter from 4.10.0 to 4.11.0

2023-01-03 Thread GitBox 


bdemers merged PR #215:
URL: https://github.com/apache/directory-scimple/pull/215


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org

[GitHub] [directory-scimple] bdemers merged pull request #216: Bump mockito-core from 4.10.0 to 4.11.0

2023-01-03 Thread GitBox 


bdemers merged PR #216:
URL: https://github.com/apache/directory-scimple/pull/216


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org