[GitHub] [directory-studio] seelmann commented on pull request #33: DIRSTUDIO-1298: Fix the Postal Address value editor en-/decoding.

2022-06-12 Thread GitBox


seelmann commented on PR #33:
URL: https://github.com/apache/directory-studio/pull/33#issuecomment-1153226030

   Adapted the tests: https://github.com/apache/directory-studio/pull/38


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org



[GitHub] [directory-studio] seelmann commented on pull request #33: DIRSTUDIO-1298: Fix the Postal Address value editor en-/decoding.

2022-05-17 Thread GitBox


seelmann commented on PR #33:
URL: https://github.com/apache/directory-studio/pull/33#issuecomment-1128453433

   > It would (of course) be nice to have an integration test also for the 
`AddressDialog`, but as far as I can tell there aren't any existing tests for 
those dialogs
   
   I created a test, please adjust as needed: 
https://github.com/apache/directory-studio/pull/34
   
   > I fear that writing one from scratch myself would be beyond my 
capabilities.
   
   I have to disagree :)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org