Re: [VOTE] Release 0.4.0, release candidate #1

[Flavio Junqueira]

You're saying my machine is slow... ;-)

-Flavio

> On 12 Jan 2017, at 16:38, Sijie Guo  wrote:
> 
> Yeah, currently some of the tests are time dependent. So they failed
> sometimes when the machine is slow. There were efforts on improving this
> and will also do this in next release.
> 
> Sijie
> 
> On Jan 12, 2017 3:32 AM, "Flavio Junqueira"  > wrote:
> 
>> Ok, so I've seen the following test cases showing errors:
>> 
>> TestBKDistributedLogManager.testNumberOfTransactionsWithIn
>> progressAtEnd:325
>> TestAsyncReaderLock.testReaderLockDlmClosed » Cancellation
>> 
>> They don't seem to fail consistently for me, though.
>> 
>> -Flavio
>> 
>>> On 10 Jan 2017, at 18:10, Sijie Guo  wrote:
>>> 
>>> Liang had a pull request for the assembly issue. Going to cancel this
>> vote
>>> and produce a new RC.
>>> 
>>> Flavio, what are the tests failed in your case?
>>> 
>>> Sijie
>>> 
>>> On Jan 10, 2017 9:10 AM, "Flavio Junqueira" >>  > f...@apache.org >> wrote:
>>> 
>>> Yeah, I can't build because of the same issue:
>>> 
>>>   [ERROR] Failed to execute goal org.apache.maven.plugins:
>>> maven-assembly-plugin:2.2.1:single (default) on project
>>> distributedlog-service: Failed to create assembly: Error adding file to
>>>   archive: distributedlog-0.4.0-incubating/distributedlog-
>> service/../README.md
>>> isn't a file. -> [Help 1]
>>> 
>>> The command I ran is:
>>> 
>>>  mvn clean apache-rat:check package findbugs:check -DskipTests
>>> 
>>> I also tried other commands, and they all seem to fail on tests.
>>> 
>>> -Flavio
>>> 
 On 10 Jan 2017, at 07:24, Xi Liu > wrote:
 
 On Mon, Jan 9, 2017 at 8:00 PM, liang xie 
>> > >> xieliang...@gmail.com>> wrote:
 
> Glad to see 0.4 will be release soon :)
> I could not find tutorials package from link[2], it should be released
> as well, please correct me if i am wrong.
> I can pass this command with current git master code: "mvn clean
> apache-rat:check package findbugs:check -DskipTests", but failed with
> from distributedlog-0.4.0-incubating-src.tar.gz which downloaded from
> dist.apache.org, the error msg:
> 
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-assembly-plugin:2.2.1:single (default)
> on project distributedlog-service: Failed to create assembly: Error
> adding file to archive:
> /tmp/distributedlog-0.4.0-incubating/distributedlog-
>> service/../README.md
> isn't a file. -> [Help 1]
> 
 
 I also saw this issue.
 
 
> 
> And none of you saw this : DL-181, it can be reproduced on my local
> box always w/o patched,  weird...
> 
> On Mon, Jan 9, 2017 at 12:04 PM, Sijie Guo  wrote:
>> Hi all,
>> 
>> Please review and vote on the release candidate #1 for the version
>>> 0.4.0,
>> as follows:
>> 
>> [ ] +1, Approve the release
>> [ ] -1, Do not approve the release (please provide specific comments)
>> 
>> The complete staging area is available for your review, which
>> includes:
>> 
>>  * JIRA release notes [1],
>>  * the official Apache source release to be deployed to
> dist.apache.org
>> [2],
>>  * all artifacts to be deployed to the Maven Central Repository [3],
>>  * source code tag "v0.4.0-RC1" [4],
>>  * website pull request listing the release [5] and publishing the
>> API
>> reference manual.
>> 
>> A simple instruction for validation the source and binary packages.
>> 
>> - source package: run "*./scripts/integration/smoketest.sh*" after
> building
>> the package with "*mvn clean apache-rat:check package findbugs:check
>> -DskipTests*"
>> 
>> The vote will be open for at least 72 hours. It is adopted by majority
>> approval, with at least 3 PPMC affirmative votes.
>> 
>> Thanks,
>> Sijie
>> 
>> [1]
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12320620=12337980
>> [2]
>> https://dist.apache.org/repos/dist/dev/incubator/
>> distributedlog/0.4.0-
> incubating/
>> [3]
>> https://repository.apache.org/content/repositories/
> orgapachedistributedlog-1001/
>> [4]
>> https://github.com/apache/incubator-distributedlog/tree/
> v0.4.0-incubating-RC1
>> [5] https://github.com/apache/incubator-distributedlog/pull/109

Re: [VOTE] Release 0.4.0, release candidate #1

[Sijie Guo]

Yeah, currently some of the tests are time dependent. So they failed
sometimes when the machine is slow. There were efforts on improving this
and will also do this in next release.

Sijie

On Jan 12, 2017 3:32 AM, "Flavio Junqueira"  wrote:

> Ok, so I've seen the following test cases showing errors:
>
> TestBKDistributedLogManager.testNumberOfTransactionsWithIn
> progressAtEnd:325
> TestAsyncReaderLock.testReaderLockDlmClosed » Cancellation
>
> They don't seem to fail consistently for me, though.
>
> -Flavio
>
> > On 10 Jan 2017, at 18:10, Sijie Guo  wrote:
> >
> > Liang had a pull request for the assembly issue. Going to cancel this
> vote
> > and produce a new RC.
> >
> > Flavio, what are the tests failed in your case?
> >
> > Sijie
> >
> > On Jan 10, 2017 9:10 AM, "Flavio Junqueira" > wrote:
> >
> > Yeah, I can't build because of the same issue:
> >
> >[ERROR] Failed to execute goal org.apache.maven.plugins:
> > maven-assembly-plugin:2.2.1:single (default) on project
> > distributedlog-service: Failed to create assembly: Error adding file to
> >archive: distributedlog-0.4.0-incubating/distributedlog-
> service/../README.md
> > isn't a file. -> [Help 1]
> >
> > The command I ran is:
> >
> >   mvn clean apache-rat:check package findbugs:check -DskipTests
> >
> > I also tried other commands, and they all seem to fail on tests.
> >
> > -Flavio
> >
> >> On 10 Jan 2017, at 07:24, Xi Liu  wrote:
> >>
> >> On Mon, Jan 9, 2017 at 8:00 PM, liang xie    > xieliang...@gmail.com>> wrote:
> >>
> >>> Glad to see 0.4 will be release soon :)
> >>> I could not find tutorials package from link[2], it should be released
> >>> as well, please correct me if i am wrong.
> >>> I can pass this command with current git master code: "mvn clean
> >>> apache-rat:check package findbugs:check -DskipTests", but failed with
> >>> from distributedlog-0.4.0-incubating-src.tar.gz which downloaded from
> >>> dist.apache.org, the error msg:
> >>>
> >>> [ERROR] Failed to execute goal
> >>> org.apache.maven.plugins:maven-assembly-plugin:2.2.1:single (default)
> >>> on project distributedlog-service: Failed to create assembly: Error
> >>> adding file to archive:
> >>> /tmp/distributedlog-0.4.0-incubating/distributedlog-
> service/../README.md
> >>> isn't a file. -> [Help 1]
> >>>
> >>
> >> I also saw this issue.
> >>
> >>
> >>>
> >>> And none of you saw this : DL-181, it can be reproduced on my local
> >>> box always w/o patched,  weird...
> >>>
> >>> On Mon, Jan 9, 2017 at 12:04 PM, Sijie Guo  wrote:
>  Hi all,
> 
>  Please review and vote on the release candidate #1 for the version
> > 0.4.0,
>  as follows:
> 
>  [ ] +1, Approve the release
>  [ ] -1, Do not approve the release (please provide specific comments)
> 
>  The complete staging area is available for your review, which
> includes:
> 
>    * JIRA release notes [1],
>    * the official Apache source release to be deployed to
> >>> dist.apache.org
>  [2],
>    * all artifacts to be deployed to the Maven Central Repository [3],
>    * source code tag "v0.4.0-RC1" [4],
>    * website pull request listing the release [5] and publishing the
> API
>  reference manual.
> 
>  A simple instruction for validation the source and binary packages.
> 
>  - source package: run "*./scripts/integration/smoketest.sh*" after
> >>> building
>  the package with "*mvn clean apache-rat:check package findbugs:check
>  -DskipTests*"
> 
>  The vote will be open for at least 72 hours. It is adopted by majority
>  approval, with at least 3 PPMC affirmative votes.
> 
>  Thanks,
>  Sijie
> 
>  [1]
>  https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> >>> projectId=12320620=12337980
>  [2]
>  https://dist.apache.org/repos/dist/dev/incubator/
> distributedlog/0.4.0-
> >>> incubating/
>  [3]
>  https://repository.apache.org/content/repositories/
> >>> orgapachedistributedlog-1001/
>  [4]
>  https://github.com/apache/incubator-distributedlog/tree/
> >>> v0.4.0-incubating-RC1
>  [5] https://github.com/apache/incubator-distributedlog/pull/109
>
>

Re: [VOTE] Release 0.4.0, release candidate #1

[Flavio Junqueira]

Ok, so I've seen the following test cases showing errors:

TestBKDistributedLogManager.testNumberOfTransactionsWithInprogressAtEnd:325
TestAsyncReaderLock.testReaderLockDlmClosed » Cancellation

They don't seem to fail consistently for me, though.

-Flavio

> On 10 Jan 2017, at 18:10, Sijie Guo  wrote:
> 
> Liang had a pull request for the assembly issue. Going to cancel this vote
> and produce a new RC.
> 
> Flavio, what are the tests failed in your case?
> 
> Sijie
> 
> On Jan 10, 2017 9:10 AM, "Flavio Junqueira"  > wrote:
> 
> Yeah, I can't build because of the same issue:
> 
>[ERROR] Failed to execute goal org.apache.maven.plugins:
> maven-assembly-plugin:2.2.1:single (default) on project
> distributedlog-service: Failed to create assembly: Error adding file to
>archive: 
> distributedlog-0.4.0-incubating/distributedlog-service/../README.md
> isn't a file. -> [Help 1]
> 
> The command I ran is:
> 
>   mvn clean apache-rat:check package findbugs:check -DskipTests
> 
> I also tried other commands, and they all seem to fail on tests.
> 
> -Flavio
> 
>> On 10 Jan 2017, at 07:24, Xi Liu  wrote:
>> 
>> On Mon, Jan 9, 2017 at 8:00 PM, liang xie >   xieliang...@gmail.com>> wrote:
>> 
>>> Glad to see 0.4 will be release soon :)
>>> I could not find tutorials package from link[2], it should be released
>>> as well, please correct me if i am wrong.
>>> I can pass this command with current git master code: "mvn clean
>>> apache-rat:check package findbugs:check -DskipTests", but failed with
>>> from distributedlog-0.4.0-incubating-src.tar.gz which downloaded from
>>> dist.apache.org, the error msg:
>>> 
>>> [ERROR] Failed to execute goal
>>> org.apache.maven.plugins:maven-assembly-plugin:2.2.1:single (default)
>>> on project distributedlog-service: Failed to create assembly: Error
>>> adding file to archive:
>>> /tmp/distributedlog-0.4.0-incubating/distributedlog-service/../README.md
>>> isn't a file. -> [Help 1]
>>> 
>> 
>> I also saw this issue.
>> 
>> 
>>> 
>>> And none of you saw this : DL-181, it can be reproduced on my local
>>> box always w/o patched,  weird...
>>> 
>>> On Mon, Jan 9, 2017 at 12:04 PM, Sijie Guo  wrote:
 Hi all,
 
 Please review and vote on the release candidate #1 for the version
> 0.4.0,
 as follows:
 
 [ ] +1, Approve the release
 [ ] -1, Do not approve the release (please provide specific comments)
 
 The complete staging area is available for your review, which includes:
 
   * JIRA release notes [1],
   * the official Apache source release to be deployed to
>>> dist.apache.org
 [2],
   * all artifacts to be deployed to the Maven Central Repository [3],
   * source code tag "v0.4.0-RC1" [4],
   * website pull request listing the release [5] and publishing the API
 reference manual.
 
 A simple instruction for validation the source and binary packages.
 
 - source package: run "*./scripts/integration/smoketest.sh*" after
>>> building
 the package with "*mvn clean apache-rat:check package findbugs:check
 -DskipTests*"
 
 The vote will be open for at least 72 hours. It is adopted by majority
 approval, with at least 3 PPMC affirmative votes.
 
 Thanks,
 Sijie
 
 [1]
 https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>>> projectId=12320620=12337980
 [2]
 https://dist.apache.org/repos/dist/dev/incubator/distributedlog/0.4.0-
>>> incubating/
 [3]
 https://repository.apache.org/content/repositories/
>>> orgapachedistributedlog-1001/
 [4]
 https://github.com/apache/incubator-distributedlog/tree/
>>> v0.4.0-incubating-RC1
 [5] https://github.com/apache/incubator-distributedlog/pull/109

Re: [VOTE] Release 0.4.0, release candidate #1

[Sijie Guo]

Liang had a pull request for the assembly issue. Going to cancel this vote
and produce a new RC.

Flavio, what are the tests failed in your case?

Sijie

On Jan 10, 2017 9:10 AM, "Flavio Junqueira"  wrote:

Yeah, I can't build because of the same issue:

[ERROR] Failed to execute goal org.apache.maven.plugins:
maven-assembly-plugin:2.2.1:single (default) on project
distributedlog-service: Failed to create assembly: Error adding file to
archive: distributedlog-0.4.0-incubating/distributedlog-service/../README.md
isn't a file. -> [Help 1]

The command I ran is:

   mvn clean apache-rat:check package findbugs:check -DskipTests

I also tried other commands, and they all seem to fail on tests.

-Flavio

> On 10 Jan 2017, at 07:24, Xi Liu  wrote:
>
> On Mon, Jan 9, 2017 at 8:00 PM, liang xie  wrote:
>
>> Glad to see 0.4 will be release soon :)
>> I could not find tutorials package from link[2], it should be released
>> as well, please correct me if i am wrong.
>> I can pass this command with current git master code: "mvn clean
>> apache-rat:check package findbugs:check -DskipTests", but failed with
>> from distributedlog-0.4.0-incubating-src.tar.gz which downloaded from
>> dist.apache.org, the error msg:
>>
>> [ERROR] Failed to execute goal
>> org.apache.maven.plugins:maven-assembly-plugin:2.2.1:single (default)
>> on project distributedlog-service: Failed to create assembly: Error
>> adding file to archive:
>> /tmp/distributedlog-0.4.0-incubating/distributedlog-service/../README.md
>> isn't a file. -> [Help 1]
>>
>
> I also saw this issue.
>
>
>>
>> And none of you saw this : DL-181, it can be reproduced on my local
>> box always w/o patched,  weird...
>>
>> On Mon, Jan 9, 2017 at 12:04 PM, Sijie Guo  wrote:
>>> Hi all,
>>>
>>> Please review and vote on the release candidate #1 for the version
0.4.0,
>>> as follows:
>>>
>>> [ ] +1, Approve the release
>>> [ ] -1, Do not approve the release (please provide specific comments)
>>>
>>> The complete staging area is available for your review, which includes:
>>>
>>>* JIRA release notes [1],
>>>* the official Apache source release to be deployed to
>> dist.apache.org
>>> [2],
>>>* all artifacts to be deployed to the Maven Central Repository [3],
>>>* source code tag "v0.4.0-RC1" [4],
>>>* website pull request listing the release [5] and publishing the API
>>> reference manual.
>>>
>>> A simple instruction for validation the source and binary packages.
>>>
>>> - source package: run "*./scripts/integration/smoketest.sh*" after
>> building
>>> the package with "*mvn clean apache-rat:check package findbugs:check
>>> -DskipTests*"
>>>
>>> The vote will be open for at least 72 hours. It is adopted by majority
>>> approval, with at least 3 PPMC affirmative votes.
>>>
>>> Thanks,
>>> Sijie
>>>
>>> [1]
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>> projectId=12320620=12337980
>>> [2]
>>> https://dist.apache.org/repos/dist/dev/incubator/distributedlog/0.4.0-
>> incubating/
>>> [3]
>>> https://repository.apache.org/content/repositories/
>> orgapachedistributedlog-1001/
>>> [4]
>>> https://github.com/apache/incubator-distributedlog/tree/
>> v0.4.0-incubating-RC1
>>> [5] https://github.com/apache/incubator-distributedlog/pull/109

Re: [VOTE] Release 0.4.0, release candidate #1

[Flavio Junqueira]

Yeah, I can't build because of the same issue:

[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-assembly-plugin:2.2.1:single (default) on 
project distributedlog-service: Failed to create assembly: Error adding file to 
 
archive: 
distributedlog-0.4.0-incubating/distributedlog-service/../README.md isn't a 
file. -> [Help 1]

The command I ran is:

   mvn clean apache-rat:check package findbugs:check -DskipTests

I also tried other commands, and they all seem to fail on tests.

-Flavio

> On 10 Jan 2017, at 07:24, Xi Liu  wrote:
> 
> On Mon, Jan 9, 2017 at 8:00 PM, liang xie  > wrote:
> 
>> Glad to see 0.4 will be release soon :)
>> I could not find tutorials package from link[2], it should be released
>> as well, please correct me if i am wrong.
>> I can pass this command with current git master code: "mvn clean
>> apache-rat:check package findbugs:check -DskipTests", but failed with
>> from distributedlog-0.4.0-incubating-src.tar.gz which downloaded from
>> dist.apache.org, the error msg:
>> 
>> [ERROR] Failed to execute goal
>> org.apache.maven.plugins:maven-assembly-plugin:2.2.1:single (default)
>> on project distributedlog-service: Failed to create assembly: Error
>> adding file to archive:
>> /tmp/distributedlog-0.4.0-incubating/distributedlog-service/../README.md
>> isn't a file. -> [Help 1]
>> 
> 
> I also saw this issue.
> 
> 
>> 
>> And none of you saw this : DL-181, it can be reproduced on my local
>> box always w/o patched,  weird...
>> 
>> On Mon, Jan 9, 2017 at 12:04 PM, Sijie Guo  wrote:
>>> Hi all,
>>> 
>>> Please review and vote on the release candidate #1 for the version 0.4.0,
>>> as follows:
>>> 
>>> [ ] +1, Approve the release
>>> [ ] -1, Do not approve the release (please provide specific comments)
>>> 
>>> The complete staging area is available for your review, which includes:
>>> 
>>>* JIRA release notes [1],
>>>* the official Apache source release to be deployed to
>> dist.apache.org
>>> [2],
>>>* all artifacts to be deployed to the Maven Central Repository [3],
>>>* source code tag "v0.4.0-RC1" [4],
>>>* website pull request listing the release [5] and publishing the API
>>> reference manual.
>>> 
>>> A simple instruction for validation the source and binary packages.
>>> 
>>> - source package: run "*./scripts/integration/smoketest.sh*" after
>> building
>>> the package with "*mvn clean apache-rat:check package findbugs:check
>>> -DskipTests*"
>>> 
>>> The vote will be open for at least 72 hours. It is adopted by majority
>>> approval, with at least 3 PPMC affirmative votes.
>>> 
>>> Thanks,
>>> Sijie
>>> 
>>> [1]
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>> projectId=12320620=12337980
>>> [2]
>>> https://dist.apache.org/repos/dist/dev/incubator/distributedlog/0.4.0-
>> incubating/
>>> [3]
>>> https://repository.apache.org/content/repositories/
>> orgapachedistributedlog-1001/
>>> [4]
>>> https://github.com/apache/incubator-distributedlog/tree/
>> v0.4.0-incubating-RC1
>>> [5] https://github.com/apache/incubator-distributedlog/pull/109

Re: [VOTE] Release 0.4.0, release candidate #1

[Xi Liu]

On Mon, Jan 9, 2017 at 8:00 PM, liang xie  wrote:

> Glad to see 0.4 will be release soon :)
> I could not find tutorials package from link[2], it should be released
> as well, please correct me if i am wrong.
> I can pass this command with current git master code: "mvn clean
> apache-rat:check package findbugs:check -DskipTests", but failed with
> from distributedlog-0.4.0-incubating-src.tar.gz which downloaded from
> dist.apache.org, the error msg:
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-assembly-plugin:2.2.1:single (default)
> on project distributedlog-service: Failed to create assembly: Error
> adding file to archive:
> /tmp/distributedlog-0.4.0-incubating/distributedlog-service/../README.md
> isn't a file. -> [Help 1]
>

I also saw this issue.


>
> And none of you saw this : DL-181, it can be reproduced on my local
> box always w/o patched,  weird...
>
> On Mon, Jan 9, 2017 at 12:04 PM, Sijie Guo  wrote:
> > Hi all,
> >
> > Please review and vote on the release candidate #1 for the version 0.4.0,
> > as follows:
> >
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > The complete staging area is available for your review, which includes:
> >
> > * JIRA release notes [1],
> > * the official Apache source release to be deployed to
> dist.apache.org
> > [2],
> > * all artifacts to be deployed to the Maven Central Repository [3],
> > * source code tag "v0.4.0-RC1" [4],
> > * website pull request listing the release [5] and publishing the API
> > reference manual.
> >
> > A simple instruction for validation the source and binary packages.
> >
> > - source package: run "*./scripts/integration/smoketest.sh*" after
> building
> > the package with "*mvn clean apache-rat:check package findbugs:check
> > -DskipTests*"
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PPMC affirmative votes.
> >
> > Thanks,
> > Sijie
> >
> > [1]
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12320620=12337980
> > [2]
> > https://dist.apache.org/repos/dist/dev/incubator/distributedlog/0.4.0-
> incubating/
> > [3]
> > https://repository.apache.org/content/repositories/
> orgapachedistributedlog-1001/
> > [4]
> > https://github.com/apache/incubator-distributedlog/tree/
> v0.4.0-incubating-RC1
> > [5] https://github.com/apache/incubator-distributedlog/pull/109
>

Re: [VOTE] Release 0.4.0, release candidate #1

[Sijie Guo]

On Mon, Jan 9, 2017 at 5:32 PM, Sijie Guo  wrote:

> Thank you for your suggestion, Khurrum. Comment inline. I'd like to
> collect more feedbacks and then cut another RC.
>
>
> On Mon, Jan 9, 2017 at 11:43 AM, Khurrum Nasim 
> wrote:
>
>> Thanks Sijie for working on this. A couple of comments:
>>
>> - do we need to publish artifacts for both scala 2.10 and 2.11 (probably
>> also 2.12)? as DL uses some scala libraries as the dependencies.
>>
>
> Ah, ah, good catch. We need to publish both 2.10 and 2.11.
>
>
>> - the source jar is also missing. do we need it? it is usually useful to
>> have a source jar so that people who uses any IDE tool can easily navigate
>> to the source code.
>>
>
> It is a good suggestion. We don't have source maven plugin configured. We
> need to configure that.
>

Create https://issues.apache.org/jira/browse/DL-183 for generating the
source jar.

>
>
>
>
>>
>> - KN
>>
>> On Sun, Jan 8, 2017 at 8:04 PM, Sijie Guo  wrote:
>>
>> > Hi all,
>> >
>> > Please review and vote on the release candidate #1 for the version
>> 0.4.0,
>> > as follows:
>> >
>> > [ ] +1, Approve the release
>> > [ ] -1, Do not approve the release (please provide specific comments)
>> >
>> > The complete staging area is available for your review, which includes:
>> >
>> > * JIRA release notes [1],
>> > * the official Apache source release to be deployed to
>> dist.apache.org
>> > [2],
>> > * all artifacts to be deployed to the Maven Central Repository [3],
>> > * source code tag "v0.4.0-RC1" [4],
>> > * website pull request listing the release [5] and publishing the
>> API
>> > reference manual.
>> >
>> > A simple instruction for validation the source and binary packages.
>> >
>> > - source package: run "*./scripts/integration/smoketest.sh*" after
>> > building
>> > the package with "*mvn clean apache-rat:check package findbugs:check
>> > -DskipTests*"
>> >
>> > The vote will be open for at least 72 hours. It is adopted by majority
>> > approval, with at least 3 PPMC affirmative votes.
>> >
>> > Thanks,
>> > Sijie
>> >
>> > [1]
>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>> > projectId=12320620=12337980
>> > [2]
>> > https://dist.apache.org/repos/dist/dev/incubator/distributedlog/0.4.0-
>> > incubating/
>> > [3]
>> > https://repository.apache.org/content/repositories/
>> > orgapachedistributedlog-1001/
>> > [4]
>> > https://github.com/apache/incubator-distributedlog/tree/
>> > v0.4.0-incubating-RC1
>> > [5] https://github.com/apache/incubator-distributedlog/pull/109
>> >
>>
>
>

Re: [VOTE] Release 0.4.0, release candidate #1

[Sijie Guo]

On Mon, Jan 9, 2017 at 8:00 PM, liang xie  wrote:

> Glad to see 0.4 will be release soon :)
> I could not find tutorials package from link[2], it should be released
> as well, please correct me if i am wrong.
>

I was thinking it might be necessary to release tutorials as a separated
bin package. since they are tutorials, people can download the src package
and build from there. A service binary package for deployment and a
benchmark binary package for benchmarking are probably enough.

But I am open to release tutorials as a separated binary package. Not sure
how does other apache project do. I'd like to see other people's opinions.


> I can pass this command with current git master code: "mvn clean
> apache-rat:check package findbugs:check -DskipTests", but failed with
> from distributedlog-0.4.0-incubating-src.tar.gz which downloaded from
> dist.apache.org, the error msg:
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-assembly-plugin:2.2.1:single (default)
> on project distributedlog-service: Failed to create assembly: Error
> adding file to archive:
> /tmp/distributedlog-0.4.0-incubating/distributedlog-service/../README.md
> isn't a file. -> [Help 1]
>
>
Ah, nice catch.

I think the src/assemble/bin.xml and src/assemble/src.xml have inconsistent
settings.

the bin.xml is looking for README.md


  ../README.md
  /
  644


however, the src.xml doesn't include README.md in the source package.

  
**/README



> And none of you saw this : DL-181, it can be reproduced on my local
> box always w/o patched,  weird...
>
>
I think I fixed that before. It is probably not pushed to master but in the
release branch. I merged your change to both master and
release-0.4.0-incubating branch. so it should be okay now.


> On Mon, Jan 9, 2017 at 12:04 PM, Sijie Guo  wrote:
> > Hi all,
> >
> > Please review and vote on the release candidate #1 for the version 0.4.0,
> > as follows:
> >
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > The complete staging area is available for your review, which includes:
> >
> > * JIRA release notes [1],
> > * the official Apache source release to be deployed to
> dist.apache.org
> > [2],
> > * all artifacts to be deployed to the Maven Central Repository [3],
> > * source code tag "v0.4.0-RC1" [4],
> > * website pull request listing the release [5] and publishing the API
> > reference manual.
> >
> > A simple instruction for validation the source and binary packages.
> >
> > - source package: run "*./scripts/integration/smoketest.sh*" after
> building
> > the package with "*mvn clean apache-rat:check package findbugs:check
> > -DskipTests*"
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PPMC affirmative votes.
> >
> > Thanks,
> > Sijie
> >
> > [1]
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12320620=12337980
> > [2]
> > https://dist.apache.org/repos/dist/dev/incubator/distributedlog/0.4.0-
> incubating/
> > [3]
> > https://repository.apache.org/content/repositories/
> orgapachedistributedlog-1001/
> > [4]
> > https://github.com/apache/incubator-distributedlog/tree/
> v0.4.0-incubating-RC1
> > [5] https://github.com/apache/incubator-distributedlog/pull/109
>

Re: [VOTE] Release 0.4.0, release candidate #1

[Sijie Guo]

On Mon, Jan 9, 2017 at 11:07 PM, Sijie Guo  wrote:

>
>
> On Mon, Jan 9, 2017 at 8:00 PM, liang xie  wrote:
>
>> Glad to see 0.4 will be release soon :)
>> I could not find tutorials package from link[2], it should be released
>> as well, please correct me if i am wrong.
>>
>
> I was thinking it might be necessary to release tutorials as a separated
> bin package. since they are tutorials, people can download the src package
> and build from there. A service binary package for deployment and a
> benchmark binary package for benchmarking are probably enough.
>
> But I am open to release tutorials as a separated binary package. Not sure
> how does other apache project do. I'd like to see other people's opinions.
>
>
>> I can pass this command with current git master code: "mvn clean
>> apache-rat:check package findbugs:check -DskipTests", but failed with
>> from distributedlog-0.4.0-incubating-src.tar.gz which downloaded from
>> dist.apache.org, the error msg:
>>
>> [ERROR] Failed to execute goal
>> org.apache.maven.plugins:maven-assembly-plugin:2.2.1:single (default)
>> on project distributedlog-service: Failed to create assembly: Error
>> adding file to archive:
>> /tmp/distributedlog-0.4.0-incubating/distributedlog-service/../README.md
>> isn't a file. -> [Help 1]
>>
>>
> Ah, nice catch.
>
> I think the src/assemble/bin.xml and src/assemble/src.xml have
> inconsistent settings.
>
> the bin.xml is looking for README.md
>
> 
>   ../README.md
>   /
>   644
> 
>
> however, the src.xml doesn't include README.md in the source package.
>
>   
> **/README
>

Created https://issues.apache.org/jira/browse/DL-182 .

Liang, do you want to help fix it?


>
>
>
>> And none of you saw this : DL-181, it can be reproduced on my local
>> box always w/o patched,  weird...
>>
>>
> I think I fixed that before. It is probably not pushed to master but in
> the release branch. I merged your change to both master and
> release-0.4.0-incubating branch. so it should be okay now.
>
>
>> On Mon, Jan 9, 2017 at 12:04 PM, Sijie Guo  wrote:
>> > Hi all,
>> >
>> > Please review and vote on the release candidate #1 for the version
>> 0.4.0,
>> > as follows:
>> >
>> > [ ] +1, Approve the release
>> > [ ] -1, Do not approve the release (please provide specific comments)
>> >
>> > The complete staging area is available for your review, which includes:
>> >
>> > * JIRA release notes [1],
>> > * the official Apache source release to be deployed to
>> dist.apache.org
>> > [2],
>> > * all artifacts to be deployed to the Maven Central Repository [3],
>> > * source code tag "v0.4.0-RC1" [4],
>> > * website pull request listing the release [5] and publishing the
>> API
>> > reference manual.
>> >
>> > A simple instruction for validation the source and binary packages.
>> >
>> > - source package: run "*./scripts/integration/smoketest.sh*" after
>> building
>> > the package with "*mvn clean apache-rat:check package findbugs:check
>> > -DskipTests*"
>> >
>> > The vote will be open for at least 72 hours. It is adopted by majority
>> > approval, with at least 3 PPMC affirmative votes.
>> >
>> > Thanks,
>> > Sijie
>> >
>> > [1]
>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
>> ctId=12320620=12337980
>> > [2]
>> > https://dist.apache.org/repos/dist/dev/incubator/distributed
>> log/0.4.0-incubating/
>> > [3]
>> > https://repository.apache.org/content/repositories/orgapache
>> distributedlog-1001/
>> > [4]
>> > https://github.com/apache/incubator-distributedlog/tree/v0.
>> 4.0-incubating-RC1
>> > [5] https://github.com/apache/incubator-distributedlog/pull/109
>>
>
>

Re: [VOTE] Release 0.4.0, release candidate #1

[Sijie Guo]

yeah, you need a clean repo before running apache-rat:check in master.

On Mon, Jan 9, 2017 at 9:01 PM, liang xie  wrote:

> Master issue gone now after checking rat.txt and removing the log
> files generated by privious tests.
>
> On Tue, Jan 10, 2017 at 12:05 PM, liang xie  wrote:
> > oops, "mvn clean apache-rat:check package findbugs:check -DskipTests"
> > failed at the latest master code with another diff err msg:
> > Failed to execute goal org.apache.rat:apache-rat-plugin:0.7:check
> > (default-cli) on project distributedlog-service: Too many unapproved
> > licenses: 5
> >
> >
> > On Tue, Jan 10, 2017 at 12:00 PM, liang xie 
> wrote:
> >> Glad to see 0.4 will be release soon :)
> >> I could not find tutorials package from link[2], it should be released
> >> as well, please correct me if i am wrong.
> >> I can pass this command with current git master code: "mvn clean
> >> apache-rat:check package findbugs:check -DskipTests", but failed with
> >> from distributedlog-0.4.0-incubating-src.tar.gz which downloaded from
> >> dist.apache.org, the error msg:
> >>
> >> [ERROR] Failed to execute goal
> >> org.apache.maven.plugins:maven-assembly-plugin:2.2.1:single (default)
> >> on project distributedlog-service: Failed to create assembly: Error
> >> adding file to archive:
> >> /tmp/distributedlog-0.4.0-incubating/distributedlog-
> service/../README.md
> >> isn't a file. -> [Help 1]
> >>
> >> And none of you saw this : DL-181, it can be reproduced on my local
> >> box always w/o patched,  weird...
> >>
> >> On Mon, Jan 9, 2017 at 12:04 PM, Sijie Guo  wrote:
> >>> Hi all,
> >>>
> >>> Please review and vote on the release candidate #1 for the version
> 0.4.0,
> >>> as follows:
> >>>
> >>> [ ] +1, Approve the release
> >>> [ ] -1, Do not approve the release (please provide specific comments)
> >>>
> >>> The complete staging area is available for your review, which includes:
> >>>
> >>> * JIRA release notes [1],
> >>> * the official Apache source release to be deployed to
> dist.apache.org
> >>> [2],
> >>> * all artifacts to be deployed to the Maven Central Repository [3],
> >>> * source code tag "v0.4.0-RC1" [4],
> >>> * website pull request listing the release [5] and publishing the
> API
> >>> reference manual.
> >>>
> >>> A simple instruction for validation the source and binary packages.
> >>>
> >>> - source package: run "*./scripts/integration/smoketest.sh*" after
> building
> >>> the package with "*mvn clean apache-rat:check package findbugs:check
> >>> -DskipTests*"
> >>>
> >>> The vote will be open for at least 72 hours. It is adopted by majority
> >>> approval, with at least 3 PPMC affirmative votes.
> >>>
> >>> Thanks,
> >>> Sijie
> >>>
> >>> [1]
> >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12320620=12337980
> >>> [2]
> >>> https://dist.apache.org/repos/dist/dev/incubator/distributedlog/0.4.0-
> incubating/
> >>> [3]
> >>> https://repository.apache.org/content/repositories/
> orgapachedistributedlog-1001/
> >>> [4]
> >>> https://github.com/apache/incubator-distributedlog/tree/
> v0.4.0-incubating-RC1
> >>> [5] https://github.com/apache/incubator-distributedlog/pull/109
>

Re: [VOTE] Release 0.4.0, release candidate #1

[liang xie]

Glad to see 0.4 will be release soon :)
I could not find tutorials package from link[2], it should be released
as well, please correct me if i am wrong.
I can pass this command with current git master code: "mvn clean
apache-rat:check package findbugs:check -DskipTests", but failed with
from distributedlog-0.4.0-incubating-src.tar.gz which downloaded from
dist.apache.org, the error msg:

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-assembly-plugin:2.2.1:single (default)
on project distributedlog-service: Failed to create assembly: Error
adding file to archive:
/tmp/distributedlog-0.4.0-incubating/distributedlog-service/../README.md
isn't a file. -> [Help 1]

And none of you saw this : DL-181, it can be reproduced on my local
box always w/o patched,  weird...

On Mon, Jan 9, 2017 at 12:04 PM, Sijie Guo  wrote:
> Hi all,
>
> Please review and vote on the release candidate #1 for the version 0.4.0,
> as follows:
>
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> The complete staging area is available for your review, which includes:
>
> * JIRA release notes [1],
> * the official Apache source release to be deployed to dist.apache.org
> [2],
> * all artifacts to be deployed to the Maven Central Repository [3],
> * source code tag "v0.4.0-RC1" [4],
> * website pull request listing the release [5] and publishing the API
> reference manual.
>
> A simple instruction for validation the source and binary packages.
>
> - source package: run "*./scripts/integration/smoketest.sh*" after building
> the package with "*mvn clean apache-rat:check package findbugs:check
> -DskipTests*"
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PPMC affirmative votes.
>
> Thanks,
> Sijie
>
> [1]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320620=12337980
> [2]
> https://dist.apache.org/repos/dist/dev/incubator/distributedlog/0.4.0-incubating/
> [3]
> https://repository.apache.org/content/repositories/orgapachedistributedlog-1001/
> [4]
> https://github.com/apache/incubator-distributedlog/tree/v0.4.0-incubating-RC1
> [5] https://github.com/apache/incubator-distributedlog/pull/109

Re: [VOTE] Release 0.4.0, release candidate #1

[Sijie Guo]

Thank you for your suggestion, Khurrum. Comment inline. I'd like to collect
more feedbacks and then cut another RC.


On Mon, Jan 9, 2017 at 11:43 AM, Khurrum Nasim 
wrote:

> Thanks Sijie for working on this. A couple of comments:
>
> - do we need to publish artifacts for both scala 2.10 and 2.11 (probably
> also 2.12)? as DL uses some scala libraries as the dependencies.
>

Ah, ah, good catch. We need to publish both 2.10 and 2.11.


> - the source jar is also missing. do we need it? it is usually useful to
> have a source jar so that people who uses any IDE tool can easily navigate
> to the source code.
>

It is a good suggestion. We don't have source maven plugin configured. We
need to configure that.




>
> - KN
>
> On Sun, Jan 8, 2017 at 8:04 PM, Sijie Guo  wrote:
>
> > Hi all,
> >
> > Please review and vote on the release candidate #1 for the version 0.4.0,
> > as follows:
> >
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > The complete staging area is available for your review, which includes:
> >
> > * JIRA release notes [1],
> > * the official Apache source release to be deployed to
> dist.apache.org
> > [2],
> > * all artifacts to be deployed to the Maven Central Repository [3],
> > * source code tag "v0.4.0-RC1" [4],
> > * website pull request listing the release [5] and publishing the API
> > reference manual.
> >
> > A simple instruction for validation the source and binary packages.
> >
> > - source package: run "*./scripts/integration/smoketest.sh*" after
> > building
> > the package with "*mvn clean apache-rat:check package findbugs:check
> > -DskipTests*"
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PPMC affirmative votes.
> >
> > Thanks,
> > Sijie
> >
> > [1]
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > projectId=12320620=12337980
> > [2]
> > https://dist.apache.org/repos/dist/dev/incubator/distributedlog/0.4.0-
> > incubating/
> > [3]
> > https://repository.apache.org/content/repositories/
> > orgapachedistributedlog-1001/
> > [4]
> > https://github.com/apache/incubator-distributedlog/tree/
> > v0.4.0-incubating-RC1
> > [5] https://github.com/apache/incubator-distributedlog/pull/109
> >
>

Re: [VOTE] Release 0.4.0, release candidate #1

[Jia Zhai]

+1 binding.

Build and smoke-test both passed on my local machine.

Thanks a lot for the work.

On Mon, Jan 9, 2017 at 12:04 PM, Sijie Guo  wrote:

> Hi all,
>
> Please review and vote on the release candidate #1 for the version 0.4.0,
> as follows:
>
> [ ] +1, Approve the release
> [ ] -1, Do not approve the release (please provide specific comments)
>
> The complete staging area is available for your review, which includes:
>
> * JIRA release notes [1],
> * the official Apache source release to be deployed to dist.apache.org
> [2],
> * all artifacts to be deployed to the Maven Central Repository [3],
> * source code tag "v0.4.0-RC1" [4],
> * website pull request listing the release [5] and publishing the API
> reference manual.
>
> A simple instruction for validation the source and binary packages.
>
> - source package: run "*./scripts/integration/smoketest.sh*" after
> building
> the package with "*mvn clean apache-rat:check package findbugs:check
> -DskipTests*"
>
> The vote will be open for at least 72 hours. It is adopted by majority
> approval, with at least 3 PPMC affirmative votes.
>
> Thanks,
> Sijie
>
> [1]
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12320620=12337980
> [2]
> https://dist.apache.org/repos/dist/dev/incubator/distributedlog/0.4.0-
> incubating/
> [3]
> https://repository.apache.org/content/repositories/
> orgapachedistributedlog-1001/
> [4]
> https://github.com/apache/incubator-distributedlog/tree/
> v0.4.0-incubating-RC1
> [5] https://github.com/apache/incubator-distributedlog/pull/109
>

[VOTE] Release 0.4.0, release candidate #1

[Sijie Guo]

Hi all,

Please review and vote on the release candidate #1 for the version 0.4.0,
as follows:

[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)

The complete staging area is available for your review, which includes:

* JIRA release notes [1],
* the official Apache source release to be deployed to dist.apache.org
[2],
* all artifacts to be deployed to the Maven Central Repository [3],
* source code tag "v0.4.0-RC1" [4],
* website pull request listing the release [5] and publishing the API
reference manual.

A simple instruction for validation the source and binary packages.

- source package: run "*./scripts/integration/smoketest.sh*" after building
the package with "*mvn clean apache-rat:check package findbugs:check
-DskipTests*"

The vote will be open for at least 72 hours. It is adopted by majority
approval, with at least 3 PPMC affirmative votes.

Thanks,
Sijie

[1]
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320620=12337980
[2]
https://dist.apache.org/repos/dist/dev/incubator/distributedlog/0.4.0-incubating/
[3]
https://repository.apache.org/content/repositories/orgapachedistributedlog-1001/
[4]
https://github.com/apache/incubator-distributedlog/tree/v0.4.0-incubating-RC1
[5] https://github.com/apache/incubator-distributedlog/pull/109