Re: [dpdk-dev] [PATCH 1/3] doc: update AESNI MB PMD guide

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Thursday, December 1, 2016 9:37 AM
> To: Doherty, Declan 
> Cc: dev@dpdk.org; De Lara Guarch, Pablo 
> Subject: [dpdk-dev] [PATCH 1/3] doc: update AESNI MB PMD guide
> 
> The Intel(R) Multi Buffer Crypto library used in the AESNI MB PMD has been
> moved to a new repository, in github.
> This patch updates the link where it can be downloaded.
> 
> Signed-off-by: Pablo de Lara 

Acked-by: John McNamara 

Re: [dpdk-dev] [PATCH 3/3] doc: add missing supported algos for AESNI MB PMD

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Thursday, December 1, 2016 9:37 AM
> To: Doherty, Declan 
> Cc: dev@dpdk.org; De Lara Guarch, Pablo 
> Subject: [dpdk-dev] [PATCH 3/3] doc: add missing supported algos for AESNI
> MB PMD
> 
> AESNI MB PMD supports SHA224-HMAC and SHA384-HMAC, but the documentation
> was not updated with this.
> 
> Signed-off-by: Pablo de Lara 

Acked-by: John McNamara 

Re: [dpdk-dev] [PATCH] nfp: add doc about supported features

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Alejandro Lucero
> Sent: Friday, December 2, 2016 8:18 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] nfp: add doc about supported features
> 
> Signed-off-by: Alejandro Lucero 

Acked-by: John McNamara 

[dpdk-dev] [PATCH 3/3] maintainers: add stable mailing list

[Mcnamara, John]

> -Original Message-
> From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> Sent: Thursday, December 1, 2016 7:07 AM
> To: dev at dpdk.org
> Cc: Thomas Monjalon ; Mcnamara, John
> ; Yuanhan Liu 
> Subject: [PATCH 3/3] maintainers: add stable mailing list
> 
> Signed-off-by: Yuanhan Liu 

Acked-by: John McNamara 

[dpdk-dev] [PATCH 2/3] maintainers: update virtio section name

[Mcnamara, John]

> -Original Message-
> From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> Sent: Thursday, December 1, 2016 7:07 AM
> To: dev at dpdk.org
> Cc: Thomas Monjalon ; Mcnamara, John
> ; Yuanhan Liu 
> Subject: [PATCH 2/3] maintainers: update virtio section name
> 
> Signed-off-by: Yuanhan Liu 

Acked-by: John McNamara 

[dpdk-dev] [PATCH 1/3] maintainers: update virtio maintainer

[Mcnamara, John]

> -Original Message-
> From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> Sent: Thursday, December 1, 2016 7:07 AM
> To: dev at dpdk.org
> Cc: Thomas Monjalon ; Mcnamara, John
> ; Yuanhan Liu ; 
> Xie,
> Huawei 
> Subject: [PATCH 1/3] maintainers: update virtio maintainer
> 
> Huawei has left DPDK team for months, and he hasn't showed up since then.
> Remove him.
> 
> Cc: Huawei Xie 
> Signed-off-by: Yuanhan Liu 

Acked-by: John McNamara 

[dpdk-dev] [PATCH v2] doc: add pdump library to API doxygen

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ferruh Yigit
> Sent: Thursday, December 1, 2016 11:02 AM
> To: dev at dpdk.org
> Cc: Pattan, Reshma 
> Subject: [dpdk-dev] [PATCH v2] doc: add pdump library to API doxygen
> 
> From: Reshma Pattan 
> 
> Add pdump library to API doxygen.
> 
> Signed-off-by: Reshma Pattan 

Acked-by: John McNamara 

[dpdk-dev] Proposal for a new Committer model

[Mcnamara, John]

> -Original Message-
> From: Neil Horman [mailto:nhorman at tuxdriver.com]
> Sent: Tuesday, November 29, 2016 7:12 PM
> To: Mcnamara, John 
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] Proposal for a new Committer model
> 
> > ...
> >
> > B) Designate alternates to serve as backups for the maintainer when
> > they are unavailable.  This provides high-availablility, and sounds
> > very much like your proposal, but in the interests of clarity, there
> > is still a single maintainer at any one time, it just may change to
> > ensure the continued merging of patches, if the primary maintainer isn't
> available.
> > Ideally however, those backup alternates arent needed, because most of
> > the primary maintainers work in merging pull requests, which are done
> > based on the trust of the submaintainer, and done during a very
> > limited window of time.  This also partially addreses multi-vendor
> > fairness if your subtree maintainers come from multiple participating
> companies.
> >
> > Regards
> > Neil
> >
> >
> >
> 
> Soo, I feel like we're wandering away from this thread.  Are you going to
> make a change to the comitter model?

Hi,

Yes. I think we have consensus on the main parts. I'll re-draft a proposal that 
we can discuss and then add to the contributors guide.

John

[dpdk-dev] [PATCH v1] maintainers: update pcap pmd maintainers

[Mcnamara, John]

> -Original Message-
> From: Mcnamara, John
> Sent: Tuesday, November 29, 2016 2:33 PM
> To: nicolas.pernas.maradei at emutex.com
> Cc: dev at dpdk.org; Yigit, Ferruh ; Mcnamara, John
> 
> Subject: [PATCH v1] maintainers: update pcap pmd maintainers

Self nack.

[dpdk-dev] [PATCH] mempool: fix Api documentation

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olivier Matz
> Sent: Tuesday, November 22, 2016 10:05 AM
> To: dev at dpdk.org
> Cc: Wiles, Keith 
> Subject: [dpdk-dev] [PATCH] mempool: fix Api documentation
> 
> A previous commit changed the local_cache table into a pointer, reducing
> the size of the rte_mempool structure.
> 
> Fix the API comment of rte_mempool_create() related to this modification.
> 
> Fixes: 213af31e0960 ("mempool: reduce structure size if no cache needed")
> 
> Signed-off-by: Olivier Matz 

Acked-by: John McNamara 

[dpdk-dev] [PATCH] doc: announce kni_vhost removal

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ferruh Yigit
> Sent: Thursday, November 17, 2016 1:27 PM
> To: dev at dpdk.org
> Cc: Yigit, Ferruh 
> Subject: [dpdk-dev] [PATCH] doc: announce kni_vhost removal
> 
> Signed-off-by: Ferruh Yigit 

Acked-by: John McNamara 

[dpdk-dev] [PATCH] doc: prog_guide: fix section heading

[Mcnamara, John]

> -Original Message-
> From: Baruch Siach [mailto:baruch at tkos.co.il]
> Sent: Tuesday, November 29, 2016 1:23 PM
> To: dev at dpdk.org
> Cc: Mcnamara, John ; Baruch Siach
> 
> Subject: [PATCH] doc: prog_guide: fix section heading
> 
> This section only deals with Tx queues configuration.
> 
> Signed-off-by: Baruch Siach 



Acked-by: John McNamara 

[dpdk-dev] [PATCH] doc: remove wrong document description

[Mcnamara, John]

> -Original Message-
> From: Baruch Siach [mailto:baruch at tkos.co.il]
> Sent: Tuesday, November 29, 2016 9:26 AM
> To: dev at dpdk.org
> Cc: Mcnamara, John ; Baruch Siach
> 
> Subject: [PATCH] doc: remove wrong document description
> 
> The Programmer?s Guide intro is not the Release Notes.
> 
> Signed-off-by: Baruch Siach 


Acked-by: John McNamara 

[dpdk-dev] [PATCH] doc: remove wrong document description

[Mcnamara, John]

> -Original Message-
> From: Baruch Siach [mailto:baruch at tkos.co.il]
> Sent: Tuesday, November 29, 2016 10:54 AM
> To: Mcnamara, John 
> Cc: dev at dpdk.org
> Subject: Re: [PATCH] doc: remove wrong document description
> 
> Hi John,
> 
> On Tue, Nov 29, 2016 at 09:54:58AM +, Mcnamara, John wrote:
> > > -Original Message-
> > > From: Baruch Siach [mailto:baruch at tkos.co.il]
> > > Sent: Tuesday, November 29, 2016 9:26 AM
> > > To: dev at dpdk.org
> > > Cc: Mcnamara, John ; Baruch Siach
> > > 
> > > Subject: [PATCH] doc: remove wrong document description
> > >
> > > The Programmer?s Guide intro is not the Release Notes.
> > >
> > > Signed-off-by: Baruch Siach 
> >
> > Thanks for the fix.
> >
> > I would be in favour of removing the entire "Documentation Roadmap"
> > and "Related Publications" sections. I meant to do that in the past.
> >
> > As for this patch:
> >
> > Acked-by: John McNamara 
> 
> Thanks. For some reason patchwork didn't get your ack.


Strange. I worked for one I acked shortly afterwards.

I'll try once more.

John

[dpdk-dev] [PATCH] doc: fix typos in code comments

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Yong Wang
> Sent: Tuesday, November 29, 2016 10:24 PM
> To: olivier.matz at 6wind.com
> Cc: dev at dpdk.org; Yong Wang 
> Subject: [dpdk-dev] [PATCH] doc: fix typos in code comments
> 
> Signed-off-by: Yong Wang 

Acked-by: John McNamara 

[dpdk-dev] [PATCH] doc: remove wrong document description

[Mcnamara, John]

> -Original Message-
> From: Baruch Siach [mailto:baruch at tkos.co.il]
> Sent: Tuesday, November 29, 2016 9:26 AM
> To: dev at dpdk.org
> Cc: Mcnamara, John ; Baruch Siach
> 
> Subject: [PATCH] doc: remove wrong document description
> 
> The Programmer?s Guide intro is not the Release Notes.
> 
> Signed-off-by: Baruch Siach 

Thanks for the fix.

I would be in favour of removing the entire "Documentation Roadmap" and 
"Related Publications" sections. I meant to do that in the past.

As for this patch:

Acked-by: John McNamara 

[dpdk-dev] [PATCH] doc: introduce PVP reference benchmark

[Mcnamara, John]

> -Original Message-
> From: Maxime Coquelin [mailto:maxime.coquelin at redhat.com]
> Sent: Wednesday, November 23, 2016 9:00 PM
> To: yuanhan.liu at linux.intel.com; thomas.monjalon at 6wind.com; Mcnamara, 
> John
> ; Yang, Zhiyong ;
> dev at dpdk.org
> Cc: fbaudin at redhat.com; Maxime Coquelin 
> Subject: [PATCH] doc: introduce PVP reference benchmark
> 
> Having reference benchmarks is important in order to obtain reproducible
> performance figures.
> 
> This patch describes required steps to configure a PVP setup using testpmd
> in both host and guest.
> 
> Not relying on external vSwitch ease integration in a CI loop by not being
> impacted by DPDK API changes.

Hi Maxime,

Thanks for the detailed doc and this initiative. Some minor documentation
comments below.



> +
> +Setup overview
> +..

This level header should be -, even if it looks like dots in the
contribution guide:

http://dpdk.org/doc/guides/contributing/documentation.html#section-headers


> +
> +.. figure:: img/pvp_2nics.svg
> +
> +  PVP setup using 2 NICs
> +

The figure needs a target so it can be used with :numref:, like this:

.. _figure_pvp_2nics:

.. figure:: img/pvp_2nics.*

   PVP setup using 2 NICs


> +DPDK build
> +~~
> +

Put a one line description at the start of each section, even if it is just: 
Build DPDK:



> +Testpmd launch
> +~~
> +
> +#. Assign NICs to DPDK:
> +
> +   .. code-block:: console
> +
> +modprobe vfio-pci
> +$RTE_SDK/install/sbin/dpdk-devbind -b vfio-pci :11:00.0
> + :11:00.1
> +
> +*Note: Sandy Bridge family seems to have some limitations wrt its
> +IOMMU, giving poor performance results. To achieve good performance on
> +these machines, consider using UIO instead.*

This would be better as an RST note:

#. Assign NICs to DPDK:

   .. code-block:: console

  modprobe vfio-pci
  $RTE_SDK/install/sbin/dpdk-devbind -b vfio-pci :11:00.0 :11:00.1

   .. Note::

  The Sandy Bridge family seems to have some IOMMU limitations giving poor
  performance results. To achieve good performance on these machines
  consider using UIO instead.



> +First, SELinux policy needs to be set to permissiven, as testpmd is run
> +as root (reboot required):

s/permissiven/permissive/


There are a couple of trailing whitespace errors as well at build as well.


John

[dpdk-dev] [PATCH] app/testpmd: display port driver name

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of David Marchand
> Sent: Wednesday, November 23, 2016 10:55 AM
> To: De Lara Guarch, Pablo 
> Cc: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] app/testpmd: display port driver name
> 
> This makes it easier to check which driver name is reported through ethdev
> rte_eth_dev_info_get().
> 
> Example:
> 
> root at ubuntu1604:~/dpdk# ./build/app/testpmd -c 0x6 --vdev
> net_af_packet0,iface=mgmt0 -- -i  --total-num-mbufs 2049 [snip]
> testpmd> show port info all
> 
> * Infos for port 0  * MAC address:
> DE:AD:DE:01:02:03 Driver name: net_af_packet Connect to socket: 0 memory
> allocation on the socket: 0
> 
> Signed-off-by: David Marchand 

Good idea.

Acked-by: John McNamara 

[dpdk-dev] [PATCH 00/56] Solarflare libefx-based PMD

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Andrew Rybchenko
> Sent: Wednesday, November 23, 2016 7:50 AM
> To: Yigit, Ferruh ; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 00/56] Solarflare libefx-based PMD
> 
> On 11/23/2016 03:02 AM, Ferruh Yigit wrote:
> > On 11/21/2016 3:00 PM, Andrew Rybchenko wrote:
> >> The patch series adds Solarflare libefx-based network PMD.
> >>
> >> This version of the driver supports Solarflare SFN7xxx and SFN8xxx
> >> families of 10/40 Gbps adapters.
> >>
> >> ...
> 
> > 2- Got following compile issues, not investigated, directly sharing
> here:
> >
> > b) for icc getting following warnings:
> > ===
> > icc: command line warning #10006: ignoring unknown option '-Wno-empty-
> body'
> > icc: command line warning #10006: ignoring unknown option
> > '-Waggregate-return'
> > icc: command line warning #10006: ignoring unknown option
> > '-Wbad-function-cast'
> > icc: command line warning #10006: ignoring unknown option '-Wnested-
> externs'
> >
> >
> > c) icc compiler errors:
> > ===
> > In file included from
> > .../x86_64-native-linuxapp-icc/include/rte_ethdev.h(185),
> >   from .../drivers/net/sfc/efx/sfc.h(35),
> >   from .../drivers/net/sfc/efx/sfc.c(37):
> > .../x86_64-native-linuxapp-icc/include/rte_ether.h(258): warning #2203:
> > cast discards qualifiers from target type
> >  uint16_t *from_words = (uint16_t *)(ea_from->addr_bytes);
> > ^
> >
> > .../drivers/net/sfc/efx/base/efx_mcdi.c(1157): warning #3179:
> > deprecated conversion of string literal to char* (should be const
> > char*)
> > .../drivers/net/sfc/efx/base/ef10_filter.c(1276): warning #188:
> > enumerated type mixed with another type
> >  : "unknown assertion";
> >  ^
> >
> >  filter_flags = 0;
> >   ^
> >
> > .../drivers/net/sfc/efx/base/efx_mcdi.c(1426): warning #188:
> > enumerated type mixed with another type
> >  epp->ep_fixed_port_type =
> >  ^
> >
> > .../drivers/net/sfc/efx/base/efx_nic.c(556): warning #188: enumerated
> > type mixed with another type
> >  enp->en_family = 0;
> 
> Yes, I have no ICC compilers. I'll try to fix these warnings, but I can't
> be sure without checking it.
> Also we cannot claim ICC supported without building and testing the
> generated binary.

Hi,

You can get a copy of ICC with a 30 day evaluation license here: 
https://software.intel.com/en-us/try-buy-tools

John

[dpdk-dev] Proposal for a new Committer model

[Mcnamara, John]

> -Original Message-
> From: Neil Horman [mailto:nhorman at tuxdriver.com]
> Sent: Tuesday, November 22, 2016 7:52 PM
> To: Thomas Monjalon 
> Cc: dev at dpdk.org; Mcnamara, John 
> Subject: Re: [dpdk-dev] Proposal for a new Committer model
> 
> On Mon, Nov 21, 2016 at 09:52:41AM +0100, Thomas Monjalon wrote:
> > 2016-11-18 13:09, Neil Horman:
> > > A) Further promote subtree maintainership.  This was a conversation
> > > that I proposed some time ago, but my proposed granularity was
> > > discarded in favor of something that hasn't worked as well (in my
> > > opinion).  That is to say a few driver pmds (i40e and fm10k come to
> > > mind) have their own tree that send pull requests to Thomas.
> >
> > Yes we tried this fine granularity and stated that it was not working
> well.
> > We are now using the bigger granularity that you describe below.
> >
> Ok, thats good, but that must be _very_ new.  Looking at your git tree, I
> see no merge commits.  How are you pulling from those subtrees?
> 


Hi Neil,

It seems like the weight of consensus in around your proposal for further 
subtree maintainers and backups. If you don't mind I'll take your text and 
redraft it as a potential section on maintainership for a future Project 
Charter document. Or at least so that we have a documented maintainship process.


> > > We should be sharding that at a much higher granularity and using it
> > > much more consistently.  That is to say, that we should have a
> > > maintainer for all the ethernet pmds, and another for the crypto
> > > pmds, another for the core eal layer, another for misc libraries
> > > that have low patch volumes, etc.
> >
> > Yes we could open a tree for EAL and another one for the core libraries.
> >
> That could be worthwhile.  Lets see how the net and crypto subtrees work
> out (assuming again that these trees are newly founded)

Could we define some of the potential subtrees now and look to introduce them 
in the this release cycle? EAL and the Core libs, as suggested by Thomas, seem 
like 2 obvious ones.


> 
> > > Each of those subdivisions should have their own list to communicate
> > > on, and each should have a tree that integrates patches for their
> > > own subsystem, and they should on a regular cycle send pull requests
> > > to Thomas.
> >
> > Yes I think it is now a good idea to split the mailing list traffic,
> > at least for netdev and cryptodev.

I'd prefer not to have split dev lists, for now at least. We can reevaluate 
that again in a few months though.


> >
> 
> > > B) Designate alternates to serve as backups for the maintainer when
> > > they are unavailable.  This provides high-availablility, and sounds
> > > very much like your proposal, but in the interests of clarity, there
> > > is still a single maintainer at any one time, it just may change to
> > > ensure the continued merging of patches, if the primary maintainer
> isn't available.
> > > Ideally however, those backup alternates arent needed, because most
> > > of the primary maintainers work in merging pull requests, which are
> > > done based on the trust of the submaintainer, and done during a very
> > > limited window of time.  This also partially addreses multi-vendor
> > > fairness if your subtree maintainers come from multiple participating
> companies.


+1 on this apart from the limited merge window (for reasons similar to Thomas).

Should we have a call for volunteers for backup, on master and the sub-trees, 
followed by a simple +1 from community members to endorse them?


John

[dpdk-dev] Proposal for a new Committer model

[Mcnamara, John]

Repost from the moving at dpdk.org mailing list to get a wider audience.
Original thread: http://dpdk.org/ml/archives/moving/2016-November/59.html


Hi,

I'd like to propose a change to the DPDK committer model. Currently we have one 
committer for the master branch of the DPDK project. 

One committer to master represents a single point of failure and at times can 
be inefficient. There is also no agreed cover for times when the committer is 
unavailable such as vacation, public holidays, etc. I propose that we change to 
a multi-committer model for the DPDK project. We should have three committers 
for each release that can commit changes to the master branch.

There are a number of benefits:

1. Greater capacity to commit patches.
2. No single points of failure - a committer should always be available if we 
have three.
3. A more timely committing of patches. More committers should equal a faster 
turnaround - ideally, maintainers should also provide feedback on patches 
submitted within a 2-3 day period, as much as possible, to facilitate this. 
4. It follows best practice in creating a successful multi-vendor community - 
to achieve this we must ensure there is a level playing field for all 
participants, no single person should be required to make all of the decisions 
on patches to be included in the release.  

Having multiple committers will require some degree of co-ordination but there 
are a number of other communities successfully following this model such as 
Apache, OVS, FD.io, OpenStack etc. so the approach is workable.

John

[dpdk-dev] [PATCH] lib/librte_mempool: a redundant word in comment

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wei Zhao
> Sent: Monday, November 14, 2016 2:47 AM
> To: dev at dpdk.org
> Cc: olivier.matz at 6wind.com; Zhao1, Wei 
> Subject: [dpdk-dev] [PATCH] lib/librte_mempool: a redundant word in
> comment
> 
> From: zhao wei 

I think you need to add your name to gitconfig file on the sending machine
to avoid this "From:"

> 
> There is a redundant repetition word "for" in commnet line the file
> rte_mempool.h after the definition of RTE_MEMPOOL_OPS_NAMESIZE.
> The word "for"appear twice in line 359 and 360.One of them is redundant,
> so delete it.
> 
> Fixes: 449c49b93a6b ("lib/librte_mempool: mempool: support handler
> operations")
> 
> Signed-off-by: zhao wei 

/commnet/comment/

And same comment as before about the title. Apart from that:

Acked-by: John McNamara 

[dpdk-dev] [PATCH] lib/librte_mempool: a redundant of socket_id assignment

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wei Zhao
> Sent: Monday, November 14, 2016 2:16 AM
> To: dev at dpdk.org
> Cc: olivier.matz at 6wind.com; Zhao1, Wei 
> Subject: [dpdk-dev] [PATCH] lib/librte_mempool: a redundant of socket_id
> assignment
> 
> From: zhao wei 
> 
> There is a redundant repetition mempool socket_id assignment in the file
> rte_mempool.c in function rte_mempool_create_empty.The statement "mp-
> >socket_id = socket_id;"appear twice in line 821 and 824.One of them is
> redundant, so delete it.
> 
> Fixes: 85226f9c526b ("lib/librte_mempool:  mempool:introduce a function to
> create an empty pool")
> 
> Signed-off-by: zhao wei 

Titles should generally start with a verb to indicate what is being done.
Something like:

lib/librte_mempool: remove redundant socket_id assignment

Apart from that. 

Acked-by: John McNamara 

[dpdk-dev] [PATCH v1] doc: rearrange the high level documentation index

[Mcnamara, John]

> -Original Message-
> From: Mcnamara, John
> Sent: Friday, November 11, 2016 1:46 PM
> To: dev at dpdk.org
> Cc: Mcnamara, John 
> Subject: [PATCH v1] doc: rearrange the high level documentation index
> 
> Rearrange the order of the high level documenation index into a more
> logical sequence for a new user.
> 
> Also, improve some of the high-level document names.
> 
> Signed-off-by: John McNamara 
> ---
> 
> After this patch the high-level index will look like this:
> 
> DPDK documentation
> 
> * Getting Started Guide for Linux
> * Getting Started Guide for FreeBSD
> * Sample Applications User Guides
> * Programmer's Guide
> * HowTo Guides
> * DPDK Tools User Guides
> * Testpmd Application User Guide
> * Network Interface Controller Drivers
> * Crypto Device Drivers
> * Xen Guide
> * Contributor's Guidelines
> * Release Notes
> * FAQ

P.S.,

I would prefer not to have some of these are highest level items such as
"Xen Guide", and possibly "Crypto Device Drivers". Perhaps we could push
them down a level with "Network Interface Controller Drivers" under a
"Devices and Drivers" (or similar) section like:

* ...
* Programmer's Guide
* HowTo Guides
* DPDK Tools User Guides
* Devices and Drivers  
* Network Interface Controller Drivers
* Crypto Device Drivers
* Xen Guide
* ...

[dpdk-dev] [PATCH] doc: add sub-repositories information

[Mcnamara, John]

> -Original Message-
> From: Yigit, Ferruh
> Sent: Thursday, November 10, 2016 5:27 PM
> To: dev at dpdk.org
> Cc: Mcnamara, John ; Thomas Monjalon
> 
> Subject: [PATCH] doc: add sub-repositories information
> 
> DPDK switched to main and sub-repositories approach, this patch documents
> new approach and updates development process according.
> 
> Signed-off-by: Ferruh Yigit 

Acked-by: John McNamara 

[dpdk-dev] [PATCH] doc: add known issue on QAT PMD into release notes

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Fiona Trahe
> Sent: Thursday, November 10, 2016 4:47 PM
> To: dev at dpdk.org
> Cc: De Lara Guarch, Pablo ; Trahe, Fiona
> ; Griffin, John 
> Subject: [dpdk-dev] [PATCH] doc: add known issue on QAT PMD into release
> notes
> 
> Issue is with the digest appended feature on QAT PMD.
> A workaround is also documented.
> 
> Signed-off-by: Fiona Trahe 

Acked-by: John McNamara 

[dpdk-dev] [PATCH] pdump: fix log message to display correct error number

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Reshma Pattan
> Sent: Thursday, November 10, 2016 4:30 PM
> To: dev at dpdk.org
> Cc: Reshma Pattan 
> Subject: [dpdk-dev] [PATCH] pdump: fix log message to display correct
> error number
> 
> The ethdev Rx/Tx remove callback apis doesn't set rte_errno during
> failures, instead they just return negative error number, so using that
> number in logs instead of rte_errno upon Rx and Tx callback removal
> failures.
> 
> Fixes: 278f9454 ("pdump: add new library for packet capture")
> 
> Signed-off-by: Reshma Pattan 

Acked-by: John McNamara 

[dpdk-dev] [PATCH] doc: fix l3fwd mode selection from compile to run time

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Reshma Pattan
> Sent: Thursday, November 10, 2016 4:30 PM
> To: dev at dpdk.org
> Cc: Pattan, Reshma 
> Subject: [dpdk-dev] [PATCH] doc: fix l3fwd mode selection from compile to
> run time
> 
> The l3fwd application route lookup mode can be selected at run time but
> not at compile time. This patch corrects the statement in the doc.
> 
> Fixes: d0dff9ba ("doc: sample application user guide")
> 
> Signed-off-by: Reshma Pattan 

Acked-by: John McNamara 

[dpdk-dev] [PATCH] doc: add more tested platforms and nics and OSes

[Mcnamara, John]

> -Original Message-
> From: Pei, Yulong
> Sent: Thursday, November 10, 2016 10:03 AM
> To: dev at dpdk.org
> Cc: Mcnamara, John ; thomas.monjalon at 6wind.com;
> Pei, Yulong 
> Subject: [PATCH] doc: add more tested platforms and nics and OSes
> 
> Add more tested platforms and nics and OSes to the release notes.
> 
> Signed-off-by: Yulong Pei 

Acked-by: John McNamara 

[dpdk-dev] [PATCH] doc: postpone ABI changes for Tx prepare

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Wednesday, November 9, 2016 10:31 PM
> To: Kulasek, TomaszX 
> Cc: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: postpone ABI changes for Tx prepare
> 
> The changes for the feature "Tx prepare" should be made in version 17.02.
> 
> Signed-off-by: Thomas Monjalon 

Acked-by: John McNamara 

[dpdk-dev] [PATCH] doc: fix typos

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Alain Leon
> Sent: Monday, November 7, 2016 3:20 AM
> To: dev at dpdk.org
> Cc: Alain Leon 
> Subject: [dpdk-dev] [PATCH] doc: fix typos
> 
> Fixes typos present in the documentation and code comments.
> 
> Signed-off-by: Alain Leon 

Acked-by: John McNamara 

[dpdk-dev] [PATCH v2] doc: arm64: document DPDK application profiling methods

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jerin Jacob
> Sent: Wednesday, October 5, 2016 9:43 AM
> To: dev at dpdk.org
> Cc: thomas.monjalon at 6wind.com; jianbo.liu at linaro.org;
> viktorin at rehivetech.com; Jerin Jacob 
> Subject: [dpdk-dev] [PATCH v2] doc: arm64: document DPDK application
> profiling methods
> 

Hi Jerin,

Thanks for this. It is probably something that should be extended from
the Intel side as well.

...



>  Profile Your Application
>  
> 
> +Introduction
> +
> +
> +The following sections describe the methods to profile DPDK
> +applications on different architectures.

You could probably just skip the introduction heading and put this
text under the main heading.

As Thomas pointed out there are a few other RST formatting issues
as well. I'll forward some suggested changes.

John

[dpdk-dev] [PATCH v1] doc: announce API and ABI change for librte_ether

[Mcnamara, John]

> -Original Message-
> From: Iremonger, Bernard
> Sent: Tuesday, October 18, 2016 2:38 PM
> To: dev at dpdk.org; Mcnamara, John 
> Cc: Iremonger, Bernard 
> Subject: [PATCH v1] doc: announce API and ABI change for librte_ether
> 
> In 17.02 five rte_eth_dev_set_vf_*** functions will be removed from
> librte_ether, renamed and moved to the ixgbe PMD.
> 
> Signed-off-by: Bernard Iremonger 

Acked-by: John McNamara 

[dpdk-dev] [PATCH v1] doc: announce API change for ethdev function

[Mcnamara, John]

> -Original Message-
> From: Iremonger, Bernard
> Sent: Tuesday, October 18, 2016 2:38 PM
> To: dev at dpdk.org; Mcnamara, John 
> Cc: Iremonger, Bernard 
> Subject: [PATCH v1] doc: announce API change for ethdev function
> 
> The _rte_eth_dev_call_process function will change to return "int"
> and a fourth parameter "void* ret_param" will be added. This change
> targets release 17.02.
> 
> Signed-off-by: Bernard Iremonger 

Acked-by: John McNamara 

[dpdk-dev] [PATCH 2/3] doc: update the vhost sample guide

[Mcnamara, John]

> -Original Message-
> From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> Sent: Wednesday, November 2, 2016 3:15 AM
> To: dev at dpdk.org
> Cc: Mcnamara, John ; Yuanhan Liu
> 
> Subject: [PATCH 2/3] doc: update the vhost sample guide
> 
> For vhost-switch sample, the old guide takes too many words on
> vhost-cuse, which is mainly due to vhost-cuse is invented before
> vhost-user.
> 
> Now vhost-cuse is removed, meaning the best part of the doc is useless.
> Instead of amending one piece here and there, this patch simply removes
> the most part of the doc and replace it with a simple test guide.
> 
> For tep_term sample, mainly for removing the part has "vhost-cuse".
> 
> Signed-off-by: Yuanhan Liu 

Good cleanup.

Acked-by: John McNamara 

[dpdk-dev] [PATCH 3/3] vhost: update comments

[Mcnamara, John]

> -Original Message-
> From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> Sent: Wednesday, November 2, 2016 3:15 AM
> To: dev at dpdk.org
> Cc: Mcnamara, John ; Yuanhan Liu
> 
> Subject: [PATCH 3/3] vhost: update comments
> 
> vhost-cuse is removed, update corresponding comments that are still
> referencing it.
> 
> Signed-off-by: Yuanhan Liu 
>
> ...
>
>  /*
> - * Backend-specific cleanup. Defined by vhost-cuse and vhost-user.
> + * Backend-specific cleanup.
> + *
> + * TODO: fix it; we have one backend now
>   */
>  void vhost_backend_cleanup(struct virtio_net *dev);

In general it is not a good idea to leave TODOs/Fixmes around unless they
that a better explanation of why they are there.

Apart from that:


Acked-by: John McNamara 

[dpdk-dev] [PATCH 1/3] doc: update vhost programming guide

[Mcnamara, John]

> -Original Message-
> From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> Sent: Wednesday, November 2, 2016 3:15 AM
> To: dev at dpdk.org
> Cc: Mcnamara, John ; Yuanhan Liu
> 
> Subject: [PATCH 1/3] doc: update vhost programming guide
> 
> vhost-cuse has been removed in this release. Update the doc, with the
> vhost-cuse part being removed.
> 
> Signed-off-by: Yuanhan Liu 

Acked-by: John McNamara 

[dpdk-dev] [PATCH] doc: add limitation for L3fwd-power app

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara
> Sent: Friday, November 4, 2016 12:48 PM
> To: dev at dpdk.org
> Cc: De Lara Guarch, Pablo 
> Subject: [dpdk-dev] [PATCH] doc: add limitation for L3fwd-power app
> 
> L3fwd-power app needs vector mode to be disabled in order to work
> properly. The app used to work previously, because it was using Rx scalar
> function, but now it uses vector function.
> 
> Vector mode needs to be disabled to make the app works, which has been
> documented in release notes.
> 
> Signed-off-by: Pablo de Lara 

Acked-by: John McNamara 

[dpdk-dev] [PATCH] doc: fix mlx5 features overview

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Nelio Laranjeiro
> Sent: Thursday, October 27, 2016 4:04 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: fix mlx5 features overview
> 
> Fixes: 75ef62a94301 ("net/mlx5: fix link speed capability information")
> Fixes: 188408719888 ("net/mlx5: fix support for newer link speeds")
> 
> Signed-off-by: Nelio Laranjeiro 

Acked-by: John McNamara 

[dpdk-dev] [PATCH] doc: update release notes with enic PMD changes

[Mcnamara, John]

> -Original Message-
> From: John Daley [mailto:johndale at cisco.com]
> Sent: Thursday, November 3, 2016 6:02 PM
> To: Mcnamara, John 
> Cc: dev at dpdk.org; John Daley 
> Subject: [PATCH] doc: update release notes with enic PMD changes
> 
> Signed-off-by: John Daley 


Acked-by: John McNamara 

[dpdk-dev] [PATCH v2] doc: add mlx5 release notes

[Mcnamara, John]

> -Original Message-
> From: Nelio Laranjeiro [mailto:nelio.laranjeiro at 6wind.com]
> Sent: Thursday, November 3, 2016 1:46 PM
> To: dev at dpdk.org
> Cc: Mcnamara, John ; Adrien Mazarguil
> 
> Subject: [PATCH v2] doc: add mlx5 release notes
> 
> Add list of tested and validated NICs too.
> 
> Signed-off-by: Nelio Laranjeiro 

Hi Nelio,

Nice to see such an extensive list of tested platforms and NICs.

I don't know if it is generally okay to update only part of a patchset
but apart from that:

Acked-by: John McNamara 

[dpdk-dev] [PATCH] doc: ZUC PMD cannot be built as a shared library

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara
> Sent: Thursday, October 13, 2016 8:35 PM
> To: dev at dpdk.org
> Cc: De Lara Guarch, Pablo 
> Subject: [dpdk-dev] [PATCH] doc: ZUC PMD cannot be built as a shared
> library
> 
> ZUC PMD cannot be built as a shared library, due to the fact that some
> assembly code in the underlying libsso library is not relocatable.
> This will be fixed in the future, but for the moment, it is added as a
> limitation of the PMD.
> 
> Signed-off-by: Pablo de Lara 

Acked-by: John McNamara 

[dpdk-dev] [PATCH] doc: how to build KASUMI as shared library

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara
> Sent: Thursday, October 13, 2016 8:34 PM
> To: dev at dpdk.org
> Cc: De Lara Guarch, Pablo 
> Subject: [dpdk-dev] [PATCH] doc: how to build KASUMI as shared library
> 
> Libsso KASUMI library has to be built with specific parameters to make the
> KASUMI PMD be built as a shared library, so a note has been added in its
> documentation.
> 
> Signed-off-by: Pablo de Lara 

Acked-by: John McNamara 

[dpdk-dev] [PATCH] doc: fix libcrypto title

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara
> Sent: Thursday, October 13, 2016 8:34 PM
> To: dev at dpdk.org
> Cc: De Lara Guarch, Pablo 
> Subject: [dpdk-dev] [PATCH] doc: fix libcrypto title
> 
> Libcrypto documentation was missing the equal signs ("="), in its title,
> so it was not present in the documentation generated.
> 
> Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library")
> 
> Signed-off-by: Pablo de Lara 

Acked-by: John McNamara 

[dpdk-dev] [PATCH v1 1/2] doc: update ixgbe guide

[Mcnamara, John]

> -Original Message-
> From: Iremonger, Bernard
> Sent: Friday, October 14, 2016 5:35 PM
> To: dev at dpdk.org; Mcnamara, John 
> Cc: Iremonger, Bernard 
> Subject: [PATCH v1 1/2] doc: update ixgbe guide
> 
> add information about new ixgbe PMD API.
> 
> Signed-off-by: Bernard Iremonger 

Acked-by: John McNamara 

[dpdk-dev] [PATCH v1 2/2] doc: update poll mode driver guide

[Mcnamara, John]

> -Original Message-
> From: Iremonger, Bernard
> Sent: Friday, October 14, 2016 5:35 PM
> To: dev at dpdk.org; Mcnamara, John 
> Cc: Iremonger, Bernard 
> Subject: [PATCH v1 2/2] doc: update poll mode driver guide
> 
> add information about new ixgbe PMD API.
> 
> Signed-off-by: Bernard Iremonger 

Acked-by: John McNamara 

[dpdk-dev] [PATCH] doc: release note for ixgbe PMD API's

[Mcnamara, John]

> -Original Message-
> From: Iremonger, Bernard
> Sent: Tuesday, October 25, 2016 1:25 PM
> To: dev at dpdk.org; Mcnamara, John 
> Cc: Iremonger, Bernard 
> Subject: [PATCH] doc: release note for ixgbe PMD API's
> 
> Signed-off-by: Bernard Iremonger 

Acked-by: John McNamara 

[dpdk-dev] [PATCH v2] doc: arm64: document DPDK application profiling methods

[Mcnamara, John]

> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Wednesday, October 26, 2016 9:07 PM
> To: Jerin Jacob ; Mcnamara, John
> 
> Cc: dev at dpdk.org; jianbo.liu at linaro.org; viktorin at rehivetech.com
> Subject: Re: [dpdk-dev] [PATCH v2] doc: arm64: document DPDK application
> profiling methods
> 
> 2016-10-05 14:13, Jerin Jacob:
> > Signed-off-by: Jerin Jacob 
> > ---
> > v2:
> > -Addressed ARM64 specific review comments(Suggested by Thomas)
> 
> I feel more comments could be done, especially about formatting.
> You are adding a chapter Introduction without any other section of the
> same level.
> Some technical terms should be enclosed in backquotes.
> 
> Please John, could you guide Jerin or provide an updated version?

Will do.

[dpdk-dev] [PATCH] doc: remove Intel reference from multi-process support guide

[Mcnamara, John]

> -Original Message-
> From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com]
> Sent: Thursday, October 27, 2016 7:11 AM
> To: dev at dpdk.org
> Cc: thomas.monjalon at 6wind.com; Mcnamara, John ;
> Jerin Jacob 
> Subject: [dpdk-dev] [PATCH] doc: remove Intel reference from multi-process
> support guide
> 
> multi-process support has been verified on non IA such as ARMv8.
> 
> Signed-off-by: Jerin Jacob 

Acked-by: John McNamara 

[dpdk-dev] [PATCH] doc: add missing library to release notes

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ferruh Yigit
> Sent: Tuesday, November 1, 2016 5:04 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: add missing library to release notes
> 
> Signed-off-by: Ferruh Yigit 
> ---
> CC: Olivier Matz 


Acked-by: John McNamara 

[dpdk-dev] [PATCH 2/2] doc: add mlx5 release notes

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Nelio Laranjeiro
> Sent: Wednesday, November 2, 2016 1:47 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH 2/2] doc: add mlx5 release notes
> 
> ...
> 
> -   This section is a comment. Make sure to start the actual text at the 
> margin.
> +#. Mellanox(R) ConnectX(R)-4 25G MCX4111A-ACAT (1x25G)

Release note patches shouldn't remove or overwrite the comments sections.

[dpdk-dev] [PATCH 1/2] doc: update mlx5 dependencies

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Nelio Laranjeiro
> Sent: Wednesday, November 2, 2016 1:47 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH 1/2] doc: update mlx5 dependencies
> 
> Signed-off-by: Nelio Laranjeiro 

Acked-by: John McNamara 

[dpdk-dev] [PATCH] doc: announce ABI changes in filtering support

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stroe, Laura
> Sent: Wednesday, November 2, 2016 3:12 PM
> To: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] doc: announce ABI changes in filtering
> support
> 
> Self-Nack.
> After an internal review of ABI breakage announcements we found a way of
> achieving this with an ABI change.
> 

Hi Laura,

I guess this should say *without* an ABI change. :-)

Thanks,

John

[dpdk-dev] [PATCH] ethdev: fix statistics description

[Mcnamara, John]

> -Original Message-
> From: Dai, Wei
> Sent: Wednesday, November 2, 2016 8:29 AM
> To: Thomas Monjalon ; Mcnamara, John
> ; Ananyev, Konstantin
> ; Wu, Jingjing ;
> Zhang, Helin ; Dai, Wei ;
> Curran, Greg 
> Cc: dev at dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] ethdev: fix statistics description
> 
> Hi, John & Greg
> 
> Would you please give any opinion for this patch ?
> 
> I have looked through all PMDs and found not all statistics items can be
> supported by some NIC.
> For example,  rx_nombuf,  q_ipackets,  q_opackets,  q_ibytes and q_obytes
> are not supported by i40e.
> But when the function rte_eth_stats_get(uint8_t port_id, struct
> rte_eth_stats *stats) is called for i40e PMD, Above un-supported
> statistics item in output stats are zero, this is not real value.
> So far, there is no way to know whether an item in struct rte_eth_stats is
> supported or not only from this structure definition.
> Maybe some structure member can be added to indicate each of statistics
> item valid or not.
> But this means ABI change.
> 
> In following list, I list statistics support details of all PMDs.
> Hope it can be displayed in your screen.

Hi,

Thanks for the analysis.

Perhaps we could an API that returns a struct, or otherwise, that indicated 
what stats are returned by a PMD. An application that required stats could call 
it once to establish what stats were available. It would have to be done in 
some way that wouldn't break ABI every time a new stat was added.

Harry, Remy, how would this fit in with the existing stats scheme or the new 
metrics library.

John

[dpdk-dev] DPDK & ASLR

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jon DeVree
> Sent: Wednesday, October 26, 2016 5:20 AM
> To: dev at dpdk.org
> Subject: Re: [dpdk-dev] DPDK & ASLR
> 
> On Tue, Oct 25, 2016 at 15:18:03 -0700, Samir Shah wrote:
> > Does ASLR need to be turned off system-wide, or DPDK-processes wide?
> > Could we use setarch/personality to disable ASLR for just the DPDK
> > process and leave it enabled for the rest of the system? Any
> > experience to say if that would work or not?
> >
> 
> I'm using setarch/personality to disable it only in the processes using
> dpdk without any trouble.

Hi Jon,

That is interesting. Do you have some more details on how to do this. 

Also, It might be worth adding this to the DPDK documentation:

http://dpdk.org/doc/guides/prog_guide/multi_proc_support.html#multi-process-limitations

John

[dpdk-dev] [PATCH] vhost: use after free

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Chas Williams
> Sent: Wednesday, October 19, 2016 5:10 PM
> To: dev at dpdk.org
> Cc: Chas Williams <3chas3 at gmail.com>
> Subject: [dpdk-dev] [PATCH] vhost: use after free
> 
> Don't dereference freed memory.
> 
> Fixes: a277c7159876 ("vhost: refactor code structure")

Hi Chas,

Thanks for that. 

Just to note that there was another patch submitted for this a few hours ago by 
Yuanhan (CCed):

http://dpdk.org/dev/patchwork/patch/16674/

John

[dpdk-dev] [PATCH v9] drivers/net:new PMD using tun/tap host interface

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Keith Wiles
> Sent: Thursday, October 13, 2016 11:04 PM
> To: dev at dpdk.org
> Cc: pmatilai at redhat.com; yuanhan.liu at linux.intel.com; Yigit, Ferruh
> 
> Subject: [dpdk-dev] [PATCH v9] drivers/net:new PMD using tun/tap host
> interface
> 
> The rte_eth_tap.c PMD creates a device using TUN/TAP interfaces on the
> local host. The PMD allows for DPDK and the host to communicate using a
> raw device interface on the host and in the DPDK application. The device
> created is a Tap device with a L2 packet header.
> 
> v9 - Fix up the docs to use correct syntax
> v8 - Fix issue with tap_tx_queue_setup() not return zero on success.
> v7 - Reword the comment in common_base and fix the data->name issue
> v6 - fixed the checkpatch issues
> v5 - merge in changes from list review see related emails
>  fixed many minor edits
> v4 - merge with latest driver changes
> v3 - fix includes by removing ifdef for other type besides Linux
>  Fix the copyright notice in the Makefile
> v2 - merge all of the patches into one patch
>  Fix a typo on naming the tap device
>  Update the maintainers list
> 
> Signed-off-by: Keith Wiles 

For the doc part of the patch:

Acked-by: John McNamara 

[dpdk-dev] [PATCH v8] drivers/net:new PMD using tun/tap host interface

[Mcnamara, John]

Hi,

Some doc comments below. Apologies, for the late review, I didn't see
the docs inline.



> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Keith Wiles
> Sent: Thursday, October 13, 2016 5:11 PM
> To: dev at dpdk.org
> Cc: pmatilai at redhat.com; yuanhan.liu at linux.intel.com; Yigit, Ferruh
> 
> Subject: [dpdk-dev] [PATCH v8] drivers/net:new PMD using tun/tap host
> interface
> 
> The rte_eth_tap.c PMD creates a device using TUN/TAP interfaces on the
> local host. The PMD allows for DPDK and the host to communicate using a
> raw device interface on the host and in the DPDK application. The device
> created is a Tap device with a L2 packet header.
> 
> v8 - Fix issue with tap_tx_queue_setup() not return zero on success.
> v7 - Reword the comment in common_base and fix the data->name issue
> v6 - fixed the checkpatch issues
> v5 - merge in changes from list review see related emails
>  fixed many minor edits
> v4 - merge with latest driver changes
> v3 - fix includes by removing ifdef for other type besides Linux
>  Fix the copyright notice in the Makefile
> v2 - merge all of the patches into one patch
>  Fix a typo on naming the tap device
>  Update the maintainers list
> 
> Signed-off-by: Keith Wiles 
> ---
>  MAINTAINERS |   5 +
>  config/common_base  |   9 +
>  config/common_linuxapp  |   1 +
>  doc/guides/nics/tap.rst | 138 ++
>  drivers/net/Makefile|   1 +
>  drivers/net/tap/Makefile|  57 +++
>  drivers/net/tap/rte_eth_tap.c   | 756


You need to add "tap" to the doc/guides/nics/index.rst file to
include the tap.rst in the docs.


> +
> +Tun/Tap Poll Mode Driver
> +
> +
> +The rte_eth_tap.c PMD creates a device using TUN/TAP interfaces on the
> +local host. The PMD allows for DPDK and the host to communicate using a
> +raw device interface on the host and in the DPDK application.
> +
> +The device created is a TAP device, which sends/receives packet in a
> +raw format with a L2 header. The usage for a TAP PMD is for
> +connectivity to the local host using a TAP interface. When the TAP PMD
> +is initialized it will create a number of tap devices in the host
> +accessed via 'ifconfig -a' or 'ip' command. The commands can be used to
> assign and query the virtual like device.

The apostrophes around the commands should be replaced with `` to render
them as fixed width.


> +
> +These TAP interfaces can be used with wireshark or tcpdump or
> +Pktgen-DPDK along with being able to be used as a network connection to
> +the DPDK application. The method enable one or more interfaces is to
> +use the --vdev=net_tap option on the DPDK application  command line.
> +Each --vdev=net_tap option give will create an interface named dtap0,
> dtap1, ... and so forth.

Same here, include any commands or variable names in backticks to render
them as fixed width in the text: ``--vdev=net_tap``


> +
> +.. code-block:: console
> +
> +   The interfaced name can be changed by adding the iface=foo0
> +   e.g. --vdev=net_tap,iface=foo0 --vdev=net_tap,iface=foo1, ...

This would be better formatted as follows:

The interfaced name can be changed by adding the ``iface=foo0``, for example::

   --vdev=eth_tap,iface=foo0 --vdev=eth_tap,iface=foo1, ...



> +If you have a Network Stack in your DPDK application or something like
> +it you can utilize that stack to handle the network protocols. Plus you
> +would be able to address the interface using an IP address assigned to
> the internal interface.
> +
> +A very crude test you can do the following:
> +
> +Apply the patch below and make sure you have socat installed on your
> system.

There is no patch below in the docs. ;-) Also, this would probably be better
as a new section. Something like:


Example
---

The following is a simple example of using the TUN/TAP PMD with the Pktgen
packet generator. It requires that the ``socat`` utility is installed on the
test system.

Build DPDK, then pull down Pktgen and build pktgen using the DPDK SDK/Target
used to build the dpdk you pulled down.

...

> +
> +Build DPDK, then pull down Pktgen and build pktgen using the DPDK
> +SDK/Target used to build the dpdk you pulled down.
> +
> +Run pktgen from the pktgen repo directory in an xterm:
> +Note: change the -b options to blacklist all of your physical ports.
> The
> +  following command line is all one line.


The RST syntax for Note and the indentation are wrong here. Also the note
would be better after the example. Something like:


.. Note:

   Change the ``-b`` options to blacklist all of your physical ports. The
   following command line is all one line.

   Also, ``-f themes/black-yellow.theme`` is optional if the default colors
   work on your system configuration. See the Pktgen docs for more
   information.


Finally, if you want to include the 

[dpdk-dev] [PATCH] net/enic: update enic guide and add warning for invalid conf

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of John Daley
> Sent: Thursday, September 29, 2016 9:55 PM
> To: Richardson, Bruce 
> Cc: dev at dpdk.org; Nelson Escobar 
> Subject: [dpdk-dev] [PATCH] net/enic: update enic guide and add warning
> for invalid conf
> 
> From: Nelson Escobar 
> 
> Update the enic guide to better explain how to setup vNIC parameters on
> the Cisco VIC since the introduction of rx scatter and print an error
> message for the case of having 1 RQ configured in the vNIC.
> 
> Signed-off-by: Nelson Escobar 

Hi,

It would be better in the RST documentation to use  backticks to
designate function and variable names as fixed width. Also, the documentation
convention is to use Rx/Tx. However, these are minor so the patch is okay as
it is.

Acked-by: John McNamara 

[dpdk-dev] [PATCH 1/1] testpmd_ug: update userguide with xstats commands

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Maryam Tahhan
> Sent: Wednesday, September 7, 2016 11:46 AM
> To: dev at dpdk.org
> Cc: Tahhan, Maryam 
> Subject: [dpdk-dev] [PATCH 1/1] testpmd_ug: update userguide with xstats
> commands
> 
> Update the testpmd user guide with instructions for retrieving extended
> NIC statistics.
> 
> Signed-off-by: Maryam Tahhan 

Acked-by: John McNamara 

[dpdk-dev] [PATCH 1/1] doc: fix errors in pdump doc

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Mark Kavanagh
> Sent: Thursday, October 6, 2016 11:37 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH 1/1] doc: fix errors in pdump doc
> 
> - Fix copy/paste error in description of how to capture both rx
>   & tx traffic in a single pcap file
> - Replace duplicate word with what original author presumably
>   intended, such that description now makes sense
> 
> Signed-off-by: Mark Kavanagh 

Acked-by: John McNamara 

[dpdk-dev] [PATCH] doc: fix typo in SNOW3G documentation

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara
> Sent: Thursday, October 6, 2016 9:55 PM
> To: dev at dpdk.org
> Cc: De Lara Guarch, Pablo 
> Subject: [dpdk-dev] [PATCH] doc: fix typo in SNOW3G documentation
> 
> Fixes: 1d0c90e6cf0b ("doc: update build instructions for libsso_snow3g")
> 
> Signed-off-by: Pablo de Lara 

Acked-by: John McNamara 

[dpdk-dev] [PATCH 1/1 v2] eal: Fix misleading error messages, errno can't be trusted.

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jean Tourrilhes
> Sent: Monday, October 3, 2016 4:56 PM
> To: Gonzalez Monroy, Sergio 
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 1/1 v2] eal: Fix misleading error messages,
> errno can't be trusted.
> 
> On Mon, Oct 03, 2016 at 02:25:40PM +0100, Sergio Gonzalez Monroy wrote:
> > Hi Jean,
> >
> > There are some format issues with the patch:
> >
> > You can run scripts/check-git-log.sh to check them:
> > Wrong headline format:
> > eal: Fix misleading error messages, errno can't be trusted.
> > Wrong headline uppercase:
> > eal: Fix misleading error messages, errno can't be trusted.
> > Missing 'Fixes' tag:
> > eal: Fix misleading error messages, errno can't be trusted.
> >
> > The script's output highlights the different issues.
> 
>   SOrry about that, I casually read the page on http://dpdk.org/dev,
> but obviously I need to look at it again.

The longer more detailed version is here: "Contributing Code to DPDK":

http://dpdk.org/doc/guides/contributing/patches.html

John

[dpdk-dev] [PATCH] doc/guides: add info on how to enable QAT

[Mcnamara, John]

> -Original Message-
> From: Breen, Eoin
> Sent: Tuesday, August 30, 2016 2:27 PM
> To: Jain, Deepak K ; Trahe, Fiona
> ; Griffin, John 
> Cc: dev at dpdk.org; Mcnamara, John ; Breen, Eoin
> 
> Subject: [PATCH] doc/guides: add info on how to enable QAT
> 
> Signed-off-by: Eoin Breen 
> ---
>  doc/guides/cryptodevs/qat.rst | 5 +
>  1 file changed, 5 insertions(+)
> 
> diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
> index cae1958..db03470 100644
> --- a/doc/guides/cryptodevs/qat.rst
> +++ b/doc/guides/cryptodevs/qat.rst
> @@ -78,6 +78,11 @@ Installation
>  To use the DPDK QAT PMD an SRIOV-enabled QAT kernel driver is required.
> The  VF devices exposed by this driver will be used by QAT PMD.
> 
> +To enable QAT in DPDK you must change the ./config/common_base file.
> +Change the line 'CONFIG_RTE_LIBRTE_PMD_QAT=n' to
> 'CONFIG_RTE_LIBRTE_PMD_QAT=y' to do this.
> +You must then configure and build dpdk, for example using the commands:
> +make T=x86_64-native-linuxapp-gcc config; make
> +

Hi,

>From a documentation point of view the 'make' commands should be on two lines, 
>indented to indicate a code block and prefixed with '::' and a blank line.

The filename and CONFIG items should also be in  backquotes.

John

[dpdk-dev] [PATCH] kni: unregister an unregisterd net_device could cause a kernel crash

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Friday, September 9, 2016 1:40 PM
> To: Yigit, Ferruh 
> Cc: Stephen Hemminger ; zhouyangchao
> ; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] kni: unregister an unregisterd net_device
> could cause a kernel crash
> 
> 2016-09-08 18:15, Ferruh Yigit:
> > On 9/8/2016 5:44 PM, Stephen Hemminger wrote:
> >
> > ...
> >
> > > But then again the whole KNI driver fails completely when running
> > > kernel style check.
> > >
> >
> > Yes, it generates lots of warnings.
> > I can fix them (excluding ethtool/*), that wouldn't take much time but
> > how syntax only patches welcomed? Another concern is it trashes git
> blame.
> 
> You ask a question and give the answer ;) I think it depends just on the
> balance of the pros/cons - to be evaluated.

Hi,

I think in general we would prefer to avoid any large scale code beautification 
since, as pointed out, it breaks the option to git blame.

However, in the case of the KNI code the main author in git is "Intel" so git 
blame doesn't tell you a lot. Also, Ferruh is the maintainer, has made most of 
the recent changes, and is actively maintaining/improving it. So I think if the 
syntax fix came from him it would be okay. At least it would allow us to apply 
the checkpatch checks.


John

[dpdk-dev] [PATCH] dpdk_procinfo: check for primary process

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Panu Matilainen
> Sent: Wednesday, September 7, 2016 9:43 AM
> To: Tahhan, Maryam ; dev at dpdk.org
> Cc: Kutch, Patrick G 
> Subject: Re: [dpdk-dev] [PATCH] dpdk_procinfo: check for primary process
> ...
>
> > @@ -329,6 +329,11 @@ main(int argc, char **argv)
> > argc -= ret;
> > argv += (ret - 3);
> >
> > +if (!rte_eal_primary_proc_alive(NULL)) {
> > +rte_exit(EXIT_FAILURE, "NO PRIMARY DPDK PROCESS IS
> > + RUNNING\n");
> 
> I don't think there'a a need to YELL THAT MESSAGE.

Our labs *are* quite noisy. ;-)

[dpdk-dev] [PATCH] maintainers: claim v16.07 as a stable release

[Mcnamara, John]

> -Original Message-
> From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com]
> Sent: Tuesday, September 6, 2016 1:24 PM
> To: dev at dpdk.org
> Cc: Thomas Monjalon ; Mcnamara, John
> 
> Subject: Re: [PATCH] maintainers: claim v16.07 as a stable release
> 
> On Thu, Jul 28, 2016 at 08:21:47PM +0800, Yuanhan Liu wrote:
> > Claim v16.07 as a stable release: only bug fix patches are allowed.
> > And volunteer to be the maintainer.
> >
> > Signed-off-by: Yuanhan Liu 
> 
> Hi all,
> 
> I will apply this patch shortly; this would literally mean I'm about to
> start applying bug fixing patches to 16.07 stable branch:


Hi Yuanhan,

That is good news. :-)


> Besides that, here I wrote some short notes about some simple rules
> applies to bug fixing patches, as well as a rough release plan I made.
> This is to prvoide some rough ideas to developers/contributors on how the
> stable release is gonna work.
> 
> And here you go (I may make it into the DPDK doc).

That is a good idea. Perhaps it could be a new Contributors Guide or a new 
section in the "Contributing Code to DPDK" doc.

John

[dpdk-dev] [PATCH] Tools: Fix issue with virtio interface names

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Gary Mussar
> Sent: Friday, September 2, 2016 2:17 PM
> To: dev at dpdk.org
> Cc: Gary Mussar 
> Subject: [dpdk-dev] [PATCH] Tools: Fix issue with virtio interface names
> 
> The dpdk-devbind.py script does not find/display the ifname for virtio
> interfaces since the "net" directory is not directly under the device
> directory but rather under a subdirectory.
> eg.
> > dpdk-devbind.py --status
> :00:03.0 'Virtio network device' if= drv=virtio-pci unused=
> 
> This change searches for the first "net" directory under the device
> directory hierarchy.
> eg.
> :00:03.0 'Virtio network device' if=ens3 drv=virtio-pci unused=
> 
> Fixes: 629395b063e8 ("igb_uio: remove PCI id table")
> 
> Signed-off-by: Gary Mussar 

Thanks for that.

Note, the subject line should be lowercase but apart from that:

Acked-by: John McNamara 

[dpdk-dev] [PATCH v1] dpdk-devbind.py: Virtio interface issue.

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Mussar, Gary
> Sent: Monday, August 29, 2016 4:10 PM
> To: Dey, Souvik ; Stephen Hemminger
> 
> Cc: nhorman at tuxdriver.com; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v1] dpdk-devbind.py: Virtio interface
> issue.
> 
> We did this slightly differently. This is 100% python and is a bit more
> general. We search for the first "net" directory under the specific device
> directory.
> 
> ---
> --- tools/dpdk-devbind.py   2016-08-29 11:02:35.594202888 -0400
> +++ ../dpdk/tools/dpdk-devbind.py 2016-08-29 11:00:34.897677233 -0400
> @@ -221,11 +221,11 @@
>  name = name.strip(":") + "_str"
>  device[name] = value
>  # check for a unix interface name
> -sys_path = "/sys/bus/pci/devices/%s/net/" % dev_id
> -if exists(sys_path):
> -device["Interface"] = ",".join(os.listdir(sys_path))
> -else:
> -device["Interface"] = ""
> +device["Interface"] = ""
> +for base, dirs, files in os.walk("/sys/bus/pci/devices/%s/" %
> dev_id):
> +if "net" in dirs:
> +device["Interface"] =
> ",".join(os.listdir(os.path.join(base,"net")))
> +break
>  # check if a port is used for ssh connection
>  device["Ssh_if"] = False
>  device["Active"] = ""
> ---

Hi Gary,

That looks like a cleaner solution. Could you submit that as a patch.

Souvik, could you test this patch and confirm it fixes your issue.


Gary, if you submit a patch could you make a few minor changes:

> +device["Interface"] = ""
> +for base, dirs, files in os.walk("/sys/bus/pci/devices/%s/" % dev_id):
> +

If "files" is unused, and it looks like it is, then replace it with "_".


> +device["Interface"] = 
> ",".join(os.listdir(os.path.join(base,"net")))

There is a space required after "," for PEP8 compliance.

John

[dpdk-dev] [PATCH 1/2] examples/l2fwd: Add new option to enable/disable MAC addresses tweaking

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Maxime Coquelin
> Sent: Tuesday, July 26, 2016 4:56 PM
> To: Richardson, Bruce ; De Lara Guarch, Pablo
> 
> Cc: dev at dpdk.org; Maxime Coquelin 
> Subject: [dpdk-dev] [PATCH 1/2] examples/l2fwd: Add new option to
> enable/disable MAC addresses tweaking
> 
> l2fwd could be useful for testing virtual devices without the need of
> physical ones.
> 
> To achieve this, this patch adds a new option to enable/disable the MAC
> addresses tweaking done at forwarding time: --[no-]mac-tweaking

Acked-by: John McNamara 

[dpdk-dev] [PATCH 0/2] examples/l2fwd: Add option to enable/disable MAC addresses tweaking

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Maxime Coquelin
> Sent: Tuesday, July 26, 2016 4:56 PM
> To: Richardson, Bruce ; De Lara Guarch, Pablo
> 
> Cc: dev at dpdk.org; Maxime Coquelin 
> Subject: [dpdk-dev] [PATCH 0/2] examples/l2fwd: Add option to
> enable/disable MAC addresses tweaking
> 
> This series adds a new option to enable/disable MAC addresses tweaking in
> l2fwd example.
> 
> Doing that, we can enable basic VM 2 VM communication easily, without
> external projects dependencies, nor real NIC (as with vhost example).

Hi,

This looks like a useful feature. However, I don't know if "tweaking" is
the best description of the feature. Maybe "updating" would be better.

John

[dpdk-dev] [PATCH 3/4] doc: add basic invocation info for dpdk-devbind

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Christian Ehrhardt
> Sent: Thursday, August 4, 2016 12:17 PM
> To: christian.ehrhardt at canonical.com; thomas.monjalon at 6wind.com;
> dev at dpdk.org
> Subject: [dpdk-dev] [PATCH 3/4] doc: add basic invocation info for dpdk-
> devbind
> 
> +
> +OPTIONS
> +---
> +
> +* ``--help, --usage``
> +
> +Display usage information and quit
> +
> +* ``-s, --status``
> +
> +Print the current status of all known network interfaces.
> +For each device, it displays the PCI domain, bus, slot and
> function,
> +along with a text description of the device. Depending upon
> whether the
> +device is being used by a kernel driver, the igb_uio driver, or
> no
> +driver, other relevant information will be displayed:
> +* the Linux interface name e.g. if=eth0
> +* the driver being used e.g. drv=igb_uio
> +* any suitable drivers not currently using that device
> +e.g. unused=igb_uio
> +NOTE: if this flag is passed along with a bind/unbind option, the
> +status display will always occur after the other operations have
> taken
> +place.

There are a few RST errors in this file. One of theme relates to the second
level bullet list above. There should be a blank line before and after the list.

Also, "e.g. unused=igb_uio" should be joined to, or aligned with, the previous
line.

Also, it would be better to quote any fixed width strings in the docs with 
quotes, like ``unused=igb_uio``. This could be applied to any of the 
``--options``
in the text as well.
> +Examples
> +
> +
> +To display current device status:
> +.. code-block:: console
> +
> +   dpdk-devbind --status
> +

All the "code-block" directives should have a blank line before them.
However it is probably better to use the simpler :: directive, like:

To display current device status::

dpdk-devbind --status

[dpdk-dev] [PATCH 2/4] doc: add basic invocation info for dpdk-pmdinfo

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Christian Ehrhardt
> Sent: Thursday, August 4, 2016 12:17 PM
> To: christian.ehrhardt at canonical.com; thomas.monjalon at 6wind.com;
> dev at dpdk.org
> Subject: [dpdk-dev] [PATCH 2/4] doc: add basic invocation info for dpdk-
> pmdinfo
> 
> This summarizes the "how to call dpdk-pmdinfo" in one place to be picked
> up by html/pdf/man-page docs.
> 
> ...
>
>  # The following hook functions add some simple handling for the :numref:
> diff --git a/doc/guides/sample_app_ug/index.rst
> b/doc/guides/sample_app_ug/index.rst
> index 96bb317..7801688 100644
> --- a/doc/guides/sample_app_ug/index.rst
> +++ b/doc/guides/sample_app_ug/index.rst
> @@ -77,6 +77,7 @@ Sample Applications User Guide

I think these docs would be better in a "doc/guides/tools" directory.
That would be clearer in terms to the documentation structure and
also in terms of their functionality



> +dpdk-pmdinfo Application
> +
> +
> +The ``dpdk-pmdinfo`` tool is a Data Plane Development Kit (DPDK) tool
> +that can dump a PMDs hardware support info.

To avoid using "tool" twice in the sentence you could use "utility" the
second time.



> +
> +   .. Note::
> +
> +  * The actual data is stored in the object files as
> + PMD_INFO_STRING

I'd leave this note out of the description.


> +Running the Application
> +---
> +
> +The tool has a number of command line options:
> +
> +.. code-block:: console
> +
> +
> +   dpdk-pmdinfo [-hrtp] [-d 
> +
> +   -h, --helpshow a short help message and exit
> +   -r, --raw Dump as raw json strings
> +   -d FILE, --pcidb=FILE
> + specify a pci database to get vendor names from
> +   -t, --table   output information on hw support as a hex table
> +   -p, --plugindir   scan dpdk for autoload plugins
> +

One of the descriptions is in sentence case and the others aren't. It should
be one or the other. I would use sentence case for all.

[dpdk-dev] [PATCH 1/4] doc: rendering and installation of man pages

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Christian Ehrhardt
> Sent: Thursday, August 4, 2016 12:17 PM
> To: christian.ehrhardt at canonical.com; thomas.monjalon at 6wind.com;
> dev at dpdk.org
> Subject: [dpdk-dev] [PATCH 1/4] doc: rendering and installation of man
> pages
> 

Acked-by: John McNamara 

[dpdk-dev] [PATCH 0/4] provide man pages for binaries provided by DPDK

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Christian Ehrhardt
> Sent: Thursday, August 4, 2016 12:17 PM
> To: christian.ehrhardt at canonical.com; thomas.monjalon at 6wind.com;
> dev at dpdk.org
> Subject: [dpdk-dev] [PATCH 0/4] provide man pages for binaries provided by
> DPDK
> 
> Hi,
> this is about providing manpages for the binaries installed by DPDK.
> Eventually people using commands expect at least something reasonable
> avalable behind "man command".
> 

Hi Christian,

Thanks for that. It is really useful and the output looks very good.

I'll make a few minor comments to the patches.

John

[dpdk-dev] [PATCH] tools: add crypto device details

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Eoin Breen
> Sent: Thursday, August 25, 2016 11:05 AM
> To: Jain, Deepak K ; Trahe, Fiona
> ; Griffin, John 
> Cc: dev at dpdk.org; Breen, Eoin 
> Subject: [dpdk-dev] [PATCH] tools: add crypto device details
> 
> Adding the support to bind/unbind crypto devices with dpdk-devbind.py
> script, as now it is not restricted to network devices anymore.
> 

Hi Eoin,

There are a couple of small pep8 issues to fix:


$ pep8 tools/dpdk-devbind.py   
tools/dpdk-devbind.py:302:1: E302 expected 2 blank lines, found 1
tools/dpdk-devbind.py:653:33: E261 at least two spaces before inline comment

See: http://dpdk.org/doc/guides/contributing/coding_style.html#python-code

John

[dpdk-dev] [PATCH v1] dpdk-devbind.py: Virtio interface issue.

[Mcnamara, John]

> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Thursday, August 25, 2016 11:19 AM
> To: Mcnamara, John 
> Cc: dev at dpdk.org; souvikdey33 ; nhorman at 
> tuxdriver.com
> Subject: Re: [dpdk-dev] [PATCH v1] dpdk-devbind.py: Virtio interface
> issue.
> 
> 2016-08-25 09:51, Mcnamara, John:
> > The word fix on the command line normally means you should add a
> > "Fixes" line to the body but in this case the issue was probably
> > always there (or at least since virtio support was added) so you can
> probably omit it.
> 
> Even if it has always been there, we need to know the commit origin.
> The "Fixes:" line makes things clear and helps when backporting.
> Thanks

In that case the fixline should be:

Fixes: 629395b063e8 ("igb_uio: remove PCI id table")

John

[dpdk-dev] [PATCH v1] dpdk-devbind.py: Virtio interface issue.

[Mcnamara, John]

Hi,

Welcome to DPDK and thanks for the contribution. It looks like a useful fix.

Since you are a new contributor the user guide on "Contributing Code to DPDK"
explains some of the steps involved:

http://dpdk.org/doc/guides/contributing/patches.html

Some comments below.


> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of souvikdey33
> Sent: Thursday, August 25, 2016 3:26 AM
> To: nhorman at tuxdriver.com; dev at dpdk.org
> Cc: souvikdey33 
> Subject: [dpdk-dev] [PATCH v1] dpdk-devbind.py: Virtio interface issue.

As you will see in the guide above the subject line should be lowercase and
shouldn't end with a full stop. Also, the prefix would be better as "tools". 
Something like this:

tools: fix issue with virtio interfaces

The word fix on the command line normally means you should add a "Fixes" line
to the body but in this case the issue was probably always there (or at least
since virtio support was added) so you can probably omit it.

> 
> This change is required to have the interface name for virtio interfaces.
> When we execute the status command the for virtio inerfaces we get Sample
> output without the change:
> :00:04.0 'Virtio network device' if= drv=virtio-pci
> unused=virtio_pci,igb_uio Though for other drivers this works.
> Sample output with the change:
> :00:04.0 'Virtio network device' if=eth0 drv=virtio-pci
> unused=virtio_pci,igb_uio
> 
> souvikdey33 (1):
>   Signed-off-by: souvikdey33 

You should add your real name to the sign off.



> diff --git a/tools/dpdk-devbind.py b/tools/dpdk-devbind.py index
> b69ca2a..9829e25 100755
> --- a/tools/dpdk-devbind.py
> +++ b/tools/dpdk-devbind.py
> @@ -36,6 +36,8 @@ import sys
>  import os
>  import getopt
>  import subprocess
> +import commands

The commands module is deprecated in Python 2 and removed in Python 3.
Python 2 and 3 should both be supported by the DPDK tools. In which case
you can use subprocess.check_output(), or similar, instead.


> +
>  from os.path import exists, abspath, dirname, basename
> 
>  # The PCI base class for NETWORK devices @@ -222,8 +224,15 @@ def
> get_pci_device_details(dev_id):
>  device[name] = value
>  # check for a unix interface name
>  sys_path = "/sys/bus/pci/devices/%s/net/" % dev_id
> +#The path for virtio devices are different. Get the correct path.
> + virtio = "/sys/bus/pci/devices/%s/" % dev_id

This space/tab indentation gives a Python error.


> +cmd = " ls %s | grep 'virt' " %virtio
> +virtio = commands.getoutput(cmd)
> +virtio_sys_path = "/sys/bus/pci/devices/%s/%s/net/" %
> +(dev_id,virtio)
>  if exists(sys_path):
>  device["Interface"] = ",".join(os.listdir(sys_path))
> +elif exists(virt_path):
> +device["Interface"] = ",".join(os.listdir(virtio_sys_path))
>  else:
>  device["Interface"] = ""
>  # check if a port is used for ssh connection

There a number of small Python formatting issues in the patch. The DPDK Python
code follows the pep8 guidelines:

http://dpdk.org/doc/guides/contributing/coding_style.html#python-code

Here are the warnings:

$ pep8 tools/dpdk-devbind.py 
tools/dpdk-devbind.py:227:5:  E265 block comment should start with '# '
tools/dpdk-devbind.py:228:1:  E101 indentation contains mixed spaces and 
tabs
tools/dpdk-devbind.py:228:1:  W191 indentation contains tabs
tools/dpdk-devbind.py:228:2:  E113 unexpected indentation
tools/dpdk-devbind.py:229:1:  E101 indentation contains mixed spaces and 
tabs
tools/dpdk-devbind.py:229:36: E225 missing whitespace around operator
tools/dpdk-devbind.py:231:66: E231 missing whitespace after ','

Could you fix those issues and submit a V2 of the patch.

Thanks.

John

[dpdk-dev] [PATCH] drivers: make driver names consistent

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pablo de Lara
> Sent: Wednesday, August 24, 2016 11:25 PM
> To: dev at dpdk.org
> Cc: De Lara Guarch, Pablo 
> Subject: [dpdk-dev] [PATCH] drivers: make driver names consistent
>
> ...
>
> -$RTE_TARGET/app/testpmd -c '0xf' -n 4 --vdev 
> 'eth_pcap0,rx_pcap=/path/to/ file_rx.pcap,tx_pcap=/path/to/file_tx.pcap' -- 
> --port-topology=chained
> +$RTE_TARGET/app/testpmd -c '0xf' -n 4 --vdev 
> 'net_pcap0,rx_pcap=/path/to/ file_rx.pcap,tx_pcap=/path/to/file_tx.pcap' -- 
> --port-topology=chained


I know that this is an existing issue but there shouldn't be a space in
"/path/to/ file". Perhaps you could fix that (in a number of places) as part
of this patch. You could probably leave out the "/path/to/" part altogether as 
it may be clearer, see below.

Also, could you wrap the long code lines in the sections that you change at 
80 chars using "\" to keep them on the page in the PDF docs, like:

$RTE_TARGET/app/testpmd -c '0xf' -n 4 \
--vdev 
'net_pcap0,rx_pcap=/path/to/file_rx.pcap,tx_pcap=/path/to/file_tx.pcap' \
-- --port-topology=chained

Or without the path part:

$RTE_TARGET/app/testpmd -c '0xf' -n 4 \
--vdev 'net_pcap0,rx_pcap=file_rx.pcap,tx_pcap=file_tx.pcap' \
-- --port-topology=chained

John

[dpdk-dev] [PATCH] doc: remove useless file listings

[Mcnamara, John]

> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Tuesday, August 23, 2016 1:45 PM
> To: Mcnamara, John 
> Cc: dev at dpdk.org
> Subject: [PATCH] doc: remove useless file listings
> 
> Lists of DPDK files are hard to maintain up to date and does not bring
> much information.
> 
> Signed-off-by: Thomas Monjalon 


Acked-by: John McNamara 

[dpdk-dev] [PATCH v1] doc: fix broken link in docs

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of O Connor, Deirdre
> Sent: Monday, August 22, 2016 5:20 PM
> To: dev at dpdk.org
> Cc: O Connor, Deirdre 
> Subject: [dpdk-dev] [PATCH v1] doc: fix broken link in docs
> 
> From: Deirdre O'Connor 
> 
> Fixes: 58abf6e77c6b ("doc: add contributors guide")
> 
> Suggested-by: Jon Loeliger 
> Signed-off-by: Deirdre O'Connor 


Acked-by: John McNamara 

[dpdk-dev] DPDK Stable Releases and Long Term Support

[Mcnamara, John]

> -Original Message-
> From: Panu Matilainen [mailto:pmatilai at redhat.com]
> Sent: Wednesday, August 17, 2016 1:30 PM
> To: Mcnamara, John ; dev at dpdk.org
> Subject: Re: [dpdk-dev] DPDK Stable Releases and Long Term Support
> 
> ...
>
> > ABI
> > ---
> >
> > The Stable Release should not be seen as a way of breaking or
> > circumventing the DPDK ABI policy.
> 
> I find this a strange thing to say about a stable/LTS release ABI. I had
> read the originating thread before seeing this, but it still made me go
> "Huh?" for several seconds. The problem perhaps being, the rest of the
> document addresses stable/LTS releases, but this statement speaks about
> normal development work going on elsewhere.
> 
> The earlier version had a mention about ABI/API breakage related to things
> what not to backport but that's entirely gone here. Given how important
> ABI + API stability is for stable/LTS releases, I think it deserves a
> special mention here. Maybe something more to the tune of:
> 
> ---
> ABI or API breakages are not permitted in stable releases, special care
> must be taken to when backporting.
> 
> The existence of stable release(s) does not lessen the need to comply to
> DPDK ABI policy in development work.
> ---

That seems reasonable. If I do an update to the doc or add it to the guides 
I'll update it with this.

> 
> With the exception of the ABI/API thing, this looks like a fair starting
> point to me. Time and experience will tell more.
> 

I also think that we will have to see how it goes. What is important is that we 
end up with something that is useful to the community and consumers.

John.
-- 

[dpdk-dev] [PATCH] examples: fix unusual-interpreter

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Monday, August 1, 2016 2:26 PM
> To: Christian Ehrhardt 
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] examples: fix unusual-interpreter
> 
> 2016-08-01 15:12, Christian Ehrhardt:
> > On Mon, Aug 1, 2016 at 2:50 PM, Thomas Monjalon
> > 
> > wrote:
> > > 2016-08-01 14:28, Christian Ehrhardt:
> > > > Due to regular lintian checks in Debian packaging it surfaced that
> > > > these two scripts had a space in their #! statement which renders
> > > > it to be human, but not shell readable.
> > > [...]
> > > > -#! /usr/bin/python2
> > > > +#!/usr/bin/python2
> > >
> > > I think we can have a space in the shebang (it works with shells I
> know).
> > > But maybe lintian do not like it (and it is a sufficient reason to
> > > accept this trivial patch).
> > >
> > > However, a better fix would be to run something else than python2,
> > > like /usr/bin/env python.
> > >
> > > Some other python scripts in tools dir may be fixed.
> >
> > I agree on both changes you suggested, but not being the scripts
> > author I wanted to change as few as possible.
> > Also thanks for taking it into consideration even if just for lintian
> > :-)
> >
> > If acceptable to you I'd ask to accept this as-is and consider the
> > patch a head-up for all script owners to change their headers.
> 
> We can remove the space in every scripts, at least.
> Then we can wait a little for the opinion of the script authors to do more
> changes.
> 

Hi,

The script is Python2/3 compatible so remove the space and change to 
/usr/bin/python or similar.

John

[dpdk-dev] [PATCH v3] doc: autogenerate nic overview table from ini files

[Mcnamara, John]

I forgot to add the annotations:

v3:
* Updated to latest version of the nic overview table.

v2:
* Updated to latest version of the nic overview table.
* Removed blank entries from the ini file.

[dpdk-dev] DPDK Stable Releases and Long Term Support

[Mcnamara, John]

This document sets out the guidelines for DPDK Stable Releases and Long Term
Support releases (LTS) based on the initial RFC and comments:
http://dpdk.org/ml/archives/dev/2016-June/040256.html.

In particular it incorporates suggestions for a Stable Release structure as
well as a Long Term Support release.


Introduction


The purpose of the DPDK Stable Releases will be to maintain releases of DPDK
with backported fixes over an extended period of time. This will provide
downstream consumers of DPDK with a stable target on which to base
applications or packages.

The Long Term Support release (LTS) will be a designation applied to a Stable
Release to indicate longer support.


Stable Releases
---

Any major release of DPDK can be designated as a Stable Release if a
maintainer volunteers to maintain it.

A Stable Release will be used to backport fixes from a N release back to a N-1
release, for example, from 16.11 to 16.07.

The duration of a stable release should be one complete release cycle. It can
be longer, up to 1 year, if a maintainer continues to support the stable
branch, or if users supply backported fixes, however the explicit commitment
should be for one release cycle.

The release cadence can be determined by the maintainer based on the number of
bugfixes and the criticality of the bugs. However, releases should be
coordinated with the validation engineers to ensure that a tagged release has
been tested.


LTS Release
---

A stable release can be designated as an LTS release based on community
agreement and a commitment from a maintainer. An LTS release will have a
maintenance duration of 2 years.

It is anticipated that there should be at least 4 releases per year of the LTS
or approximately 1 every 3 months. However, the cadence can be shorter or
longer depending on the number and criticality of the backported
fixes. Releases should be coordinated with the validation engineers to ensure
that a tagged release has been tested.


Initial Stable Release
--

The initial DPDK Stable Release will be 16.07. It will be viewed as a trial of
the Stable Release/LTS policy to determine what are the best working practices
for DPDK.

The maintainer for the initial release will be Yuanhan Liu
. It is hoped that other community members will
volunteer as maintainers for other Stable Releases.

The initial targeted release for LTS is proposed to be 16.11 based on the
results of the work carried out on the 16.07 Stable Release.

A list has been set up for Stable Release/LTS specific discussions:
. This address can also be used for CCing maintainers on bug
fix submissions.


What changes should be backported
-

The backporting should be limited to bug fixes.

Features should not be backported to stable releases. It may be acceptable, in
limited cases, to back port features for the LTS release where:

* There is a justifiable use case (for example a new PMD).
* The change is non-invasive.
* The work of preparing the backport is done by the proposer.
* There is support within the community.


Testing
---

Stable and LTS releases should be tested before release/tagging.

Intel will provide validation engineers to test the 16.07 Stable Release and
the initial LTS tree. Other community members should provide testing for other
stable releases.

The validation will consist of compilation testing on the range of OSes
supported by the master release and functional/performance testing on the
current major/LTS release of the following OSes:

* Ubuntu
* RHEL
* SuSE
* FreeBSD


Releasing
-

A Stable Release will be released by:

* Tagging the release with YY.MM.nn (year, month, number) or similar.
* Uploading a tarball of the release to dpdk.org.
* Sending an announcement to the  list.


ABI
---

The Stable Release should not be seen as a way of breaking or circumventing
the DPDK ABI policy.


Review of the Stable Release/LTS guidelines
---

This document serves as a set of guidelines for the planned Stable
Releases/LTS activities. However, the actual process can be reviewed and
amended over time, based on experiences and feedback.

[dpdk-dev] [PATCH] doc: announce removal of Xen Dom0 support

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Thursday, July 28, 2016 9:20 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: announce removal of Xen Dom0 support
> 
> There were some efforts to fix Xen Dom0 support in 16.07:
>   http://dpdk.org/ml/archives/dev/2016-July/043823.html
> But there is still at least one bug:
>   http://dpdk.org/ml/archives/dev/2016-July/044207.html
> And nobody cares:
>   http://dpdk.org/ml/archives/dev/2016-July/044376.html
> 
> Signed-off-by: Thomas Monjalon 

We would like some additional time to gauge customer usage of this feature and 
also the possibility of taking maintainership. So our preference would be to 
Nack the deprecation in this release. If there is no change/customer feedback 
we will Ack it in the next release.

So: Nack.

John

[dpdk-dev] [PATCH v5] doc: add section on tested platforms and nics and OSes

[Mcnamara, John]

> -Original Message-
> From: Pei, Yulong
> Sent: Thursday, July 28, 2016 7:19 AM
> To: dev at dpdk.org; thomas.monjalon at 6wind.com; Mcnamara, John
> 
> Cc: Pei, Yulong 
> Subject: [PATCH v5] doc: add section on tested platforms and nics and OSes
> 
> Add new section on tested platforms and nics and OSes to the release
> notes.
> 
> Signed-off-by: Yulong Pei 

Acked-by: John McNamara 

[dpdk-dev] Compiler hardening flags for libraries and performance implications

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Matthew Hall
> Sent: Tuesday, July 26, 2016 5:44 PM
> To: Luca Boccassi 
> Cc: dev at dpdk.org; christian.ehrhardt at canonical.com;
> cjcollier at linuxfoundation.org; ricardo.salveti at linaro.org
> Subject: Re: [dpdk-dev] Compiler hardening flags for libraries and
> performance implications
> 
> On Tue, Jul 26, 2016 at 02:53:13PM +, Luca Boccassi wrote:
> > While working on uploading DPDK to Ubuntu and Debian, we were
> > wondering if anyone had any thoughts/opinions on enabling compiler
> > hardening flags for the DPDK libraries and the possible performance
> implications.
> 
> Most of the C profilers, both VTune and Perf based tools, have not given
> me that much helpful data. They make it very hard to go from slow
> functions down to actual slow lines of code causing performance issues
> that I should fix. So I would love to see a MUCH better DPDK tuning guide,
> because the current one is really generic and gives no useful advice
> beyond what any programmer has already heard many times that doesn't
> really add much value.

Hi Matthew,

Maybe you kick this off and submit something to the new howto section of the 
docs with whatever tuning tips you have so far.

Then we can get people to contribute over time until we have something more 
useful.

John

[dpdk-dev] [PATCH v2] doc: update guide and release notes for mlx5

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olga Shern
> Sent: Wednesday, July 27, 2016 10:27 AM
> To: dev at dpdk.org
> Cc: Olga Shern 
> Subject: [dpdk-dev] [PATCH v2] doc: update guide and release notes for
> mlx5
> 
> Signed-off-by: Olga Shern 

Acked-by: John McNamara 

[dpdk-dev] [PATCH] doc : update guide and release notes for mlx5

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olga Shern
> Sent: Tuesday, July 26, 2016 5:29 PM
> To: dev at dpdk.org
> Cc: Olga Shern 
> Subject: [dpdk-dev] [PATCH] doc : update guide and release notes for mlx5
> 
> ...
>
> +* **Updated the mlx5 driver.**
> +
> +  The mlx5 driver was updated with changes including the following:
> +
> +  * Data path was refactored to bypass Verbs to improve RX and TX
> performance.
> +  * Removed compilation parameters for inline send, MLX5_MAX_INLINE, and
> +added command line parameter instead, txq_inline.
> +  * Improved TX scatter gather support:
> +Removed compilation parameter MLX5_PMD_SGE_WR_N.
> +Scatter-gather elements is set to the maximum value the NIC supports.
> +Removed linearization logic, this decreases the memory consumption of
> the PMD.
> +  * Improved jumbo frames support, by dynamically setting RX scatter
> gather elements
> +according to the MTU and mbuf size,
> +no need for compilation parameter MLX5_PMD_SGE_WR_N.
> +

Hi,

There are 2 whitespace warnings in the patch. If you resubmit can you also
put the MLX5 variables in  fixed width quotes.

Apart from that:

Acked-by: John McNamara 

[dpdk-dev] [PATCH v4] doc: add section on tested platforms and nics and OSes

[Mcnamara, John]

> -Original Message-
> From: Pei, Yulong
> Sent: Wednesday, July 27, 2016 4:14 AM
> To: dev at dpdk.org; thomas.monjalon at 6wind.com
> Cc: Mcnamara, John ; Pei, Yulong
> 
> Subject: [PATCH v4] doc: add section on tested platforms and nics and OSes
> 
> Add new section on tested platforms and nics and OSes to the release
> notes.
> 
> ...
>
> +Tested OSes
> +---
> +
> +.. This section should contain a list of OSes that were tested with this
> release.
> +
> +   - CentOS 7.0
> +   - Fedora 23
> +   - Fedora 24
> +   - FreeBSD 10.3
> +   - Red Hat Enterprise Linux 7.2
> +   - SUSE Enterprise Linux 12
> +   - Ubuntu 15.10
> +   - Ubuntu 16.04 LTS
> +   - Wind River Linux 8
> +

Unfortunately, the list of OSes is at the same indentation level as the comment 
so it is parsed as a comment and isn't visible in the final doc. You can check 
the doc output as follows:

make doc-guides-html  -j 
firefox build/doc/html/guides/rel_notes/release_16_07.html &

Just remove the leading whitespace at the start of the list.

Sorry for the rework.

John

[dpdk-dev] [PATCH v3] doc: add known issue about promiscuous mode for I40e VF

[Mcnamara, John]

> -Original Message-
> From: Guo, Jia
> Sent: Wednesday, July 27, 2016 3:57 AM
> To: Mcnamara, John 
> Cc: dev at dpdk.org; Guo, Jia 
> Subject: [PATCH v3] doc: add known issue about promiscuous mode for I40e
> VF
> 
> When use i40e linux kernel driver as host driver and DPDK handler the i40e
> VF, the promiscuous mode doesn't work in i40e VF. It is not supported by
> DPDK i40e VF driver right now.
> 
> Signed-off-by: Jeff Guo 

Acked-by: John McNamara 

[dpdk-dev] [PATCH v2] ethdev: fix documentation for queue start/stop

[Mcnamara, John]

> -Original Message-
> From: Rao, Nikhil
> Sent: Tuesday, July 26, 2016 3:13 PM
> To: dev at dpdk.org
> Cc: thomas.monjalon at 6wind.com; Yigit, Ferruh ;
> Mcnamara, John ; Rao, Nikhil
> 
> Subject: [PATCH v2] ethdev: fix documentation for queue start/stop
> 
> Fix documentation for rte_eth_dev_tx/rx_queue_start/stop() functions
> 
> Fixes: 2de9f8551ff9 ("ethdev: fix documentation for queue start/stop")
> 
> Signed-off-by: Nikhil Rao 

Acked-by: John McNamara 

[dpdk-dev] [PATCH v2] doc: add known issue about promiscuous mode for I40e VF

[Mcnamara, John]

> -Original Message-
> From: Guo, Jia
> Sent: Tuesday, July 26, 2016 3:24 AM
> To: Mcnamara, John 
> Cc: dev at dpdk.org; Guo, Jia 
> Subject: [PATCH v2] doc: add known issue about promiscuous mode for I40e
> VF
> 
> When use i40e linux kernel driver as host driver and DPDK handler the i40e
> VF, the promiscuous mode doesn't work in i40e VF. It is not supported by
> DPDK i40e VF driver right now.
> 
> Signed-off-by: Jeff Guo 
> ---
> v1->v2:
> - add singned-off and modify some format
> 
>  doc/guides/rel_notes/known_issues.rst | 22 ++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/known_issues.rst
> b/doc/guides/rel_notes/known_issues.rst
> index 5ec1987..e907c22 100644
> --- a/doc/guides/rel_notes/known_issues.rst
> +++ b/doc/guides/rel_notes/known_issues.rst
> @@ -620,3 +620,25 @@ The last EAL argument is replaced by the program name
> in argv[]
> 
>  **Driver/Module**:
> Environment Abstraction Layer (EAL).
> +
> +
> +I40e VF can't receive the promiscuous unicast/multicast/broadcast packet.
> +-

The underline here is too short and generates a warning:

doc/guides/rel_notes/known_issues.rst:626: WARNING: Title underline too 
short.

I40e VF can't receive the promiscuous unicast/multicast/broadcast packet.
-

> +
> +**Description**:
> +   Use i40e linux kernel driver PF generate VF, and run testpmd, set
> Promiscuous mode and
> +   All multicast mode to be enabled, then send packet with unknown
> destination MAC address
> +   to VF, but VF can't receive the packet.


The text style and tense doesn't match the rest of the doc. I would suggest
something like:


I40e VF may not receive packets in promiscuous mode
---

**Description**:
   Promiscuous mode is not supported by the DPDK i40e VF driver when using the
   i40e Linux kernel driver as host driver.

**Implication**:
   The i40e VF does not receive packets when the destination MAC address is 
unknown.

**Resolution/Workaround**:
   Use a destination MAC address that matches the VF.

**Affected Environment/Platform**:
   All.

**Driver/Module**:
   Poll Mode Driver (PMD).

[dpdk-dev] [PATCH v3] doc: add section on tested platforms and nics and OSes

[Mcnamara, John]

> -Original Message-
> From: Pei, Yulong
> Sent: Tuesday, July 26, 2016 4:33 AM
> To: dev at dpdk.org; thomas.monjalon at 6wind.com
> Cc: Mcnamara, John ; Pei, Yulong
> 
> Subject: [PATCH v3] doc: add section on tested platforms and nics and OSes
> 
> Add new section on tested platforms and nics and OSes to the release
> notes.
> 
> Signed-off-by: Yulong Pei 
> ---
>  doc/guides/rel_notes/release_16_07.rst | 119
> ++---
>  1 file changed, 111 insertions(+), 8 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/release_16_07.rst
> b/doc/guides/rel_notes/release_16_07.rst
> index d00a6ed..52faa8f 100644
> --- a/doc/guides/rel_notes/release_16_07.rst
> +++ b/doc/guides/rel_notes/release_16_07.rst
> @@ -393,12 +393,51 @@ Tested Platforms
>  .. This section should contain a list of platforms that were tested with
> this
> release.
> 
> -   The format is:
> +#. SuperMicro 1U

Hi,

This patch is still removing some RST comments. It is best to leave them
in place.

John

[dpdk-dev] [PATCH] doc: fix incorrect path to testpmd app

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Mcnamara, John
> Sent: Tuesday, July 26, 2016 2:57 PM
> To: Shreyansh Jain ; De Lara Guarch, Pablo
> 
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] doc: fix incorrect path to testpmd app
> 
> >
> >  .. code-block:: console
> >
> > -$RTE_SDK/$RTE_TARGET/build/app/testpmd
> > +$RTE_SDK/$RTE_TARGET/app/testpmd
> 
> The exe is actually two places after the build but the existing one in the
> docs looks correct, the one in "build" looks different to me:
> 
> $ find . -name testpmd | xargs ls -1
> ./x86_64-native-linuxapp-gcc/app/testpmd
> ./x86_64-native-linuxapp-gcc/build/app/test-pmd/testpmd
> 

Sorry, I misread the +/- on that. So the fix looks good.

Acked-by: John McNamara 

[dpdk-dev] [PATCH] doc: fix incorrect path to testpmd app

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Shreyansh Jain
> Sent: Tuesday, July 26, 2016 2:32 PM
> To: De Lara Guarch, Pablo 
> Cc: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: fix incorrect path to testpmd app
> 
> Signed-off-by: Shreyansh Jain 
> ---
>  doc/guides/testpmd_app_ug/build_app.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/guides/testpmd_app_ug/build_app.rst
> b/doc/guides/testpmd_app_ug/build_app.rst
> index 7f32a7c..4c7cf2e 100644
> --- a/doc/guides/testpmd_app_ug/build_app.rst
> +++ b/doc/guides/testpmd_app_ug/build_app.rst
> @@ -58,4 +58,4 @@ The basic compilation steps are:
> 
>  .. code-block:: console
> 
> -$RTE_SDK/$RTE_TARGET/build/app/testpmd
> +$RTE_SDK/$RTE_TARGET/app/testpmd

The exe is actually two places after the build but the existing one in
the docs looks correct, the one in "build" looks different to me:

$ find . -name testpmd | xargs ls -1
./x86_64-native-linuxapp-gcc/app/testpmd
./x86_64-native-linuxapp-gcc/build/app/test-pmd/testpmd

John

[dpdk-dev] [PATCH] ethdev: fix documentation for queue start/stop functions

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Nikhil P Rao
> Sent: Tuesday, July 26, 2016 1:37 PM
> To: dev at dpdk.org
> Cc: thomas.monjalon at 6wind.com; Rao, Nikhil 
> Subject: [dpdk-dev] [PATCH] ethdev: fix documentation for queue start/stop
> functions
> 
> From: nikhil.rao at intel.com
> 
> Fix documentation for rte_eth_dev_tx/rx_queue_start/stop() functions

Hi,

Thanks for this. Some comments below.


> 
> Signed-off-by: Nikhil Rao 
> ---
>  lib/librte_ether/rte_ethdev.h | 12 +---
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
> index 022733e..d72fab9 100644
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> @@ -2039,9 +2039,7 @@ int rte_eth_dev_socket_id(uint8_t port_id);  int
> rte_eth_dev_is_valid_port(uint8_t port_id);
> 
>  /*
> - * Allocate mbuf from mempool, setup the DMA physical address
> - * and then start RX for specified queue of a port. It is used
> - * when rx_deferred_start flag of the specified queue is true.
> + * Start specified RX queue of a port.

This change, more or less, reverts the change to this description added in 
commit 3111eae26e2296ec049e6dfc3c0c522d7b9e1c62.

I don't know if "Allocate mbuf from mempool, setup the DMA physical address"
is correct for all pmds so maybe that could be omitted. However, it is 
probably worth keeping the part about the rx_deferred_start flag.



>   *
>   * @param port_id
>   *   The port identifier of the Ethernet device
> @@ -2050,7 +2048,7 @@ int rte_eth_dev_is_valid_port(uint8_t port_id);
>   *   The value must be in the range [0, nb_rx_queue - 1] previously
> supplied
>   *   to rte_eth_dev_configure().
>   * @return
> - *   - 0: Success, the transmit queue is correctly set up.
> + *   - 0: Success, the receive queue is enabled.

+1 to this and the other changes.

John

[dpdk-dev] [PATCH] maintainers: add an entry for the stable branches

[Mcnamara, John]

> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Monday, July 25, 2016 3:38 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] maintainers: add an entry for the stable
> branches
> 
> This git tree will be used to backport some fixes from the master branch
> to maintain some "stable releases".
> The minor version number z will be incremented for these releases:
>   YY.MM.z
> 
> Signed-off-by: Thomas Monjalon 


Acked-by: John McNamara 

[dpdk-dev] [PATCH v4] doc: flow bifurcation guide on Linux

[Mcnamara, John]

> -Original Message-
> From: Wu, Jingjing
> Sent: Tuesday, July 19, 2016 4:31 AM
> To: Mcnamara, John 
> Cc: dev at dpdk.org; Wu, Jingjing ; Liu, Yong
> ; Zhang, Helin 
> Subject: [PATCH v4] doc: flow bifurcation guide on Linux
> 
> Flow Bifurcation is a mechanism which uses features of advanced Ethernet
> devices to split traffic between queues. It provides the capability to let
> the kernel driver and DPDK driver co-exist and take advantage of both.
> 
> It is achieved by using SR-IOV and the NIC's advanced filtering. This
> patch describes Flow Bifurcation and adds the user guide for ixgbe and
> i40e NICs.
> 
> Signed-off-by: Jingjing Wu 




This patch is dependent on:
[PATCH v5 1/2] doc: live migration of VM with Virtio and VF

The following patch is also dependent on it:

[PATCH v3 1/2] doc: live migration of VM with vhost_user on host

There is now a merge conflict between your patch and the second patch
because index.rst has been changed.

Maybe the 2 patches above could be combined and you can rebase your
patch against it.

But as for the patch itself:


Acked-by: John McNamara