[dpdk-dev] [PATCH] app/test: fix bond device name too long
> > Bond device name was too long (grather than 32 signs) that cause mempool
> > allocation to fail.
> >
> > Fixes: 92073ef961ee ("bond: unit tests")
> >
> > Signed-off-by: Michal Jastrzebski
>
> Acked-by: Bernard Iremonger
Applied, thanks
[dpdk-dev] [PATCH] app/test: fix bond device name too long
2016-06-08 11:50, Jastrzebski, MichalX K: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2016-05-27 18:38, Thomas Monjalon: > > > 2016-05-27 17:20, Michal Jastrzebski: > > > > Bond device name was too long (grather than 32 signs) that > > > > cause mempool allocation to fail. > > > > > > Maybe that this kind of failure would be avoided if the test > > > was added to autotests (app/test/autotest_data.py). > > > > > > Generally speaking, it would be a good idea to make an audit > > > on which tests are missing in "make fast_test" and "make test". > > > > Any comment please? > > Hi Thomas, > > There is a small timeout in test_tlb_tx_burst - big burst has to be generated > to > detect balancing and small timeout has to be included between each burst, > thus I am not sure if link_bonding_autotest can be classified to fast tests > (test takes about 3-4 seconds). > We can add this test to autotests script for which time is not so critical. The bug we see here could be detected by just initializing bonding. Maybe we can consider having some basic/fast tests and others longer.
[dpdk-dev] [PATCH] app/test: fix bond device name too long
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, June 08, 2016 3:31 PM > To: Jastrzebski, MichalX K > Cc: Iremonger, Bernard ; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] app/test: fix bond device name too long > > 2016-06-08 11:50, Jastrzebski, MichalX K: > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > > 2016-05-27 18:38, Thomas Monjalon: > > > > 2016-05-27 17:20, Michal Jastrzebski: > > > > > Bond device name was too long (grather than 32 signs) that > > > > > cause mempool allocation to fail. > > > > > > > > Maybe that this kind of failure would be avoided if the test > > > > was added to autotests (app/test/autotest_data.py). > > > > > > > > Generally speaking, it would be a good idea to make an audit > > > > on which tests are missing in "make fast_test" and "make test". > > > > > > Any comment please? > > > > Hi Thomas, > > > > There is a small timeout in test_tlb_tx_burst - big burst has to be > generated to > > detect balancing and small timeout has to be included between each > burst, > > thus I am not sure if link_bonding_autotest can be classified to fast tests > > (test takes about 3-4 seconds). > > We can add this test to autotests script for which time is not so critical. > > The bug we see here could be detected by just initializing bonding. > Maybe we can consider having some basic/fast tests and others longer. Actually this particular bug does not happen during bonding initialization, but only after user will configure bond device in mode 6 (ALB). As only in mode 6 we need mempool allocation and we do rte_pktmbuf_pool_create giving as a mempool name - bond device name BONDED_DEV_NAME. Best regards Michal
[dpdk-dev] [PATCH] app/test: fix bond device name too long
2016-05-27 18:38, Thomas Monjalon: > 2016-05-27 17:20, Michal Jastrzebski: > > Bond device name was too long (grather than 32 signs) that > > cause mempool allocation to fail. > > Maybe that this kind of failure would be avoided if the test > was added to autotests (app/test/autotest_data.py). > > Generally speaking, it would be a good idea to make an audit > on which tests are missing in "make fast_test" and "make test". Any comment please?
[dpdk-dev] [PATCH] app/test: fix bond device name too long
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, June 08, 2016 12:40 PM > To: Jastrzebski, MichalX K ; Iremonger, > Bernard > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] app/test: fix bond device name too long > > 2016-05-27 18:38, Thomas Monjalon: > > 2016-05-27 17:20, Michal Jastrzebski: > > > Bond device name was too long (grather than 32 signs) that > > > cause mempool allocation to fail. > > > > Maybe that this kind of failure would be avoided if the test > > was added to autotests (app/test/autotest_data.py). > > > > Generally speaking, it would be a good idea to make an audit > > on which tests are missing in "make fast_test" and "make test". > > Any comment please? Hi Thomas, There is a small timeout in test_tlb_tx_burst - big burst has to be generated to detect balancing and small timeout has to be included between each burst, thus I am not sure if link_bonding_autotest can be classified to fast tests (test takes about 3-4 seconds). We can add this test to autotests script for which time is not so critical. Best regards Michal
[dpdk-dev] [PATCH] app/test: fix bond device name too long
Test case: link_bonging_autotest
Package:dpdk.org master branch newest commit + this patch
Test cmdline: ./x86_64-native-linuxapp-gcc/app/test -c -n 1
Exec link_bonging_autotest cmdl Test environment:
OS: dpdk-rhel72 3.10.0-327.el7.x86_64
Gcc: gcc version 4.8.5 20150623 (Red Hat 4.8.5-4) (GCC)
Hugepage: 4096*2M
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Michal Jastrzebski
> Sent: Friday, May 27, 2016 11:21 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] app/test: fix bond device name too long
>
> Bond device name was too long (grather than 32 signs) that
> cause mempool allocation to fail.
>
> Fixes: 92073ef961ee ("bond: unit tests")
>
> Signed-off-by: Michal Jastrzebski
Tested-by: huilong xu
> ---
> app/test/test_link_bonding.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c
> index 7cbc289..eeb1395 100644
> --- a/app/test/test_link_bonding.c
> +++ b/app/test/test_link_bonding.c
> @@ -83,7 +83,7 @@
> #define MAX_PKT_BURST(512)
> #define DEF_PKT_BURST(16)
>
> -#define BONDED_DEV_NAME ("unit_test_bonded_device")
> +#define BONDED_DEV_NAME ("unit_test_bond_dev")
>
> #define INVALID_SOCKET_ID(-1)
> #define INVALID_PORT_ID (-1)
> --
> 1.7.9.5
[dpdk-dev] [PATCH] app/test: fix bond device name too long
Tester-by: huilong xu
Test case: link_bonging_autotest
Package:dpdk.org master branch newest commit + this patch
Test cmdline: ./x86_64-native-linuxapp-gcc/app/test -c -n 1
Exec link_bonging_autotest cmdl
Test environment:
OS: dpdk-rhel72 3.10.0-327.el7.x86_64
Gcc: gcc version 4.8.5 20150623 (Red Hat 4.8.5-4) (GCC)
Hugepage: 4096*2M
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Michal Jastrzebski
> Sent: Friday, May 27, 2016 11:21 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] app/test: fix bond device name too long
>
> Bond device name was too long (grather than 32 signs) that
> cause mempool allocation to fail.
>
> Fixes: 92073ef961ee ("bond: unit tests")
>
> Signed-off-by: Michal Jastrzebski
> ---
> app/test/test_link_bonding.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c
> index 7cbc289..eeb1395 100644
> --- a/app/test/test_link_bonding.c
> +++ b/app/test/test_link_bonding.c
> @@ -83,7 +83,7 @@
> #define MAX_PKT_BURST(512)
> #define DEF_PKT_BURST(16)
>
> -#define BONDED_DEV_NAME ("unit_test_bonded_device")
> +#define BONDED_DEV_NAME ("unit_test_bond_dev")
>
> #define INVALID_SOCKET_ID(-1)
> #define INVALID_PORT_ID (-1)
> --
> 1.7.9.5
[dpdk-dev] [PATCH] app/test: fix bond device name too long
2016-05-27 17:20, Michal Jastrzebski: > Bond device name was too long (grather than 32 signs) that > cause mempool allocation to fail. Maybe that this kind of failure would be avoided if the test was added to autotests (app/test/autotest_data.py). Generally speaking, it would be a good idea to make an audit on which tests are missing in "make fast_test" and "make test".
[dpdk-dev] [PATCH] app/test: fix bond device name too long
Bond device name was too long (grather than 32 signs) that
cause mempool allocation to fail.
Fixes: 92073ef961ee ("bond: unit tests")
Signed-off-by: Michal Jastrzebski
---
app/test/test_link_bonding.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c
index 7cbc289..eeb1395 100644
--- a/app/test/test_link_bonding.c
+++ b/app/test/test_link_bonding.c
@@ -83,7 +83,7 @@
#define MAX_PKT_BURST (512)
#define DEF_PKT_BURST (16)
-#define BONDED_DEV_NAME("unit_test_bonded_device")
+#define BONDED_DEV_NAME("unit_test_bond_dev")
#define INVALID_SOCKET_ID (-1)
#define INVALID_PORT_ID(-1)
--
1.7.9.5
[dpdk-dev] [PATCH] app/test: fix bond device name too long
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Michal Jastrzebski
> Sent: Friday, May 27, 2016 4:21 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH] app/test: fix bond device name too long
>
> Bond device name was too long (grather than 32 signs) that cause mempool
> allocation to fail.
>
> Fixes: 92073ef961ee ("bond: unit tests")
>
> Signed-off-by: Michal Jastrzebski
Acked-by: Bernard Iremonger
