[dpdk-dev] [PATCH] eal: remove useless internal function from memcpy headers

2016-04-27 Thread Thomas Monjalon
2016-04-20 11:07, David Marchand:
> On Tue, Apr 19, 2016 at 10:47 PM, Thomas Monjalon
>  wrote:
> > The function rte_memcpy_func() is used in ARM and PPC implementations
> > of rte_memcpy().
> > There are some useless copies in Tile and some ARM branches.
> > It was also declared without doxygen comment in the generic header.
> >
> > Signed-off-by: Thomas Monjalon 
> 
> Looks good to me.
> Acked-by: David Marchand 

Applied


[dpdk-dev] [PATCH] eal: remove useless internal function from memcpy headers

2016-04-20 Thread David Marchand
On Tue, Apr 19, 2016 at 10:47 PM, Thomas Monjalon
 wrote:
> The function rte_memcpy_func() is used in ARM and PPC implementations
> of rte_memcpy().
> There are some useless copies in Tile and some ARM branches.
> It was also declared without doxygen comment in the generic header.
>
> Signed-off-by: Thomas Monjalon 

Looks good to me.
Acked-by: David Marchand 


-- 
David Marchand


[dpdk-dev] [PATCH] eal: remove useless internal function from memcpy headers

2016-04-19 Thread Thomas Monjalon
The function rte_memcpy_func() is used in ARM and PPC implementations
of rte_memcpy().
There are some useless copies in Tile and some ARM branches.
It was also declared without doxygen comment in the generic header.

Signed-off-by: Thomas Monjalon 
---
 lib/librte_eal/common/include/arch/arm/rte_memcpy_32.h | 6 --
 lib/librte_eal/common/include/arch/arm/rte_memcpy_64.h | 6 --
 lib/librte_eal/common/include/arch/tile/rte_memcpy.h   | 6 --
 lib/librte_eal/common/include/generic/rte_memcpy.h | 7 ---
 4 files changed, 25 deletions(-)

diff --git a/lib/librte_eal/common/include/arch/arm/rte_memcpy_32.h 
b/lib/librte_eal/common/include/arch/arm/rte_memcpy_32.h
index 988125b..da6c233 100644
--- a/lib/librte_eal/common/include/arch/arm/rte_memcpy_32.h
+++ b/lib/librte_eal/common/include/arch/arm/rte_memcpy_32.h
@@ -323,12 +323,6 @@ rte_memcpy(void *dst, const void *src, size_t n)
return memcpy(dst, src, n);
 }

-static inline void *
-rte_memcpy_func(void *dst, const void *src, size_t n)
-{
-   return memcpy(dst, src, n);
-}
-
 #endif /* RTE_ARCH_ARM_NEON_MEMCPY */

 #ifdef __cplusplus
diff --git a/lib/librte_eal/common/include/arch/arm/rte_memcpy_64.h 
b/lib/librte_eal/common/include/arch/arm/rte_memcpy_64.h
index 917cdc1..5db66b6 100644
--- a/lib/librte_eal/common/include/arch/arm/rte_memcpy_64.h
+++ b/lib/librte_eal/common/include/arch/arm/rte_memcpy_64.h
@@ -80,12 +80,6 @@ rte_mov256(uint8_t *dst, const uint8_t *src)

 #define rte_memcpy(d, s, n)memcpy((d), (s), (n))

-static inline void *
-rte_memcpy_func(void *dst, const void *src, size_t n)
-{
-   return memcpy(dst, src, n);
-}
-
 #ifdef __cplusplus
 }
 #endif
diff --git a/lib/librte_eal/common/include/arch/tile/rte_memcpy.h 
b/lib/librte_eal/common/include/arch/tile/rte_memcpy.h
index 9b5b37e..e606957 100644
--- a/lib/librte_eal/common/include/arch/tile/rte_memcpy.h
+++ b/lib/librte_eal/common/include/arch/tile/rte_memcpy.h
@@ -80,12 +80,6 @@ rte_mov256(uint8_t *dst, const uint8_t *src)

 #define rte_memcpy(d, s, n)memcpy((d), (s), (n))

-static inline void *
-rte_memcpy_func(void *dst, const void *src, size_t n)
-{
-   return memcpy(dst, src, n);
-}
-
 #ifdef __cplusplus
 }
 #endif
diff --git a/lib/librte_eal/common/include/generic/rte_memcpy.h 
b/lib/librte_eal/common/include/generic/rte_memcpy.h
index 03e8477..afb0afe 100644
--- a/lib/librte_eal/common/include/generic/rte_memcpy.h
+++ b/lib/librte_eal/common/include/generic/rte_memcpy.h
@@ -134,11 +134,4 @@ rte_memcpy(void *dst, const void *src, size_t n);

 #endif /* __DOXYGEN__ */

-/*
- * memcpy() function used by rte_memcpy macro
- */
-static inline void *
-rte_memcpy_func(void *dst, const void *src, size_t n) 
__attribute__((always_inline));
-
-
 #endif /* _RTE_MEMCPY_H_ */
-- 
2.7.0