[dpdk-dev] [PATCH] enic: fix vlan filtering

[Thomas Monjalon]

2015-10-31 17:04, Sujith Sankar:
> On 30/10/15 9:43 pm, "David Marchand"  wrote:
> >From: Julien Meunier 
> >
> >Report an error when something went wrong.
> >
> >Signed-off-by: Julien Meunier 
> >Signed-off-by: David Marchand 
> Acked.

Applied, thanks

[dpdk-dev] [PATCH] enic: fix vlan filtering

[Sujith Sankar (ssujith)]

On 30/10/15 9:43 pm, "David Marchand"  wrote:

>From: Julien Meunier 
>
>Report an error when something went wrong.
>
>Signed-off-by: Julien Meunier 
>Signed-off-by: David Marchand 
>---
> drivers/net/enic/enic_ethdev.c | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/net/enic/enic_ethdev.c
>b/drivers/net/enic/enic_ethdev.c
>index e385560..5df9a6c 100644
>--- a/drivers/net/enic/enic_ethdev.c
>+++ b/drivers/net/enic/enic_ethdev.c
>@@ -271,13 +271,14 @@ static int enicpmd_vlan_filter_set(struct
>rte_eth_dev *eth_dev,
>   uint16_t vlan_id, int on)
> {
>   struct enic *enic = pmd_priv(eth_dev);
>+  int err;
> 
>   ENICPMD_FUNC_TRACE();
>   if (on)
>-  enic_add_vlan(enic, vlan_id);
>+  err = enic_add_vlan(enic, vlan_id);
>   else
>-  enic_del_vlan(enic, vlan_id);
>-  return 0;
>+  err = enic_del_vlan(enic, vlan_id);
>+  return err;

Acked.

Thanks,
-Sujith

> }
> 
> static void enicpmd_vlan_offload_set(struct rte_eth_dev *eth_dev, int
>mask)
>-- 
>1.9.1
>

[dpdk-dev] [PATCH] enic: fix vlan filtering

[David Marchand]

From: Julien Meunier 

Report an error when something went wrong.

Signed-off-by: Julien Meunier 
Signed-off-by: David Marchand 
---
 drivers/net/enic/enic_ethdev.c | 7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c
index e385560..5df9a6c 100644
--- a/drivers/net/enic/enic_ethdev.c
+++ b/drivers/net/enic/enic_ethdev.c
@@ -271,13 +271,14 @@ static int enicpmd_vlan_filter_set(struct rte_eth_dev 
*eth_dev,
uint16_t vlan_id, int on)
 {
struct enic *enic = pmd_priv(eth_dev);
+   int err;

ENICPMD_FUNC_TRACE();
if (on)
-   enic_add_vlan(enic, vlan_id);
+   err = enic_add_vlan(enic, vlan_id);
else
-   enic_del_vlan(enic, vlan_id);
-   return 0;
+   err = enic_del_vlan(enic, vlan_id);
+   return err;
 }

 static void enicpmd_vlan_offload_set(struct rte_eth_dev *eth_dev, int mask)
-- 
1.9.1