[dpdk-dev] [PATCH] ethdev: change comments of VLAN type
> -Original Message- > From: Lu, Wenzhuo > Sent: Friday, June 3, 2016 10:53 AM > To: Xing, Beilei ; Wu, Jingjing intel.com> > Cc: dev at dpdk.org; Xing, Beilei > Subject: RE: [dpdk-dev] [PATCH] ethdev: change comments of VLAN type > > Hi Beilei, > > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Beilei Xing > > Sent: Thursday, May 26, 2016 3:28 PM > > To: Wu, Jingjing > > Cc: dev at dpdk.org; Xing, Beilei > > Subject: [dpdk-dev] [PATCH] ethdev: change comments of VLAN type > > > > If the packet carries a single VLAN header, it is treated as the outer > > header. > > So change the comments of inner VLAN and outer VLAN. > > > > Signed-off-by: Beilei Xing > > --- > > doc/guides/rel_notes/release_16_07.rst | 3 +++ > > lib/librte_ether/rte_ethdev.h | 4 ++-- > > 2 files changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/doc/guides/rel_notes/release_16_07.rst > > b/doc/guides/rel_notes/release_16_07.rst > > index 30e78d4..29db86c 100644 > > --- a/doc/guides/rel_notes/release_16_07.rst > > +++ b/doc/guides/rel_notes/release_16_07.rst > > @@ -116,6 +116,9 @@ API Changes > >ibadcrc, ibadlen, imcasts, fdirmatch, fdirmiss, > >tx_pause_xon, rx_pause_xon, tx_pause_xoff, rx_pause_xoff. > > > > +* The comments of ``ETH_VLAN_TYPE_INNER`` and > > ``ETH_VLAN_TYPE_OUTER`` > > +in > > + ``rte_vlan_type`` are changed. > I think we need more explanation here. At least the info in the commit log. Hi Wenzhuo, Thanks for your comments, and plan to combine this patch with i40 driver modification, it should be better. Beilei
[dpdk-dev] [PATCH] ethdev: change comments of VLAN type
Hi Beilei, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Beilei Xing > Sent: Thursday, May 26, 2016 3:28 PM > To: Wu, Jingjing > Cc: dev at dpdk.org; Xing, Beilei > Subject: [dpdk-dev] [PATCH] ethdev: change comments of VLAN type > > If the packet carries a single VLAN header, it is treated as the outer header. > So change the comments of inner VLAN and outer VLAN. > > Signed-off-by: Beilei Xing > --- > doc/guides/rel_notes/release_16_07.rst | 3 +++ > lib/librte_ether/rte_ethdev.h | 4 ++-- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/doc/guides/rel_notes/release_16_07.rst > b/doc/guides/rel_notes/release_16_07.rst > index 30e78d4..29db86c 100644 > --- a/doc/guides/rel_notes/release_16_07.rst > +++ b/doc/guides/rel_notes/release_16_07.rst > @@ -116,6 +116,9 @@ API Changes >ibadcrc, ibadlen, imcasts, fdirmatch, fdirmiss, >tx_pause_xon, rx_pause_xon, tx_pause_xoff, rx_pause_xoff. > > +* The comments of ``ETH_VLAN_TYPE_INNER`` and > ``ETH_VLAN_TYPE_OUTER`` > +in > + ``rte_vlan_type`` are changed. I think we need more explanation here. At least the info in the commit log.
[dpdk-dev] [PATCH] ethdev: change comments of VLAN type
If the packet carries a single VLAN header, it is treated as the
outer header.
So change the comments of inner VLAN and outer VLAN.
Signed-off-by: Beilei Xing
---
doc/guides/rel_notes/release_16_07.rst | 3 +++
lib/librte_ether/rte_ethdev.h | 4 ++--
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/doc/guides/rel_notes/release_16_07.rst
b/doc/guides/rel_notes/release_16_07.rst
index 30e78d4..29db86c 100644
--- a/doc/guides/rel_notes/release_16_07.rst
+++ b/doc/guides/rel_notes/release_16_07.rst
@@ -116,6 +116,9 @@ API Changes
ibadcrc, ibadlen, imcasts, fdirmatch, fdirmiss,
tx_pause_xon, rx_pause_xon, tx_pause_xoff, rx_pause_xoff.
+* The comments of ``ETH_VLAN_TYPE_INNER`` and ``ETH_VLAN_TYPE_OUTER`` in
+ ``rte_vlan_type`` are changed.
+
ABI Changes
---
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index 2757510..c5c29fb 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -363,8 +363,8 @@ struct rte_eth_rxmode {
*/
enum rte_vlan_type {
ETH_VLAN_TYPE_UNKNOWN = 0,
- ETH_VLAN_TYPE_INNER, /**< Single VLAN, or inner VLAN. */
- ETH_VLAN_TYPE_OUTER, /**< Outer VLAN. */
+ ETH_VLAN_TYPE_INNER, /**< Inner VLAN. */
+ ETH_VLAN_TYPE_OUTER, /**< Single VLAN, or outer VLAN. */
ETH_VLAN_TYPE_MAX,
};
--
2.5.0
