[dpdk-dev] [PATCH] qede: fix icc build error
> >fix errors:
> >icc: command line warning #10006: ignoring unknown option
> >'-Wno-unused-value'
> >icc: command line warning #10006: ignoring unknown option
> >'-Wno-format-nonliteral'
> >icc: command line warning #10006: ignoring unknown option
> >'-Wno-shift-negative-value'
> >qede/base/ecore_dev.c(1643): error #188: enumerated type mixed with
> >another type
> >return 0;
> > ^
> >
> >Signed-off-by: Ferruh Yigit
>
> Looks good.
> I hope its retested against gcc/clang also to make sure the change doesn?t
> cause build errors.
>
> Acked-by: Harish Patil
Fixes: ec94dbc57362 ("qede: add base driver")
Applied, thanks
[dpdk-dev] [PATCH] qede: fix icc build error
On 5/10/2016 9:02 PM, Harish Patil wrote: > Hi Ferruh, > >> fix errors: >> icc: command line warning #10006: ignoring unknown option >> '-Wno-unused-value' >> icc: command line warning #10006: ignoring unknown option >> '-Wno-format-nonliteral' >> icc: command line warning #10006: ignoring unknown option >> '-Wno-shift-negative-value' >> qede/base/ecore_dev.c(1643): error #188: enumerated type mixed with >> another type >>return 0; >> ^ >> >> Signed-off-by: Ferruh Yigit >> --- >> drivers/net/qede/Makefile | 7 +-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile >> index 47e01be..d0c1361 100644 >> --- a/drivers/net/qede/Makefile >> +++ b/drivers/net/qede/Makefile >> @@ -27,7 +27,6 @@ OS_TYPE := $(shell uname -s) >> # CFLAGS >> # >> CFLAGS_BASE_DRIVER = -Wno-unused-parameter >> -CFLAGS_BASE_DRIVER += -Wno-unused-value >> CFLAGS_BASE_DRIVER += -Wno-sign-compare >> CFLAGS_BASE_DRIVER += -Wno-missing-prototypes >> CFLAGS_BASE_DRIVER += -Wno-cast-qual >> @@ -35,12 +34,16 @@ CFLAGS_BASE_DRIVER += -Wno-unused-function >> CFLAGS_BASE_DRIVER += -Wno-unused-variable >> CFLAGS_BASE_DRIVER += -Wno-strict-aliasing >> CFLAGS_BASE_DRIVER += -Wno-missing-prototypes >> + >> +ifneq ($(CONFIG_RTE_TOOLCHAIN_ICC),y) >> +CFLAGS_BASE_DRIVER += -Wno-unused-value > > This change is not for the actual build error but to mask the warning: > > icc: command line warning #10006: ignoring unknown option > '-Wno-unused-value?, right? > > > If so, what about for Wno-format-nonliteral and Wno-shift-negative-value? These three flags are not supported by icc, please check commit log, it has three of them in warnings, so removing them for icc. This doesn't cause a compilation error, just warnings from compiler but it is too noisy, I believe good to remove. > >> CFLAGS_BASE_DRIVER += -Wno-format-nonliteral >> ifeq ($(OS_TYPE),Linux) >> ifeq ($(shell clang -Wno-shift-negative-value -Werror -E - < /dev/null > >> /dev/null 2>&1; echo $$?),0) >> CFLAGS_BASE_DRIVER += -Wno-shift-negative-value >> endif >> endif >> +endif >> >> ifneq (,$(filter gcc gcc48,$(CC))) >> CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable >> @@ -57,7 +60,7 @@ ifeq ($(shell clang -Wno-pointer-bool-conversion >> -Werror -E - < /dev/null > /dev >> CFLAGS_BASE_DRIVER += -Wno-pointer-bool-conversion >> endif >> else >> -#icc flags >> +CFLAGS_BASE_DRIVER += -wd188 #188: enumerated type mixed with another >> type >> endif >> >> # >> -- >> 2.5.5 >> >> > Looks good. > I hope its retested against gcc/clang also to make sure the change doesn?t > cause build errors. Yes, did a gcc and clang compile test. > Acked-by: Harish Patil > >
[dpdk-dev] [PATCH] qede: fix icc build error
Hi Ferruh, >fix errors: >icc: command line warning #10006: ignoring unknown option >'-Wno-unused-value' >icc: command line warning #10006: ignoring unknown option >'-Wno-format-nonliteral' >icc: command line warning #10006: ignoring unknown option >'-Wno-shift-negative-value' >qede/base/ecore_dev.c(1643): error #188: enumerated type mixed with >another type >return 0; > ^ > >Signed-off-by: Ferruh Yigit >--- > drivers/net/qede/Makefile | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > >diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile >index 47e01be..d0c1361 100644 >--- a/drivers/net/qede/Makefile >+++ b/drivers/net/qede/Makefile >@@ -27,7 +27,6 @@ OS_TYPE := $(shell uname -s) > # CFLAGS > # > CFLAGS_BASE_DRIVER = -Wno-unused-parameter >-CFLAGS_BASE_DRIVER += -Wno-unused-value > CFLAGS_BASE_DRIVER += -Wno-sign-compare > CFLAGS_BASE_DRIVER += -Wno-missing-prototypes > CFLAGS_BASE_DRIVER += -Wno-cast-qual >@@ -35,12 +34,16 @@ CFLAGS_BASE_DRIVER += -Wno-unused-function > CFLAGS_BASE_DRIVER += -Wno-unused-variable > CFLAGS_BASE_DRIVER += -Wno-strict-aliasing > CFLAGS_BASE_DRIVER += -Wno-missing-prototypes >+ >+ifneq ($(CONFIG_RTE_TOOLCHAIN_ICC),y) >+CFLAGS_BASE_DRIVER += -Wno-unused-value This change is not for the actual build error but to mask the warning: icc: command line warning #10006: ignoring unknown option '-Wno-unused-value?, right? If so, what about for Wno-format-nonliteral and Wno-shift-negative-value? > CFLAGS_BASE_DRIVER += -Wno-format-nonliteral > ifeq ($(OS_TYPE),Linux) > ifeq ($(shell clang -Wno-shift-negative-value -Werror -E - < /dev/null > >/dev/null 2>&1; echo $$?),0) > CFLAGS_BASE_DRIVER += -Wno-shift-negative-value > endif > endif >+endif > > ifneq (,$(filter gcc gcc48,$(CC))) > CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable >@@ -57,7 +60,7 @@ ifeq ($(shell clang -Wno-pointer-bool-conversion >-Werror -E - < /dev/null > /dev > CFLAGS_BASE_DRIVER += -Wno-pointer-bool-conversion > endif > else >-#icc flags >+CFLAGS_BASE_DRIVER += -wd188 #188: enumerated type mixed with another >type > endif > > # >-- >2.5.5 > > Looks good. I hope its retested against gcc/clang also to make sure the change doesn?t cause build errors. Acked-by: Harish Patil
[dpdk-dev] [PATCH] qede: fix icc build error
fix errors: icc: command line warning #10006: ignoring unknown option '-Wno-unused-value' icc: command line warning #10006: ignoring unknown option '-Wno-format-nonliteral' icc: command line warning #10006: ignoring unknown option '-Wno-shift-negative-value' qede/base/ecore_dev.c(1643): error #188: enumerated type mixed with another type return 0; ^ Signed-off-by: Ferruh Yigit --- drivers/net/qede/Makefile | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/qede/Makefile b/drivers/net/qede/Makefile index 47e01be..d0c1361 100644 --- a/drivers/net/qede/Makefile +++ b/drivers/net/qede/Makefile @@ -27,7 +27,6 @@ OS_TYPE := $(shell uname -s) # CFLAGS # CFLAGS_BASE_DRIVER = -Wno-unused-parameter -CFLAGS_BASE_DRIVER += -Wno-unused-value CFLAGS_BASE_DRIVER += -Wno-sign-compare CFLAGS_BASE_DRIVER += -Wno-missing-prototypes CFLAGS_BASE_DRIVER += -Wno-cast-qual @@ -35,12 +34,16 @@ CFLAGS_BASE_DRIVER += -Wno-unused-function CFLAGS_BASE_DRIVER += -Wno-unused-variable CFLAGS_BASE_DRIVER += -Wno-strict-aliasing CFLAGS_BASE_DRIVER += -Wno-missing-prototypes + +ifneq ($(CONFIG_RTE_TOOLCHAIN_ICC),y) +CFLAGS_BASE_DRIVER += -Wno-unused-value CFLAGS_BASE_DRIVER += -Wno-format-nonliteral ifeq ($(OS_TYPE),Linux) ifeq ($(shell clang -Wno-shift-negative-value -Werror -E - < /dev/null > /dev/null 2>&1; echo $$?),0) CFLAGS_BASE_DRIVER += -Wno-shift-negative-value endif endif +endif ifneq (,$(filter gcc gcc48,$(CC))) CFLAGS_BASE_DRIVER += -Wno-unused-but-set-variable @@ -57,7 +60,7 @@ ifeq ($(shell clang -Wno-pointer-bool-conversion -Werror -E - < /dev/null > /dev CFLAGS_BASE_DRIVER += -Wno-pointer-bool-conversion endif else -#icc flags +CFLAGS_BASE_DRIVER += -wd188 #188: enumerated type mixed with another type endif # -- 2.5.5
