[dpdk-dev] [PATCH] ring: fix minor memory free issue

2015-11-07 Thread Thomas Monjalon
2015-11-06 17:28, John McNamara:
> Fix minor memory free issue in error clean-up.
> 
> Reported-by Coverity (CID 119258)
> 
> Signed-off-by: John McNamara 

Fixes: 651c505af862 ("ring: enhance device setup from rings")

Applied, thanks



[dpdk-dev] [PATCH] ring: fix minor memory free issue

2015-11-06 Thread John McNamara
Fix minor memory free issue in error clean-up.

Reported-by Coverity (CID 119258)

Signed-off-by: John McNamara 
---
 drivers/net/ring/rte_eth_ring.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index cc60008..9a31bce 100644
--- a/drivers/net/ring/rte_eth_ring.c
+++ b/drivers/net/ring/rte_eth_ring.c
@@ -363,8 +363,10 @@ rte_eth_from_rings(const char *name, struct rte_ring 
*const rx_queues[],
return data->port_id;

 error:
-   rte_free(data->rx_queues);
-   rte_free(data->tx_queues);
+   if (data) {
+   rte_free(data->rx_queues);
+   rte_free(data->tx_queues);
+   }
rte_free(data);
rte_free(internals);

-- 
1.8.1.4