[dpdk-dev] [PATCH 01/17] qede/base: update base driver

2016-09-16 Thread Ferruh Yigit
Hi Rasesh,

On 8/27/2016 7:26 AM, Rasesh Mody wrote:
> This patch updates the base driver and incorporates neccessary changes
> required to bring in the new firmware 8.10.9.0.
> 
> In addition, it would allow driver to add new functionalities that might
> be needed in future.
> 
> Signed-off-by: Rasesh Mody 
> ---
<...>
>  65 files changed, 14653 insertions(+), 8536 deletions(-)
<...>

Sorry for late review.

This is base driver update, but still a big single patch with 14K lines
insertions, it is too hard to both review or contribute.

Is it possible to split patch into more smaller ones, ideally it should
be one patch for one feature/fix, but please do whatever can be done.

I can see there are some big chunk of whitespace updates, or new files
for debug (hsi_debug_tools.h), those can be easy to target.

Thanks,
ferruh


[dpdk-dev] [PATCH 01/17] qede/base: update base driver

2016-08-27 Thread Rasesh Mody
This patch updates the base driver and incorporates neccessary changes
required to bring in the new firmware 8.10.9.0.

In addition, it would allow driver to add new functionalities that might
be needed in future.

Signed-off-by: Rasesh Mody 
---
 doc/guides/nics/features/qede.ini |2 +
 doc/guides/nics/features/qede_vf.ini  |2 +
 doc/guides/nics/qede.rst  |   15 +-
 drivers/net/qede/Makefile |4 +
 drivers/net/qede/base/bcm_osal.c  |   21 +
 drivers/net/qede/base/bcm_osal.h  |   10 +
 drivers/net/qede/base/common_hsi.h| 1511 +
 drivers/net/qede/base/ecore.h |  626 +++
 drivers/net/qede/base/ecore_chain.h   |   51 +-
 drivers/net/qede/base/ecore_cxt.c |  387 -
 drivers/net/qede/base/ecore_cxt.h |   52 +-
 drivers/net/qede/base/ecore_cxt_api.h |   25 +-
 drivers/net/qede/base/ecore_dcbx.c|  589 ++-
 drivers/net/qede/base/ecore_dcbx.h|   18 +-
 drivers/net/qede/base/ecore_dcbx_api.h|  154 +-
 drivers/net/qede/base/ecore_dev.c | 1778 ++--
 drivers/net/qede/base/ecore_dev_api.h |  209 ++-
 drivers/net/qede/base/ecore_gtt_reg_addr.h|   30 +-
 drivers/net/qede/base/ecore_gtt_values.h  |   20 +-
 drivers/net/qede/base/ecore_hsi_common.h  | 1358 +--
 drivers/net/qede/base/ecore_hsi_debug_tools.h | 1025 
 drivers/net/qede/base/ecore_hsi_eth.h |  997 ---
 drivers/net/qede/base/ecore_hsi_init_func.h   |  132 ++
 drivers/net/qede/base/ecore_hsi_init_tool.h   |  454 +
 drivers/net/qede/base/ecore_hsi_tools.h   | 1081 
 drivers/net/qede/base/ecore_hw.c  |  222 ++-
 drivers/net/qede/base/ecore_hw.h  |   75 +-
 drivers/net/qede/base/ecore_hw_defs.h |   39 +-
 drivers/net/qede/base/ecore_init_fw_funcs.c   |  400 +++--
 drivers/net/qede/base/ecore_init_fw_funcs.h   |  250 ++-
 drivers/net/qede/base/ecore_init_ops.c|   30 +-
 drivers/net/qede/base/ecore_init_ops.h|   14 +-
 drivers/net/qede/base/ecore_int.c |  446 +++--
 drivers/net/qede/base/ecore_int.h |   23 +-
 drivers/net/qede/base/ecore_int_api.h |   11 +
 drivers/net/qede/base/ecore_iov_api.h |  519 ++
 drivers/net/qede/base/ecore_iro.h |  234 ++-
 drivers/net/qede/base/ecore_iro_values.h  |  140 +-
 drivers/net/qede/base/ecore_l2.c  |  423 +++--
 drivers/net/qede/base/ecore_l2.h  |   61 +-
 drivers/net/qede/base/ecore_l2_api.h  |  112 +-
 drivers/net/qede/base/ecore_mcp.c |  713 ++--
 drivers/net/qede/base/ecore_mcp.h |   91 +-
 drivers/net/qede/base/ecore_mcp_api.h |  210 ++-
 drivers/net/qede/base/ecore_proto_if.h|   63 +-
 drivers/net/qede/base/ecore_rt_defs.h |  869 +-
 drivers/net/qede/base/ecore_sp_api.h  |   15 +-
 drivers/net/qede/base/ecore_sp_commands.c |   99 +-
 drivers/net/qede/base/ecore_sp_commands.h |   38 +-
 drivers/net/qede/base/ecore_spq.c |  237 +--
 drivers/net/qede/base/ecore_spq.h |  162 +-
 drivers/net/qede/base/ecore_sriov.c   | 1810 
 drivers/net/qede/base/ecore_sriov.h   |  247 +--
 drivers/net/qede/base/ecore_status.h  |   18 +-
 drivers/net/qede/base/ecore_vf.c  |  752 +
 drivers/net/qede/base/ecore_vf.h  |  258 +--
 drivers/net/qede/base/ecore_vf_api.h  |   97 +-
 drivers/net/qede/base/ecore_vfpf_if.h |  439 +++--
 drivers/net/qede/base/eth_common.h|  439 +++--
 drivers/net/qede/base/mcp_public.h|  825 +++---
 drivers/net/qede/base/nvm_cfg.h   | 2183 +++--
 drivers/net/qede/base/reg_addr.h  |   36 +
 drivers/net/qede/qede_eth_if.c|1 +
 drivers/net/qede/qede_main.c  |   33 +-
 drivers/net/qede/qede_rxtx.h  |4 +
 65 files changed, 14653 insertions(+), 8536 deletions(-)
 create mode 100644 drivers/net/qede/base/ecore_hsi_debug_tools.h
 create mode 100644 drivers/net/qede/base/ecore_hsi_init_func.h
 create mode 100644 drivers/net/qede/base/ecore_hsi_init_tool.h
 delete mode 100644 drivers/net/qede/base/ecore_hsi_tools.h

diff --git a/doc/guides/nics/features/qede.ini 
b/doc/guides/nics/features/qede.ini
index 0df93a6..7690773 100644
--- a/doc/guides/nics/features/qede.ini
+++ b/doc/guides/nics/features/qede.ini
@@ -19,6 +19,8 @@ VLAN filter  = Y
 Flow control = Y
 CRC offload  = Y
 VLAN offload = Y
+L3 checksum offload  = Y
+L4 checksum offload  = Y
 Packet type parsing  = Y
 Basic stats  = Y
 Extended stats   = Y
diff --git a/doc/guides/nics/features/qede_vf.ini 
b/doc/guides/nics/features/qede_vf.ini
index