[dpdk-dev] [PATCH 1/2] net/thunderx: select -fno-prefetch-loop-arrays only for gcc
On Wed, Jun 29, 2016 at 11:39:07AM +0100, Bruce Richardson wrote: > On Tue, Jun 28, 2016 at 09:55:55AM +0100, Ferruh Yigit wrote: > > On 6/27/2016 5:16 PM, Jerin Jacob wrote: > > > 'fno-prefetch-loop-arrays' optimization flag is not supported with clang > > > > > > Fixes: dcc49041 (net/thunderx: add single and multi-segment Tx functions") > > > > > > Signed-off-by: Jerin Jacob > > > Reported-by: Ferruh Yigit > > > > check-git-log gives following errors: > > > > Wrong 'Fixes' reference: > > Fixes: dcc49041 (net/thunderx: add single and multi-segment Tx > > functions") > > > > This looks like because of missing " in the beginning > > Yes, but I can fix that on apply. > > Other very minor nit is that the standard for fixes lines is to use a 12-char > commit id, rather than 8. Per contributors guide: >git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")'" > > /Bruce Applied to dpdk-next-net/rel_16_07 /Bruce
[dpdk-dev] [PATCH 1/2] net/thunderx: select -fno-prefetch-loop-arrays only for gcc
On Tue, Jun 28, 2016 at 09:55:55AM +0100, Ferruh Yigit wrote: > On 6/27/2016 5:16 PM, Jerin Jacob wrote: > > 'fno-prefetch-loop-arrays' optimization flag is not supported with clang > > > > Fixes: dcc49041 (net/thunderx: add single and multi-segment Tx functions") > > > > Signed-off-by: Jerin Jacob > > Reported-by: Ferruh Yigit > > check-git-log gives following errors: > > Wrong 'Fixes' reference: > Fixes: dcc49041 (net/thunderx: add single and multi-segment Tx > functions") > > This looks like because of missing " in the beginning Yes, but I can fix that on apply. Other very minor nit is that the standard for fixes lines is to use a 12-char commit id, rather than 8. Per contributors guide: git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h (\"%s\")'" /Bruce
[dpdk-dev] [PATCH 1/2] net/thunderx: select -fno-prefetch-loop-arrays only for gcc
On 6/27/2016 5:16 PM, Jerin Jacob wrote: > 'fno-prefetch-loop-arrays' optimization flag is not supported with clang > > Fixes: dcc49041 (net/thunderx: add single and multi-segment Tx functions") > > Signed-off-by: Jerin Jacob > Reported-by: Ferruh Yigit check-git-log gives following errors: Wrong 'Fixes' reference: Fixes: dcc49041 (net/thunderx: add single and multi-segment Tx functions") This looks like because of missing " in the beginning
