[dpdk-dev] [PATCH 2/2 v3] kni: add documentation for the mempool capacity
> > From: Alex Wang > > > > Function like 'rte_kni_rx_burst()' keeps allocating 'MAX_MBUF_BURST_NUM' > > mbufs to kni fifo queue unless the queue's capacity > > ('KNI_FIFO_COUNT_MAX') is reached. So, if the mempool is under- > > provisioned, user may run into "Out of Memory" logs from KNI code. > > This commit documents the need to provision mempool capacity of more than > > "2 x KNI_FIFO_COUNT_MAX" for each KNI interface. > > > > Signed-off-by: Alex Wang > > Acked-by: Ferruh Yigit > > Acked-by: John McNamara Applied, thanks
[dpdk-dev] [PATCH 2/2 v3] kni: add documentation for the mempool capacity
> Just to confirm, should I do anything before it gets merged? No. Looks good to me. Now you just need to wait. :-) John.
[dpdk-dev] [PATCH 2/2 v3] kni: add documentation for the mempool capacity
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Alex Wang > Sent: Saturday, May 21, 2016 8:59 AM > To: dev at dpdk.org > Cc: Yigit, Ferruh ; Alex Wang > > Subject: [dpdk-dev] [PATCH 2/2 v3] kni: add documentation for the mempool > capacity > > From: Alex Wang > > Function like 'rte_kni_rx_burst()' keeps allocating 'MAX_MBUF_BURST_NUM' > mbufs to kni fifo queue unless the queue's capacity > ('KNI_FIFO_COUNT_MAX') is reached. So, if the mempool is under- > provisioned, user may run into "Out of Memory" logs from KNI code. > This commit documents the need to provision mempool capacity of more than > "2 x KNI_FIFO_COUNT_MAX" for each KNI interface. > > Signed-off-by: Alex Wang > Acked-by: Ferruh Yigit Acked-by: John McNamara
[dpdk-dev] [PATCH 2/2 v3] kni: add documentation for the mempool capacity
Just to confirm, should I do anything before it gets merged? On Thu, Jun 9, 2016 at 5:03 AM, Mcnamara, John wrote: > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Alex Wang > > Sent: Saturday, May 21, 2016 8:59 AM > > To: dev at dpdk.org > > Cc: Yigit, Ferruh ; Alex Wang > > > > Subject: [dpdk-dev] [PATCH 2/2 v3] kni: add documentation for the mempool > > capacity > > > > From: Alex Wang > > > > Function like 'rte_kni_rx_burst()' keeps allocating 'MAX_MBUF_BURST_NUM' > > mbufs to kni fifo queue unless the queue's capacity > > ('KNI_FIFO_COUNT_MAX') is reached. So, if the mempool is under- > > provisioned, user may run into "Out of Memory" logs from KNI code. > > This commit documents the need to provision mempool capacity of more than > > "2 x KNI_FIFO_COUNT_MAX" for each KNI interface. > > > > Signed-off-by: Alex Wang > > Acked-by: Ferruh Yigit > > Acked-by: John McNamara > >
[dpdk-dev] [PATCH 2/2 v3] kni: add documentation for the mempool capacity
From: Alex WangFunction like 'rte_kni_rx_burst()' keeps allocating 'MAX_MBUF_BURST_NUM' mbufs to kni fifo queue unless the queue's capacity ('KNI_FIFO_COUNT_MAX') is reached. So, if the mempool is under-provisioned, user may run into "Out of Memory" logs from KNI code. This commit documents the need to provision mempool capacity of more than "2 x KNI_FIFO_COUNT_MAX" for each KNI interface. Signed-off-by: Alex Wang Acked-by: Ferruh Yigit --- lib/librte_kni/rte_kni.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_kni/rte_kni.h b/lib/librte_kni/rte_kni.h index 25fa45e..ac11148 100644 --- a/lib/librte_kni/rte_kni.h +++ b/lib/librte_kni/rte_kni.h @@ -113,6 +113,9 @@ extern void rte_kni_init(unsigned int max_kni_ifaces); * The rte_kni_alloc shall not be called before rte_kni_init() has been * called. rte_kni_alloc is thread safe. * + * The mempool should have capacity of more than "2 x KNI_FIFO_COUNT_MAX" + * elements for each KNI interface allocated. + * * @param pktmbuf_pool * The mempool for allocting mbufs for packets. * @param conf -- 2.1.4