[dpdk-dev] [PATCH 3/3] drivers/net:build support for new tap device driver
Regards, Keith > On Sep 16, 2016, at 2:36 AM, Panu Matilainen wrote: > > On 09/15/2016 05:10 PM, Keith Wiles wrote: >> Signed-off-by: Keith Wiles >> --- >> config/common_linuxapp | 3 +++ >> drivers/net/Makefile | 1 + >> mk/rte.app.mk | 1 + >> 3 files changed, 5 insertions(+) >> >> diff --git a/config/common_linuxapp b/config/common_linuxapp >> index 2483dfa..704c01c 100644 >> --- a/config/common_linuxapp >> +++ b/config/common_linuxapp >> @@ -44,3 +44,6 @@ CONFIG_RTE_LIBRTE_PMD_VHOST=y >> CONFIG_RTE_LIBRTE_PMD_AF_PACKET=y >> CONFIG_RTE_LIBRTE_POWER=y >> CONFIG_RTE_VIRTIO_USER=y >> +CONFIG_RTE_LIBRTE_PMD_TAP=y >> +CONFIG_RTE_PMD_TAP_MAX_QUEUES=32 >> + >> diff --git a/drivers/net/Makefile b/drivers/net/Makefile >> index bc93230..b4afa98 100644 >> --- a/drivers/net/Makefile >> +++ b/drivers/net/Makefile >> @@ -55,6 +55,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD) += thunderx >> DIRS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += virtio >> DIRS-$(CONFIG_RTE_LIBRTE_VMXNET3_PMD) += vmxnet3 >> DIRS-$(CONFIG_RTE_LIBRTE_PMD_XENVIRT) += xenvirt >> +DIRS-$(CONFIG_RTE_LIBRTE_PMD_TAP) += tap >> >> ifeq ($(CONFIG_RTE_LIBRTE_VHOST),y) >> DIRS-$(CONFIG_RTE_LIBRTE_PMD_VHOST) += vhost >> diff --git a/mk/rte.app.mk b/mk/rte.app.mk >> index 1a0095b..bd1d10f 100644 >> --- a/mk/rte.app.mk >> +++ b/mk/rte.app.mk >> @@ -129,6 +129,7 @@ ifeq ($(CONFIG_RTE_LIBRTE_VHOST),y) >> _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_VHOST) += -lrte_pmd_vhost >> endif # $(CONFIG_RTE_LIBRTE_VHOST) >> _LDLIBS-$(CONFIG_RTE_LIBRTE_VMXNET3_PMD)+= -lrte_pmd_vmxnet3_uio >> +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_TAP)+= -lrte_pmd_tap >> >> ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y) >> _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_MB) += -lrte_pmd_aesni_mb >> > > Splitting the Makefile and config changes into a separate patch makes no > sense at all in this case. Just do it in the patch introducing the driver. > > And actually, ditto for documentation. OK, will do, but I thought other patches followed something like this as I had thought I was following the normally process. Without some place defining the real process it is hard to decide the real way to send patches. :-( I will send a new single patch later today with one little typo I fixed. > > - Panu -
[dpdk-dev] [PATCH 3/3] drivers/net:build support for new tap device driver
On 09/15/2016 05:10 PM, Keith Wiles wrote: > Signed-off-by: Keith Wiles > --- > config/common_linuxapp | 3 +++ > drivers/net/Makefile | 1 + > mk/rte.app.mk | 1 + > 3 files changed, 5 insertions(+) > > diff --git a/config/common_linuxapp b/config/common_linuxapp > index 2483dfa..704c01c 100644 > --- a/config/common_linuxapp > +++ b/config/common_linuxapp > @@ -44,3 +44,6 @@ CONFIG_RTE_LIBRTE_PMD_VHOST=y > CONFIG_RTE_LIBRTE_PMD_AF_PACKET=y > CONFIG_RTE_LIBRTE_POWER=y > CONFIG_RTE_VIRTIO_USER=y > +CONFIG_RTE_LIBRTE_PMD_TAP=y > +CONFIG_RTE_PMD_TAP_MAX_QUEUES=32 > + > diff --git a/drivers/net/Makefile b/drivers/net/Makefile > index bc93230..b4afa98 100644 > --- a/drivers/net/Makefile > +++ b/drivers/net/Makefile > @@ -55,6 +55,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD) += thunderx > DIRS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += virtio > DIRS-$(CONFIG_RTE_LIBRTE_VMXNET3_PMD) += vmxnet3 > DIRS-$(CONFIG_RTE_LIBRTE_PMD_XENVIRT) += xenvirt > +DIRS-$(CONFIG_RTE_LIBRTE_PMD_TAP) += tap > > ifeq ($(CONFIG_RTE_LIBRTE_VHOST),y) > DIRS-$(CONFIG_RTE_LIBRTE_PMD_VHOST) += vhost > diff --git a/mk/rte.app.mk b/mk/rte.app.mk > index 1a0095b..bd1d10f 100644 > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -129,6 +129,7 @@ ifeq ($(CONFIG_RTE_LIBRTE_VHOST),y) > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_VHOST) += -lrte_pmd_vhost > endif # $(CONFIG_RTE_LIBRTE_VHOST) > _LDLIBS-$(CONFIG_RTE_LIBRTE_VMXNET3_PMD)+= -lrte_pmd_vmxnet3_uio > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_TAP)+= -lrte_pmd_tap > > ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y) > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_MB) += -lrte_pmd_aesni_mb > Splitting the Makefile and config changes into a separate patch makes no sense at all in this case. Just do it in the patch introducing the driver. And actually, ditto for documentation. - Panu -
[dpdk-dev] [PATCH 3/3] drivers/net:build support for new tap device driver
Signed-off-by: Keith Wiles --- config/common_linuxapp | 3 +++ drivers/net/Makefile | 1 + mk/rte.app.mk | 1 + 3 files changed, 5 insertions(+) diff --git a/config/common_linuxapp b/config/common_linuxapp index 2483dfa..704c01c 100644 --- a/config/common_linuxapp +++ b/config/common_linuxapp @@ -44,3 +44,6 @@ CONFIG_RTE_LIBRTE_PMD_VHOST=y CONFIG_RTE_LIBRTE_PMD_AF_PACKET=y CONFIG_RTE_LIBRTE_POWER=y CONFIG_RTE_VIRTIO_USER=y +CONFIG_RTE_LIBRTE_PMD_TAP=y +CONFIG_RTE_PMD_TAP_MAX_QUEUES=32 + diff --git a/drivers/net/Makefile b/drivers/net/Makefile index bc93230..b4afa98 100644 --- a/drivers/net/Makefile +++ b/drivers/net/Makefile @@ -55,6 +55,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD) += thunderx DIRS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += virtio DIRS-$(CONFIG_RTE_LIBRTE_VMXNET3_PMD) += vmxnet3 DIRS-$(CONFIG_RTE_LIBRTE_PMD_XENVIRT) += xenvirt +DIRS-$(CONFIG_RTE_LIBRTE_PMD_TAP) += tap ifeq ($(CONFIG_RTE_LIBRTE_VHOST),y) DIRS-$(CONFIG_RTE_LIBRTE_PMD_VHOST) += vhost diff --git a/mk/rte.app.mk b/mk/rte.app.mk index 1a0095b..bd1d10f 100644 --- a/mk/rte.app.mk +++ b/mk/rte.app.mk @@ -129,6 +129,7 @@ ifeq ($(CONFIG_RTE_LIBRTE_VHOST),y) _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_VHOST) += -lrte_pmd_vhost endif # $(CONFIG_RTE_LIBRTE_VHOST) _LDLIBS-$(CONFIG_RTE_LIBRTE_VMXNET3_PMD)+= -lrte_pmd_vmxnet3_uio +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_TAP)+= -lrte_pmd_tap ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y) _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_MB) += -lrte_pmd_aesni_mb -- 2.8.0.GIT
