[dpdk-dev] [PATCH 3/8] driver/virtio:add vhost TX offload support capability in virtio-net

2015-10-30 Thread Liu, Jijiang 


From: David Marchand [mailto:david.march...@6wind.com]
Sent: Thursday, October 29, 2015 8:45 PM
To: Liu, Jijiang
Cc: dev at dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/8] driver/virtio:add vhost TX offload support 
capability in virtio-net

Hello Jijiang,

On Wed, Oct 21, 2015 at 6:46 AM, Jijiang Liu mailto:jijiang.liu at intel.com>> wrote:
Add vhost TX checksum and TSO capabilities in virtio-net lib.

Signed-off-by: Jijiang Liu mailto:jijiang.liu at 
intel.com>>
---
 drivers/net/virtio/virtio_ethdev.h |5 -
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/drivers/net/virtio/virtio_ethdev.h 
b/drivers/net/virtio/virtio_ethdev.h
index 9026d42..6ee95c6 100644
--- a/drivers/net/virtio/virtio_ethdev.h
+++ b/drivers/net/virtio/virtio_ethdev.h
@@ -64,7 +64,10 @@
 1u << VIRTIO_NET_F_CTRL_VQ   | \
 1u << VIRTIO_NET_F_CTRL_RX   | \
 1u << VIRTIO_NET_F_CTRL_VLAN | \
-1u << VIRTIO_NET_F_MRG_RXBUF)
+1u << VIRTIO_NET_F_MRG_RXBUF | \
+1u << VIRTIO_NET_F_HOST_TSO4 | \
+1u << VIRTIO_NET_F_HOST_TSO6 | \
+1u << VIRTIO_NET_F_CSUM)

You did not update tx offload capabilities field in dev_info.


--
David Marchand

You meant that I should update the tx offload capabilities in the 
virtio_dev_info_get() function, correct?

[dpdk-dev] [PATCH 3/8] driver/virtio:add vhost TX offload support capability in virtio-net

2015-10-29 Thread David Marchand 
Hello Jijiang,

On Wed, Oct 21, 2015 at 6:46 AM, Jijiang Liu  wrote:

> Add vhost TX checksum and TSO capabilities in virtio-net lib.
>
> Signed-off-by: Jijiang Liu 
> ---
>  drivers/net/virtio/virtio_ethdev.h |5 -
>  1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/virtio/virtio_ethdev.h
> b/drivers/net/virtio/virtio_ethdev.h
> index 9026d42..6ee95c6 100644
> --- a/drivers/net/virtio/virtio_ethdev.h
> +++ b/drivers/net/virtio/virtio_ethdev.h
> @@ -64,7 +64,10 @@
>  1u << VIRTIO_NET_F_CTRL_VQ   | \
>  1u << VIRTIO_NET_F_CTRL_RX   | \
>  1u << VIRTIO_NET_F_CTRL_VLAN | \
> -1u << VIRTIO_NET_F_MRG_RXBUF)
> +1u << VIRTIO_NET_F_MRG_RXBUF | \
> +1u << VIRTIO_NET_F_HOST_TSO4 | \
> +1u << VIRTIO_NET_F_HOST_TSO6 | \
> +1u << VIRTIO_NET_F_CSUM)
>
>
You did not update tx offload capabilities field in dev_info.


-- 
David Marchand