[dpdk-dev] [PATCH v1] Return ENOMEM during mpipe_devinit failure

[Thomas Monjalon]

> >In function rte_pmd_mpipe_devinit, if rte_eth_dev_allocate
> >fails return error which is inline with other drivers.
> >
> >Signed-off-by: Ravi Kerur 
> 
> Thanks for fixing this.
> Acked-by: Zhigang Lu 

Applied, thanks

[dpdk-dev] [PATCH v1] Return ENOMEM during mpipe_devinit failure

[Tetsuya Mukawa]

On 2015/08/20 5:00, Ravi Kerur wrote:
> In function rte_pmd_mpipe_devinit, if rte_eth_dev_allocate
> fails return error which is inline with other drivers.
>
> Signed-off-by: Ravi Kerur 
> ---
>  drivers/net/mpipe/mpipe_tilegx.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/mpipe/mpipe_tilegx.c 
> b/drivers/net/mpipe/mpipe_tilegx.c
> index 743feef..6e3e304 100644
> --- a/drivers/net/mpipe/mpipe_tilegx.c
> +++ b/drivers/net/mpipe/mpipe_tilegx.c
> @@ -1582,6 +1582,7 @@ rte_pmd_mpipe_devinit(const char *ifname,
>   if (!eth_dev) {
>   RTE_LOG(ERR, PMD, "%s: Failed to allocate device.\n", ifname);
>   rte_free(priv);
> + return -ENOMEM;
>   }
>  
>   RTE_LOG(INFO, PMD, "%s: Initialized mpipe device"
Acked-by: Tetsuya Mukawa 

[dpdk-dev] [PATCH v1] Return ENOMEM during mpipe_devinit failure

[Tony Lu]

>-Original Message-
>From: Ravi Kerur [mailto:rkerur at gmail.com]
>Sent: Thursday, August 20, 2015 4:00 AM
>To: dev at dpdk.org
>Cc: zlu at ezchip.com; Ravi Kerur
>Subject: [PATCH v1] Return ENOMEM during mpipe_devinit failure
>
>In function rte_pmd_mpipe_devinit, if rte_eth_dev_allocate
>fails return error which is inline with other drivers.
>
>Signed-off-by: Ravi Kerur 
>---
> drivers/net/mpipe/mpipe_tilegx.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/mpipe/mpipe_tilegx.c
>b/drivers/net/mpipe/mpipe_tilegx.c
>index 743feef..6e3e304 100644
>--- a/drivers/net/mpipe/mpipe_tilegx.c
>+++ b/drivers/net/mpipe/mpipe_tilegx.c
>@@ -1582,6 +1582,7 @@ rte_pmd_mpipe_devinit(const char *ifname,
>   if (!eth_dev) {
>   RTE_LOG(ERR, PMD, "%s: Failed to allocate device.\n",
ifname);
>   rte_free(priv);
>+  return -ENOMEM;
>   }
>
>   RTE_LOG(INFO, PMD, "%s: Initialized mpipe device"
>--
>1.9.1

Thanks for fixing this.
Acked-by: Zhigang Lu 

[dpdk-dev] [PATCH v1] Return ENOMEM during mpipe_devinit failure

[Ravi Kerur]

In function rte_pmd_mpipe_devinit, if rte_eth_dev_allocate
fails return error which is inline with other drivers.

Signed-off-by: Ravi Kerur 
---
 drivers/net/mpipe/mpipe_tilegx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/mpipe/mpipe_tilegx.c b/drivers/net/mpipe/mpipe_tilegx.c
index 743feef..6e3e304 100644
--- a/drivers/net/mpipe/mpipe_tilegx.c
+++ b/drivers/net/mpipe/mpipe_tilegx.c
@@ -1582,6 +1582,7 @@ rte_pmd_mpipe_devinit(const char *ifname,
if (!eth_dev) {
RTE_LOG(ERR, PMD, "%s: Failed to allocate device.\n", ifname);
rte_free(priv);
+   return -ENOMEM;
}

RTE_LOG(INFO, PMD, "%s: Initialized mpipe device"
-- 
1.9.1