[dpdk-dev] [PATCH v2] app/testpmd: fix RSS by setting mq_mode

[Thomas Monjalon]

14/01/2014 11:57, Daniel Kan :
> On Jan 14, 2014, at 9:42 AM, Maxime Leroy  wrote:
> > An other issue about not enabling RSS with 1 queue, when you use the
> > command show_rss_key in the testpmd, this one will display that the RSS
> > is enabled. (because rss_hf != 0; see port_rss_hash_conf_show function in
> > app/test-pmd/config.c)
> 
> PS. I don?t see port_rss_hash_conf_show in config.c, at not in 1.5.1 branch.
> Which branch is this in?

Maxime is talking about a local development branch. The function 
port_rss_hash_conf_show() is in a patch which should be ready for the next 
version. By the way, your fix will be integrated in version 1.5.2.

Daniel, thanks to provide a new version of your patch which allow RSS 
debugging with only 1 queue.

-- 
Thomas

[dpdk-dev] [PATCH v2] app/testpmd: fix RSS by setting mq_mode

[Maxime Leroy]

Hello,

Thanks for your patch fixing the regression introduced by my commit
(igb/ixgbe: ETH_MQ_RX_NONE should disable RSS).

I have one comment about your fix. I don't think there are any reasons
to not enable RSS with only one RX queue in testpmd.

RSS is mainly used in testpmd to spread traffic on the different rx queues.
But you can use RSS with one rx queue for debbugging purpose.
For example, you can use the rxonly forward engine of the testpmd to display
the RSS hash. (see pkt_burst_receive in app/test-pmd/rxonly.c)

An other issue about not enabling RSS with 1 queue, when you use the command
show_rss_key in the testpmd, this one will display that the RSS is enabled.
(because rss_hf != 0; see port_rss_hash_conf_show function in
app/test-pmd/config.c)

Do you agree with my analyze ?

Thanks.

-- 
Maxime Leroy

[dpdk-dev] [PATCH v2] app/testpmd: fix RSS by setting mq_mode

[Daniel Kan]

The mq_mode was not set when rxq is > 1; it's defaulted to ETH_MQ_RX_NONE.
As a result, RSS remains inactive. The fix is to set mq_mode to ETH_MQ_RX_RSS
when rxq is > 1 and hf is non-zero.

This bug was introduced by commit 243db2ddee3094a2cb39fdd4b17e26df4e7735e1
igb/ixgbe: ETH_MQ_RX_NONE should disable RSS

Signed-off-by: Daniel Kan 
---
Updated commit log in accordance with dpdk guidelines

 app/test-pmd/testpmd.c |3 +++
 1 file changed, 3 insertions(+)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index b11eb2e..355db0f 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -1546,6 +1546,9 @@ init_port_config(void)
if (nb_rxq > 0) {
port->dev_conf.rx_adv_conf.rss_conf.rss_key = NULL;
port->dev_conf.rx_adv_conf.rss_conf.rss_hf = rss_hf;
+   if (nb_rxq > 1 && rss_hf != 0) {
+   port->dev_conf.rxmode.mq_mode = ETH_MQ_RX_RSS;
+   }
} else {
port->dev_conf.rx_adv_conf.rss_conf.rss_key = NULL;
port->dev_conf.rx_adv_conf.rss_conf.rss_hf = 0;
-- 
1.7.9.5