[dpdk-dev] [PATCH v2] mempool: remove a redundant word "for" in comment

[Olivier Matz]

Hi Wei,

On Mon, 28 Nov 2016 09:42:12 +0100
Olivier Matz  wrote:
> Hi Wenzhuo,

First, sorry for the mistake in your name my previous mail.

Please find below some other comments about the patch (on the form).

> On Sun, 27 Nov 2016 10:43:47 +0800
> Wei Zhao  wrote:
> 
> > From: zhao wei 
> > 
> > There is a redundant repetition word "for" in commnet line of the

commnet -> comment

> > file rte_mempool.h after the definition of RTE_MEMPOOL_OPS_NAMESIZE.
> > The word "for"appear twice in line 359 and 360.One of them is

Missing space after '"for"' and after '360.'


> > redundant, so delete it.
> > 
> > Fixes: 449c49b93a6b (" mempool: support handler operations")

We should have an empty line after the 'Fixes:' tag. The
check-git-log.sh can help you to notice these errors.

Also, it is important that no spaces are added in the title of the
commit. You can get the exact line with:
  git log -1 --abbrev=12 --format='Fixes: %h (\"%s\")' 

> > Signed-off-by: zhao wei 

The name in your .gitconfig should be the same than in you mail:
Wei Zhao 

> > Acked-by: John McNamara   
> 
> Acked-by: Olivier Matz 
> 

Please, could you also check the same comments in the other patch?

Last thing: when doing another version of the patch, you should add a
changelog that describes what was modified. They take place after the 3
dashes.

Thank you for contributing.

Regards,
Olivier

[dpdk-dev] [PATCH v2] mempool: remove a redundant word "for" in comment

[Olivier Matz]

Hi Wenzhuo,

On Sun, 27 Nov 2016 10:43:47 +0800
Wei Zhao  wrote:

> From: zhao wei 
> 
> There is a redundant repetition word "for" in commnet line of the
> file rte_mempool.h after the definition of RTE_MEMPOOL_OPS_NAMESIZE.
> The word "for"appear twice in line 359 and 360.One of them is
> redundant, so delete it.
> 
> Fixes: 449c49b93a6b (" mempool: support handler operations")
> Signed-off-by: zhao wei 
> Acked-by: John McNamara 

Acked-by: Olivier Matz 

[dpdk-dev] [PATCH v2] mempool: remove a redundant word "for" in comment

[Wei Zhao]

From: zhao wei 

There is a redundant repetition word "for" in commnet line of the
file rte_mempool.h after the definition of RTE_MEMPOOL_OPS_NAMESIZE.
The word "for"appear twice in line 359 and 360.One of them is
redundant, so delete it.

Fixes: 449c49b93a6b (" mempool: support handler operations")
Signed-off-by: zhao wei 
Acked-by: John McNamara 
---
 lib/librte_mempool/rte_mempool.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h
index 440f3b1..911102b 100644
--- a/lib/librte_mempool/rte_mempool.h
+++ b/lib/librte_mempool/rte_mempool.h
@@ -357,7 +357,7 @@ void rte_mempool_check_cookies(const struct rte_mempool *mp,
  * Prototype for implementation specific data provisioning function.
  *
  * The function should provide the implementation specific memory for
- * for use by the other mempool ops functions in a given mempool ops struct.
+ * use by the other mempool ops functions in a given mempool ops struct.
  * E.g. the default ops provides an instance of the rte_ring for this purpose.
  * it will most likely point to a different type of data structure, and
  * will be transparent to the application programmer.
-- 
2.5.5