Re: [dpdk-dev] [PATCH v2 00/55] Solarflare libefx-based PMD
On 11/29/2016 4:18 PM, Andrew Rybchenko wrote: > The patch series adds Solarflare libefx-based network PMD. > > This version of the driver supports Solarflare SFN7xxx and SFN8xxx > families of 10/40 Gbps adapters. > > libefx is a platform-independent library to implement drivers for > Solarflare network adapters. It provides unified adapter family > independent interface (if possible). FreeBSD [1] and illumos [2] > drivers are built on top of the library. > > The patch series could be logically structured into 5 sub-series: > 1. (1) add the driver skeleton including documentation > 2. (2-30) import libefx and include it in build with the latest patch > 3. (31-42) implement minimal device level operations in steps > 4. (43-50) implement Rx subsystem > 5. (51-55) implement Tx subsystem > > Functional driver with multi-queue support capable to send and receive > traffic appears with the last patch in the series. > > The following design decisions are made during development: > > 1. Since libefx uses positive errno return codes, positive errno > return codes are used inside the driver and coversion to negative > is done on return from eth_dev_ops callbacks. We think that it > is the less error-prone way. > > 2. Own event queue (a way to deliver events from HW to host CPU) is > used for house-keeping (e.g. link status notifications), each Tx > and each Rx queue. No locks on datapath are requires in this case. > > 3. Alarm is used to periodically poll house-keeping event queue. > The event queue is used to deliver link status change notifications, > Rx/Tx queue flush events, SRAM events. It is not used on datapath. > The event queue polling is protected using spin-lock since > concurrent access from different contexts is possible (e.g. device > stop when polling alarm is running). > > [1] https://svnweb.freebsd.org/base/head/sys/dev/sfxge/common/ > [2] > https://github.com/illumos/illumos-gate/tree/master/usr/src/uts/common/io/sfxge/common/ > > --- > > v2: > * Fix spelling > * Fix ICC and clang build warnings > * Remove efx subdirectory > * Fix bug in Makefile which results in duplication of warnings options > * Use WERROR_FLAGS and remove warnings disabling for the PMD itself > * Comment enabled EFSYS_OPT_ > * Use space after #define instead of TAB > * Update version map to upcoming release > * Use bool for boolean_t in efsys.h > > > Andrew Rybchenko (48): > net/sfc: libefx-based PMD stub sufficient to build and init > net/sfc: import libefx base > net/sfc: import libefx register definitions > net/sfc: import libefx filters support > net/sfc: import libefx MCDI definition > net/sfc: import libefx MCDI implementation > net/sfc: import libefx MCDI logging support > net/sfc: import libefx MCDI proxy authorization support > net/sfc: import libefx 5xxx/6xxx family support > net/sfc: import libefx SFN7xxx family support > net/sfc: import libefx SFN8xxx family support > net/sfc: import libefx diagnostics support > net/sfc: import libefx built-in selftest support > net/sfc: import libefx software per-queue statistics support > net/sfc: import libefx PHY flags control support > net/sfc: import libefx PHY statistics support > net/sfc: import libefx PHY LEDs control support > net/sfc: import libefx MAC statistics support > net/sfc: import libefx event prefetch support > net/sfc: import libefx Rx scatter support > net/sfc: import libefx RSS support > net/sfc: import libefx loopback control support > net/sfc: import libefx monitors statistics support > net/sfc: import libefx support to access monitors via MCDI > net/sfc: import libefx support for Rx packed stream mode > net/sfc: import libefx NVRAM support > net/sfc: import libefx VPD support > net/sfc: import libefx bootrom configuration support > net/sfc: import libefx licensing support > net/sfc: implement driver operation to init device on attach > net/sfc: add device configure and close stubs > net/sfc: add device configuration checks > net/sfc: implement device start and stop operations > net/sfc: make available resources estimation and allocation > net/sfc: interrupts support sufficient for event queue init > net/sfc: implement event queue support > net/sfc: implement EVQ dummy exception handling > net/sfc: maintain management event queue > net/sfc: periodic management EVQ polling using alarm > net/sfc: minimum port control sufficient to receive traffic > net/sfc: implement Rx subsystem stubs > net/sfc: check configured rxmode > net/sfc: implement Rx queue setup release operations > net/sfc: calculate Rx buffer size which may be used > net/sfc: validate Rx queue buffers setup > net/sfc: implement Rx queue start and stop operations > net/sfc: implement device callback to Rx burst of packets > net/sfc: discard scattered packet on Rx correctly > > Artem Andreev (2): > net/sfc: include libefx in build >
[dpdk-dev] [PATCH v2 00/55] Solarflare libefx-based PMD
The patch series adds Solarflare libefx-based network PMD. This version of the driver supports Solarflare SFN7xxx and SFN8xxx families of 10/40 Gbps adapters. libefx is a platform-independent library to implement drivers for Solarflare network adapters. It provides unified adapter family independent interface (if possible). FreeBSD [1] and illumos [2] drivers are built on top of the library. The patch series could be logically structured into 5 sub-series: 1. (1) add the driver skeleton including documentation 2. (2-30) import libefx and include it in build with the latest patch 3. (31-42) implement minimal device level operations in steps 4. (43-50) implement Rx subsystem 5. (51-55) implement Tx subsystem Functional driver with multi-queue support capable to send and receive traffic appears with the last patch in the series. The following design decisions are made during development: 1. Since libefx uses positive errno return codes, positive errno return codes are used inside the driver and coversion to negative is done on return from eth_dev_ops callbacks. We think that it is the less error-prone way. 2. Own event queue (a way to deliver events from HW to host CPU) is used for house-keeping (e.g. link status notifications), each Tx and each Rx queue. No locks on datapath are requires in this case. 3. Alarm is used to periodically poll house-keeping event queue. The event queue is used to deliver link status change notifications, Rx/Tx queue flush events, SRAM events. It is not used on datapath. The event queue polling is protected using spin-lock since concurrent access from different contexts is possible (e.g. device stop when polling alarm is running). [1] https://svnweb.freebsd.org/base/head/sys/dev/sfxge/common/ [2] https://github.com/illumos/illumos-gate/tree/master/usr/src/uts/common/io/sfxge/common/ --- v2: * Fix spelling * Fix ICC and clang build warnings * Remove efx subdirectory * Fix bug in Makefile which results in duplication of warnings options * Use WERROR_FLAGS and remove warnings disabling for the PMD itself * Comment enabled EFSYS_OPT_ * Use space after #define instead of TAB * Update version map to upcoming release * Use bool for boolean_t in efsys.h Andrew Rybchenko (48): net/sfc: libefx-based PMD stub sufficient to build and init net/sfc: import libefx base net/sfc: import libefx register definitions net/sfc: import libefx filters support net/sfc: import libefx MCDI definition net/sfc: import libefx MCDI implementation net/sfc: import libefx MCDI logging support net/sfc: import libefx MCDI proxy authorization support net/sfc: import libefx 5xxx/6xxx family support net/sfc: import libefx SFN7xxx family support net/sfc: import libefx SFN8xxx family support net/sfc: import libefx diagnostics support net/sfc: import libefx built-in selftest support net/sfc: import libefx software per-queue statistics support net/sfc: import libefx PHY flags control support net/sfc: import libefx PHY statistics support net/sfc: import libefx PHY LEDs control support net/sfc: import libefx MAC statistics support net/sfc: import libefx event prefetch support net/sfc: import libefx Rx scatter support net/sfc: import libefx RSS support net/sfc: import libefx loopback control support net/sfc: import libefx monitors statistics support net/sfc: import libefx support to access monitors via MCDI net/sfc: import libefx support for Rx packed stream mode net/sfc: import libefx NVRAM support net/sfc: import libefx VPD support net/sfc: import libefx bootrom configuration support net/sfc: import libefx licensing support net/sfc: implement driver operation to init device on attach net/sfc: add device configure and close stubs net/sfc: add device configuration checks net/sfc: implement device start and stop operations net/sfc: make available resources estimation and allocation net/sfc: interrupts support sufficient for event queue init net/sfc: implement event queue support net/sfc: implement EVQ dummy exception handling net/sfc: maintain management event queue net/sfc: periodic management EVQ polling using alarm net/sfc: minimum port control sufficient to receive traffic net/sfc: implement Rx subsystem stubs net/sfc: check configured rxmode net/sfc: implement Rx queue setup release operations net/sfc: calculate Rx buffer size which may be used net/sfc: validate Rx queue buffers setup net/sfc: implement Rx queue start and stop operations net/sfc: implement device callback to Rx burst of packets net/sfc: discard scattered packet on Rx correctly Artem Andreev (2): net/sfc: include libefx in build net/sfc: implement device operation to retrieve link info Ivan Malov (5): net/sfc: provide basic stubs for Tx subsystem net/sfc: add function to check configured Tx mode net/sfc: add callbacks to set up and release Tx queues net/sfc: implement transmit path