[dpdk-dev] [PATCH v2 1/3] eal: add new keepalive states & callback hooks

2016-06-08 Thread Thomas Monjalon
2016-05-18 10:30, Remy Horton:

The explanations are missing.
Probably you should split this patch.

> Signed-off-by: Remy Horton 
[...]
> +enum rte_keepalive_state {
> + UNUSED = 0,
> + ALIVE = 1,
> + MISSING = 4,
> + DEAD = 2,
> + GONE = 3,
> + DOZING = 5,
> + SLEEP = 6
> +};

Please use RTE_ prefix.

[...]
>  /**
> + * Keepalive relay callback.
> + *
> + *  Receives a data pointer passed to rte_keepalive_register_relay_callback()
> + *  and the id of the core for which state is to be forwarded.
> + */

Please document each parameter.

> +typedef void (*rte_keepalive_relay_callback_t)(
> + void *data,
> + const int id_core,
> + enum rte_keepalive_state core_state,
> + uint64_t last_seen
> + );

[...]
> +/**
> + * Per-core sleep-time indication.
> + * @param *keepcfg
> + *   Keepalive structure pointer
> + *
> + * This function needs to be called from within the main process loop of
> + * the LCore going to sleep.

Why? Please add more comments.

> + */



[dpdk-dev] [PATCH v2 1/3] eal: add new keepalive states & callback hooks

2016-05-18 Thread Remy Horton
Signed-off-by: Remy Horton 
---
 examples/Makefile   |  2 +-
 lib/librte_eal/bsdapp/eal/rte_eal_version.map   |  7 
 lib/librte_eal/common/include/rte_keepalive.h   | 55 -
 lib/librte_eal/common/rte_keepalive.c   | 48 +
 lib/librte_eal/linuxapp/eal/rte_eal_version.map |  7 
 5 files changed, 110 insertions(+), 9 deletions(-)

diff --git a/examples/Makefile b/examples/Makefile
index b28b30e..3bc635a 100644
--- a/examples/Makefile
+++ b/examples/Makefile
@@ -1,6 +1,6 @@
 #   BSD LICENSE
 #
-#   Copyright(c) 2014 6WIND S.A.
+#   Copyright(c) 2016 6WIND S.A.
 #
 #   Redistribution and use in source and binary forms, with or without
 #   modification, are permitted provided that the following conditions
diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map 
b/lib/librte_eal/bsdapp/eal/rte_eal_version.map
index 58c2951..9a33441 100644
--- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map
+++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map
@@ -151,3 +151,10 @@ DPDK_16.04 {
rte_eal_primary_proc_alive;

 } DPDK_2.2;
+
+DPDK_16.7 {
+   global:
+
+   rte_keepalive_register_alive_callback;
+
+} DPDK_16.04;
diff --git a/lib/librte_eal/common/include/rte_keepalive.h 
b/lib/librte_eal/common/include/rte_keepalive.h
index 10dac2e..e23dda2 100644
--- a/lib/librte_eal/common/include/rte_keepalive.h
+++ b/lib/librte_eal/common/include/rte_keepalive.h
@@ -1,7 +1,7 @@
 /*-
  *   BSD LICENSE
  *
- *   Copyright 2015 Intel Shannon Ltd. All rights reserved.
+ *   Copyright 2015-2016 Intel Shannon Ltd. All rights reserved.
  *
  *   Redistribution and use in source and binary forms, with or without
  *   modification, are permitted provided that the following conditions
@@ -48,6 +48,16 @@
 #define RTE_KEEPALIVE_MAXCORES RTE_MAX_LCORE
 #endif

+enum rte_keepalive_state {
+   UNUSED = 0,
+   ALIVE = 1,
+   MISSING = 4,
+   DEAD = 2,
+   GONE = 3,
+   DOZING = 5,
+   SLEEP = 6
+};
+
 /**
  * Keepalive failure callback.
  *
@@ -59,6 +69,19 @@ typedef void (*rte_keepalive_failure_callback_t)(
const int id_core);

 /**
+ * Keepalive relay callback.
+ *
+ *  Receives a data pointer passed to rte_keepalive_register_relay_callback()
+ *  and the id of the core for which state is to be forwarded.
+ */
+typedef void (*rte_keepalive_relay_callback_t)(
+   void *data,
+   const int id_core,
+   enum rte_keepalive_state core_state,
+   uint64_t last_seen
+   );
+
+/**
  * Keepalive state structure.
  * @internal
  */
@@ -105,4 +128,34 @@ void rte_keepalive_register_core(struct rte_keepalive 
*keepcfg,
 void
 rte_keepalive_mark_alive(struct rte_keepalive *keepcfg);

+/**
+ * Per-core sleep-time indication.
+ * @param *keepcfg
+ *   Keepalive structure pointer
+ *
+ * This function needs to be called from within the main process loop of
+ * the LCore going to sleep.
+ */
+void
+rte_keepalive_mark_sleep(struct rte_keepalive *keepcfg);
+
+/**
+ * Registers a 'live core' callback.
+ *
+ * The complement of the 'dead core' callback. This is called when a
+ * core is known to be alive, and is intended for cases when an app
+ * needs to know 'liveness' beyond just knowing when a core has died.
+ *
+ * @param *keepcfg
+ *   Keepalive structure pointer
+ * @param callback
+ *   Function called upon detection of a dead core.
+ * @param data
+ *   Data pointer to be passed to function callback.
+ */
+void
+rte_keepalive_register_relay_callback(struct rte_keepalive *keepcfg,
+   rte_keepalive_relay_callback_t callback,
+   void *data);
+
 #endif /* _KEEPALIVE_H_ */
diff --git a/lib/librte_eal/common/rte_keepalive.c 
b/lib/librte_eal/common/rte_keepalive.c
index 23363ec..9cc890c 100644
--- a/lib/librte_eal/common/rte_keepalive.c
+++ b/lib/librte_eal/common/rte_keepalive.c
@@ -42,12 +42,8 @@

 struct rte_keepalive {
/** Core Liveness. */
-   enum rte_keepalive_state {
-   ALIVE = 1,
-   MISSING = 0,
-   DEAD = 2,
-   GONE = 3
-   } __rte_cache_aligned state_flags[RTE_KEEPALIVE_MAXCORES];
+   enum rte_keepalive_state __rte_cache_aligned state_flags[
+   RTE_KEEPALIVE_MAXCORES];

/** Last-seen-alive timestamps */
uint64_t last_alive[RTE_KEEPALIVE_MAXCORES];
@@ -68,6 +64,15 @@ struct rte_keepalive {
void *callback_data;
uint64_t tsc_initial;
uint64_t tsc_mhz;
+
+   /** Core state relay handler. */
+   rte_keepalive_relay_callback_t relay_callback;
+
+   /**
+* Core state relay handler app data.
+* Pointer is passed to live core handler.
+*/
+   void *relay_callback_data;
 };

 static void
@@ -92,6 +97,8 @@ rte_keepalive_dispatch_pings(__rte_unused void *ptr_timer,
continue;

switch (keepcfg->state_flags[idx_core]) {
+   case UNUSED:
+   break;
case