[dpdk-dev] [PATCH v2 3/7] pipeline: fix truncated dependency list
2016-06-27 09:20, Dumitrescu, Cristian: > As discussed in some other email thread, it would also make sense to replace > the ':=' operator with '+=' operator in Makefile of rte_port and rte_table as > well, do you want us to send a separate patch for this? It's a cosmetic change. Yes you can send a patch.
[dpdk-dev] [PATCH v2 3/7] pipeline: fix truncated dependency list
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Sunday, June 26, 2016 5:42 PM > To: Panu Matilainen > Cc: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2 3/7] pipeline: fix truncated dependency list > > From: Panu Matilainen > > In other libraries, dependency list is always appended to, but > in commit 6cbf4f75e059 it with an assignment. This causes the > librte_eal dependency added in commit 6cbf4f75e059 to get discarded, > resulting in missing dependency on librte_eal. > Acked-by: Cristian Dumitrescu Hi Thomas, As discussed in some other email thread, it would also make sense to replace the ':=' operator with '+=' operator in Makefile of rte_port and rte_table as well, do you want us to send a separate patch for this? Thanks, Cristian
[dpdk-dev] [PATCH v2 3/7] pipeline: fix truncated dependency list
From: Panu MatilainenIn other libraries, dependency list is always appended to, but in commit 6cbf4f75e059 it with an assignment. This causes the librte_eal dependency added in commit 6cbf4f75e059 to get discarded, resulting in missing dependency on librte_eal. Fixes: 6cbf4f75e059 ("mk: fix missing internal dependencies") Signed-off-by: Panu Matilainen --- lib/librte_pipeline/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_pipeline/Makefile b/lib/librte_pipeline/Makefile index 95387aa..a8f3128 100644 --- a/lib/librte_pipeline/Makefile +++ b/lib/librte_pipeline/Makefile @@ -53,7 +53,7 @@ SYMLINK-$(CONFIG_RTE_LIBRTE_PIPELINE)-include += rte_pipeline.h # this lib depends upon: DEPDIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) += lib/librte_eal -DEPDIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) := lib/librte_table +DEPDIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) += lib/librte_table DEPDIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) += lib/librte_port include $(RTE_SDK)/mk/rte.lib.mk -- 2.7.0