[dpdk-dev] [PATCH v3 08/16] vmxnet3: support of unified packet type
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, February 27, 2015 7:26 PM > To: dev at dpdk.org; Zhang, Helin > Subject: Re: [dpdk-dev] [PATCH v3 08/16] vmxnet3: support of unified packet > type > > 2015-02-17 14:59, Helin Zhang: > > To unify packet types among all PMDs, bit masks of packet type for > > 'ol_flags' are replaced by unified packet type. > > > > Signed-off-by: Helin Zhang > > Helin, this patch was already acked in v2 and you didn't change it. > Please keep the Acked-by line in such case. > Note that Acked-by is still valid after minor changes like typos. OK. Good to learn that! Thank you very much! > > I'd like every developers adopt this rule. Please spread the word. Yes, I will forward this rule to all the team here. Hopefully it will be helpful for all of us! Regards, Helin
[dpdk-dev] [PATCH v3 08/16] vmxnet3: support of unified packet type
2015-02-17 14:59, Helin Zhang: > To unify packet types among all PMDs, bit masks of packet type for > 'ol_flags' are replaced by unified packet type. > > Signed-off-by: Helin Zhang Helin, this patch was already acked in v2 and you didn't change it. Please keep the Acked-by line in such case. Note that Acked-by is still valid after minor changes like typos. I'd like every developers adopt this rule. Please spread the word.
[dpdk-dev] [PATCH v3 08/16] vmxnet3: support of unified packet type
To unify packet types among all PMDs, bit masks of packet type for
'ol_flags' are replaced by unified packet type.
Signed-off-by: Helin Zhang
---
lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
v2 changes:
* Used redefined packet types and enlarged packet_type field in mbuf.
diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c
b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c
index 8425f32..c85ebd8 100644
--- a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c
+++ b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c
@@ -650,9 +650,9 @@ vmxnet3_recv_pkts(void *rx_queue, struct rte_mbuf
**rx_pkts, uint16_t nb_pkts)
struct ipv4_hdr *ip = (struct ipv4_hdr *)(eth + 1);
if (((ip->version_ihl & 0xf) << 2) > (int)sizeof(struct
ipv4_hdr))
- rxm->ol_flags |= PKT_RX_IPV4_HDR_EXT;
+ rxm->packet_type = RTE_PTYPE_L3_IPV4_EXT;
else
- rxm->ol_flags |= PKT_RX_IPV4_HDR;
+ rxm->packet_type = RTE_PTYPE_L3_IPV4;
if (!rcd->cnc) {
if (!rcd->ipc)
--
1.9.3
