[dpdk-dev] [PATCH v4 00/32] net/qede: update qede pmd to 1.2.0.1 and enable by default
Hi Thomas, > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Wednesday, October 26, 2016 8:20 AM > > 2016-10-24 14:41, Bruce Richardson: > > On Tue, Oct 18, 2016 at 09:11:14PM -0700, Rasesh Mody wrote: > > > Please apply to DPDK tree for v16.11 release. > > > > Patchset applied to dpdk_next_net/rel_16_11 > > It breaks compilation because it is enabled everywhere and zlib.h is still > included without checking CONFIG_ECORE_ZIPPED_FW. > The patch removing zlib dependency was not tested without zlib installed. > I will fix it while applying with this change: Sorry, we missed to test the patch removing zlib dependency from latest patch set when zlib headers are unavailable. The zlib.h include is not needed in bcm_osal.c. It got left out there when zlib.h was included in ecore.h file by patch "[PATCH v4 03/32] net/qede: use FW CONFIG defines as needed". In ecore.h it is protected by ifdef, however, same is not true about bcm_osal.c. Hence compilation complains when zlib.h is not available. --- a/drivers/net/qede/base/bcm_osal.c +++ b/drivers/net/qede/base/bcm_osal.c @@ -6,8 +6,6 @@ * See LICENSE.qede_pmd for copyright and licensing details. */ -#include - #include #include > --- a/drivers/net/qede/base/bcm_osal.c > +++ b/drivers/net/qede/base/bcm_osal.c > @@ -6,7 +6,9 @@ > * See LICENSE.qede_pmd for copyright and licensing details. > */ > > +#ifdef CONFIG_ECORE_ZIPPED_FW > #include > +#endif > > #include > #include > Above change looks fine. Thanks! > I won't do any quality review of qede patches but from what I've seen > before, there is some room for improvements. > > Another nit, important to help reviews, please use --in-reply-to when > sending a new revision of a patch to keep them in the same thread and allow > us to understand the progress. > I plan to do an automatic nack for patches missing the --in-reply-to. Sure, will do. Thanks! -Rasesh
[dpdk-dev] [PATCH v4 00/32] net/qede: update qede pmd to 1.2.0.1 and enable by default
On Tue, Oct 18, 2016 at 09:11:14PM -0700, Rasesh Mody wrote: > Hi, > > This patch set includes changes to update the base driver, work with > newer FW 8.10.9.0, adds new features, includes enhancements and code > cleanup, provides bug fixes and updates documentation for the QEDE > poll mode driver. > > It enables QEDE PMD in the dpdk config by default. The dependency on > external library libz has been addressed. > > The patch set updates the QEDE PMD to 1.2.0.1. > > Review comments received for v3 have been addressed. > > Please apply to DPDK tree for v16.11 release. > > Thanks! > Rasesh > > Harish Patil (14): > net/qede: change signature of MCP command API > net/qede: serialize access to MFW mbox > net/qede: add NIC selftest and query sensor info support > net/qede: fix port (re)configuration issue > net/qede/base: allow MTU change via vport-update > net/qede: add missing 100G link speed capability > net/qede: remove unused/dead code > net/qede: fixes for VLAN filters > net/qede: add enable/disable VLAN filtering > net/qede: fix RSS related issues > net/qede/base: add support to initiate PF FLR > net/qede: skip slowpath polling for 100G VF device > net/qede: fix driver version string > net/qede: fix status block index for VF queues > > Rasesh Mody (16): > net/qede/base: add new init files and rearrange the code > net/qede/base: formatting changes > net/qede: use FW CONFIG defines as needed > net/qede/base: add HSI changes and register defines > net/qede/base: add attention formatting string > net/qede/base: additional formatting/comment changes > net/qede: fix 32 bit compilation > net/qede/base: update base driver > net/qede/base: rename structure and defines > net/qede/base: comment enhancements > net/qede/base: add MFW crash dump support > net/qede/base: change Rx Tx queue start APIs > net/qede: add support for queue statistics > net/qede: remove zlib dependency and enable PMD by default > doc: update qede pmd documentation > net/qede: update driver version > > Sony Chacko (2): > net/qede: enable support for unequal number of Rx/Tx queues > net/qede: add scatter gather support > Patchset applied to dpdk_next_net/rel_16_11 Thanks, /Bruce
[dpdk-dev] [PATCH v4 00/32] net/qede: update qede pmd to 1.2.0.1 and enable by default
Hi, This patch set includes changes to update the base driver, work with newer FW 8.10.9.0, adds new features, includes enhancements and code cleanup, provides bug fixes and updates documentation for the QEDE poll mode driver. It enables QEDE PMD in the dpdk config by default. The dependency on external library libz has been addressed. The patch set updates the QEDE PMD to 1.2.0.1. Review comments received for v3 have been addressed. Please apply to DPDK tree for v16.11 release. Thanks! Rasesh Harish Patil (14): net/qede: change signature of MCP command API net/qede: serialize access to MFW mbox net/qede: add NIC selftest and query sensor info support net/qede: fix port (re)configuration issue net/qede/base: allow MTU change via vport-update net/qede: add missing 100G link speed capability net/qede: remove unused/dead code net/qede: fixes for VLAN filters net/qede: add enable/disable VLAN filtering net/qede: fix RSS related issues net/qede/base: add support to initiate PF FLR net/qede: skip slowpath polling for 100G VF device net/qede: fix driver version string net/qede: fix status block index for VF queues Rasesh Mody (16): net/qede/base: add new init files and rearrange the code net/qede/base: formatting changes net/qede: use FW CONFIG defines as needed net/qede/base: add HSI changes and register defines net/qede/base: add attention formatting string net/qede/base: additional formatting/comment changes net/qede: fix 32 bit compilation net/qede/base: update base driver net/qede/base: rename structure and defines net/qede/base: comment enhancements net/qede/base: add MFW crash dump support net/qede/base: change Rx Tx queue start APIs net/qede: add support for queue statistics net/qede: remove zlib dependency and enable PMD by default doc: update qede pmd documentation net/qede: update driver version Sony Chacko (2): net/qede: enable support for unequal number of Rx/Tx queues net/qede: add scatter gather support config/common_base|2 +- doc/guides/nics/features/qede.ini |4 + doc/guides/nics/features/qede_vf.ini |4 + doc/guides/nics/qede.rst | 32 +- drivers/net/qede/Makefile |6 +- drivers/net/qede/base/bcm_osal.c | 23 + drivers/net/qede/base/bcm_osal.h | 10 + drivers/net/qede/base/common_hsi.h| 956 ++- drivers/net/qede/base/ecore.h | 631 +++ drivers/net/qede/base/ecore_chain.h | 51 +- drivers/net/qede/base/ecore_cxt.c | 387 - drivers/net/qede/base/ecore_cxt.h | 52 +- drivers/net/qede/base/ecore_cxt_api.h | 25 +- drivers/net/qede/base/ecore_dcbx.c| 589 ++- drivers/net/qede/base/ecore_dcbx.h| 18 +- drivers/net/qede/base/ecore_dcbx_api.h| 154 +- drivers/net/qede/base/ecore_dev.c | 1813 +--- drivers/net/qede/base/ecore_dev_api.h | 238 ++- drivers/net/qede/base/ecore_gtt_reg_addr.h| 30 +- drivers/net/qede/base/ecore_gtt_values.h | 20 +- drivers/net/qede/base/ecore_hsi_common.h | 1358 +-- drivers/net/qede/base/ecore_hsi_debug_tools.h | 1025 drivers/net/qede/base/ecore_hsi_eth.h | 997 --- drivers/net/qede/base/ecore_hsi_init_func.h | 132 ++ drivers/net/qede/base/ecore_hsi_init_tool.h | 454 + drivers/net/qede/base/ecore_hsi_tools.h | 1081 drivers/net/qede/base/ecore_hw.c | 222 ++- drivers/net/qede/base/ecore_hw.h | 75 +- drivers/net/qede/base/ecore_hw_defs.h | 39 +- drivers/net/qede/base/ecore_init_fw_funcs.c | 400 +++-- drivers/net/qede/base/ecore_init_fw_funcs.h | 250 ++- drivers/net/qede/base/ecore_init_ops.c| 11 +- drivers/net/qede/base/ecore_init_ops.h| 14 +- drivers/net/qede/base/ecore_int.c | 446 +++-- drivers/net/qede/base/ecore_int.h | 23 +- drivers/net/qede/base/ecore_int_api.h | 11 + drivers/net/qede/base/ecore_iov_api.h | 519 ++ drivers/net/qede/base/ecore_iro.h | 234 ++- drivers/net/qede/base/ecore_iro_values.h | 140 +- drivers/net/qede/base/ecore_l2.c | 531 +++--- drivers/net/qede/base/ecore_l2.h | 85 +- drivers/net/qede/base/ecore_l2_api.h | 167 +- drivers/net/qede/base/ecore_mcp.c | 881 -- drivers/net/qede/base/ecore_mcp.h | 141 +- drivers/net/qede/base/ecore_mcp_api.h | 220 ++- drivers/net/qede/base/ecore_proto_if.h| 63 +- drivers/net/qede/base/ecore_rt_defs.h | 869 +- drivers/net/qede/base/ecore_sp_api.h | 15 +- drivers/net/qede/base/ecore_sp_commands.c | 99 +- drivers/net/qede/base/ecore_sp_commands.h | 38 +-
