Re: [dpdk-dev] [PATCH] mem: warn user when running without NUMA support

[Burakov, Anatoly]

On 27-Mar-19 10:31 AM, Thomas Monjalon wrote:

22/02/2019 16:59, Anatoly Burakov:

Running in non-legacy mode on a NUMA-enabled system without libnuma
is unsupported, so explicitly print out a warning when trying to
do so.

Running in legacy mode without libnuma is still supported whether or
not we are running with libnuma support enabled, so also fix init to
allow that scenario.

Cc: sta...@dpdk.org

Signed-off-by: Anatoly Burakov 
---
--- a/lib/librte_eal/linuxapp/eal/eal_memory.c
+++ b/lib/librte_eal/linuxapp/eal/eal_memory.c
@@ -50,6 +50,7 @@
  #include "eal_internal_cfg.h"
  #include "eal_filesystem.h"
  #include "eal_hugepages.h"
+#include "eal_options.h"


I'm seeing this error:

lib/librte_eal/common/eal_options.h:74:28: error:
array type has incomplete element type ‘struct option’
  extern const struct option eal_long_options[];



Yes, i've been meaning to resubmit but it fell through the cracks. I'll 
do a v2 ASAP.


--
Thanks,
Anatoly

Re: [dpdk-dev] [PATCH] mem: warn user when running without NUMA support

[Thomas Monjalon]

22/02/2019 16:59, Anatoly Burakov:
> Running in non-legacy mode on a NUMA-enabled system without libnuma
> is unsupported, so explicitly print out a warning when trying to
> do so.
> 
> Running in legacy mode without libnuma is still supported whether or
> not we are running with libnuma support enabled, so also fix init to
> allow that scenario.
> 
> Cc: sta...@dpdk.org
> 
> Signed-off-by: Anatoly Burakov 
> ---
> --- a/lib/librte_eal/linuxapp/eal/eal_memory.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c
> @@ -50,6 +50,7 @@
>  #include "eal_internal_cfg.h"
>  #include "eal_filesystem.h"
>  #include "eal_hugepages.h"
> +#include "eal_options.h"

I'm seeing this error:

lib/librte_eal/common/eal_options.h:74:28: error:
array type has incomplete element type ‘struct option’
 extern const struct option eal_long_options[];