[GitHub] drill pull request #719: DRILL-5172: Display elapsed time for queries in the...
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/719#discussion_r95107988
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -72,16 +72,30 @@
public static final SimpleDateFormat format = new
SimpleDateFormat("MM/dd/ HH:mm:ss");
private String queryId;
+private long startTime;
+private long endTime;
private Date time;
private String location;
private String foreman;
private String query;
private String state;
private String user;
-public ProfileInfo(String queryId, long time, String foreman, String
query, String state, String user) {
+public ProfileInfo(String queryId, long startTime, String foreman,
String query, String state, String user) {
this.queryId = queryId;
- this.time = new Date(time);
+ this.startTime = startTime;
--- End diff --
Agreed. Collapsed into a single constructor. We'll use the current time
directly to mark the current 'end' time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #713: DRILL-3562: Query fails when using flatten on JSON ...
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/713#discussion_r95100719 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java --- @@ -59,6 +59,12 @@ private final boolean readNumbersAsDouble; /** + * Collection for tracking empty array writers during reading + * and storing them for initializing empty arrays + */ + private final Set emptyArrayWritersSet = Sets.newHashSet(); --- End diff -- Any reason why this needs to be HashSet rather than just a List ? The HashSet may change the insertion order, so if you had 2 or more empty arrays in the same Json doc within one list, the output of Flatten could end up changing the order. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill pull request #706: DRILL-5039: NPE - CTAS PARTITION BY (
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/706 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill pull request #718: DRILL-5127: Revert the fix for DRILL-4831
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/718 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill pull request #690: DRILL-5121 A memory leak is observed when exact cas...
Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/690 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
