Re: [DISCUSS] Drill 1.12.0 release

2017-10-20 Thread Paul Rogers
Hi Arina,

Though I would very much like to get DRILL-5832 and DRILL-5842 into master, I 
realize everyone is busy and there may not be time to review them. They can 
wait until after the release if necessary since they are primarily required for 
a 1.13 project.

Thanks,

- Paul

> On Oct 20, 2017, at 3:49 AM, Arina Yelchiyeva  
> wrote:
> 
> Current status:
> 
> Targeted for 1.12 release:
> DRILL-5832: Migrate OperatorFixture to use SystemOptionManager rather than
> mock (developer - Paul, code reviewer - ?) - waiting for the code review
> DRILL-5842: Refactor and simplify the fragment, operator contexts for
> testing (developer - Paul, code reviewer - ?) - waiting for the code review
> DRILL-5834: Adding network functions (developer - Charles, code reviewer -
> Arina) - waiting changes after code review
> DRILL-5337: OpenTSDB plugin (developer - Dmitriy, code reviewer -
> Arina) - waiting
> for the code review
> DRILL-5772: Enable UTF-8 support in query string by default (developer -
> Arina, code reviewer - Paul) - finalizing approach
> DRILL-4779: Kafka storage plugin support (developer - Anil, code reviewer -
> ?) - finishing implementation
> 
> Under question:
> DRILL-4286: Graceful shutdown of drillbit (developer - Jyothsna, code
> reviewer - ?) - waiting for the status update from the developer
> 
> Please free to suggest other items that are targeted for 1.12 release.
> There are many Jiras that have fix version marked as 1.12, it would be good
> if developers revisit them and update fix version to the actual one.
> Link to the dashboard -
> https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=185=DRILL=detail
> 
> 
> Kind regards
> Arina
> 
> 
> On Wed, Oct 11, 2017 at 2:42 AM, Parth Chandra  wrote:
> 
>> I'm waiting to merge the SSL  changes in. Waiting a couple of days more to
>> see if there are any more comments before I merge the changes in.
>> 
>> On Mon, Oct 9, 2017 at 10:28 AM, Paul Rogers  wrote:
>> 
>>> Hi Arina,
>>> 
>>> In addition to my own PRs, there are several in the “active” queue that
>> we
>>> could get in if we can just push them over the line and clear the queue.
>>> The owners of the PRs should check if we are waiting on them to take
>> action.
>>> 
>>> 977 DRILL-5849: Add freemarker lib to dependencyManagement to ensure
>>> prop…
>>> 976 DRILL-5797: Choose parquet reader from read columns
>>> 975 DRILL-5743: Handling column family and column scan for hbase
>>> 973 DRILL-5775: Select * query on a maprdb binary table fails
>>> 972 DRILL-5838: Fix MaprDB filter pushdown for the case of nested
>>> field (reg. of DRILL-4264)
>>> 950 Drill 5431: SSL Support
>>> 949 DRILL-5795: Parquet Filter push down at rowgroup level
>>> 936 DRILL-5772: Add unit tests to indicate how utf-8 support can be
>>> enabled / disabled in Drill
>>> 904 DRILL-5717: change some date time test cases with specific
>>> timezone or Local
>>> 892 DRILL-5645: negation of expression causes null pointer exception
>>> 889 DRILL-5691: enhance scalar sub queries checking for the cartesian
>>> join
>>> 
>>> (Items not on the list above have become “inactive” for a variety of
>>> reasons.)
>>> 
>>> Thanks,
>>> 
>>> - Paul
>>> 
 On Oct 9, 2017, at 9:57 AM, Paul Rogers  wrote:
 
 Hi Arina,
 
 I’d like to include the following that are needed to finish up the
>>> “managed” sort and spill-to-disk for hash agg:
 
 #928: DRILL-5716: Queue-driven memory allocation
 #958, DRILL-5808: Reduce memory allocator strictness for "managed"
>>> operators
 #960, DRILL-5815: Option to set query memory as percent of total
 
 The following is needed to resolve issues with HBase support in empty
>>> batches:
 
 #968, DRILL-5830: Resolve regressions to MapR DB from DRILL-5546
 
 The following are nice-to-haves that build on work already done in this
>>> release, and that some of my own work depends on:
 
 #970, DRILL-5832: Migrate OperatorFixture to use SystemOptionManager
>>> rather than mock
 #978: DRILL-5842: Refactor and simplify the fragment, operator contexts
>>> for testing
 
 The following is not needed for 1.12 per-se, but is the foundation for
>> a
>>> project I’m working on; would be good to get this in after 2-3 months of
>>> review time:
 
 #921, foundation for batch size limitation
 
 The key issue with each of the above is that they each need a committer
>>> to review. Some have reviews from non-committers. Any volunteers?
 
 Thanks,
 
 - Paul
 
> On Oct 9, 2017, at 9:38 AM, Charles Givre  wrote:
> 
> Hi Arina,
> I’d like to include Drill-5834, Adding network functions.
> https://github.com/apache/drill/pull/971 >> drill/pull/971>
> 
> Hopefully I didn’t violate too many coding standards this time ;-)

[GitHub] drill pull request #1005: DRILL-5896: Handle HBase columns vector creation i...

2017-10-20 Thread prasadns14
GitHub user prasadns14 opened a pull request:

https://github.com/apache/drill/pull/1005

DRILL-5896: Handle HBase columns vector creation in the HBaseRecordReader

Handling vector creation for projected hbase columns, by keeping track of 
column families and columns separately. 
@paul-rogers please review

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prasadns14/drill DRILL-5896

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/1005.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1005


commit 0f61a2dcd955d30d52103be0454fa45089eee064
Author: Prasad Nagaraj Subramanya 
Date:   2017-10-20T21:29:01Z

DRILL-5896: Handle HBase columns vector creation in the HBaseRecordReader




---


[GitHub] drill issue #1004: DRILL-5876: Use openssl profile to include netty-tcnative...

2017-10-20 Thread parthchandra
Github user parthchandra commented on the issue:

https://github.com/apache/drill/pull/1004
  
+1 . Thanks Vlad. Maven awesomeness !


---


[jira] [Created] (DRILL-5896) Handle vector creation in HbaseRecordReader to avoid NullableInt vectors later

2017-10-20 Thread Prasad Nagaraj Subramanya (JIRA)
Prasad Nagaraj Subramanya created DRILL-5896:


 Summary: Handle vector creation in HbaseRecordReader to avoid 
NullableInt vectors later
 Key: DRILL-5896
 URL: https://issues.apache.org/jira/browse/DRILL-5896
 Project: Apache Drill
  Issue Type: Bug
  Components: Storage - HBase
Affects Versions: 1.11.0
Reporter: Prasad Nagaraj Subramanya
Assignee: Prasad Nagaraj Subramanya
 Fix For: 1.12.0


When a hbase query projects both a column family and a column in the column 
family, the vector for the column is not created in the HbaseRecordReader.

So, in cases where scan batch is empty we create a NullableInt vector for this 
column. We need to handle column creation in the reader.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] drill issue #991: DRILL-5876: Remove netty-tcnative dependency from java-exe...

2017-10-20 Thread vrozov
Github user vrozov commented on the issue:

https://github.com/apache/drill/pull/991
  
@parthchandra open PR #1004 


---


[GitHub] drill pull request #1004: DRILL-5876: Use openssl profile to include netty-t...

2017-10-20 Thread vrozov
GitHub user vrozov opened a pull request:

https://github.com/apache/drill/pull/1004

DRILL-5876: Use openssl profile to include netty-tcnative dependency with 
the platform specific classifier



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vrozov/drill DRILL-5876

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/1004.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1004


commit 575d09e8e4de6c9ff61ab53cb23e4aede29d2398
Author: Vlad Rozov 
Date:   2017-10-18T22:00:37Z

DRILL-5876: Use openssl profile to include netty-tcnative dependency with 
the platform specific classifier




---


[GitHub] drill issue #991: DRILL-5876: Remove netty-tcnative dependency from java-exe...

2017-10-20 Thread parthchandra
Github user parthchandra commented on the issue:

https://github.com/apache/drill/pull/991
  
@vrozov your proposed solution is better and  works for intellij and 
eclipse. Closing this PR and will wait for you to submit a new PR.
Thanks!!


---


[GitHub] drill pull request #991: DRILL-5876: Remove netty-tcnative dependency from j...

2017-10-20 Thread parthchandra
Github user parthchandra closed the pull request at:

https://github.com/apache/drill/pull/991


---


[GitHub] drill issue #1002: DRILL-5888: Remove dependency of SSLConfig on hadoop.secu...

2017-10-20 Thread parthchandra
Github user parthchandra commented on the issue:

https://github.com/apache/drill/pull/1002
  
Yes, I will remove it. Thanks !


---


[jira] [Resolved] (DRILL-5582) [Threat Modeling] Drillbit may be spoofed by an attacker and this may lead to data being written to the attacker's target instead of Drillbit

2017-10-20 Thread Sorabh Hamirwasia (JIRA)

 [ 
https://issues.apache.org/jira/browse/DRILL-5582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sorabh Hamirwasia resolved DRILL-5582.
--
Resolution: Fixed

> [Threat Modeling] Drillbit may be spoofed by an attacker and this may lead to 
> data being written to the attacker's target instead of Drillbit
> -
>
> Key: DRILL-5582
> URL: https://issues.apache.org/jira/browse/DRILL-5582
> Project: Apache Drill
>  Issue Type: Bug
>Affects Versions: 1.10.0
>Reporter: Rob Wu
>Assignee: Sorabh Hamirwasia
>Priority: Minor
>  Labels: doc-impacting
> Fix For: 1.12.0
>
>
> *Consider the scenario:*
> Alice has a drillbit (my.drillbit.co) with plain and kerberos authentication 
> enabled containing important data. Bob, the attacker, attempts to spoof the 
> connection and redirect it to his own drillbit (fake.drillbit.co) with no 
> authentication setup. 
> When Alice is under attack and attempts to connect to her secure drillbit, 
> she is actually authenticating against Bob's drillbit. At this point, the 
> connection should have failed due to unmatched configuration. However, the 
> current implementation will return SUCCESS as long as the (spoofing) drillbit 
> has no authentication requirement set.
> Currently, the drillbit <-  to  -> drill client connection accepts the lowest 
> authentication configuration set on the server. This leaves unsuspecting user 
> vulnerable to spoofing. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (DRILL-5895) Fix unit tests for mongo storage plugin

2017-10-20 Thread Volodymyr Tkach (JIRA)
Volodymyr Tkach created DRILL-5895:
--

 Summary: Fix unit tests for mongo storage plugin
 Key: DRILL-5895
 URL: https://issues.apache.org/jira/browse/DRILL-5895
 Project: Apache Drill
  Issue Type: Bug
Reporter: Volodymyr Tkach
Assignee: Volodymyr Tkach
 Fix For: Future


All tests pass but run fails with:

{noformat}
[mongod output] Exception in thread "Thread-25" 
java.lang.IllegalStateException: Couldn't kill mongod process!


Something bad happend. We couldn't kill mongod process, and tried a lot.
If you want this problem solved you can help us if you open a new issue.

Follow this link:
https://github.com/flapdoodle-oss/de.flapdoodle.embed.mongo/issues

Thank you:)



at 
de.flapdoodle.embed.process.runtime.ProcessControl.waitForProcessGotKilled(ProcessControl.java:192)
at 
de.flapdoodle.embed.process.runtime.ProcessControl.stop(ProcessControl.java:76)
at 
de.flapdoodle.embed.process.runtime.AbstractProcess.stopProcess(AbstractProcess.java:189)
at 
de.flapdoodle.embed.mongo.AbstractMongoProcess.stopInternal(AbstractMongoProcess.java:117)
at 
de.flapdoodle.embed.process.runtime.AbstractProcess.stop(AbstractProcess.java:170)
at 
de.flapdoodle.embed.process.runtime.Executable.stop(Executable.java:73)
at 
de.flapdoodle.embed.process.runtime.Executable$JobKiller.run(Executable.java:90)
at java.lang.Thread.run(Thread.java:745)
Exception in thread "Thread-13" java.lang.IllegalStateException: Couldn't kill 
mongod process!


Something bad happend. We couldn't kill mongod process, and tried a lot.
If you want this problem solved you can help us if you open a new issue.

Follow this link:
https://github.com/flapdoodle-oss/de.flapdoodle.embed.mongo/issues

Thank you:)



at 
de.flapdoodle.embed.process.runtime.ProcessControl.waitForProcessGotKilled(ProcessControl.java:192)
at 
de.flapdoodle.embed.process.runtime.ProcessControl.stop(ProcessControl.java:76)
at 
de.flapdoodle.embed.process.runtime.AbstractProcess.stopProcess(AbstractProcess.java:189)
at 
de.flapdoodle.embed.mongo.AbstractMongoProcess.stopInternal(AbstractMongoProcess.java:117)
at 
de.flapdoodle.embed.process.runtime.AbstractProcess.stop(AbstractProcess.java:170)
at 
de.flapdoodle.embed.process.runtime.Executable.stop(Executable.java:73)
at 
de.flapdoodle.embed.process.runtime.Executable$JobKiller.run(Executable.java:90)
at java.lang.Thread.run(Thread.java:745)

Results :

Tests in error: 
  MongoTestSuit.tearDownCluster:260 » IllegalState Couldn't kill mongod 
process!...

{noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Re: [DISCUSS] Drill 1.12.0 release

2017-10-20 Thread Arina Yelchiyeva
Current status:

Targeted for 1.12 release:
DRILL-5832: Migrate OperatorFixture to use SystemOptionManager rather than
mock (developer - Paul, code reviewer - ?) - waiting for the code review
DRILL-5842: Refactor and simplify the fragment, operator contexts for
testing (developer - Paul, code reviewer - ?) - waiting for the code review
DRILL-5834: Adding network functions (developer - Charles, code reviewer -
Arina) - waiting changes after code review
DRILL-5337: OpenTSDB plugin (developer - Dmitriy, code reviewer -
Arina) - waiting
for the code review
DRILL-5772: Enable UTF-8 support in query string by default (developer -
Arina, code reviewer - Paul) - finalizing approach
DRILL-4779: Kafka storage plugin support (developer - Anil, code reviewer -
?) - finishing implementation

Under question:
DRILL-4286: Graceful shutdown of drillbit (developer - Jyothsna, code
reviewer - ?) - waiting for the status update from the developer

Please free to suggest other items that are targeted for 1.12 release.
There are many Jiras that have fix version marked as 1.12, it would be good
if developers revisit them and update fix version to the actual one.
Link to the dashboard -
https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=185=DRILL=detail


Kind regards
Arina


On Wed, Oct 11, 2017 at 2:42 AM, Parth Chandra  wrote:

> I'm waiting to merge the SSL  changes in. Waiting a couple of days more to
> see if there are any more comments before I merge the changes in.
>
> On Mon, Oct 9, 2017 at 10:28 AM, Paul Rogers  wrote:
>
> > Hi Arina,
> >
> > In addition to my own PRs, there are several in the “active” queue that
> we
> > could get in if we can just push them over the line and clear the queue.
> > The owners of the PRs should check if we are waiting on them to take
> action.
> >
> > 977 DRILL-5849: Add freemarker lib to dependencyManagement to ensure
> > prop…
> > 976 DRILL-5797: Choose parquet reader from read columns
> > 975 DRILL-5743: Handling column family and column scan for hbase
> > 973 DRILL-5775: Select * query on a maprdb binary table fails
> > 972 DRILL-5838: Fix MaprDB filter pushdown for the case of nested
> > field (reg. of DRILL-4264)
> > 950 Drill 5431: SSL Support
> > 949 DRILL-5795: Parquet Filter push down at rowgroup level
> > 936 DRILL-5772: Add unit tests to indicate how utf-8 support can be
> > enabled / disabled in Drill
> > 904 DRILL-5717: change some date time test cases with specific
> > timezone or Local
> > 892 DRILL-5645: negation of expression causes null pointer exception
> > 889 DRILL-5691: enhance scalar sub queries checking for the cartesian
> > join
> >
> > (Items not on the list above have become “inactive” for a variety of
> > reasons.)
> >
> > Thanks,
> >
> > - Paul
> >
> > > On Oct 9, 2017, at 9:57 AM, Paul Rogers  wrote:
> > >
> > > Hi Arina,
> > >
> > > I’d like to include the following that are needed to finish up the
> > “managed” sort and spill-to-disk for hash agg:
> > >
> > > #928: DRILL-5716: Queue-driven memory allocation
> > > #958, DRILL-5808: Reduce memory allocator strictness for "managed"
> > operators
> > > #960, DRILL-5815: Option to set query memory as percent of total
> > >
> > > The following is needed to resolve issues with HBase support in empty
> > batches:
> > >
> > > #968, DRILL-5830: Resolve regressions to MapR DB from DRILL-5546
> > >
> > > The following are nice-to-haves that build on work already done in this
> > release, and that some of my own work depends on:
> > >
> > > #970, DRILL-5832: Migrate OperatorFixture to use SystemOptionManager
> > rather than mock
> > > #978: DRILL-5842: Refactor and simplify the fragment, operator contexts
> > for testing
> > >
> > > The following is not needed for 1.12 per-se, but is the foundation for
> a
> > project I’m working on; would be good to get this in after 2-3 months of
> > review time:
> > >
> > > #921, foundation for batch size limitation
> > >
> > > The key issue with each of the above is that they each need a committer
> > to review. Some have reviews from non-committers. Any volunteers?
> > >
> > > Thanks,
> > >
> > > - Paul
> > >
> > >> On Oct 9, 2017, at 9:38 AM, Charles Givre  wrote:
> > >>
> > >> Hi Arina,
> > >> I’d like to include Drill-5834, Adding network functions.
> > >> https://github.com/apache/drill/pull/971  > drill/pull/971>
> > >>
> > >> Hopefully I didn’t violate too many coding standards this time ;-)
> > >> —C
> > >>
> > >>> On Oct 9, 2017, at 9:09 AM, Arina Yelchiyeva <
> > arina.yelchiy...@gmail.com> wrote:
> > >>>
> > >>> I want to include DRILL-5337 (OpenTSDB plugin), I'll try to finish
> code
> > >>> review during this week.
> > >>>
> > >>> Kind regards
> > >>> Arina
> > >>>
> > >>> On Mon, Oct 9, 2017 at 4:08 PM, Arina Ielchiieva 
> > wrote:
> > >>>
> >  Hi Drillers,
> > 
> >  It's been 

[GitHub] drill issue #921: DRILL-4286 Graceful shutdown of drillbit

2017-10-20 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/921
  
@dvjyothsna is there any update on the status for this PR? Should it be 
targeted for the 1.12.0 release?


---


[GitHub] drill issue #1002: DRILL-5888: Remove dependency of SSLConfig on hadoop.secu...

2017-10-20 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/1002
  
One more thing, I have noticed that 
`TestSSLConfig#testInvalidHadoopKeystore()` contains the following line 
```
String hadoopSSLFileProp = MessageFormat
 .format(HADOOP_SSL_CONF_TPL_KEY, 
SSLFactory.Mode.SERVER.toString().toLowerCase());  
.format(HADOOP_SSL_CONF_TPL_KEY, 
SSLFactory.Mode.SERVER.toString().toLowerCase());
```
Do we need to replace `SSLFactory.Mode.SERVER.toString()` here as well?


---


[GitHub] drill issue #1003: DRILL-5893: Reverted the number of forked test processes ...

2017-10-20 Thread arina-ielchiieva
Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/1003
  
+1, LGTM.


---


Re: Excessive review comments

2017-10-20 Thread Arina Yelchiyeva
Ideally, there should be an option if you want to receive all notifications
from github or not. All these notifications don't really bother me. As
Parth mentioned this is the way to track dev activity.
Subscribing to the pull request maybe not always be the best solution,
since sometimes the comments in pull request is the point of interest and
gets you engaged into the discussion.

Regarding the code review comments, I think we should not point to the code
reviewers how they should write comments until they provide good code
review and raise good questions.
Especially taking into account limited number of volunteers to do the code
review...


Kind regards
Arina

On Thu, Oct 19, 2017 at 9:55 PM, Aman Sinha  wrote:

> Going back to one comment by Paul : “The only other solution is to give few
> review comments; not sure if we want to go that route...”
> IMO the individual code review comments should be concise such that the
> main idea is expressed.  This is more palatable for the original developer
> and he/she can act on it.  If there are several comments that are somewhat
> lengthier, it amounts to a design discussion.  These would be better
> combined and could either be (a) added to the JIRA or (b) added to the
> ‘conversation’ section of the PR to minimize notifications.
>
> -Aman
>
> On Thu, Oct 19, 2017 at 10:59 AM, Padma Penumarthy 
> wrote:
>
> > To subscribe to PRs and JIRAs of interest, we need to know about them
> > first.
> > Is it possible to get notified when a new PR or JIRA is created and not
> for
> > further updates unless you subscribe to them ?
> >
> > Thanks
> > Padma
> >
> >
> > > On Oct 19, 2017, at 10:13 AM, Paul Rogers  wrote:
> > >
> > > So, rather than copying all messages to dev, simply ask interested
> folks
> > subscribe to the PRs of interest. (Or, subscribe to the corresponding
> JIRA
> > tickets, since JIRA echos all comments in another spray of e-mail…)
> > >
> > > This way, semi-active folks on the dev list can see substantive
> > discussions without being bombarded with day-to-day minutia.
> > >
> > > Thanks,
> > >
> > > - Paul
> > >
> > >> On Oct 19, 2017, at 10:07 AM, Parth Chandra 
> wrote:
> > >>
> > >> I generally keep track of dev activity only through the emails sent. I
> > >> don't mind getting duplicate emails either - it's not too hard to
> write
> > a
> > >> filter to take out the stuff you're not interested in.
> > >>
> > >> Interestingly, I've never noticed whether 'start a review' sends one
> > email
> > >> or many; mostly because gmail does a nice job of grouping the emails
> > >> together. I have seen a single email with many comments being sent out
> > so
> > >> the feature did work as advertised at one point.
> > >>
> > >> That said, if there is a way I can stay updated via email (repo
> > watching,
> > >> jira updates, etc.) then I am fine with turning the feature off.
> > >>
> > >>
> > >>
> > >> On Thu, Oct 19, 2017 at 9:51 AM, Timothy Farkas 
> > wrote:
> > >>
> > >>> +1 for turning off the feature. If someone really needs to be emailed
> > with
> > >>> comment updates they can become a watcher of the repo on Github.
> > >>>
> > >>> 
> > >>> From: Paul Rogers 
> > >>> Sent: Thursday, October 19, 2017 9:43:26 AM
> > >>> To: dev@drill.apache.org
> > >>> Subject: Re: Excessive review comments
> > >>>
> > >>> Can we simply turn off the feature? I never, ever read the e-mails
> > coming
> > >>> from this source; I always follow the link back to the PR. Can we
> > reduce it
> > >>> to “Hey, just wanted to let you know that a new comment was posted.
> > Click
> > >>> _here_ to read it.”
> > >>>
> > >>> The only other solution is to give few review comments; not sure if
> we
> > >>> want to go that route...
> > >>>
> > >>> - Paul
> > >>>
> >  On Oct 19, 2017, at 8:35 AM, Arina Yelchiyeva <
> > >>> arina.yelchiy...@gmail.com> wrote:
> > 
> >  Agree, I am not sure I saw this feature working as well.
> >  All it did it was sending all the emails at once, rather in the
> > process
> > >>> of
> >  comments emergence.
> > 
> >  Kind regards
> >  Arina
> > 
> >  On Thu, Oct 19, 2017 at 6:27 PM, Julian Hyde 
> > wrote:
> > 
> > > I don’t know whether anything is broken. I believed that the GitHub
> > >>> “start
> > > a review” feature would cause all review comments to be sent in a
> > single
> > > email. But now I think of it, I’m not sure I ever saw it working. I
> > >>> wonder
> > > whether Github-ASF integration is at fault.
> > >
> > > Whatever the reasons for it, 39 emails to dev list is quite a
> blast.
> > > People tend to unsubscribe from lists if the volume is too high.
> > >
> > > Julian
> > >
> > >
> > >> On Oct 18, 2017, at 5:54 PM, Paul Rogers 
> wrote:
> > >>
> > >>