[GitHub] drill pull request #1064: DRILL-6017 Fix for SHUTDOWN button being visible f...

[bitblender]

Github user bitblender commented on a diff in the pull request:

https://github.com/apache/drill/pull/1064#discussion_r155606076
  
--- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
@@ -112,7 +114,7 @@
   
   
 
-   <#if model.shouldShowUserInfo()>
+   <#if model.shouldShowAdminInfo()>
--- End diff --

I have added the check around the shutdown JS code.


---

[jira] [Created] (DRILL-6020) NullPointerException with Union setting on when querying JSON

[Mitchel Labonte (JIRA)]

Mitchel Labonte created DRILL-6020:
--

 Summary: NullPointerException with Union setting on when querying 
JSON
 Key: DRILL-6020
 URL: https://issues.apache.org/jira/browse/DRILL-6020
 Project: Apache Drill
  Issue Type: Bug
Reporter: Mitchel Labonte


h1. Steps to reproduce
alter session set `exec.enable_union_type`=true;
select tb.level1.dta from dfs.`file.json` tb;

*Content of file.json:*
{noformat}
{"level1":{"dta":{"test":"test"}}}
{"level1":{"dta":"test"}}
{noformat}

h1. Stack trace
Error: SYSTEM ERROR: NullPointerException

Fragment 0:0

[Error Id: fe267584-32f3-413c-a77c-fc5b5c1ba513 on localhost:31010]

  (java.lang.NullPointerException) null

org.apache.drill.exec.vector.complex.FieldIdUtil.getFieldIdIfMatchesUnion():34
org.apache.drill.exec.vector.complex.FieldIdUtil.getFieldIdIfMatches():135
org.apache.drill.exec.vector.complex.FieldIdUtil.getFieldIdIfMatches():130
org.apache.drill.exec.vector.complex.FieldIdUtil.getFieldId():201
org.apache.drill.exec.record.SimpleVectorWrapper.getFieldIdIfMatches():102
org.apache.drill.exec.record.VectorContainer.getValueVectorId():298
org.apache.drill.exec.physical.impl.ScanBatch.getValueVectorId():313

org.apache.drill.exec.expr.ExpressionTreeMaterializer$MaterializeVisitor.visitSchemaPath():289

org.apache.drill.exec.expr.ExpressionTreeMaterializer$MaterializeVisitor.visitSchemaPath():272
org.apache.drill.common.expression.SchemaPath.accept():150

org.apache.drill.exec.expr.ExpressionTreeMaterializer$AbstractMaterializeVisitor.visitFunctionCall():399

org.apache.drill.exec.expr.ExpressionTreeMaterializer$AbstractMaterializeVisitor.visitFunctionCall():331
org.apache.drill.common.expression.FunctionCall.accept():60
org.apache.drill.exec.expr.ExpressionTreeMaterializer.materialize():169
org.apache.drill.exec.expr.ExpressionTreeMaterializer.materialize():147

org.apache.drill.exec.physical.impl.project.ProjectRecordBatch.setupNewSchema():421
org.apache.drill.exec.record.AbstractSingleRecordBatch.innerNext():78

org.apache.drill.exec.physical.impl.project.ProjectRecordBatch.innerNext():133
org.apache.drill.exec.record.AbstractRecordBatch.next():162
org.apache.drill.exec.physical.impl.BaseRootExec.next():105
org.apache.drill.exec.physical.impl.ScreenCreator$ScreenRoot.innerNext():81
org.apache.drill.exec.physical.impl.BaseRootExec.next():95
org.apache.drill.exec.work.fragment.FragmentExecutor$1.run():234
org.apache.drill.exec.work.fragment.FragmentExecutor$1.run():227
java.security.AccessController.doPrivileged():-2
javax.security.auth.Subject.doAs():422
org.apache.hadoop.security.UserGroupInformation.doAs():1657
org.apache.drill.exec.work.fragment.FragmentExecutor.run():227
org.apache.drill.common.SelfCleaningRunnable.run():38
java.util.concurrent.ThreadPoolExecutor.runWorker():1142
java.util.concurrent.ThreadPoolExecutor$Worker.run():617
java.lang.Thread.run():745 (state=,code=0)




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] drill pull request #1064: DRILL-6017 Fix for SHUTDOWN button being visible f...

[arina-ielchiieva]

Github user arina-ielchiieva commented on a diff in the pull request:

https://github.com/apache/drill/pull/1064#discussion_r155560945
  
--- Diff: exec/java-exec/src/main/resources/rest/index.ftl ---
@@ -112,7 +114,7 @@
   
   
 
-   <#if model.shouldShowUserInfo()>
+   <#if model.shouldShowAdminInfo()>
--- End diff --

We also need to exclude js functionality that triggers shutdown using this 
option.


---

[jira] [Created] (DRILL-6019) Only admin should be able to access shutdown resources

[Arina Ielchiieva (JIRA)]

Arina Ielchiieva created DRILL-6019:
---

 Summary: Only admin should be able to access shutdown resources
 Key: DRILL-6019
 URL: https://issues.apache.org/jira/browse/DRILL-6019
 Project: Apache Drill
  Issue Type: Bug
Affects Versions: 1.12.0
Reporter: Arina Ielchiieva
Assignee: Arina Ielchiieva
Priority: Blocker
 Fix For: 1.12.0


Only admin should be able to access shutdown resources.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] drill issue #1064: DRILL-6017 Fix for SHUTDOWN button being visible for non ...

[arina-ielchiieva]

Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/1064
  
+1, LGTM.


---

[jira] [Created] (DRILL-6018) Drill can't handle NaN, Infinity literals

[Volodymyr Tkach (JIRA)]

Volodymyr Tkach created DRILL-6018:
--

 Summary: Drill can't handle NaN, Infinity literals
 Key: DRILL-6018
 URL: https://issues.apache.org/jira/browse/DRILL-6018
 Project: Apache Drill
  Issue Type: Bug
Reporter: Volodymyr Tkach
Assignee: Volodymyr Tkach


Queries like:
select sin(cast('NaN' as double)) from (values(1))
select cast('Infinity' as double)+1 from (values(1))

end up with NumberFormatException, because Drill and Calcite use BigDecimal to 
handle double literals. As a solution we can add  special symbols NAN, POS_INF, 
NEG_INF which will represent not numeric literals.
Created [calcite jira | https://issues.apache.org/jira/browse/CALCITE-2067] for 
this functionality.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] drill pull request #1064: Fix for SHUTDOWN button being visible for non Admi...

[bitblender]

GitHub user bitblender opened a pull request:

https://github.com/apache/drill/pull/1064

Fix for SHUTDOWN button being visible for non Admin users

This fix repurposes an earlier change I had made to show admin user info, 
to selectively enable the SHUTDOWN button. 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bitblender/drill DRILL-6017

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/1064.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1064


commit 3d310b23061461fe0e058018a35c1b95f8876f71
Author: karthik 
Date:   2017-12-07T04:13:24Z

Fix for SHUTDOWN button being visible for non Admin users




---

[GitHub] drill issue #1063: DRILL-5702: Jdbc Driver Class not found

[vdiravka]

Github user vdiravka commented on the issue:

https://github.com/apache/drill/pull/1063
  
The issue is enabling "apache-release" profile disabled "default" profile 
automatically and then `"package.namespace.prefix"` had invalid value 
`${package.namespace.prefix}`.


---

[GitHub] drill pull request #1063: DRILL-5702: Jdbc Driver Class not found

[vdiravka]

GitHub user vdiravka opened a pull request:

https://github.com/apache/drill/pull/1063

DRILL-5702: Jdbc Driver Class not found

- Setting "package.namespace.prefix" to "oadd." by default for all 
profiles. It can be overridden if necessary within any profile.
- Removing duplicated and redundant excluding of commons-logging packages.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vdiravka/drill DRILL-5702

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/1063.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1063


commit 8c557741139252189c1add05e2a1c3c9f77b5074
Author: Vitalii Diravka 
Date:   2017-12-06T15:31:10Z

DRILL-5702: Jdbc Driver Class not found

- Setting "package.namespace.prefix" to "oadd." by default for all 
profiles. It can be overridden if necessary within any profile.
- Removing duplicated and redundant excluding of commons-logging packages.




---

[jira] [Created] (DRILL-6017) Fix for SHUTDOWN button being visible for non Admin users

[Arina Ielchiieva (JIRA)]

Arina Ielchiieva created DRILL-6017:
---

 Summary: Fix for SHUTDOWN button being visible for non Admin users
 Key: DRILL-6017
 URL: https://issues.apache.org/jira/browse/DRILL-6017
 Project: Apache Drill
  Issue Type: Bug
Reporter: Arina Ielchiieva
Priority: Blocker


DRILL-4286 introduces shutdown button on index page but when authorization is 
enabled it should be visible only to admin users.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)