[GitHub] drill pull request #1190: DRILL-5937: ExecConstants: changed comment, timeou...

[vrozov]

Github user vrozov commented on a diff in the pull request:

https://github.com/apache/drill/pull/1190#discussion_r177300882
  
--- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -558,7 +558,7 @@ private ExecConstants() {
 
   /**
* Timeout for create prepare statement request. If the request exceeds 
this timeout, then request is timed out.
-   * Default value is 10mins.
+   * Default value is 30 seconds.
--- End diff --

I refer to the entire comment. "If the request exceeds this timeout, then 
request is timed out" does not add any value, it is simply a definition for a 
timeout. The same for `CREATE_PREPARE_STATEMENT_TIMEOUT_MILLIS` and "Timeout 
for create prepare statement request".


---

[GitHub] drill issue #1189: DRILL-6282: Excluding io.dropwizard.metrics dependencies

[vrozov]

Github user vrozov commented on the issue:

https://github.com/apache/drill/pull/1189
  
Why not make Drill to use `io.dropwizard.metrics` instead of 
`com.codahale.metrics`? As far as I can see it is the same library (this is why 
it causes the conflict).


---

[GitHub] drill issue #536: DRILL-4699: Add description column to sys.options table

[Ben-Zvi]

Github user Ben-Zvi commented on the issue:

https://github.com/apache/drill/pull/536
  
The work in this PR is dated; the relevant base code has changed so much 
(e.g. DRILL-5547, DRILL-5752) so this change cannot just be pulled; it needs to 
be redone. Also part of the intended goal is now covered by DRILL-5723, which 
separated the internal options out of sys.options, thus allowing to hide those 
options that users "should not modify". 



---

[GitHub] drill issue #1189: DRILL-6282: Excluding io.dropwizard.metrics dependencies

[vdiravka]

Github user vdiravka commented on the issue:

https://github.com/apache/drill/pull/1189
  
@vrozov Drill doesn't use  `io.dropwizard.metrics` at all and it is in 
conflict with Drill's `com.codahale.metrics` (misspoke was in PR's 
description). Even Hive uses it only for own unit test, so there is no need to 
keep it in Drill for now.


---

Apache Drill 1.14 Release Dashboards

[Pritesh Maker]

Hi All

Thank you all for the contributions to Apache Drill 1.13 release. I have setup 
the release dashboard and the Kanban board for the next 1.14 release.

Apache Drill 1.14 Release Dashboard
https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12332463

Apache Drill Kanban Board (current filter is for 1.14)
https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=185

And as a reminder to help with the code reviews, you can look at the following 
dashboard:
https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12331268

If you have any suggestions about improvements to the dashboards or the Kanban 
board, please don’t hesitate to send them my way.

Thanks,
Pritesh

[GitHub] drill issue #1172: DRILL-6256: Remove references to java 7 from readme and o...

[vladimirtkach]

Github user vladimirtkach commented on the issue:

https://github.com/apache/drill/pull/1172
  
@vdiravka done


---

[GitHub] drill pull request #1166: DRILL-6016 - Fix for Error reading INT96 created b...

[vdiravka]

Github user vdiravka commented on a diff in the pull request:

https://github.com/apache/drill/pull/1166#discussion_r177154051
  
--- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
 ---
@@ -797,6 +797,24 @@ public void 
testImpalaParquetBinaryAsTimeStamp_DictChange() throws Exception {
 }
   }
 
+  @Test
+  public void testSparkParquetBinaryAsTimeStamp_DictChange() throws 
Exception {
+try {
+  mockUtcDateTimeZone();
--- End diff --

It doesn't work without `@RunWith(JMockit.class)`. 
Also please enable above test case 
`testImpalaParquetBinaryAsTimeStamp_DictChange` with the same change. And be 
sure that tests pass in the other time zone.


---

[GitHub] drill issue #1190: DRILL-5937: ExecConstants: changed comment, timeout defau...

[arina-ielchiieva]

Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/1190
  
@pushpendra-jaiswal-90 try searching for the occurrence of 
`prepare.statement.create_timeout_ms` in the project using your IDE :)


---

[GitHub] drill pull request #1190: DRILL-5937: ExecConstants: changed comment, timeou...

[arina-ielchiieva]

Github user arina-ielchiieva commented on a diff in the pull request:

https://github.com/apache/drill/pull/1190#discussion_r177152303
  
--- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -558,7 +558,7 @@ private ExecConstants() {
 
   /**
* Timeout for create prepare statement request. If the request exceeds 
this timeout, then request is timed out.
-   * Default value is 10mins.
+   * Default value is 30 seconds.
--- End diff --

Agree, with Vlad, it better to remove this sentence at all: `Default value 
is 30 seconds.`


---

[GitHub] drill issue #1190: DRILL-5937: ExecConstants: changed comment, timeout defau...

[pushpendra-jaiswal-90]

Github user pushpendra-jaiswal-90 commented on the issue:

https://github.com/apache/drill/pull/1190
  
@arina-ielchiieva Can you please tell me which drill-module.conf has it ?


---

[GitHub] drill pull request #1190: DRILL-5937: ExecConstants: changed comment, timeou...

[vrozov]

Github user vrozov commented on a diff in the pull request:

https://github.com/apache/drill/pull/1190#discussion_r177103076
  
--- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java ---
@@ -558,7 +558,7 @@ private ExecConstants() {
 
   /**
* Timeout for create prepare statement request. If the request exceeds 
this timeout, then request is timed out.
-   * Default value is 10mins.
+   * Default value is 30 seconds.
--- End diff --

Is it 30 seconds or 10 seconds? In any case, I don't think that the entire 
comment provides any additional info that cannot be inferred from the code 
itself.


---

[GitHub] drill issue #1190: DRILL-5937: ExecConstants: changed comment, timeout defau...

[arina-ielchiieva]

Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/1190
  
@pushpendra-jaiswal-90 two more points:
1. In drill-module.conf default for prepare.statement.create_timeout_ms is 
set 1 ms, which does not correspond to the value you have indicated. Please 
make sure both values are in sync.
2. Please do not do merge, it's not convenient when we are cherry-picking 
range of commits. But for your case I suggest you do squash the commits into 
one.


---

[GitHub] drill issue #1190: DRILL-5937: ExecConstants: changed comment, timeout defau...

[pushpendra-jaiswal-90]

Github user pushpendra-jaiswal-90 commented on the issue:

https://github.com/apache/drill/pull/1190
  
@arina-ielchiieva I've done the required changes. 
 


---

Build failed in Jenkins: drill-scm #950

[Apache Jenkins Server]

See 

Changes:

[vitalii.diravka] DRILL-6005: Fixed TestGracefulShutdown tests to skip check 
for loopback

[vitalii.diravka] DRILL-6237: Upgrade checkstyle version to 5.9 or above

[vitalii.diravka] DRILL-6053: Avoid excessive locking in LocalPersistentStore

[vitalii.diravka] DRILL-6224: Publish metrics gauge values correctly

[vitalii.diravka] DRILL-6231: Fix memory allocation for repeated list vector

[vitalii.diravka] DRILL-6239: Add build and license badges to README.md

[vitalii.diravka] DRILL-6243: Added alert box to confirm shutdown of drillbit 
after

[vitalii.diravka] DRILL-6248: Added limit push down support for system tables

[vitalii.diravka] DRILL-6262: IndexOutOfBoundException in RecordBatchSize for 
empty

[vitalii.diravka] DRILL-6280: Cleanup execution of BuildTimeScan during maven 
build

[vitalii.diravka] DRILL-6283: WebServer stores SPNEGO client principal without 
taking any

[vitalii.diravka] DRILL-6290: Refactor TestInfoSchemaFilterPushDown tests to use

[vitalii.diravka] DRILL-6288: Upgrade org.javassist:javassist and

--
[...truncated 12.20 KB...]
[INFO] 
[INFO] --- maven-clean-plugin:3.0.0:clean (default-clean) @ tools-parent ---
[INFO] 
[INFO] --- apache-rat-plugin:0.12:check (rat-checks) @ tools-parent ---
[INFO] Enabled default license matchers.
[INFO] Will parse SCM ignores for exclusions...
[INFO] Finished adding exclusions from SCM ignore files.
[INFO] 62 implicit excludes (use -debug for more details).
[INFO] Exclude: **/*.log
[INFO] Exclude: **/*.css
[INFO] Exclude: **/*.js
[INFO] Exclude: **/*.md
[INFO] Exclude: **/*.eps
[INFO] Exclude: **/*.json
[INFO] Exclude: **/*.seq
[INFO] Exclude: **/*.parquet
[INFO] Exclude: **/*.sql
[INFO] Exclude: **/git.properties
[INFO] Exclude: **/*.csv
[INFO] Exclude: **/*.csvh
[INFO] Exclude: **/*.csvh-test
[INFO] Exclude: **/*.tsv
[INFO] Exclude: **/*.txt
[INFO] Exclude: **/*.ssv
[INFO] Exclude: **/drill-*.conf
[INFO] Exclude: **/.buildpath
[INFO] Exclude: **/*.proto
[INFO] Exclude: **/*.fmpp
[INFO] Exclude: **/target/**
[INFO] Exclude: **/*.iml
[INFO] Exclude: **/.idea/**
[INFO] Exclude: **/*.tdd
[INFO] Exclude: **/*.project
[INFO] Exclude: **/TAGS
[INFO] Exclude: **/*.checkstyle
[INFO] Exclude: **/.classpath
[INFO] Exclude: **/.settings/**
[INFO] Exclude: .*/**
[INFO] Exclude: **/*.patch
[INFO] Exclude: **/*.pb.cc
[INFO] Exclude: **/*.pb.h
[INFO] Exclude: **/*.linux
[INFO] Exclude: **/client/*build*/**
[INFO] Exclude: **/client/tags
[INFO] Exclude: **/cmake_install.cmake
[INFO] Exclude: **/ssl/*.csr
[INFO] Exclude: **/ssl/*.pem
[INFO] Exclude: **/ssl/*.p12
[INFO] Exclude: **/*.tbl
[INFO] Exclude: **/*.httpd
[INFO] Exclude: **/*.autotools
[INFO] Exclude: **/*.cproject
[INFO] Exclude: **/*.drill
[INFO] Exclude: dependency-reduced-pom.xml
[INFO] 3 resources included (use -debug for more details)
[INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 
0, approved: 3 licenses.
[INFO] 
[INFO] --- git-commit-id-plugin:2.1.9:revision (for-jars) @ tools-parent ---
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (process-resource-bundles) 
@ tools-parent ---
[INFO] 
[INFO] --- maven-site-plugin:3.5.1:attach-descriptor (attach-descriptor) @ 
tools-parent ---
[INFO] 
[INFO] --- maven-jar-plugin:3.0.0:test-jar (default) @ tools-parent ---
[INFO] Skipping packaging of the test-jar
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.12.1:check (checkstyle-validation) @ 
tools-parent ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-enforcer-plugin:1.3.1:enforce (avoid_bad_dependencies) @ 
tools-parent ---
[INFO] 
[INFO] --- maven-install-plugin:2.5.2:install (default-install) @ tools-parent 
---
[INFO] Installing  to 
/home/jenkins/.m2/repository/org/apache/drill/tools/tools-parent/1.14.0-SNAPSHOT/tools-parent-1.14.0-SNAPSHOT.pom
[INFO] 
[INFO] 
[INFO] Building tools/freemarker codegen tooling 1.14.0-SNAPSHOT
[INFO] 
Downloading: http://repository.mapr.com/maven/oro/oro/maven-metadata.xml
Downloading: 
http://repository.mapr.com/nexus/content/repositories/drill-optiq/oro/oro/maven-metadata.xml
Downloading: 
http://repository.mapr.com/nexus/content/repositories/drill/oro/oro/maven-metadata.xml
Downloading: http://repo.dremio.com/release/oro/oro/maven-metadata.xml
 Downloading: 
https://oss.sonatype.org/content/repositories/snapshots/oro/oro/maven-metadata.xml
   Downloading: 
http://repository.apache.org/snapshots/oro/oro/maven-metadata.xml
Downloading: https://repo.maven.apache.org/maven2/oro/oro/maven-metadata.xml
260/260 BDownloaded: 

[jira] [Created] (DRILL-6293) Unable to read hive(2.1.1) tables using Drill 1.13.0

[Anup Tiwari (JIRA)]

Anup Tiwari created DRILL-6293:
--

 Summary: Unable to read hive(2.1.1) tables using Drill 1.13.0 
 Key: DRILL-6293
 URL: https://issues.apache.org/jira/browse/DRILL-6293
 Project: Apache Drill
  Issue Type: Bug
Affects Versions: 1.13.0
Reporter: Anup Tiwari


Hi,

{color:#22}I am not able to read my hive tables in drill 1.13.0 and with 
same plugin conf it was working in Drill 1.12.0 and 1.10.0.{color}
 
*Hive Plugin :-* 
{
  "type": "hive",
  "enabled": true,
  "configProps": {
"hive.metastore.uris": 
"thrift://[prod-hadoop-1xx.com:9083|http://prod-hadoop-1xx.com:9083/];,
"hive.metastore.sasl.enabled": "false",
"[fs.default.name|http://fs.default.name/]": 
"hdfs://[prod-hadoop-1xx.com:9000|http://prod-hadoop-1xx.com:9000/];
  }
} 
 
*Query :-* 
select id from hive.cad where log_date = '2018-03-18' limit 3;
 
*Error :-* 
2018-03-20 14:25:27,351 [254f337f-9ac3-b66f-ed17-1de459da3283:foreman] INFO 
o.a.drill.exec.work.foreman.Foreman - Query text for query id 
254f337f-9ac3-b66f-ed17-1de459da3283: select id from hive.cad where log_date = 
'2018-03-18' limit 3
2018-03-20 14:25:27,354 [254f337f-9ac3-b66f-ed17-1de459da3283:foreman] WARN 
o.a.d.e.s.h.DrillHiveMetaStoreClient - Failure while attempting to get hive 
table. Retries once.
org.apache.thrift.TApplicationException: Invalid method name: 'get_table_req'
 at 
org.apache.thrift.TApplicationException.read(TApplicationException.java:111) 
~[drill-hive-exec-shaded-1.13.0.jar:1.13.0]
 at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:79) 
~[drill-hive-exec-shaded-1.13.0.jar:1.13.0]
 at 
org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore$Client.recv_get_table_req(ThriftHiveMetastore.java:1563)
 ~[drill-hive-exec-shaded-1.13.0.jar:1.13.0]
 at 
org.apache.hadoop.hive.metastore.api.ThriftHiveMetastore$Client.get_table_req(ThriftHiveMetastore.java:1550)
 ~[drill-hive-exec-shaded-1.13.0.jar:1.13.0]
 at 
org.apache.hadoop.hive.metastore.HiveMetaStoreClient.getTable(HiveMetaStoreClient.java:1344)
 ~[drill-hive-exec-shaded-1.13.0.jar:1.13.0]
 at 
org.apache.drill.exec.store.hive.DrillHiveMetaStoreClient.getHiveReadEntryHelper(DrillHiveMetaStoreClient.java:285)
 ~[drill-storage-hive-core-1.13.0.jar:1.13.0]
 at 
org.apache.drill.exec.store.hive.DrillHiveMetaStoreClient$TableLoader.load(DrillHiveMetaStoreClient.java:535)
 [drill-storage-hive-core-1.13.0.jar:1.13.0]
 at 
org.apache.drill.exec.store.hive.DrillHiveMetaStoreClient$TableLoader.load(DrillHiveMetaStoreClient.java:531)
 [drill-storage-hive-core-1.13.0.jar:1.13.0]
 at 
com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3527)
 [guava-18.0.jar:na]
 at com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2319) 
[guava-18.0.jar:na]
 at 
com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2282)
 [guava-18.0.jar:na]
 at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2197) 
[guava-18.0.jar:na]
 at com.google.common.cache.LocalCache.get(LocalCache.java:3937) 
[guava-18.0.jar:na]
 at com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:3941) 
[guava-18.0.jar:na]
 at 
com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4824) 
[guava-18.0.jar:na]
 at 
org.apache.drill.exec.store.hive.DrillHiveMetaStoreClient$HiveClientWithCaching.getHiveReadEntry(DrillHiveMetaStoreClient.java:495)
 [drill-storage-hive-core-1.13.0.jar:1.13.0]
 at 
org.apache.drill.exec.store.hive.schema.HiveSchemaFactory$HiveSchema.getSelectionBaseOnName(HiveSchemaFactory.java:233)
 [drill-storage-hive-core-1.13.0.jar:1.13.0]
 at 
org.apache.drill.exec.store.hive.schema.HiveSchemaFactory$HiveSchema.getDrillTable(HiveSchemaFactory.java:213)
 [drill-storage-hive-core-1.13.0.jar:1.13.0]
 at 
org.apache.drill.exec.store.hive.schema.HiveDatabaseSchema.getTable(HiveDatabaseSchema.java:62)
 [drill-storage-hive-core-1.13.0.jar:1.13.0]
 at 
org.apache.drill.exec.store.hive.schema.HiveSchemaFactory$HiveSchema.getTable(HiveSchemaFactory.java:201)
 [drill-storage-hive-core-1.13.0.jar:1.13.0]
 at 
org.apache.calcite.jdbc.SimpleCalciteSchema.getImplicitTable(SimpleCalciteSchema.java:82)
 [calcite-core-1.15.0-drill-r0.jar:1.15.0-drill-r0]
 at org.apache.calcite.jdbc.CalciteSchema.getTable(CalciteSchema.java:257) 
[calcite-core-1.15.0-drill-r0.jar:1.15.0-drill-r0]
 at 
org.apache.calcite.sql.validate.SqlValidatorUtil.getTableEntryFrom(SqlValidatorUtil.java:1003)
 [calcite-core-1.15.0-drill-r0.jar:1.15.0-drill-r0]
 at 
org.apache.calcite.sql.validate.SqlValidatorUtil.getTableEntry(SqlValidatorUtil.java:960)
 [calcite-core-1.15.0-drill-r0.jar:1.15.0-drill-r0]
 at 
org.apache.calcite.prepare.CalciteCatalogReader.getTable(CalciteCatalogReader.java:117)
 [calcite-core-1.15.0-drill-r0.jar:1.15.0-drill-r0]
 at 
org.apache.drill.exec.planner.sql.SqlConverter$DrillCalciteCatalogReader.getTable(SqlConverter.java:633)
 

[GitHub] drill pull request #1177: DRILL-6280: Cleanup execution of BuildTimeScan dur...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/1177


---

[GitHub] drill pull request #1163: DRILL-6053 & DRILL-6237

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/1163


---

[GitHub] drill pull request #1185: DRILL-6288: Upgrade org.javassist:javassist and or...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/1185


---

[GitHub] drill pull request #1171: DRILL-6231: Fix memory allocation for repeated lis...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/1171


---

[GitHub] drill pull request #1169: DRILL-6243: Added alert box to confirm shutdown of...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/1169


---

[GitHub] drill pull request #1175: DRILL-6262: IndexOutOfBoundException in RecordBatc...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/1175


---

[GitHub] drill pull request #1180: DRILL-6283: WebServer stores SPNEGO client princip...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/1180


---

[GitHub] drill pull request #1183: DRILL-6248: Added limit push down support for syst...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/1183


---

[GitHub] drill pull request #1165: DRILL-6239: Add build and license badges to README...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/1165


---

[GitHub] drill pull request #1162: DRILL-6005: Fixed TestGracefulShutdown tests to sk...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/1162


---

[GitHub] drill pull request #1186: DRILL-6290: Refactor TestInfoSchemaFilterPushDown ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/1186


---

[GitHub] drill pull request #1160: DRILL-6224: Publish current memory usage for Drill...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/1160


---

[GitHub] drill issue #1190: [DRILL-5937] ExecConstants: changed comment, timeout defa...

[arina-ielchiieva]

Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/1190
  
@pushpendra-jaiswal-90 please mind Drill convention about naming commit 
message.
Example: https://github.com/apache/drill/commits/master


---

[GitHub] drill issue #1190: [DRILL-5937] ExecConstants: changed comment, timeout defa...

[pushpendra-jaiswal-90]

Github user pushpendra-jaiswal-90 commented on the issue:

https://github.com/apache/drill/pull/1190
  
@vrozov @vdiravka Could you please review this?


---

[GitHub] drill pull request #1190: [DRILL-5937] ExecConstants: changed comment, timeo...

[pushpendra-jaiswal-90]

GitHub user pushpendra-jaiswal-90 opened a pull request:

https://github.com/apache/drill/pull/1190

[DRILL-5937] ExecConstants: changed comment, timeout default is 30 sec.

**Changed comment** to reflect default prepared statement timeout as 30 
sec. (same as hive) .
10 seconds timeout is also failing in some cases in our mapr environment.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pushpendra-jaiswal-90/drill 
bug/DRILL-5937-prepared-timeout-default

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/1190.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1190


commit 5556e25ed689a9029de27d9a3ad91f02e46b95f2
Author: Pushpendra Jaiswal 
Date:   2018-03-26T07:05:51Z

[DRILL-5937] ExecConstants: changed comment, timeout default is 30 sec.




---