[GitHub] drill pull request #1198: DRILL-6294: Changes to support Calcite 1.16.0

[vvysotskyi]

Github user vvysotskyi commented on a diff in the pull request:

https://github.com/apache/drill/pull/1198#discussion_r178404654
  
--- Diff: 
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -1142,16 +1142,8 @@ public void moveToCurrentRow() throws SQLException {
   }
 
   @Override
-  public AvaticaStatement getStatement() {
-try {
-  throwIfClosed();
-} catch (AlreadyClosedSqlException e) {
-  // Can't throw any SQLException because AvaticaConnection's
-  // getStatement() is missing "throws SQLException".
-  throw new RuntimeException(e.getMessage(), e);
-} catch (SQLException e) {
-  throw new RuntimeException(e.getMessage(), e);
-}
+  public AvaticaStatement getStatement() throws SQLException {
+throwIfClosed();
--- End diff --

Thanks, it looks clearer now.


---

[GitHub] drill issue #1182: DRILL-6287: apache-release profile should be disabled by ...

[vrozov]

Github user vrozov commented on the issue:

https://github.com/apache/drill/pull/1182
  
@parthchandra Please review


---

[GitHub] drill pull request #1198: DRILL-6294: Changes to support Calcite 1.16.0

[chunhui-shi]

Github user chunhui-shi commented on a diff in the pull request:

https://github.com/apache/drill/pull/1198#discussion_r178395314
  
--- Diff: 
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -1142,16 +1142,8 @@ public void moveToCurrentRow() throws SQLException {
   }
 
   @Override
-  public AvaticaStatement getStatement() {
-try {
-  throwIfClosed();
-} catch (AlreadyClosedSqlException e) {
-  // Can't throw any SQLException because AvaticaConnection's
-  // getStatement() is missing "throws SQLException".
-  throw new RuntimeException(e.getMessage(), e);
-} catch (SQLException e) {
-  throw new RuntimeException(e.getMessage(), e);
-}
+  public AvaticaStatement getStatement() throws SQLException {
+throwIfClosed();
--- End diff --

Since you are touching this file. You might want to remove not needed 
Exceptions for throwIfClosed() method that are derives of SqlException.


---

[GitHub] drill pull request #1196: DRILL-6286: Fixed incorrect reference to shutdown ...

[vrozov]

Github user vrozov commented on a diff in the pull request:

https://github.com/apache/drill/pull/1196#discussion_r178375583
  
--- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java ---
@@ -86,6 +86,9 @@
   private final StatusThread statusThread;
   private final Lock isEmptyLock = new ReentrantLock();
   private final Condition isEmptyCondition = isEmptyLock.newCondition();
+  private boolean isShutdownTriggered = false;
--- End diff --

Is this boolean necessary? Can you delay getting `isEmptyCondition` till 
shutdown is requested and use it in place of `isShutdownTriggered`?


---

[GitHub] drill pull request #1196: DRILL-6286: Fixed incorrect reference to shutdown ...

[vrozov]

Github user vrozov commented on a diff in the pull request:

https://github.com/apache/drill/pull/1196#discussion_r178376213
  
--- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java ---
@@ -212,19 +218,29 @@ private boolean areQueriesAndFragmentsEmpty() {
 return queries.isEmpty() && runningFragments.isEmpty();
   }
 
+  /**
+   * Check if there any new queries or fragments that are added after the 
shutdown is triggered
+   */
+  private boolean areNewQueriesOrFragmentsAdded() {
+return runningFragments.size() > numOfRunningFragments || 
queries.size() > numOfRunningQueries;
--- End diff --

This condition is not reliable. What if some fragments exited and some were 
added? The total number may still be less than the number of fragments when the 
shutdown was requested.


---

[GitHub] drill pull request #1196: DRILL-6286: Fixed incorrect reference to shutdown ...

[vrozov]

Github user vrozov commented on a diff in the pull request:

https://github.com/apache/drill/pull/1196#discussion_r178376362
  
--- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java ---
@@ -212,19 +218,29 @@ private boolean areQueriesAndFragmentsEmpty() {
 return queries.isEmpty() && runningFragments.isEmpty();
   }
 
+  /**
+   * Check if there any new queries or fragments that are added after the 
shutdown is triggered
+   */
+  private boolean areNewQueriesOrFragmentsAdded() {
+return runningFragments.size() > numOfRunningFragments || 
queries.size() > numOfRunningQueries;
+  }
+
   /**
* A thread calling the {@link #waitToExit(boolean)} method is notified 
when a foreman is retired.
*/
   private void indicateIfSafeToExit() {
 isEmptyLock.lock();
 try {
-  logger.info("Waiting for "+ queries.size() +" queries to complete 
before shutting down");
-  logger.info("Waiting for "+ runningFragments.size() +" running 
fragments to complete before shutting down");
+  if (isShutdownTriggered) {
+logger.info("Waiting for "+ queries.size() +" queries to complete 
before shutting down");
--- End diff --

Use slf4j smart logging.


---

[GitHub] drill pull request #1198: DRILL-6294: Changes to support Calcite 1.16.0

[vvysotskyi]

Github user vvysotskyi commented on a diff in the pull request:

https://github.com/apache/drill/pull/1198#discussion_r178371341
  
--- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillReduceAggregatesRule.java
 ---
@@ -218,7 +218,8 @@ private void reduceAggs(
 RelOptUtil.createProject(
 newAggRel,
 projList,
-oldAggRel.getRowType().getFieldNames());
+oldAggRel.getRowType().getFieldNames(),
+DrillRelFactories.LOGICAL_BUILDER);
--- End diff --

In the second commit it was fixed and used relBuilderFactory to create 
builder and project. 


---

[GitHub] drill pull request #1195: DRILL-6273: Removed dependency licensed under Cate...

[vrozov]

Github user vrozov commented on a diff in the pull request:

https://github.com/apache/drill/pull/1195#discussion_r178364790
  
--- Diff: tools/fmpp/src/main/java/bsh/EvalError.java ---
@@ -0,0 +1,28 @@
+/**
--- End diff --

Please do not use doc comment for the license.


---

[GitHub] drill pull request #1195: DRILL-6273: Removed dependency licensed under Cate...

[vrozov]

Github user vrozov commented on a diff in the pull request:

https://github.com/apache/drill/pull/1195#discussion_r178365989
  
--- Diff: tools/fmpp/src/main/java/bsh/EvalError.java ---
@@ -0,0 +1,28 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package bsh;
+/**
--- End diff --

will be better to have this comment in package-info.


---

[GitHub] drill pull request #1195: DRILL-6273: Removed dependency licensed under Cate...

[vrozov]

Github user vrozov commented on a diff in the pull request:

https://github.com/apache/drill/pull/1195#discussion_r178366218
  
--- Diff: tools/fmpp/pom.xml ---
@@ -57,6 +57,10 @@
   commons-logging-api
   commons-logging
 
+
+  bsh
--- End diff --

add bsh:org.beanshell to the prohibited dependencies.


---

[GitHub] drill pull request #1198: DRILL-6294: Changes to support Calcite 1.16.0

[chunhui-shi]

Github user chunhui-shi commented on a diff in the pull request:

https://github.com/apache/drill/pull/1198#discussion_r178364263
  
--- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillReduceAggregatesRule.java
 ---
@@ -218,7 +218,8 @@ private void reduceAggs(
 RelOptUtil.createProject(
 newAggRel,
 projList,
-oldAggRel.getRowType().getFieldNames());
+oldAggRel.getRowType().getFieldNames(),
+DrillRelFactories.LOGICAL_BUILDER);
--- End diff --

Could you explain why we are using DrillRelFactories.LOGICAL_BUILDER but 
not relBuilderFactory that was used in line 211? And could you point me to this 
4 param createProject method with Factory as the last param?


---

[jira] [Created] (DRILL-6303) Provide a button to copy the Drillbit's JStack shown in /threads

[Kunal Khatua (JIRA)]

Kunal Khatua created DRILL-6303:
---

 Summary: Provide a button to copy the Drillbit's JStack shown in 
/threads
 Key: DRILL-6303
 URL: https://issues.apache.org/jira/browse/DRILL-6303
 Project: Apache Drill
  Issue Type: Improvement
  Components: Web Server
Reporter: Kunal Khatua
Assignee: Kunal Khatua
 Fix For: 1.14.0


Currently, when using the WebUI inspecting the JStack for the state of threads 
within a Drillbit (via +{{http://:8047/threads}}+ ), the contents of 
the `div` element refreshes automatically and resets any selection, making it 
harder to freeze the contents for inspection.

Pausing the refresh is not recommended, so the alternative is to copy the 
contents to the user's clipboard for separately viewing in a text editor.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] drill issue #1197: DRILL-6279: UI indicates operators that spilled in-memory...

[kkhatua]

Github user kkhatua commented on the issue:

https://github.com/apache/drill/pull/1197
  
@arina-ielchiieva could you review this? I will be using this commit as the 
basis for [DRILL-6289](https://issues.apache.org/jira/browse/DRILL-6289)


---

[GitHub] drill issue #1170: DRILL-6223: Fixed several Drillbit failures due to schema...

[paul-rogers]

Github user paul-rogers commented on the issue:

https://github.com/apache/drill/pull/1170
  
Over the last year, we've tended to favor including unit tests with each 
PR. There don't seem to be any with this one, yet we are proposing to make a 
fairly complex change. Perhaps tests can be added.

Further, by having good tests, we don't have to debate how Drill will 
handle the scenarios discussed in an earlier comment: we just code 'em up and 
try 'em out, letting Drill speak for itself. We can then decide whether or not 
we like the results, rather than discussing hypotheticals.


---

[GitHub] drill issue #1170: DRILL-6223: Fixed several Drillbit failures due to schema...

[paul-rogers]

Github user paul-rogers commented on the issue:

https://github.com/apache/drill/pull/1170
  
BTW: thanks for tackling such a difficult, core issue in Drill. Drill 
claims to be a) schema free and b) SQL compliant. SQL is based on operations 
over relations with a fixed number of columns of fixed types. Reconciling these 
two ideas is very difficult. Even the original Drill developers, who built a 
huge amount of code very quickly, and who had intimate knowledge of the Drill 
internals, even they did not find a good solution which is why the problem is 
still open.

There are two obvious approaches: 1) redefine SQL to operate over lists of 
maps (with arbitrary name/value pairs that differ across rows), or 2) define 
translation rules from schema-free input into the schema-full relations that 
SQL requires.

This PR attempts to go down the first route: redefine SQL. To be 
successful, we'd want to rely on research papers, if any, that show how to 
reformulate relational theory on top of lists of maps rather than on relations 
and domains.

The other approach is to define conversion rules: something much more on 
the order of a straight-forward implementation project. Can the user provide 
conversion rules (in the form of a schema) when the conversion is ambiguous? 
Would users rather encounter schema change exceptions or provide the conversion 
rules? These are interesting open questions.


---

[GitHub] drill issue #1198: DRILL-6294: Changes to support Calcite 1.16.0

[vvysotskyi]

Github user vvysotskyi commented on the issue:

https://github.com/apache/drill/pull/1198
  
@amansinha100, @chunhui-shi could you please take a look?


---

[GitHub] drill issue #1173: DRILL-6259: Support parquet filter push down for complex ...

[arina-ielchiieva]

Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/1173
  
Done.


---

[GitHub] drill pull request #1198: DRILL-6294: Changes to support Calcite 1.16.0

[vvysotskyi]

GitHub user vvysotskyi opened a pull request:

https://github.com/apache/drill/pull/1198

DRILL-6294: Changes to support Calcite 1.16.0



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vvysotskyi/drill DRILL-6294

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/1198.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1198


commit a79d6586033b618c95462368520237aab84f47bf
Author: Volodymyr Vysotskyi 
Date:   2018-02-07T14:24:50Z

DRILL-6294: Changes to support Calcite 1.16.0

commit 48880eb80d60a15e4ffdfcd6c729bfc75cf5d2da
Author: Volodymyr Vysotskyi 
Date:   2018-03-11T10:11:45Z

DRILL-6294: Remove deprecated API usage




---

[GitHub] drill pull request #1166: DRILL-6016 - Fix for Error reading INT96 created b...

[rajrahul]

Github user rajrahul commented on a diff in the pull request:

https://github.com/apache/drill/pull/1166#discussion_r178324303
  
--- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
 ---
@@ -61,6 +60,7 @@
 import org.junit.runners.Parameterized;
 
 @RunWith(Parameterized.class)
+
--- End diff --

Actually not required, tried to add another RunWith for Mocking and removed 
later on leaving the newline.


---

[GitHub] drill issue #1060: DRILL-5846: Improve parquet performance for Flat Data Typ...

[sachouche]

Github user sachouche commented on the issue:

https://github.com/apache/drill/pull/1060
  
Parth,

- I have attached, within the DRILL-5846, two profiles with latest Apache 
code and this PR request (bounds checks are off):
  o Used one thread in each run
  o I observe ~3x performance difference when the new logic is turned on
  o The difference is 4x if I include the implicit column optimization 
(which is not part of this PR)
  o The impact of the new optimizations can be felt when there are many 
variable length columns

- The rational of trying to approve this PR
   o The optimizations that I have included are local to the Flat Parquet 
Reader (incapsulated)
   o The logic is backward compatible and turned off by default
   o I have added the new Batch Sizing functionality on top of this PR 
(columnar processing pattern)
   o The result of DRILL-6301 would only result in a local refactoring step
   o Not being able to add the new code results in a substantial 
maintenance overhead

   


---

[GitHub] drill issue #1173: DRILL-6259: Support parquet filter push down for complex ...

[amansinha100]

Github user amansinha100 commented on the issue:

https://github.com/apache/drill/pull/1173
  
@arina-ielchiieva could you rebase this on latest master ? thanks. 


---

[GitHub] drill pull request #1178: DRILL-6278: Removed temp codegen directory in test...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/1178


---

[GitHub] drill pull request #1172: DRILL-6256: Remove references to java 7 from readm...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/1172


---

[GitHub] drill pull request #1105: DRILL-6125: Fix possible memory leak when query is...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/1105


---

[GitHub] drill pull request #1190: DRILL-5937: ExecConstants: changed comment, timeou...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/1190


---

[GitHub] drill pull request #1192: DRILL-6299: Fixed a filter pushed down issue when ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/1192


---

[GitHub] drill pull request #1194: DRILL-6300: Refresh protobuf C++ source files

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/1194


---

[GitHub] drill pull request #1179: DRILL-6254: IllegalArgumentException: the requeste...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/1179


---

Build failed in Jenkins: drill-scm #951

[Apache Jenkins Server]

See 

Changes:

[asinha] DRILL-6300: Refresh protobuf C++ source files

[asinha] DRILL-6299: Fixed a filter pushed down issue when a column doesn't have

[asinha] DRILL-5937: drill-module.conf : Changed timeout to 30 seconds,

[asinha] DRILL-6254: IllegalArgumentException: the requested size must be

[asinha] DRILL-6278: Removed temp codegen directory in testing framework.

[asinha] DRILL-6256: Remove references to java 7 from readme and other files

[asinha] DRILL-6125: Fix possible memory leak when query is cancelled or

--
Started by an SCM change
[EnvInject] - Loading node environment variables.
Building remotely on H23 (ubuntu xenial) in workspace 

Cloning the remote Git repository
Cloning repository https://git-wip-us.apache.org/repos/asf/drill.git
 > git init  # timeout=10
Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/drill.git
 > git --version # timeout=10
 > git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/drill.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/drill.git # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # 
 > timeout=10
 > git config remote.origin.url 
 > https://git-wip-us.apache.org/repos/asf/drill.git # timeout=10
Fetching upstream changes from https://git-wip-us.apache.org/repos/asf/drill.git
 > git fetch --tags --progress 
 > https://git-wip-us.apache.org/repos/asf/drill.git 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
 > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
Checking out Revision a264e7feb1d02ffd5762bb1f652ea22d17aa5243 
(refs/remotes/origin/master)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f a264e7feb1d02ffd5762bb1f652ea22d17aa5243
Commit message: "DRILL-6125: Fix possible memory leak when query is cancelled 
or finished."
 > git rev-list --no-walk f1cfaaf3aa08b25910918255fbf8daf67278d5c9 # timeout=10
[drill-scm] $ /home/jenkins/tools/maven/apache-maven-3.3.3/bin/mvn clean 
install -DskipTests
[INFO] Scanning for projects...
[INFO] 
[INFO] Detecting the operating system and CPU architecture
[INFO] 
[INFO] os.detected.name: linux
[INFO] os.detected.arch: x86_64
[INFO] os.detected.version: 4.4
[INFO] os.detected.version.major: 4
[INFO] os.detected.version.minor: 4
[INFO] os.detected.release: ubuntu
[INFO] os.detected.release.version: 16.04
[INFO] os.detected.release.like.ubuntu: true
[INFO] os.detected.release.like.debian: true
[INFO] os.detected.classifier: linux-x86_64
[INFO] 
[INFO] Reactor Build Order:
[INFO] 
[INFO] Apache Drill Root POM
[INFO] tools/Parent Pom
[INFO] tools/freemarker codegen tooling
[INFO] Drill Protocol
[INFO] Common (Logical Plan, Base expressions)
[INFO] Logical Plan, Base expressions
[INFO] exec/Parent Pom
[INFO] exec/memory/Parent Pom
[INFO] exec/memory/base
[INFO] exec/rpc
[INFO] exec/Vectors
[INFO] contrib/Parent Pom
[INFO] contrib/data/Parent Pom
[INFO] contrib/data/tpch-sample-data
[INFO] exec/Java Execution Engine
[INFO] exec/JDBC Driver using dependencies
[INFO] JDBC JAR with all dependencies
[INFO] Drill-on-YARN
[INFO] contrib/kudu-storage-plugin
[INFO] contrib/opentsdb-storage-plugin
[INFO] contrib/mongo-storage-plugin
[INFO] contrib/hbase-storage-plugin
[INFO] contrib/jdbc-storage-plugin
[INFO] contrib/hive-storage-plugin/Parent Pom
[INFO] contrib/hive-storage-plugin/hive-exec-shaded
[INFO] contrib/hive-storage-plugin/core
[INFO] contrib/drill-gis-plugin
[INFO] contrib/kafka-storage-plugin
[INFO] Packaging and Distribution Assembly
[INFO] contrib/mapr-format-plugin
[INFO] contrib/sqlline
[INFO] 
[INFO] 
[INFO] Building Apache Drill Root POM 1.14.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-clean-plugin:3.0.0:clean (default-clean) @ drill-root ---
[INFO] 
[INFO] --- apache-rat-plugin:0.12:check (rat-checks) @ drill-root ---
[INFO] Enabled default license matchers.
[INFO] Will parse SCM ignores for exclusions...
[INFO] Parsing exclusions from 

[INFO] Finished adding exclusions from SCM ignore files.
[INFO] 89 implicit excludes (use -debug for more details).
[INFO] Exclude: **/*.log
[INFO] Exclude: **/*.css
[INFO] Exclude: **/*.js
[INFO] Exclude: **/*.md
[INFO] Exclude: **/*.eps
[INFO] Exclude: 

[GitHub] drill pull request #1166: DRILL-6016 - Fix for Error reading INT96 created b...

[rajrahul]

Github user rajrahul commented on a diff in the pull request:

https://github.com/apache/drill/pull/1166#discussion_r178290675
  
--- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
 ---
@@ -780,17 +780,31 @@ public void 
testImpalaParquetBinaryAsVarBinary_DictChange() throws Exception {
   Test the reading of a binary field as drill timestamp where data is in 
dictionary _and_ non-dictionary encoded pages
*/
   @Test
-  @Ignore("relies on particular time zone, works for UTC")
   public void testImpalaParquetBinaryAsTimeStamp_DictChange() throws 
Exception {
 try {
   testBuilder()
-  .sqlQuery("select int96_ts from dfs.`parquet/int96_dict_change` 
order by int96_ts")
+  .sqlQuery("select min(int96_ts) date_value from 
dfs.`parquet/int96_dict_change`")
--- End diff --

I did not try a WHERE statement, MIN was used to select a single record to 
compare. Was there any specific reason to use WHERE?


---

[GitHub] drill issue #1060: DRILL-5846: Improve parquet performance for Flat Data Typ...

[parthchandra]

Github user parthchandra commented on the issue:

https://github.com/apache/drill/pull/1060
  
I feel putting this PR in without finalizing DRILL-6301 is putting the cart 
before the horse. (BTW, it would help the discussion if the benchmarks were 
published !). My observation based on profiling I did sometime back is that the 
performance gains seen here are roughly in line with removing bounds checks. 
Paul has seen similar gains in the batch sizing project.
Which takes us back to the question, raised by Paul in his first comment, 
of how we want to reconcile batch sizing and vectorizing of scans; a question 
we have deferred. If removing bounds checks gets us the same performance gains, 
then why not would put our efforts in implementing batch sizing with the 
accompanying elimination in bounds checking. 
I'm mostly not in favor of having MemoryUtils unless you make a compelling 
argument that it is the only way to save the planet (i.e get the performance 
you want). I feel operators should not establish the pattern of accessing 
memory directly. So far, I'm -0 on this as my arguments are mostly high level 
(and somewhat philosophical). 
Minor nitpick - The prefix VL is not as informative as say, VarLen or 
VariableLength.



---

[GitHub] drill pull request #1166: DRILL-6016 - Fix for Error reading INT96 created b...

[vdiravka]

Github user vdiravka commented on a diff in the pull request:

https://github.com/apache/drill/pull/1166#discussion_r178255699
  
--- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
 ---
@@ -61,6 +60,7 @@
 import org.junit.runners.Parameterized;
 
 @RunWith(Parameterized.class)
+
--- End diff --

new line?


---

[GitHub] drill pull request #1166: DRILL-6016 - Fix for Error reading INT96 created b...

[vdiravka]

Github user vdiravka commented on a diff in the pull request:

https://github.com/apache/drill/pull/1166#discussion_r178255942
  
--- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
 ---
@@ -780,17 +780,31 @@ public void 
testImpalaParquetBinaryAsVarBinary_DictChange() throws Exception {
   Test the reading of a binary field as drill timestamp where data is in 
dictionary _and_ non-dictionary encoded pages
*/
   @Test
-  @Ignore("relies on particular time zone, works for UTC")
   public void testImpalaParquetBinaryAsTimeStamp_DictChange() throws 
Exception {
 try {
   testBuilder()
-  .sqlQuery("select int96_ts from dfs.`parquet/int96_dict_change` 
order by int96_ts")
+  .sqlQuery("select min(int96_ts) date_value from 
dfs.`parquet/int96_dict_change`")
--- End diff --

Did you try WHERE statement?


---

[GitHub] drill issue #1168: DRILL-6246: Reduced the size of the jdbc-all jar file

[parthchandra]

Github user parthchandra commented on the issue:

https://github.com/apache/drill/pull/1168
  
I would recommend trying to setup a connection using Spotfire or Squirrel 
and running a couple of metadata queries and a couple of queries on complex 
data. (These have traditionally been areas that were affected when the jar was 
incomplete). 
Also try on a secure cluster. You might need help from other folks on some 
of this. 


---

[GitHub] drill pull request #1197: DRILL-6279: UI indicates operators that spilled in...

[kkhatua]

GitHub user kkhatua opened a pull request:

https://github.com/apache/drill/pull/1197

DRILL-6279: UI indicates operators that spilled in-memory data to disk

1. Detect the presence of an operator that has spilled to disk, in the 
Operators Overview section of a query's profile page.
2. Introduced API to inject html attributes into a cell. This is used to 
inject details about the spill in the avg peak and max peak memory usage
3. Javascript is leveraged to detect spilled operators' HTML elements, and 
inject a symbolic font for indicating the operator as having spilt.
4. Mouse-over effect indicates the average and max number of spill cycles 
the operator went through. 

NOTE: Bootstrap library comes with Glyphicons Halfling Fonts and meets the 
Apache license requirements.
http://glyphicons.com/license#halflingsbootstrap

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kkhatua/drill DRILL-6279

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/1197.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1197


commit 230d739c05e2f2da93232fe31dec55adf627937e
Author: Kunal Khatua 
Date:   2018-03-30T04:58:53Z

DRILL-6279: UI indicates operators that spilled in-memory data to disk

1. Detect the presence of an operator that has spilled to disk, in the 
Operators Overview section of a query's profile page.
2. Introduced API to inject html attributes into a cell. This is used to 
inject details about the spill in the avg peak and max peak memory usage
3. Javascript is leveraged to detect spilled operators' HTML elements, and 
inject a symbolic font for indicating the operator as having spilt.
4. Mouse-over effect indicates the average and max number of spill cycles 
the operator went through.

commit 5641e713888db6e3e028a5749bd902dc3bdc6562
Author: Kunal Khatua 
Date:   2018-03-26T05:05:06Z

Addition of Bootstrap's Glyphicons

As part of the Bootstrap's components, this meets Apache License criteria




---