[GitHub] [drill] cgivre commented on a change in pull request #2493: DRILL-8164: Upgrade metadata-extractor because of CVE-2022-24613
cgivre commented on a change in pull request #2493: URL: https://github.com/apache/drill/pull/2493#discussion_r831198283 ## File path: metastore/rdbms-metastore/src/main/java/org/apache/drill/metastore/rdbms/RdbmsMetastore.java ## @@ -117,6 +117,8 @@ private HikariDataSource dataSource(DrillConfig config) { private void initTables(DataSource dataSource) { try (Connection connection = dataSource.getConnection()) { JdbcConnection jdbcConnection = new JdbcConnection(connection); + // TODO Replace the following steps with new function once this issue is resolved. Review comment: Actually... I think rebasing will solve this. Please rebase on current master with the liquibase PR merged, and then it's good to go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [drill] cgivre commented on a change in pull request #2493: DRILL-8164: Upgrade metadata-extractor because of CVE-2022-24613
cgivre commented on a change in pull request #2493: URL: https://github.com/apache/drill/pull/2493#discussion_r831196452 ## File path: metastore/rdbms-metastore/src/main/java/org/apache/drill/metastore/rdbms/RdbmsMetastore.java ## @@ -117,6 +117,8 @@ private HikariDataSource dataSource(DrillConfig config) { private void initTables(DataSource dataSource) { try (Connection connection = dataSource.getConnection()) { JdbcConnection jdbcConnection = new JdbcConnection(connection); + // TODO Replace the following steps with new function once this issue is resolved. Review comment: Could you please open a JIRA with this issue and reference here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [drill] cgivre merged pull request #2497: DRILL-8165: Upgrade liquibase because of CVE-2022-0839
cgivre merged pull request #2497: URL: https://github.com/apache/drill/pull/2497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [drill] jnturton merged pull request #2500: DRILL-8172: Use the specified memory usage for Travis CI
jnturton merged pull request #2500: URL: https://github.com/apache/drill/pull/2500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [drill] lgtm-com[bot] commented on pull request #2485: DRILL-8086: Convert the CSV (AKA "compliant text") reader to EVF V2
lgtm-com[bot] commented on pull request #2485: URL: https://github.com/apache/drill/pull/2485#issuecomment-1073519845 This pull request **introduces 3 alerts** and **fixes 3** when merging 82e1055524ac9543bc6ff9132f9e43880b24edb3 into 7ef203b840f873fca0625d2fe77d9d4fab6ad99f - [view on LGTM.com](https://lgtm.com/projects/g/apache/drill/rev/pr-2e715554d1f7136c4ca945f04a54b34225da71ea) **new alerts:** * 3 for Dereferenced variable may be null **fixed alerts:** * 3 for Dereferenced variable may be null -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org