cgivre commented on PR #2731:
URL: https://github.com/apache/drill/pull/2731#issuecomment-1367977377
> Thanks @cgivre for the clarification, but suppose the assumption that
considering nulls as strings would solve the issue, were the changes i made
(over the class JSONReader.java) adequate (should the methods be changed as i
did)? i see that some tests didn't pass.
For us to merge a pull request, all the unit tests have to pass. (Or be
modified with an explanation of why they are being modified) Drill is a very
complex beast with a lot of dependencies so even small changes can break things
you didn't intend to. Believe me... I know from experience ;-)
One other thing to note is that there is another option
`drill.exec.functions.cast_empty_string_to_null`. Setting this to true forces
empty strings to be treated as `null`. This can have some unintended side
effects, but might also help you out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
