License headers inside Javadoc comments
Good morning! I'd like to ask about a feature to prevent RAT from allowing license headers to appear inside Javadoc comments (/**) while still requiring them in Java comments (/*) in .java files. Currently the Drill project makes use of com.mycila.license-maven-plugin to reject licenses in Javadoc comments because the developers at the time didn't want license headers cluttering the Javadoc website that is generated from the source. Are you aware of a general view on Apache license headers appearing in Javadoc pages? If preventing them from doing so is a good idea, could this become a (configurable) feature in RAT? Thanks James Turton
Re: Possible Regression: Can't build current master
I updated my GitHub branch from master, then pulled that branch to my computer, where I did a build. It is clean. Now, I did have to do some git tricks to clean up the stray commits from my botched merge. See below. Then, I pulled cgivre/master and did a diff with my local copy of master. There are *many* different files. So, I wonder if your master branch has somehow diverged from the Drill master. Or, are you tracking some other branch? As a sanity check, I suggest you reset your master to the Drill master and do a clean build. Some commands that might help: git fetch origin git checkout master git reset --hard origin/master Use these with caution: I used a slightly different set to update my own branch. Caveat emptor. This assumes that your Drill clone is "origin". - Paul On Thu, Jan 25, 2024 at 12:48 PM Paul Rogers wrote: > The symbols in questions are some I modified in my recent PR. I wonder if > there was a merge issue somewhere? The PR did get a clean build on the > master branch. > > I'll try a build myself to see if I can locate the issue. > > - Paul > > > On Thu, Jan 25, 2024 at 10:56 AM Charles Givre wrote: > >> All, >> I just rebased my local Drill on the current master and I'm getting the >> following error when I try to build it. Is anyone else encountering this? >> >> [ERROR] Failed to execute goal >> org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile >> (default-compile) on project vector: Compilation failure >> [ERROR] >> /Users/charlesgivre/github/drill/exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/writer/UnionVectorShim.java:[78,10] >> error: cannot find symbol >> [ERROR] symbol: class UnionWriter >> [ERROR] location: class UnionVectorShim >> [ERROR] >> [ERROR] -> [Help 1] >> [ERROR] >> [ERROR] To see the full stack trace of the errors, re-run Maven with the >> -e switch. >> [ERROR] Re-run Maven using the -X switch to enable full debug logging. >> [ERROR] >> [ERROR] For more information about the errors and possible solutions, >> please read the following articles: >> [ERROR] [Help 1] >> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException > >
Re: Possible Regression: Can't build current master
The symbols in questions are some I modified in my recent PR. I wonder if there was a merge issue somewhere? The PR did get a clean build on the master branch. I'll try a build myself to see if I can locate the issue. - Paul On Thu, Jan 25, 2024 at 10:56 AM Charles Givre wrote: > All, > I just rebased my local Drill on the current master and I'm getting the > following error when I try to build it. Is anyone else encountering this? > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile > (default-compile) on project vector: Compilation failure > [ERROR] > /Users/charlesgivre/github/drill/exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/writer/UnionVectorShim.java:[78,10] > error: cannot find symbol > [ERROR] symbol: class UnionWriter > [ERROR] location: class UnionVectorShim > [ERROR] > [ERROR] -> [Help 1] > [ERROR] > [ERROR] To see the full stack trace of the errors, re-run Maven with the > -e switch. > [ERROR] Re-run Maven using the -X switch to enable full debug logging. > [ERROR] > [ERROR] For more information about the errors and possible solutions, > please read the following articles: > [ERROR] [Help 1] > http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
Possible Regression: Can't build current master
All, I just rebased my local Drill on the current master and I'm getting the following error when I try to build it. Is anyone else encountering this? [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project vector: Compilation failure [ERROR] /Users/charlesgivre/github/drill/exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/writer/UnionVectorShim.java:[78,10] error: cannot find symbol [ERROR] symbol: class UnionWriter [ERROR] location: class UnionVectorShim [ERROR] [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
