[GitHub] drill pull request #944: DRILL-5425: Support HTTP Kerberos auth using SPNEGO
Github user sindhurirayavaram closed the pull request at: https://github.com/apache/drill/pull/944 ---
[GitHub] drill pull request #944: DRILL-5425: Support HTTP Kerberos auth using SPNEGO
GitHub user sindhurirayavaram opened a pull request: https://github.com/apache/drill/pull/944 DRILL-5425: Support HTTP Kerberos auth using SPNEGO SPNEGO extends kerberos authentication to Drill WEB UI. Things to be added -Unit Tests -Showing the login option depending on the configured mechanisms You can merge this pull request into a Git repository by running: $ git pull https://github.com/sindhurirayavaram/drill Spnego Alternatively you can review and apply these changes as the patch at: https://github.com/apache/drill/pull/944.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #944 commit c770a2e7b0e75c4f18b954d8ada36469f00c8355 Author: mapr <mapr@mapr.local> Date: 2017-09-11T23:56:22Z Added comments commit 6015e98f08c1961bbbc9911946522f9a076e87e0 Author: mapr <mapr@mapr.local> Date: 2017-09-13T19:48:28Z Added Test Cases commit 5ff12ba1fe38fd728b0c33a686c665547dd21c50 Author: Sindhuri <mapr@mapr.local> Date: 2017-09-15T22:21:53Z Formatted code ---
[GitHub] drill issue #933: DRILL-5765: Json query profile is not shown on Web UI
Github user sindhurirayavaram commented on the issue: https://github.com/apache/drill/pull/933 @arina-ielchiieva I updated the jquery to it's latest min version. The updated jquery library doesn't support load function anymore. It should be "onload". We were using load in graph.js which was failing. I updated that to "onload". ---
[GitHub] drill pull request #933: DRILL-5765: Json query profile is not shown on Web ...
GitHub user sindhurirayavaram opened a pull request:
https://github.com/apache/drill/pull/933
DRILL-5765: Json query profile is not shown on Web UI
The "graph.js", used in the profiles page of Drill Web UI, uses
$(window).load(function () {}). The ".load" function is deprecated from the
Jquery after 1.8. In this change, I have changed the function to onload.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sindhurirayavaram/drill bug
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/933.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #933
commit 833e69c0b5811449667446b06212016f5925e9cd
Author: Sindhuri Rayavaram <sindhurirayavaram@mapr.local>
Date: 2017-09-01T23:51:07Z
DRILL-5765: Json query profile is not shown on Web UI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #874: DRILL-5663: Drillbit fails to start when only keystore pat...
Github user sindhurirayavaram commented on the issue: https://github.com/apache/drill/pull/874 Changes made and added another commit! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill issue #874: DRILL-5663: Drillbit fails to start when only keystore pat...
Github user sindhurirayavaram commented on the issue: https://github.com/apache/drill/pull/874 Created a separate pull request for DRILL-5712. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill pull request #903: DRILL-5712: Update the pom files with dependency ex...
GitHub user sindhurirayavaram opened a pull request: https://github.com/apache/drill/pull/903 DRILL-5712: Update the pom files with dependency exclusions for commons-codec In java-exec, we are adding a dependency for commons-codec of version 1.10. Other dependencies like hadoop-common, parquet-column etc are trying to download different versions for common codec. Exclusions should be added for common-codec in these dependencies. This change has added exclusions in all the pom.xml files. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sindhurirayavaram/drill DRILL-5712 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/drill/pull/903.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #903 commit 88389f83e7c786c47c907b73a086d677a224778a Author: Sindhuri Rayavaram <sindhurirayavaram@mapr.local> Date: 2017-08-10T19:50:58Z DRILL-5712: Update the pom files with dependency exclusions for commons-codec --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill pull request #891: DRILL-5699: Drill Web UI Page Source Has Links To E...
Github user sindhurirayavaram commented on a diff in the pull request: https://github.com/apache/drill/pull/891#discussion_r131671757 --- Diff: exec/java-exec/src/main/resources/rest/generic.ftl --- @@ -27,7 +27,9 @@ - + --- End diff -- According to this [reference](https://stackoverflow.com/questions/550038/is-it-valid-to-replace-http-with-in-a-script-src-http), it shouldn't be a problem. I will change it though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill issue #891: DRILL-5699: Drill Web UI Page Source Has Links To External...
Github user sindhurirayavaram commented on the issue: https://github.com/apache/drill/pull/891 @arina-ielchiieva After the first commit, I had a detailed discussion with @parthchandra. There are two reasons two include all the js and css files locally 1) The biggest library among them, the jquery is already included in the resources file. Even libraries like d3 are there locally. 2) One of the js and css libraries, Colvis by datatables is retired. We have to keep a local copy of that incase the url becomes extinct in the future. Check this please [Colvis](https://datatables.net/extensions/colvis/) So we decided to just include all the js and css libraries locally. I updated the libraries to their min versions and some of them to their latest versions. I made a change in generic page where we are loading google external cdn first and if its failing falling back to the local library. Please let me know if there are any changes needed here. Thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill issue #891: DRILL-5699: Drill Web UI Page Source Has Links To External...
Github user sindhurirayavaram commented on the issue: https://github.com/apache/drill/pull/891 @arina! I am planning to keep all the files in the local resources file! I have mentioned the reasons above. Yes, onload should be used for IE. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill pull request #874: DRILL-5663: Drillbit fails to start when only keyst...
Github user sindhurirayavaram commented on a diff in the pull request: https://github.com/apache/drill/pull/874#discussion_r131238139 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -122,10 +122,10 @@ String HTTP_SESSION_MEMORY_RESERVATION = "drill.exec.http.session.memory.reservation"; String HTTP_SESSION_MEMORY_MAXIMUM = "drill.exec.http.session.memory.maximum"; String HTTP_SESSION_MAX_IDLE_SECS = "drill.exec.http.session_max_idle_secs"; - String HTTP_KEYSTORE_PATH = "javax.net.ssl.keyStore"; --- End diff -- Using the _javax_ property name for Drill property might be confusing for users, since changing that value inside Drill configuration will not reflect on the actual System property. So to avoid that confusion this property was renamed taking example from [Hadoop](https://hadoop.apache.org/docs/r2.7.2/hadoop-mapreduce-client/hadoop-mapreduce-client-core/EncryptedShuffle.html) and [IBM](https://www.ibm.com/support/knowledgecenter/en/SSZH4A_5.0.6/com.ibm.worklight.help.doc/admin/r_ssl_certificate_keystore_setup.html). Though Hadoop provides separate parameter for client/server whereas Drill has only server side config, these properties can be renamed to include _.server_ if needed. But making this name change will not affect Drill users already using the older property since backward compatibility is provided here. It will work seamlessly for them. All the below scenarios are tested. 1) Setting javax.ssl.* properties in drill-override.conf 2) Setting javax.ssl.* properties as system options with -D option. 3) Setting ssl.* properties in drill-override.conf So if a user provide the property values only as system property, then both Drill and JSSE will still be consuming it and work as expected. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill issue #874: DRILL-5663: Drillbit fails to start when only keystore pat...
Github user sindhurirayavaram commented on the issue: https://github.com/apache/drill/pull/874 Hadoop uses different property names for configuring ssl properties. We can provide backward compatibility where we can still use the java properties in drill-override.conf. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill issue #891: DRILL-5699: Drill Web UI Page Source Has Links To External...
Github user sindhurirayavaram commented on the issue: https://github.com/apache/drill/pull/891 @arina-ielchiieva Thanks for the comments! Yes drillbit fails if it can't download them during build time. These are pretty large fails. Is it good to add them in the source tree? To answer your second question! Even if we have local files it's better to check the browser's cache first. If that fails, we can load them locally. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill pull request #874: DRILL-5663: Drillbit fails to start when only keyst...
Github user sindhurirayavaram commented on a diff in the pull request:
https://github.com/apache/drill/pull/874#discussion_r130939205
--- Diff: distribution/src/resources/drill-override-example.conf ---
@@ -214,7 +214,7 @@ drill.exec: {
}
# Below SSL parameters need to be set for custom transport layer settings.
-javax.net.ssl {
+ssl{
keyStore: "/keystore.file",
--- End diff --
Can you look into this paul? This an example I got.
SSL certificate keystore location.
Default: conf/default.keystore.
ssl.keystore.path can be configured in 2 ways:
By using the relative path, for example,
ssl.keystore.path=conf/default.keystore, where the root directory is \server\.
By using the absolute path, for example,
ssl.keystore.path=/opt/wl/default.keystore for UNIX, or
C:\\wl\\default.keystore for Windows.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #891: DRILL-5699: Drill Web UI Page Source Has Links To E...
GitHub user sindhurirayavaram opened a pull request: https://github.com/apache/drill/pull/891 DRILL-5699: Drill Web UI Page Source Has Links To External Sites When there is no internet, Drill Web UI fails to load the external CDNs and will not load the result page. This change, uses the maven download plugin to download the javascript and css files during build time. First this tries to load the CDNs from the internet. If a failure occurs, it uses the local downloaded Javascript and css files. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sindhurirayavaram/drill DRILL-5699 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/drill/pull/891.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #891 commit 61b874e2e17e44666cea9c7626767651ce7e4c70 Author: Sindhuri Rayavaram <sindhurirayavaram@srayava-e422.local> Date: 2017-07-31T18:45:53Z DRILL-5699: Drill Web UI Page Source Has Links To External Sites --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] drill pull request #874: DRILL-5663: Drillbit fails to start when only keyst...
GitHub user sindhurirayavaram opened a pull request: https://github.com/apache/drill/pull/874 DRILL-5663: Drillbit fails to start when only keystore path is provided without keystore password. When we configure keystore path without keystore password inside drill-override.conf for WebServer, then Drillbit fails to start. We should explicitly check for either both being present or both being absent. If any one of them is only present then we should throw startup exception for Drill. In the code change, added checks for both keystorepath and keystorepasword. You can merge this pull request into a Git repository by running: $ git pull https://github.com/sindhurirayavaram/drill master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/drill/pull/874.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #874 commit b9c6ee1cddffaf1472235adba7ac5597959f9c8e Author: Sindhuri Rayavaram <sraya...@uci.edu> Date: 2017-07-10T23:59:36Z DRILL-5663:added check for keystorePassword commit ca1f56776911c2c312212e3546264defe812c7c2 Author: Sindhuri Rayavaram <sraya...@uci.edu> Date: 2017-07-11T20:26:51Z DRILL-5663: Added a check for keystorePassword commit 59b581d5402da104bcaee6ffa16050c5ecf3a90b Author: Sindhuri Rayavaram <sraya...@uci.edu> Date: 2017-07-12T22:50:52Z DRILL-5663: Added check for keystorepassword commit e3cc91bea31921a8c540e981db2b7cbccae9ff83 Author: Sindhuri Rayavaram <sraya...@uci.edu> Date: 2017-07-12T23:35:20Z DRILL-5663: Added check for keystorepassword --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
