Re: [DISCUSSION] Travis build failures
Or we can be more radical here and exclude all tests from contib module? On Fri, Jun 29, 2018 at 7:28 PM Vitalii Diravka wrote: > Agree, TestTpchExplain and TestTpchPlanning are fast enough. > TestTpchLimit0 has PlannerTest category, but it is slower than the above > tests. > Actually only TestTpchSingleMode and TestTpchLimit0 are candidates for > excluding. > I am not sure that it is enough for Travis (45 seconds on my machine). What > about Mongo unit tests? > > I have created Jira for it [1]. > > [1] https://issues.apache.org/jira/browse/DRILL-6559 > > Kind regards > Vitalii > > > On Wed, Jun 27, 2018 at 10:29 PM Aman Sinha wrote: > > > Sounds good but why exclude the planning tests ? Only the TPC-H runtime > > tests should be excluded I think. > > > > On Wed, Jun 27, 2018 at 12:16 PM Timothy Farkas > wrote: > > > > > +1 > > > > > > On Wed, Jun 27, 2018 at 10:00 AM, Vitalii Diravka < > > > vitalii.dira...@gmail.com > > > > wrote: > > > > > > > This is a topic from last Hangout meeting. > > > > > > > > Sometimes Drill Travis Build fails because of job run expires. > > > > Certainly, the right way is to accelerate Drill execution :) > > > > > > > > Nevertheless I believe we could consider excluding some more tests > from > > > > Travis Build. > > > > We can add all TPCH tests ( > > > > TestTpchLimit0, TestTpchExplain, TestTpchPlanning, TestTpchExplain) > to > > > the > > > > SlowTest category. > > > > Actually it isn't urgent, but we can consider it for future, if this > > > > happens more often. > > > > > > > > Kind regards > > > > Vitalii > > > > > > > > > >
Re: [DISCUSSION] Travis build failures
Agree, TestTpchExplain and TestTpchPlanning are fast enough. TestTpchLimit0 has PlannerTest category, but it is slower than the above tests. Actually only TestTpchSingleMode and TestTpchLimit0 are candidates for excluding. I am not sure that it is enough for Travis (45 seconds on my machine). What about Mongo unit tests? I have created Jira for it [1]. [1] https://issues.apache.org/jira/browse/DRILL-6559 Kind regards Vitalii On Wed, Jun 27, 2018 at 10:29 PM Aman Sinha wrote: > Sounds good but why exclude the planning tests ? Only the TPC-H runtime > tests should be excluded I think. > > On Wed, Jun 27, 2018 at 12:16 PM Timothy Farkas wrote: > > > +1 > > > > On Wed, Jun 27, 2018 at 10:00 AM, Vitalii Diravka < > > vitalii.dira...@gmail.com > > > wrote: > > > > > This is a topic from last Hangout meeting. > > > > > > Sometimes Drill Travis Build fails because of job run expires. > > > Certainly, the right way is to accelerate Drill execution :) > > > > > > Nevertheless I believe we could consider excluding some more tests from > > > Travis Build. > > > We can add all TPCH tests ( > > > TestTpchLimit0, TestTpchExplain, TestTpchPlanning, TestTpchExplain) to > > the > > > SlowTest category. > > > Actually it isn't urgent, but we can consider it for future, if this > > > happens more often. > > > > > > Kind regards > > > Vitalii > > > > > >
Re: [DISCUSSION] Travis build failures
Sounds good but why exclude the planning tests ? Only the TPC-H runtime tests should be excluded I think. On Wed, Jun 27, 2018 at 12:16 PM Timothy Farkas wrote: > +1 > > On Wed, Jun 27, 2018 at 10:00 AM, Vitalii Diravka < > vitalii.dira...@gmail.com > > wrote: > > > This is a topic from last Hangout meeting. > > > > Sometimes Drill Travis Build fails because of job run expires. > > Certainly, the right way is to accelerate Drill execution :) > > > > Nevertheless I believe we could consider excluding some more tests from > > Travis Build. > > We can add all TPCH tests ( > > TestTpchLimit0, TestTpchExplain, TestTpchPlanning, TestTpchExplain) to > the > > SlowTest category. > > Actually it isn't urgent, but we can consider it for future, if this > > happens more often. > > > > Kind regards > > Vitalii > > >
Re: [DISCUSSION] Travis build failures
+1 On Wed, Jun 27, 2018 at 10:00 AM, Vitalii Diravka wrote: > This is a topic from last Hangout meeting. > > Sometimes Drill Travis Build fails because of job run expires. > Certainly, the right way is to accelerate Drill execution :) > > Nevertheless I believe we could consider excluding some more tests from > Travis Build. > We can add all TPCH tests ( > TestTpchLimit0, TestTpchExplain, TestTpchPlanning, TestTpchExplain) to the > SlowTest category. > Actually it isn't urgent, but we can consider it for future, if this > happens more often. > > Kind regards > Vitalii >
[DISCUSSION] Travis build failures
This is a topic from last Hangout meeting. Sometimes Drill Travis Build fails because of job run expires. Certainly, the right way is to accelerate Drill execution :) Nevertheless I believe we could consider excluding some more tests from Travis Build. We can add all TPCH tests ( TestTpchLimit0, TestTpchExplain, TestTpchPlanning, TestTpchExplain) to the SlowTest category. Actually it isn't urgent, but we can consider it for future, if this happens more often. Kind regards Vitalii
