[GitHub] [drill] vvysotskyi commented on a change in pull request #1921: DRILL-7478: Add Pull Request Template
vvysotskyi commented on a change in pull request #1921: DRILL-7478: Add Pull Request Template URL: https://github.com/apache/drill/pull/1921#discussion_r362840268 ## File path: .github/PULL_REQUEST_TEMPLATE.md ## @@ -0,0 +1,12 @@ +# DRILL-: Summary Review comment: Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [drill] vvysotskyi commented on a change in pull request #1921: DRILL-7478: Add Pull Request Template
vvysotskyi commented on a change in pull request #1921: DRILL-7478: Add Pull Request Template URL: https://github.com/apache/drill/pull/1921#discussion_r362746849 ## File path: .github/PULL_REQUEST_TEMPLATE.md ## @@ -0,0 +1,12 @@ +# DRILL-: Summary Review comment: Could you please replace it with reference: ```suggestion # [DRILL-](https://issues.apache.org/jira/browse/DRILL-): Summary ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [drill] vvysotskyi commented on a change in pull request #1921: DRILL-7478: Add Pull Request Template
vvysotskyi commented on a change in pull request #1921: DRILL-7478: Add Pull Request Template URL: https://github.com/apache/drill/pull/1921#discussion_r356536117 ## File path: .github/PULL_REQUEST_TEMPLATE.md ## @@ -0,0 +1,47 @@ +# Pull Request Details + +Provide a general summary of your changes in the Title above + +## Description + +Describe your changes in detail + +## Related Issue(s) + +This project only accepts pull requests related to open issues in JIRA [1] +If suggesting a new feature or change, please discuss it in an issue first +If fixing a bug, there should be an issue describing it with steps to reproduce +Please link to the issue here: + +## Motivation and Context + +Why is this change required? What problem does it solve? + +## How Has This Been Tested + +Please describe in detail how you tested your changes. If the PR does not require testing +please give a very good reason why that is the case. + +## Types of changes + +What types of changes does your code introduce? Put an `x` in all the boxes that apply: + +- [ ] Docs change / refactoring / dependency upgrade +- [ ] Bug fix (non-breaking change which fixes an issue) +- [ ] New feature (non-breaking change which adds functionality) +- [ ] Breaking change (fix or feature that would cause existing functionality to change) + +## Checklist Review comment: Could you please add a point to check whether all newly added dependencies are really required and check the size of jars that are attached to the project (including transitive dependencies) and for the case of large jars, to try excluding them or using alternative libraries. Also, it would be useful to advise avoiding adding large files for tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [drill] vvysotskyi commented on a change in pull request #1921: DRILL-7478: Add Pull Request Template
vvysotskyi commented on a change in pull request #1921: DRILL-7478: Add Pull Request Template URL: https://github.com/apache/drill/pull/1921#discussion_r356536117 ## File path: .github/PULL_REQUEST_TEMPLATE.md ## @@ -0,0 +1,47 @@ +# Pull Request Details + +Provide a general summary of your changes in the Title above + +## Description + +Describe your changes in detail + +## Related Issue(s) + +This project only accepts pull requests related to open issues in JIRA [1] +If suggesting a new feature or change, please discuss it in an issue first +If fixing a bug, there should be an issue describing it with steps to reproduce +Please link to the issue here: + +## Motivation and Context + +Why is this change required? What problem does it solve? + +## How Has This Been Tested + +Please describe in detail how you tested your changes. If the PR does not require testing +please give a very good reason why that is the case. + +## Types of changes + +What types of changes does your code introduce? Put an `x` in all the boxes that apply: + +- [ ] Docs change / refactoring / dependency upgrade +- [ ] Bug fix (non-breaking change which fixes an issue) +- [ ] New feature (non-breaking change which adds functionality) +- [ ] Breaking change (fix or feature that would cause existing functionality to change) + +## Checklist Review comment: Could you please add a point to check whether all newly added dependencies are really required. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
