vvysotskyi commented on a change in pull request #1984: DRILL-7586:
drill-hive-exec-shaded contains commons-lang3 version 3.1
URL: https://github.com/apache/drill/pull/1984#discussion_r380155881
##########
File path: contrib/storage-hive/hive-exec-shade/pom.xml
##########
@@ -158,6 +158,8 @@
you can use
TestHiveStorage.readFromAlteredPartitionedTableWithEmptyGroupType() test case.
-->
<exclude>org/apache/parquet/**</exclude>
<exclude>shaded/parquet/org/**</exclude>
+ <exclude>org/apache/commons/lang/**</exclude>
Review comment:
I'm afraid it can break something since hive explicitly includes these
libraries into `hive-exec` jar:
https://github.com/apache/hive/blob/master/ql/pom.xml#L958.
As an alternative solution, I would recommend relocating them (as it is done
above for other libraries).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
