[GitHub] drill issue #1096: DRILL-6099 : Push limit past flatten(project) without pus...

2018-03-01 Thread amansinha100 
Github user amansinha100 commented on the issue:

https://github.com/apache/drill/pull/1096
  
Updated version lgtm.  +1


---

[GitHub] drill issue #1096: DRILL-6099 : Push limit past flatten(project) without pus...

2018-03-01 Thread gparai 
Github user gparai commented on the issue:

https://github.com/apache/drill/pull/1096
  
@amansinha100 I have addressed your review comments. Please take a look. 
Thanks!


---

[GitHub] drill issue #1096: DRILL-6099 : Push limit past flatten(project) without pus...

2018-02-27 Thread priteshm 
Github user priteshm commented on the issue:

https://github.com/apache/drill/pull/1096
  
@gparai did you get a chance to address @amansinha100 's comment for this 
PR?


---

[GitHub] drill issue #1096: DRILL-6099 : Push limit past flatten(project) without pus...

2018-01-27 Thread gparai 
Github user gparai commented on the issue:

https://github.com/apache/drill/pull/1096
  
@chunhui-shi can you please review the new changes (in commit e6dcf14)? 
Thanks!


---

[GitHub] drill issue #1096: DRILL-6099 : Push limit past flatten(project) without pus...

2018-01-22 Thread chunhui-shi 
Github user chunhui-shi commented on the issue:

https://github.com/apache/drill/pull/1096
  
Once all tests are done, I think it is fine to add 'ready-to-commit' label 
to the JIRA.


---

[GitHub] drill issue #1096: DRILL-6099 : Push limit past flatten(project) without pus...

2018-01-22 Thread chunhui-shi 
Github user chunhui-shi commented on the issue:

https://github.com/apache/drill/pull/1096
  
+1


---