[GitHub] drill issue #1201: DRILL-4091: Support for additional gis operations in gis ...

[cgivre]

Github user cgivre commented on the issue:

https://github.com/apache/drill/pull/1201
  
@arina-ielchiieva Should I do the commit or would you like to do that.


---

[GitHub] drill issue #1201: DRILL-4091: Support for additional gis operations in gis ...

[cgivre]

Github user cgivre commented on the issue:

https://github.com/apache/drill/pull/1201
  
In that case,  LGTM +1 
Thank you for your work on this!.  Are you going to take a look at the ESRI 
format plugin?  


---

[GitHub] drill issue #1201: DRILL-4091: Support for additional gis operations in gis ...

[ChrisSandison]

Github user ChrisSandison commented on the issue:

https://github.com/apache/drill/pull/1201
  
@cgivre I had some issues between this and a previous branch I was working 
on, but I fixed it by upgrade the base image that I was building it on. I ended 
up building it on maven:3.5.3-jdk-8


---

[GitHub] drill issue #1201: DRILL-4091: Support for additional gis operations in gis ...

[cgivre]

Github user cgivre commented on the issue:

https://github.com/apache/drill/pull/1201
  
LGTM +1

One thing, which I suspect may be a problem with my environment, not this 
PR, but when I try to build the module with the tests, I get the following 
errors:

```
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-assembly-plugin:2.6:single 
(source-release-assembly) on project drill-gis: Error reading assemblies: Error 
locating assembly descriptor: src/main/resources/assemblies/source-assembly.xml
[ERROR] 
[ERROR] [1] [INFO] Searching for file location: 
/Users/cgivre/github/drill-dev/drill-gis/drill/contrib/gis/src/main/resources/assemblies/source-assembly.xml
[ERROR] 
[ERROR] [2] [INFO] File: 
/Users/cgivre/github/drill-dev/drill-gis/drill/contrib/gis/src/main/resources/assemblies/source-assembly.xml
 does not exist.
[ERROR] 
[ERROR] [3] [INFO] File: 
/Users/cgivre/github/drill-dev/drill-gis/drill/contrib/gis/src/main/resources/assemblies/source-assembly.xml
 does not exist.
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
goal org.apache.maven.plugins:maven-assembly-plugin:2.6:single 
(source-release-assembly) on project drill-gis: Error reading assemblies: Error 
locating assembly descriptor: src/main/resources/assemblies/source-assembly.xml

[1] [INFO] Searching for file location: 
/Users/cgivre/github/drill-dev/drill-gis/drill/contrib/gis/src/main/resources/assemblies/source-assembly.xml

[2] [INFO] File: 
/Users/cgivre/github/drill-dev/drill-gis/drill/contrib/gis/src/main/resources/assemblies/source-assembly.xml
 does not exist.

[3] [INFO] File: 
/Users/cgivre/github/drill-dev/drill-gis/drill/contrib/gis/src/main/resources/assemblies/source-assembly.xml
 does not exist.
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:213)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:154)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:146)
at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:117)
at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:81)
at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
 (SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:497)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
(Launcher.java:229)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
(Launcher.java:415)
at org.codehaus.plexus.classworlds.launcher.Launcher.main 
(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoExecutionException: Error reading 
assemblies: Error locating assembly descriptor: 
src/main/resources/assemblies/source-assembly.xml

[1] [INFO] Searching for file location: 
/Users/cgivre/github/drill-dev/drill-gis/drill/contrib/gis/src/main/resources/assemblies/source-assembly.xml

[2] [INFO] File: 
/Users/cgivre/github/drill-dev/drill-gis/drill/contrib/gis/src/main/resources/assemblies/source-assembly.xml
 does not exist.

[3] [INFO] File: 
/Users/cgivre/github/drill-dev/drill-gis/drill/contrib/gis/src/main/resources/assemblies/source-assembly.xml
 does not exist.
at org.apache.maven.plugin.assembly.mojos.AbstractAssemblyMojo.execute 
(AbstractAssemblyMojo.java:453)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:208)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:154)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:146)
at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:117)
at 

[GitHub] drill issue #1201: DRILL-4091: Support for additional gis operations in gis ...

[ChrisSandison]

Github user ChrisSandison commented on the issue:

https://github.com/apache/drill/pull/1201
  
@cgivre I'm also needing to use ST_DWithin 
(https://postgis.net/docs/ST_DWithin.html). I'm going to add it to this PR.


---

[GitHub] drill issue #1201: DRILL-4091: Support for additional gis operations in gis ...

[cgivre]

Github user cgivre commented on the issue:

https://github.com/apache/drill/pull/1201
  
@ChrisSandison Done.  Here's a link to the JIRA 
https://issues.apache.org/jira/browse/DRILL-6319


---

[GitHub] drill issue #1201: DRILL-4091: Support for additional gis operations in gis ...

[ChrisSandison]

Github user ChrisSandison commented on the issue:

https://github.com/apache/drill/pull/1201
  
@cgivre I agree. Would you be able to open a JIRA ticket with any details 
of the work that @k255 was doing for it?


---

[GitHub] drill issue #1201: DRILL-4091: Support for additional gis operations in gis ...

[cgivre]

Github user cgivre commented on the issue:

https://github.com/apache/drill/pull/1201
  
If you want to include it on this PR that would be great, but I’m fine 
with including it in a separate PR as well.  I want to get this functionality 
into Drill asap, so it probably would be quicker to do a separate PR.  

> On Apr 10, 2018, at 10:32, Chris Sandison  
wrote:
> 
> @cgivre  do you mean including that in this PR?
> 
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub 
, or mute the 
thread 
.
> 




---

[GitHub] drill issue #1201: DRILL-4091: Support for additional gis operations in gis ...

[ChrisSandison]

Github user ChrisSandison commented on the issue:

https://github.com/apache/drill/pull/1201
  
@cgivre do you mean including that in this PR?


---

[GitHub] drill issue #1201: DRILL-4091: Support for additional gis operations in gis ...

[cgivre]

Github user cgivre commented on the issue:

https://github.com/apache/drill/pull/1201
  
@ChrisSandison This isn't a review comment, but @k255 was working on a 
format plugin for ESRI shape files.  Would you want to take a look and see if 
we could get that in as well?  I could see that being VERY useful once we get 
all this GIS functionality in. 


---

[GitHub] drill issue #1201: DRILL-4091: Support for additional gis operations in gis ...

[ChrisSandison]

Github user ChrisSandison commented on the issue:

https://github.com/apache/drill/pull/1201
  
@cgivre added comments


---

[GitHub] drill issue #1201: DRILL-4091: Support for additional gis operations in gis ...

[kkhatua]

Github user kkhatua commented on the issue:

https://github.com/apache/drill/pull/1201
  
@cgivre could you review this?


---