[GitHub] drill issue #1203: DRILL-6289: Cluster view should show more relevant inform...
Github user sohami commented on the issue: https://github.com/apache/drill/pull/1203 Thanks for all the changes Kunal. LGTM +1 ---
[GitHub] drill issue #1203: DRILL-6289: Cluster view should show more relevant inform...
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1203 @sohami Rebased the commits on top of the latest master ( https://github.com/apache/drill/commit/931b43ec54bf47dcbb4aa9ae4499f37a8f21b408 ) ---
[GitHub] drill issue #1203: DRILL-6289: Cluster view should show more relevant inform...
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1203 @sohami , I've answered your questions in the review. ---
[GitHub] drill issue #1203: DRILL-6289: Cluster view should show more relevant inform...
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1203 @kkhatua I definitely like new design more, thanks for the changes! I see some unanswered comments from Saurabh in index.ftl, could you please take a look? ---
[GitHub] drill issue #1203: DRILL-6289: Cluster view should show more relevant inform...
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1203 Forgot to mention, this also resolves DRILL-5261 because of the protobuf carrying the HTTP port info. @arina-ielchiieva / @sohami / @dvjyothsna , please have a review of the changes. ---
[GitHub] drill issue #1203: DRILL-6289: Cluster view should show more relevant inform...
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1203 Updated with an additional set of changes. * Added CPU metrics (obtained from [OperatingSystemMXBean.getProcessCpuLoad()](https://docs.oracle.com/javase/7/docs/jre/api/management/extension/com/sun/management/OperatingSystemMXBean.html#getProcessCpuLoad()) ) * Added uptime information so that you know if a Drillbit ever has a different start time. * Grey-out a button (disabled, i.e.) if the node is offline or remote & requires HTTPS * Additional changes based on comments Screenshot  ---
[GitHub] drill issue #1203: DRILL-6289: Cluster view should show more relevant inform...
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1203 Regarding shutdown button (icon) placement, there are two more options: 1. have separate column for shutdown, when shutdown for the particular drillbits are unavailable, show disabled button / icon. Maybe better then just have empty rows as we do now. 2. remove shutdown column and add shutdown icon in address column near those drillbits which we can shutdown. ---
[GitHub] drill issue #1203: DRILL-6289: Cluster view should show more relevant inform...
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1203 Latest screenshot with the power button,  ---
[GitHub] drill issue #1203: DRILL-6289: Cluster view should show more relevant inform...
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1203 Will add some new screenshots. In the meanwhile, I was thinking of reduce the 'SHUTDOWN' button to just the power Symbol, because we already have the 'STATUS' field. The single button does look odd in this case, but would be fine when the option appears for all Drillbits in an non-secured Drill cluster setup. Would that work, @arina-ielchiieva ? ---
[GitHub] drill issue #1203: DRILL-6289: Cluster view should show more relevant inform...
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1203 @sohami could you please also review this PR (it contains some changes with port hunting, you might be more familiar with)? ---
[GitHub] drill issue #1203: DRILL-6289: Cluster view should show more relevant inform...
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1203 Some more points: 1. Please add updated screenshots. 2. Since we have only one shutdown button, we should consider redesigning, it's position, since it looks really strange: ---
[GitHub] drill issue #1203: DRILL-6289: Cluster view should show more relevant inform...
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1203 @arina-ielchiieva / @dvjyothsna Updated the PR with changes based on the comments. Could you please review and let me know what else would need to be fixed. ---
[GitHub] drill issue #1203: DRILL-6289: Cluster view should show more relevant inform...
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1203 @arina-ielchiieva You're correct about the inability to shutdown other Drillbits from the WebUI. But, from what @dvjyothsna explained, it seems that this was the result of a technical hurdle with HTTP**S** protocol. My understanding was that issuing shutdown to secure remote nodes won't work because of lack of certificates for those nodes, making it difficult for the remote Drillbit to authenticate the shutdown command. Keeping that in mind, the SHUTDOWN buttons would appear only for unsecured Drillbits, i.e. when Authentication is **_not_** enabled. https://github.com/kkhatua/drill/blob/dd507ea95a7d0ef4904092ef4fc43ee3b44ef058/exec/java-exec/src/main/resources/rest/index.ftl#L100 For setups requiring Authentication, the shutdown button would not appear. ---
[GitHub] drill issue #1203: DRILL-6289: Cluster view should show more relevant inform...
Github user arina-ielchiieva commented on the issue: https://github.com/apache/drill/pull/1203 Before the review I guess we need to clarify one thing. After DRILL-6044 Shutdown button was shown only for the current drillbit. As far as I understood, you cannot shutdown other drillbits from Web UI except of current. @dvjyothsna please confirm. ---
[GitHub] drill issue #1203: DRILL-6289: Cluster view should show more relevant inform...
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1203 @arina-ielchiieva could you please review this? ---
[GitHub] drill issue #1203: DRILL-6289: Cluster view should show more relevant inform...
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1203 **PopOut to open in new window:**  Tooltip describing the new columns  ---
[GitHub] drill issue #1203: DRILL-6289: Cluster view should show more relevant inform...
Github user kkhatua commented on the issue: https://github.com/apache/drill/pull/1203 **Snapshot:**  ---
