[GitHub] drill issue #1214: DRILL-6331: Revisit Hive Drill native parquet implementat...

2018-04-27 Thread vrozov 
Github user vrozov commented on the issue:

https://github.com/apache/drill/pull/1214
  
When moving files around please preserve the history of modifications done 
to the file.


---

[GitHub] drill issue #1214: DRILL-6331: Revisit Hive Drill native parquet implementat...

2018-04-26 Thread parthchandra 
Github user parthchandra commented on the issue:

https://github.com/apache/drill/pull/1214
  
Looks Good. Thanks for making the changes Arina.
+1


---

[GitHub] drill issue #1214: DRILL-6331: Revisit Hive Drill native parquet implementat...

2018-04-26 Thread arina-ielchiieva 
Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/1214
  
@parthchandra added two new commits:
1. reverted custom Stopwatch implementation and used logger checks instead.
2. allowed to create several non-tracking fs but only one tracking per 
operator context (details in prior discussion).


---

[GitHub] drill issue #1214: DRILL-6331: Revisit Hive Drill native parquet implementat...

2018-04-25 Thread arina-ielchiieva 
Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/1214
  
@vdiravka thanks for the code review! Addressed code review comment.


---

[GitHub] drill issue #1214: DRILL-6331: Revisit Hive Drill native parquet implementat...

2018-04-19 Thread arina-ielchiieva 
Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/1214
  
@vdiravka / @parthchandra please review.


---