[GitHub] drill issue #258: DRILL-4091: Support for additional gis operations in gis c...

[cgivre]

Github user cgivre commented on the issue:

https://github.com/apache/drill/pull/258
  
HI @brendanstennett I still am able to review if you'd like.


---

[GitHub] drill issue #258: DRILL-4091: Support for additional gis operations in gis c...

[brendanstennett]

Github user brendanstennett commented on the issue:

https://github.com/apache/drill/pull/258
  
Hey guys, we have some cycles to have a look at this now. @ChrisSandison is 
going to take a look who has made a few contributions to this project before.  


---

[GitHub] drill issue #258: DRILL-4091: Support for additional gis operations in gis c...

[lherrmann974]

Github user lherrmann974 commented on the issue:

https://github.com/apache/drill/pull/258
  
Pinging again.
If I may help, please let me know what I can do.


---

[GitHub] drill issue #258: DRILL-4091: Support for additional gis operations in gis c...

[brendanstennett]

Github user brendanstennett commented on the issue:

https://github.com/apache/drill/pull/258
  
Hi @cgivre .  I have some spare cycles coming up in our next open sprint 
starting Apr 2 that either I or someone on my team can take a look at it to get 
it across if it isn't already.  Will keep you updated.  What is your timeline 
for the next release?


---

[GitHub] drill issue #258: DRILL-4091: Support for additional gis operations in gis c...

[cgivre]

Github user cgivre commented on the issue:

https://github.com/apache/drill/pull/258
  
Hi Brendan, I can review it if you can complete it. 

—C

> On Mar 6, 2018, at 10:57, Brendan Stennett  
wrote:
> 
> +1 And would be happy to help get it across the finish line for you.
> 
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub 
, or mute the 
thread 
.
> 




---

[GitHub] drill issue #258: DRILL-4091: Support for additional gis operations in gis c...

[brendanstennett]

Github user brendanstennett commented on the issue:

https://github.com/apache/drill/pull/258
  
+1 And would be happy to help get it across the finish line for you.


---

[GitHub] drill issue #258: DRILL-4091: Support for additional gis operations in gis c...

[cgivre]

Github user cgivre commented on the issue:

https://github.com/apache/drill/pull/258
  
I also would really like to see this through to completion.  If there is 
something I can do, please let me know.

> On Mar 6, 2018, at 08:04, lherrmann974  wrote:
> 
> Hello,
> any news on this PR ? The upgraded GIS abilities would be greatly 
appreciated.
> Thanks in advance.
> 
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub 
, or mute the 
thread 
.
> 




---

[GitHub] drill issue #258: DRILL-4091: Support for additional gis operations in gis c...

[lherrmann974]

Github user lherrmann974 commented on the issue:

https://github.com/apache/drill/pull/258
  
Hello,
any news on this PR ? The upgraded GIS abilities would be greatly 
appreciated.
Thanks in advance.


---

[GitHub] drill issue #258: DRILL-4091: Support for additional gis operations in gis c...

[cgivre]

Github user cgivre commented on the issue:

https://github.com/apache/drill/pull/258
  
I'm getting some unit test failures when I build this.  

[org.apache.drill.exec.expr.fn.impl.gis.TestGeometryFunctions.txt](https://github.com/apache/drill/files/1483754/org.apache.drill.exec.expr.fn.impl.gis.TestGeometryFunctions.txt)





---

[GitHub] drill issue #258: DRILL-4091: Support for additional gis operations in gis c...

[amansinha100]

Github user amansinha100 commented on the issue:

https://github.com/apache/drill/pull/258
  
@cgivre regarding the commit process, you can send me a note at 
amansi...@apache.org  and I can walk through it.  Although someone else 
familiar with the process could do the commit, it would be a good learning 
exercise for you :)  



---

[GitHub] drill issue #258: DRILL-4091: Support for additional gis operations in gis c...

[k255]

Github user k255 commented on the issue:

https://github.com/apache/drill/pull/258
  
It's good that now there's commiter which is aware of the GIS context! The 
list of functions added in this PR is as follows:
ST_Buffer, ST_Contains, ST_Crosses, ST_Difference, ST_Disjoint, 
ST_DiST_ance, ST_Envelope, ST_Equals, ST_Intersects, ST_Overlaps, ST_Relate, 
ST_Touches, ST_Transform, ST_Union, ST_UnionAggregate, ST_X, ST_Y, ST_XMin, 
ST_XMax, ST_YMin, ST_YMax
 
Regarding the documentation, I wouldn't like to duplicate it because I 
followed what is available in PostGIS (which actually uses GEOS lib, in similar 
way as drill-gis uses relevant java libs - esri, proj4j) and these are defined 
in open geospatial consortium (OGC) specs. Of course here we have just a subset 
of what PostGIS is capable of, but I think it's valuable subset.
So i.e. for ST_X function the docs are at 
http://www.postgis.net/docs/ST_X.html
Also on example usage please refer to examples contained in readme at:
https://github.com/k255/drill-gis

I'll also finally need to think about blog post/presentation on this 
extension, but most probably not in following days but later in the future.




---

[GitHub] drill issue #258: DRILL-4091: Support for additional gis operations in gis c...

[cgivre]

Github user cgivre commented on the issue:

https://github.com/apache/drill/pull/258
  
Hi there, 
This will be my first commit, (AH!) so any assistance would be greatly 
appreciated.  I would like to see some documentation, or at minimum a list of 
what functions are included and sentence about what they do.  I think this 
could be a great addition to Drill!

> On Oct 27, 2017, at 11:21, Aman Sinha  wrote:
> 
> Thanks @k255  . @cgivre 
 once you have reviewed and are satisfied, pls mark 
the JIRA as ready-to-commit label. Also, what do you both think about 
documentation for these GIS functions ?
> 
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub 
, or mute the 
thread 
.
> 




---

[GitHub] drill issue #258: DRILL-4091: Support for additional gis operations in gis c...

[amansinha100]

Github user amansinha100 commented on the issue:

https://github.com/apache/drill/pull/258
  
Thanks @k255 .   @cgivre once you have reviewed and are satisfied, pls mark 
the JIRA as ready-to-commit label.  Also, what do you both think about 
documentation for these GIS functions ?  


---

[GitHub] drill issue #258: DRILL-4091: Support for additional gis operations in gis c...

[k255]

Github user k255 commented on the issue:

https://github.com/apache/drill/pull/258
  
@amansinha100 better later than never! The PR is updated now.
@cgivre offered that he could help reviewing this.
@joeauty probably in further development we can consider adding geojson 
support. I'm happy that you like it!


---

[GitHub] drill issue #258: DRILL-4091: Support for additional gis operations in gis c...

[amansinha100]

Github user amansinha100 commented on the issue:

https://github.com/apache/drill/pull/258
  
Somehow these extensions to the GIS module never got reviewed ! (the 
original GIS functions are in the contrib).   @k255 would you be able to rebase 
your PR onto the latest master branch ? Hopefully someone familiar with the 
semantics of these functions can do a quick review and then we will merge it 
in.  Thanks for your contribution !


---

[GitHub] drill issue #258: DRILL-4091: Support for additional gis operations in gis c...

[joeauty]

Github user joeauty commented on the issue:

https://github.com/apache/drill/pull/258
  
I'm super excited about this! Just wondering, is there plans for 
ST_ASGeoJSON?




---