[GitHub] drill issue #570: DRILL-4834 decimal implementation is vulnerable to overflo...

2018-01-18 Thread daveoshinsky
Github user daveoshinsky commented on the issue:

https://github.com/apache/drill/pull/570
  
The new VARDECIMAL one-size-fits-all decimal type, which this PR 
implements, will now be incorporated into the following new JIRA with 
additional changes and fixes for Drill 1.13:
https://issues.apache.org/jira/browse/DRILL-6094

So, development on this PR will now cease.  But VARDECIMAL lives on
Dave Oshinsky


---


[GitHub] drill issue #570: DRILL-4834 decimal implementation is vulnerable to overflo...

2017-02-28 Thread daveoshinsky
Github user daveoshinsky commented on the issue:

https://github.com/apache/drill/pull/570
  
Would someone please review this?  Or estimate when this can be started?  
It has now been months, and I just merged some conflicts that were introduced 
because it has been months since I completed the initial set of changes.  The 
decimal implementation definitely could use some TLC


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] drill issue #570: DRILL-4834 decimal implementation is vulnerable to overflo...

2016-09-06 Thread daveoshinsky
Github user daveoshinsky commented on the issue:

https://github.com/apache/drill/pull/570
  
Please review "one-size-fits-all" VARDECIMAL implementation in this pull 
request.  Initially, it exists alongside all of the other decimal types, and is 
only used for variable-width BINARY decimal in Parquet files.  If reviews look 
good, we can extend it to eventually replace other decimal types.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---