[GitHub] drill issue #597: DRILL-4905: Push down the LIMIT to the parquet reader scan...

2016-10-11 Thread ppadma
Github user ppadma commented on the issue:

https://github.com/apache/drill/pull/597
  
updated with new diffs. Please review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] drill issue #597: DRILL-4905: Push down the LIMIT to the parquet reader scan...

2016-09-29 Thread jinfengni
Github user jinfengni commented on the issue:

https://github.com/apache/drill/pull/597
  
+1

LGTM.

If possible, please run a performance workload.  The patch supposedly 
should not impact the performance workload. But in case I might miss something, 
it would be good to run the performance regression to make sure. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] drill issue #597: DRILL-4905: Push down the LIMIT to the parquet reader scan...

2016-09-29 Thread ppadma
Github user ppadma commented on the issue:

https://github.com/apache/drill/pull/597
  
updated with all review comments taken care of. Please review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] drill issue #597: DRILL-4905: Push down the LIMIT to the parquet reader scan...

2016-09-27 Thread ppadma
Github user ppadma commented on the issue:

https://github.com/apache/drill/pull/597
  
updated with review comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] drill issue #597: DRILL-4905: Push down the LIMIT to the parquet reader scan...

2016-09-27 Thread jinfengni
Github user jinfengni commented on the issue:

https://github.com/apache/drill/pull/597
  
comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---